Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] Package `xen' creates service that spams dmesg when no hypervisor is running
@ 2020-01-31  6:09 voidlinux-github
  2020-08-08 11:55 ` ashpooljh
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: voidlinux-github @ 2020-01-31  6:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]

New issue by xelxebar on void-packages repository

https://github.com/void-linux/void-packages/issues/18676

Description:
### Symptom

With the `xen` package installed, and booting *without* the hypervisor, dmesg gets spammed with the following message once every second:

    [000000.000000] xen_evtchn: unknown parameter 'xen-gnttalloc' ignored

### Cause

The problem can be traced back to the `xenstored` service installed by the `xen` package:

    $ grep xen-gnttalloc /etc/sv/xenstored/run
    modprobe -q xen-evtchn xen-gnttalloc || exit 1

This modprobe fails (logging our error) causing the service to fail. Thus `runit` (futually) tries to restart the service *ad infinitum*, leading to the dmesg spam.

### Potential Solution

The `xenstored` service should gracefully degrade to a noop in the case when xen isn't running. One way we can do this is by checking `xl list`. The following patch to shows a workaround that functions on my machine:

    --- /etc/sv/xenstored/run	2020-01-31 15:03:46.619346755 +0900
    +++ /etc/sv/xenstored/run	2020-01-31 15:03:35.912144255 +0900
    @@ -1,4 +1,5 @@
     #!/bin/sh
    +xl list >/dev/null 2>&1 || exit
     [ ! -d /run/xen ] && mkdir -p /run/xen
     modprobe -q xen-evtchn xen-gnttalloc || exit 1
     mountpoint -q /proc/xen || mount -t xenfs xenfs /proc/xen



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Package `xen' creates service that spams dmesg when no hypervisor is running
  2020-01-31  6:09 [ISSUE] Package `xen' creates service that spams dmesg when no hypervisor is running voidlinux-github
@ 2020-08-08 11:55 ` ashpooljh
  2021-02-15  6:06 ` ericonr
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ashpooljh @ 2020-08-08 11:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by ashpooljh on void-packages repository

https://github.com/void-linux/void-packages/issues/18676#issuecomment-670920400

Comment:
Sorry, linked to the wrong issue initially.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Package `xen' creates service that spams dmesg when no hypervisor is running
  2020-01-31  6:09 [ISSUE] Package `xen' creates service that spams dmesg when no hypervisor is running voidlinux-github
  2020-08-08 11:55 ` ashpooljh
@ 2021-02-15  6:06 ` ericonr
  2021-02-16 21:40 ` CMB
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-02-15  6:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/18676#issuecomment-778970187

Comment:
@CMB what do you think about this suggestion?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Package `xen' creates service that spams dmesg when no hypervisor is running
  2020-01-31  6:09 [ISSUE] Package `xen' creates service that spams dmesg when no hypervisor is running voidlinux-github
  2020-08-08 11:55 ` ashpooljh
  2021-02-15  6:06 ` ericonr
@ 2021-02-16 21:40 ` CMB
  2021-02-16 21:52 ` ericonr
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: CMB @ 2021-02-16 21:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

New comment by CMB on void-packages repository

https://github.com/void-linux/void-packages/issues/18676#issuecomment-780135145

Comment:
Looks reasonable on the face of it, but a couple points:

* In the no-op softfail condition, I'd do something like an `exec pause` or `exec chpst ... pause`.  Otherwise runsv will just keep looping trying to start it.
* The command `xl list` pulls data from xenstored.  I'm not sure that it will return 0 before xenstored is up, so it's a chicken and egg problem.  I need to test that.  If `xl list` doesn't work, I know of other ways to test whether something is running in a Xen dom0.

Another thing I want to do with the xenstored service is have a configurable executable name.  There are two xenstored implementations shipped by Xen: the original C implementation (xenstored) and the newer ocaml implementation (oxenstored).  oxenstored is recommended by upstream and -- in my experience -- less buggy.  So xenstored/run should allow overriding the executable name in ./conf.

I'll send a well-tested PR for all of this.  It may be a day or two; I'm recovering from a 3-day power outage.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Package `xen' creates service that spams dmesg when no hypervisor is running
  2020-01-31  6:09 [ISSUE] Package `xen' creates service that spams dmesg when no hypervisor is running voidlinux-github
                   ` (2 preceding siblings ...)
  2021-02-16 21:40 ` CMB
@ 2021-02-16 21:52 ` ericonr
  2022-04-15  2:13 ` github-actions
  2022-04-29  2:13 ` [ISSUE] [CLOSED] " github-actions
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-02-16 21:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/18676#issuecomment-780140960

Comment:
No rush, the issue has been open for a while, so I don't think a fix is urgent.

Thank you very much for looking into this, and good luck :)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Package `xen' creates service that spams dmesg when no hypervisor is running
  2020-01-31  6:09 [ISSUE] Package `xen' creates service that spams dmesg when no hypervisor is running voidlinux-github
                   ` (3 preceding siblings ...)
  2021-02-16 21:52 ` ericonr
@ 2022-04-15  2:13 ` github-actions
  2022-04-29  2:13 ` [ISSUE] [CLOSED] " github-actions
  5 siblings, 0 replies; 7+ messages in thread
From: github-actions @ 2022-04-15  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/18676#issuecomment-1099786957

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [ISSUE] [CLOSED] Package `xen' creates service that spams dmesg when no hypervisor is running
  2020-01-31  6:09 [ISSUE] Package `xen' creates service that spams dmesg when no hypervisor is running voidlinux-github
                   ` (4 preceding siblings ...)
  2022-04-15  2:13 ` github-actions
@ 2022-04-29  2:13 ` github-actions
  5 siblings, 0 replies; 7+ messages in thread
From: github-actions @ 2022-04-29  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

Closed issue by xelxebar on void-packages repository

https://github.com/void-linux/void-packages/issues/18676

Description:
### Symptom

With the `xen` package installed, and booting *without* the hypervisor, dmesg gets spammed with the following message once every second:

    [000000.000000] xen_evtchn: unknown parameter 'xen-gnttalloc' ignored

### Cause

The problem can be traced back to the `xenstored` service installed by the `xen` package:

    $ grep xen-gnttalloc /etc/sv/xenstored/run
    modprobe -q xen-evtchn xen-gnttalloc || exit 1

This modprobe fails (logging our error) causing the service to fail. Thus `runit` (futually) tries to restart the service *ad infinitum*, leading to the dmesg spam.

### Potential Solution

The `xenstored` service should gracefully degrade to a noop in the case when xen isn't running. One way we can do this is by checking `xl list`. The following patch to shows a workaround that functions on my machine:

    --- /etc/sv/xenstored/run	2020-01-31 15:03:46.619346755 +0900
    +++ /etc/sv/xenstored/run	2020-01-31 15:03:35.912144255 +0900
    @@ -1,4 +1,5 @@
     #!/bin/sh
    +xl list >/dev/null 2>&1 || exit
     [ ! -d /run/xen ] && mkdir -p /run/xen
     modprobe -q xen-evtchn xen-gnttalloc || exit 1
     mountpoint -q /proc/xen || mount -t xenfs xenfs /proc/xen



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-04-29  2:13 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-31  6:09 [ISSUE] Package `xen' creates service that spams dmesg when no hypervisor is running voidlinux-github
2020-08-08 11:55 ` ashpooljh
2021-02-15  6:06 ` ericonr
2021-02-16 21:40 ` CMB
2021-02-16 21:52 ` ericonr
2022-04-15  2:13 ` github-actions
2022-04-29  2:13 ` [ISSUE] [CLOSED] " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).