Re: WIP: New package: matterhorn-50200.7.0

Re: WIP: New package: matterhorn-50200.7.0

[Eluminae]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

New comment by Eluminae on void-packages repository

https://github.com/void-linux/void-packages/pull/20136#issuecomment-599648411

Comment:
@ametisf 

This is not stack packaged

I got: 

```
Error parsing targets: The specified targets matched no packages.
Perhaps you need to run 'stack init'?
=> ERROR: matterhorn-50200.7.0_1: do_install: 'STACK_ROOT=$wrksrc/.stack stack ${_stack_args} install ${make_build_args} --local-bin-path=${DESTDIR}/usr/bin' exited with 1
=> ERROR:   in do_install() at common/build-style/haskell-stack.sh:35
```

Is stack cabal compatible ?

Re: WIP: New package: matterhorn-50200.7.0

[ametisf]

[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]

New comment by ametisf on void-packages repository

https://github.com/void-linux/void-packages/pull/20136#issuecomment-599706556

Comment:
I don't see the whole error in your last comment so I can't tell exactly but, Stack doesn't have to have the package you're trying to build it has to have all it's dependencies and it's not the case for matterhorn anyway so that won't work.

The error you get with cabal is caused by it being built as a dynamically linked binary, all the haskell libraries are being linked dynamicaly, and then you don't include them in the package, xbps goest to search for them and then it tells you it couldn't find any package providing those libraries. The solution is (since those libraries wouldn't be useful to anything else) is to link the binary statically.

This made it build properly
```
diff --git a/srcpkgs/matterhorn/template b/srcpkgs/matterhorn/template
index 83dbcd0aac..95681b649c 100644
--- a/srcpkgs/matterhorn/template
+++ b/srcpkgs/matterhorn/template
@@ -16,7 +16,7 @@ nopie_files="/usr/bin/matterhorn"
 do_build() {
        rm -f cabal.project
        cabal new-update
-       cabal new-build -j --enable-shared --enable-executable-dynamic --ghc-options=-dynamic
+       cabal new-build --jobs="${XBPS_MAKEJOBS}" --disable-executable-dynamic
 }

 do_install() {
```
but there are more things that should be fixed about your template, definitely installing with `vbin "$(find ...)"` is a bad idea, either change it to the exact location of the output binary or better use the `cabal new-install` subcommand if it's possible to give it a `$DESTDIR`.

Re: WIP: New package: matterhorn-50200.7.0

[ametisf]

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

New comment by ametisf on void-packages repository

https://github.com/void-linux/void-packages/pull/20136#issuecomment-599706556

Comment:
I don't see the whole error in your last comment so I can't tell exactly but Stack doesn't have to have the package you're trying to build it has to have all it's dependencies and it's not the case for matterhorn anyway so that won't work.

The error you get with cabal is caused by building it as a dynamically linked binary, all the haskell libraries are linked dynamicaly, and then you don't include them in the package, xbps goes to search for them and tells you it couldn't find any package providing those libraries. The solution is (since those libraries wouldn't be useful for anything else) to link the binary statically.

This made it build properly
```
diff --git a/srcpkgs/matterhorn/template b/srcpkgs/matterhorn/template
index 83dbcd0aac..95681b649c 100644
--- a/srcpkgs/matterhorn/template
+++ b/srcpkgs/matterhorn/template
@@ -16,7 +16,7 @@ nopie_files="/usr/bin/matterhorn"
 do_build() {
        rm -f cabal.project
        cabal new-update
-       cabal new-build -j --enable-shared --enable-executable-dynamic --ghc-options=-dynamic
+       cabal new-build --jobs="${XBPS_MAKEJOBS}" --disable-executable-dynamic
 }

 do_install() {
```
but there are more things that should be fixed about your template, definitely installing with `vbin "$(find ...)"` is a bad idea, either change it to the exact location of the output binary or better use the `cabal new-install` subcommand if it's possible to give it a `$DESTDIR`.

Re: WIP: New package: matterhorn-50200.7.0

[ametisf]

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

New comment by ametisf on void-packages repository

https://github.com/void-linux/void-packages/pull/20136#issuecomment-599706556

Comment:
I don't see the whole error in your last comment so I can't tell exactly but Stack doesn't have to have the package you're trying to build it has to have all it's dependencies and it's not the case for matterhorn anyway so that won't work.

The error you get with cabal is caused by building it as a dynamically linked binary, all the haskell libraries are linked dynamicaly, and then you don't include them in the package, xbps goes to search for them and tells you it couldn't find any package providing those libraries. The solution is (since those libraries wouldn't be useful for anything else) to link the binary statically.

This made it build properly
```
diff --git a/srcpkgs/matterhorn/template b/srcpkgs/matterhorn/template
index 83dbcd0aac..95681b649c 100644
--- a/srcpkgs/matterhorn/template
+++ b/srcpkgs/matterhorn/template
@@ -16,7 +16,7 @@ nopie_files="/usr/bin/matterhorn"
 do_build() {
        rm -f cabal.project
        cabal new-update
-       cabal new-build -j --enable-shared --enable-executable-dynamic --ghc-options=-dynamic
+       cabal new-build --jobs="${XBPS_MAKEJOBS}" --disable-executable-dynamic
 }

 do_install() {
```
but there are more things that should be fixed about your template, definitely installing with `vbin~"$(find ...)"` is a bad idea, either change it to the exact location of the output binary or better use the `cabal new-install` subcommand if it's possible to give it a `$DESTDIR`.

Re: WIP: New package: matterhorn-50200.7.0

[ametisf]

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

New comment by ametisf on void-packages repository

https://github.com/void-linux/void-packages/pull/20136#issuecomment-599706556

Comment:
I don't see the whole error in your last comment so I can't tell exactly but Stack doesn't have to have the package you're trying to build it has to have all it's dependencies and it's not the case for matterhorn anyway so that won't work.

The error you get with cabal is caused by building it as a dynamically linked binary, all the haskell libraries are linked dynamicaly, and then you don't include them in the package, xbps goes to search for them and tells you it couldn't find any package providing those libraries. The solution is (since those libraries wouldn't be useful for anything else) to link the binary statically.

This made it build properly
```
diff --git a/srcpkgs/matterhorn/template b/srcpkgs/matterhorn/template
index 83dbcd0aac..95681b649c 100644
--- a/srcpkgs/matterhorn/template
+++ b/srcpkgs/matterhorn/template
@@ -16,7 +16,7 @@ nopie_files="/usr/bin/matterhorn"
 do_build() {
        rm -f cabal.project
        cabal new-update
-       cabal new-build -j --enable-shared --enable-executable-dynamic --ghc-options=-dynamic
+       cabal new-build --jobs="${XBPS_MAKEJOBS}" --disable-executable-dynamic
 }

 do_install() {
```
but there are more things that should be fixed about your template, definitely installing with `vbin "$(find ...)"` is a bad idea, either change it to the exact location of the output binary or better use the `cabal new-install` subcommand if it's possible to give it a `$DESTDIR`.

Re: WIP: New package: matterhorn-50200.7.0

[Eluminae]

[-- Attachment #1: Type: text/plain, Size: 2112 bytes --]

New comment by Eluminae on void-packages repository

https://github.com/void-linux/void-packages/pull/20136#issuecomment-599730646

Comment:
> I don't see the whole error in your last comment so I can't tell exactly but, Stack doesn't have to have the package you're trying to build it has to have all it's dependencies and it's not the case for matterhorn anyway so that won't work.

Yeah I just tried to play with the lts stack variable without
understanding what I was doing, stucked on the "omg it miss all of those
dependencies" step.

> The error you get with cabal is caused by it being built as a dynamically linked binary, all the haskell libraries are being linked dynamicaly, and then you don't include them in the package, xbps goest to search for them and then it tells you it couldn't find any package providing those libraries. The solution is (since those libraries wouldn't be useful to anything else) is to link the binary statically.
> 
> This made it build properly
> ```
> diff --git a/srcpkgs/matterhorn/template b/srcpkgs/matterhorn/template
> index 83dbcd0aac..95681b649c 100644
> --- a/srcpkgs/matterhorn/template
> +++ b/srcpkgs/matterhorn/template
> @@ -16,7 +16,7 @@ nopie_files="/usr/bin/matterhorn"
>  do_build() {
>         rm -f cabal.project
>         cabal new-update
> -       cabal new-build -j --enable-shared --enable-executable-dynamic --ghc-options=-dynamic
> +       cabal new-build --jobs="${XBPS_MAKEJOBS}" --disable-executable-dynamic
>  }
> 
>  do_install() {
> ```

Oh yeah, it feels always better when you understand what your doing.
Thanks a lot for you help, you made it working!

> but there are more things that should be fixed about your template, definitely installing with `vbin "$(find ...)"` is a bad idea, either change it to the exact location of the output binary or better use the `cabal new-install` subcommand if it's possible to give it a `$DESTDIR`.

I agree, I'll try something better. It seems there is a destdir cabal
argument but I think using the bin path a more minimalist way (but the
full path is horrible x))

Thanks again for your help!

Re: New package: matterhorn-50200.7.0

[ametisf]

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

New comment by ametisf on void-packages repository

https://github.com/void-linux/void-packages/pull/20136#issuecomment-599706556

Comment:
I don't see the whole error in your last comment so I can't tell exactly but Stack doesn't have to have the package you're trying to build it has to have all its dependencies and it's not the case for matterhorn anyway so that won't work.

The error you get with cabal is caused by building it as a dynamically linked binary, all the haskell libraries are linked dynamicaly, and then you don't include them in the package, xbps goes to search for them and tells you it couldn't find any package providing those libraries. The solution is (since those libraries wouldn't be useful for anything else) to link the binary statically.

This made it build properly
```
diff --git a/srcpkgs/matterhorn/template b/srcpkgs/matterhorn/template
index 83dbcd0aac..95681b649c 100644
--- a/srcpkgs/matterhorn/template
+++ b/srcpkgs/matterhorn/template
@@ -16,7 +16,7 @@ nopie_files="/usr/bin/matterhorn"
 do_build() {
        rm -f cabal.project
        cabal new-update
-       cabal new-build -j --enable-shared --enable-executable-dynamic --ghc-options=-dynamic
+       cabal new-build --jobs="${XBPS_MAKEJOBS}" --disable-executable-dynamic
 }

 do_install() {
```
but there are more things that should be fixed about your template, definitely installing with `vbin "$(find ...)"` is a bad idea, either change it to the exact location of the output binary or better use the `cabal new-install` subcommand if it's possible to give it a `$DESTDIR`.

Re: [PR PATCH] [Updated] New package: matterhorn-50200.7.0

[Eluminae]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

There is an updated pull request by Eluminae against master on the void-packages repository

https://github.com/Eluminae/void-packages matterhorn
https://github.com/void-linux/void-packages/pull/20136

New package: matterhorn-50200.7.0
related: https://github.com/void-linux/void-packages/issues/20115

A patch file from https://github.com/void-linux/void-packages/pull/20136.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-matterhorn-20136.patch --]
[-- Type: text/x-diff, Size: 1449 bytes --]

From 10345405aeb46bccf493508ceae33429ca30a787 Mon Sep 17 00:00:00 2001
From: Reed Wade <reedwade@misterbanal.net>
Date: Mon, 16 Mar 2020 15:55:03 +0100
Subject: [PATCH] New package: matterhorn-50200.7.0

---
 srcpkgs/matterhorn/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/matterhorn/template

diff --git a/srcpkgs/matterhorn/template b/srcpkgs/matterhorn/template
new file mode 100644
index 00000000000..4a139f8fb0f
--- /dev/null
+++ b/srcpkgs/matterhorn/template
@@ -0,0 +1,24 @@
+# Template file for 'matterhorn'
+pkgname=matterhorn
+version=50200.7.0
+revision=1
+makedepends="cabal-install ghc zlib-devel ncurses-devel"
+short_desc="Terminal-based chat client for MatterMost"
+maintainer="Stacy Harper <contact@stacyharper.net>"
+license="BSD-3-Clause"
+homepage="https://github.com/matterhorn-chat/matterhorn"
+changelog="https://raw.githubusercontent.com/matterhorn-chat/matterhorn/master/CHANGELOG.md"
+distfiles="https://github.com/matterhorn-chat/matterhorn/archive/${version}.tar.gz"
+checksum=24ee5ac95c37e30e209ed6d39f4e9986c2f37365382e4f56a8e1988516f26ff3
+nopie_files="/usr/bin/matterhorn"
+
+do_build() {
+	rm -f cabal.project
+	cabal new-update
+	cabal new-build --jobs="${XBPS_MAKEJOBS}" --disable-executable-dynamic
+}
+
+do_install() {
+	vbin dist-newstyle/build/"$(arch)"-linux/ghc-8.6.5/matterhorn-50200.7.0/x/matterhorn/build/matterhorn/matterhorn
+	vlicense LICENSE
+}

Re: [PR PATCH] [Updated] New package: matterhorn-50200.7.0

[Eluminae]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

There is an updated pull request by Eluminae against master on the void-packages repository

https://github.com/Eluminae/void-packages matterhorn
https://github.com/void-linux/void-packages/pull/20136

New package: matterhorn-50200.7.0
related: https://github.com/void-linux/void-packages/issues/20115

A patch file from https://github.com/void-linux/void-packages/pull/20136.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-matterhorn-20136.patch --]
[-- Type: text/x-diff, Size: 1457 bytes --]

From c6f311bd5bcb9ef510fb6464c982d47e5a063e43 Mon Sep 17 00:00:00 2001
From: Reed Wade <reedwade@misterbanal.net>
Date: Mon, 16 Mar 2020 15:55:03 +0100
Subject: [PATCH] New package: matterhorn-50200.7.0

---
 srcpkgs/matterhorn/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/matterhorn/template

diff --git a/srcpkgs/matterhorn/template b/srcpkgs/matterhorn/template
new file mode 100644
index 00000000000..2feccd8d5d6
--- /dev/null
+++ b/srcpkgs/matterhorn/template
@@ -0,0 +1,24 @@
+# Template file for 'matterhorn'
+pkgname=matterhorn
+version=50200.7.0
+revision=1
+makedepends="cabal-install ghc zlib-devel ncurses-devel"
+short_desc="Terminal-based chat client for MatterMost"
+maintainer="Stacy Harper <contact@stacyharper.net>"
+license="BSD-3-Clause"
+homepage="https://github.com/matterhorn-chat/matterhorn"
+changelog="https://raw.githubusercontent.com/matterhorn-chat/matterhorn/master/CHANGELOG.md"
+distfiles="https://github.com/matterhorn-chat/matterhorn/archive/${version}.tar.gz"
+checksum=24ee5ac95c37e30e209ed6d39f4e9986c2f37365382e4f56a8e1988516f26ff3
+nopie_files="/usr/bin/matterhorn"
+
+do_build() {
+	rm -f cabal.project
+	cabal new-update
+	cabal new-build --jobs="${XBPS_MAKEJOBS}" --disable-executable-dynamic
+}
+
+do_install() {
+	vbin dist-newstyle/build/"${XBPS_MACHINE}"-linux/ghc-8.6.5/matterhorn-50200.7.0/x/matterhorn/build/matterhorn/matterhorn
+	vlicense LICENSE
+}

Re: [PR PATCH] [Updated] New package: matterhorn-50200.7.0

[Eluminae]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

There is an updated pull request by Eluminae against master on the void-packages repository

https://github.com/Eluminae/void-packages matterhorn
https://github.com/void-linux/void-packages/pull/20136

New package: matterhorn-50200.7.0
related: https://github.com/void-linux/void-packages/issues/20115

A patch file from https://github.com/void-linux/void-packages/pull/20136.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-matterhorn-20136.patch --]
[-- Type: text/x-diff, Size: 1478 bytes --]

From 44319b2d00be7c14aa95a1e7d15af7b9d876ae1f Mon Sep 17 00:00:00 2001
From: Reed Wade <reedwade@misterbanal.net>
Date: Mon, 16 Mar 2020 15:55:03 +0100
Subject: [PATCH] New package: matterhorn-50200.7.0

---
 srcpkgs/matterhorn/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/matterhorn/template

diff --git a/srcpkgs/matterhorn/template b/srcpkgs/matterhorn/template
new file mode 100644
index 00000000000..11f112dc88e
--- /dev/null
+++ b/srcpkgs/matterhorn/template
@@ -0,0 +1,25 @@
+# Template file for 'matterhorn'
+pkgname=matterhorn
+version=50200.7.0
+revision=1
+hostmakedepends="cabal-install ghc"
+makedepends="zlib-devel ncurses-devel"
+short_desc="Terminal-based chat client for MatterMost"
+maintainer="Stacy Harper <contact@stacyharper.net>"
+license="BSD-3-Clause"
+homepage="https://github.com/matterhorn-chat/matterhorn"
+changelog="https://raw.githubusercontent.com/matterhorn-chat/matterhorn/master/CHANGELOG.md"
+distfiles="https://github.com/matterhorn-chat/matterhorn/archive/${version}.tar.gz"
+checksum=24ee5ac95c37e30e209ed6d39f4e9986c2f37365382e4f56a8e1988516f26ff3
+nopie_files="/usr/bin/matterhorn"
+
+do_build() {
+	rm -f cabal.project
+	cabal new-update
+	cabal new-build --jobs="${XBPS_MAKEJOBS}" --disable-executable-dynamic
+}
+
+do_install() {
+	vbin dist-newstyle/build/"${XBPS_MACHINE}"-linux/ghc-8.6.5/matterhorn-${version}/x/matterhorn/build/matterhorn/matterhorn
+	vlicense LICENSE
+}

Re: New package: matterhorn-50200.7.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/20136#issuecomment-1100506529

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: matterhorn-50200.7.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

There's a closed pull request on the void-packages repository

New package: matterhorn-50200.7.0
https://github.com/void-linux/void-packages/pull/20136

Description:
related: https://github.com/void-linux/void-packages/issues/20115