From: freshprince <freshprince@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] synapse: update to 1.58.0.
Date: Wed, 04 May 2022 11:27:17 +0200 [thread overview]
Message-ID: <20220504092717.C2oNI25LE1IxiG2bt-_WohYTiTnd_0Z1-hKct_UZP_k@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36973@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
New review comment by freshprince on void-packages repository
https://github.com/void-linux/void-packages/pull/36973#discussion_r864629866
Comment:
true... hmm.
my last suggestion:
```
pre_check() {
pip install -t ./ --no-deps ${make_install_target}
}
```
this produces some warnings because some directories already exist but won't pollute masterdir.
next prev parent reply other threads:[~2022-05-04 9:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 12:34 [PR PATCH] " TinfoilSubmarine
2022-05-04 8:35 ` [PR REVIEW] " freshprince
2022-05-04 8:39 ` paper42
2022-05-04 9:00 ` freshprince
2022-05-04 9:08 ` paper42
2022-05-04 9:27 ` freshprince [this message]
2022-05-04 12:38 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-05-04 12:39 ` [PR REVIEW] " TinfoilSubmarine
2022-05-04 12:58 ` TinfoilSubmarine
2022-05-04 14:11 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-05-04 14:13 ` TinfoilSubmarine
2022-05-07 21:34 ` [PR REVIEW] " paper42
2022-05-07 21:35 ` TinfoilSubmarine
2022-05-07 21:38 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-05-09 8:41 ` paper42
2022-05-09 9:03 ` [PR REVIEW] " paper42
2022-05-09 9:04 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504092717.C2oNI25LE1IxiG2bt-_WohYTiTnd_0Z1-hKct_UZP_k@z \
--to=freshprince@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).