[PR PATCH] git: add perl-CGI to depends to fix gitweb

[PR PATCH] git: add perl-CGI to depends to fix gitweb

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

There is a new pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages gitweb
https://github.com/void-linux/void-packages/pull/37018

git: add perl-CGI to depends to fix gitweb
When `perl-CGI` is not installed, `git instaweb` opens a blank browser page. This is not a new problem <https://bbs.archlinux.org/viewtopic.php?id=203412>.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37018.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gitweb-37018.patch --]
[-- Type: text/x-diff, Size: 959 bytes --]

From 44723d4d460fd602fc5d3072228961895686d5b1 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Sat, 7 May 2022 11:47:49 +0200
Subject: [PATCH] git: add perl-CGI to depends to fix gitweb

---
 srcpkgs/git/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/git/template b/srcpkgs/git/template
index dc2146690ab2..08217683b297 100644
--- a/srcpkgs/git/template
+++ b/srcpkgs/git/template
@@ -6,7 +6,7 @@ revision=2
 hostmakedepends="asciidoc gettext perl pkg-config tk xmlto"
 makedepends="libglib-devel libcurl-devel libsecret-devel pcre2-devel tk-devel"
 # Required by https://
-depends="ca-certificates perl-Authen-SASL perl-MIME-tools perl-Net-SMTP-SSL"
+depends="ca-certificates perl-Authen-SASL perl-MIME-tools perl-Net-SMTP-SSL perl-CGI"
 checkdepends="gnupg cvs cvsps2 perl-DBD-SQLite subversion subversion-perl
  perl-Term-ReadKey perl-CGI perl-IO-Tty"
 short_desc="Git Tree History Storage Tool"

Re: [PR PATCH] [Updated] git: add perl-CGI to depends to fix gitweb

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

There is an updated pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages gitweb
https://github.com/void-linux/void-packages/pull/37018

git: add perl-CGI to depends to fix gitweb
When `perl-CGI` is not installed, `git instaweb` opens a blank browser page. This is not a new problem <https://bbs.archlinux.org/viewtopic.php?id=203412>.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37018.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gitweb-37018.patch --]
[-- Type: text/x-diff, Size: 1027 bytes --]

From 11ebb513758bd88793cac7f2eaa98c0a1498571d Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Sat, 7 May 2022 11:47:49 +0200
Subject: [PATCH] git: add perl-CGI to depends to fix gitweb

---
 srcpkgs/git/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/git/template b/srcpkgs/git/template
index dc2146690ab2..d10c6119c273 100644
--- a/srcpkgs/git/template
+++ b/srcpkgs/git/template
@@ -2,11 +2,11 @@
 pkgname=git
 reverts="2.36.0_1"
 version=2.35.3
-revision=2
+revision=3
 hostmakedepends="asciidoc gettext perl pkg-config tk xmlto"
 makedepends="libglib-devel libcurl-devel libsecret-devel pcre2-devel tk-devel"
 # Required by https://
-depends="ca-certificates perl-Authen-SASL perl-MIME-tools perl-Net-SMTP-SSL"
+depends="ca-certificates perl-Authen-SASL perl-MIME-tools perl-Net-SMTP-SSL perl-CGI"
 checkdepends="gnupg cvs cvsps2 perl-DBD-SQLite subversion subversion-perl
  perl-Term-ReadKey perl-CGI perl-IO-Tty"
 short_desc="Git Tree History Storage Tool"

Re: git: add perl-CGI to depends to fix gitweb

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/37018#issuecomment-1120179222

Comment:
@sgn

Re: git: add perl-CGI to depends to fix gitweb

[sgn]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/37018#issuecomment-1120326056

Comment:
Sorry, no. I don't want to install another perl package to my machine.
It's optional dependency, should you need gitweb, you would install it yourself. IIRC, git-instaweb also requires an http server to be functioning, will you make git depends on them, too?

Re: git: add perl-CGI to depends to fix gitweb

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

New comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/37018#issuecomment-1120332630

Comment:
It is not obvious that gitweb needs perl-CGI. If it's not installed, git-instaweb doesn't print any warning of any kind. The need for a web server is instead clearly documented in the man page and reminded by an error message.
It would make sense to split gitweb into a subpackage, but this could break the setup of people already running it on their server. What do you think?

Re: git: add perl-CGI to depends to fix gitweb

[sgn]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/37018#issuecomment-1120337392

Comment:
Maybe a document in `/usr/share/doc/git` will help, I think.

Re: [PR PATCH] [Closed]: git: add perl-CGI to depends to fix gitweb

[r-ricci]

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

There's a closed pull request on the void-packages repository

git: add perl-CGI to depends to fix gitweb
https://github.com/void-linux/void-packages/pull/37018

Description:
When `perl-CGI` is not installed, `git instaweb` opens a blank browser page. This is not a new problem <https://bbs.archlinux.org/viewtopic.php?id=203412>.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->