Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] oil: bring package contents more inline with the project's install script
@ 2021-09-05 23:03 AviKav
  2021-09-05 23:23 ` [PR REVIEW] " Duncaen
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: AviKav @ 2021-09-05 23:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

There is a new pull request by AviKav against master on the void-packages repository

https://github.com/AviKav/void-packages oil
https://github.com/void-linux/void-packages/pull/32850

oil: bring package contents more inline with the project's install script
 Add `oil` symlink as well as man page
Project no longer bothers to symlink `oshc` (seems to be incomplete/broken)

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/32850.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-oil-32850.patch --]
[-- Type: text/x-diff, Size: 1470 bytes --]

From 32d701e821b6df33acdd2207762211a3289a89fd Mon Sep 17 00:00:00 2001
From: AviKav <avikav@avikav.net>
Date: Sun, 5 Sep 2021 16:53:29 -0400
Subject: [PATCH] oil: bring package contents more inline with the project's
 install script

include man page
add oil as a command and as a shell
remove oshc as the projects's own install script no longer installs it
---
 srcpkgs/oil/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/oil/template b/srcpkgs/oil/template
index 09b496a6d3b1..3c1b5e9a7ebe 100644
--- a/srcpkgs/oil/template
+++ b/srcpkgs/oil/template
@@ -1,7 +1,7 @@
 # Template file for 'oil'
 pkgname=oil
 version=0.9.0
-revision=1
+revision=2
 build_style=configure
 configure_args="--prefix=/usr $(vopt_with readline)"
 hostmakedepends="$(vopt_if readline readline-devel)"
@@ -12,7 +12,7 @@ license="Apache-2.0"
 homepage="https://www.oilshell.org"
 distfiles="${homepage}/download/${pkgname}-${version}.tar.xz"
 checksum=c64e22a3665756ea54ea60aa983f7893501a13c2a4d1c7f73c8c76f17ea03636
-register_shell="/usr/bin/osh"
+register_shell="/usr/bin/osh /usr/bin/osh"
 nocross="Build systems gets confused with host and cross toolchains/headers"
 nostrip=yes
 
@@ -27,8 +27,9 @@ pre_build() {
 do_install() {
 	# Install binaries
 	vbin _bin/oil.ovm
-	# Symlink osh, oshc to oil.ovm.
+	vman doc/osh.1
+	# Symlink osh, oil to oil.ovm.
 	cd "${DESTDIR}"/usr/bin
 	ln -s oil.ovm osh
-	ln -s oil.ovm oshc
+	ln -s oil.ovm oil
 }

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] oil: bring package contents more inline with the project's install script
  2021-09-05 23:03 [PR PATCH] oil: bring package contents more inline with the project's install script AviKav
@ 2021-09-05 23:23 ` Duncaen
  2021-09-06  2:29 ` [PR PATCH] [Updated] " AviKav
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Duncaen @ 2021-09-05 23:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/32850#discussion_r702491194

Comment:
I think you wanted `/usr/bin/oil`.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] oil: bring package contents more inline with the project's install script
  2021-09-05 23:03 [PR PATCH] oil: bring package contents more inline with the project's install script AviKav
  2021-09-05 23:23 ` [PR REVIEW] " Duncaen
@ 2021-09-06  2:29 ` AviKav
  2021-09-06  2:32 ` [PR REVIEW] " AviKav
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: AviKav @ 2021-09-06  2:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

There is an updated pull request by AviKav against master on the void-packages repository

https://github.com/AviKav/void-packages oil
https://github.com/void-linux/void-packages/pull/32850

oil: bring package contents more inline with the project's install script
 Add `oil` symlink as well as man page
Project no longer bothers to symlink `oshc` (seems to be incomplete/broken)

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/32850.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-oil-32850.patch --]
[-- Type: text/x-diff, Size: 1470 bytes --]

From 5cef434f829e98b5891137033b6f18bf687d2871 Mon Sep 17 00:00:00 2001
From: AviKav <avikav@avikav.net>
Date: Sun, 5 Sep 2021 16:53:29 -0400
Subject: [PATCH] oil: bring package contents more inline with the project's
 install script

include man page
add oil as a command and as a shell
remove oshc as the projects's own install script no longer installs it
---
 srcpkgs/oil/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/oil/template b/srcpkgs/oil/template
index 09b496a6d3b1..934607a92a1e 100644
--- a/srcpkgs/oil/template
+++ b/srcpkgs/oil/template
@@ -1,7 +1,7 @@
 # Template file for 'oil'
 pkgname=oil
 version=0.9.0
-revision=1
+revision=2
 build_style=configure
 configure_args="--prefix=/usr $(vopt_with readline)"
 hostmakedepends="$(vopt_if readline readline-devel)"
@@ -12,7 +12,7 @@ license="Apache-2.0"
 homepage="https://www.oilshell.org"
 distfiles="${homepage}/download/${pkgname}-${version}.tar.xz"
 checksum=c64e22a3665756ea54ea60aa983f7893501a13c2a4d1c7f73c8c76f17ea03636
-register_shell="/usr/bin/osh"
+register_shell="/usr/bin/osh /usr/bin/oil"
 nocross="Build systems gets confused with host and cross toolchains/headers"
 nostrip=yes
 
@@ -27,8 +27,9 @@ pre_build() {
 do_install() {
 	# Install binaries
 	vbin _bin/oil.ovm
-	# Symlink osh, oshc to oil.ovm.
+	vman doc/osh.1
+	# Symlink osh, oil to oil.ovm.
 	cd "${DESTDIR}"/usr/bin
 	ln -s oil.ovm osh
-	ln -s oil.ovm oshc
+	ln -s oil.ovm oil
 }

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] oil: bring package contents more inline with the project's install script
  2021-09-05 23:03 [PR PATCH] oil: bring package contents more inline with the project's install script AviKav
  2021-09-05 23:23 ` [PR REVIEW] " Duncaen
  2021-09-06  2:29 ` [PR PATCH] [Updated] " AviKav
@ 2021-09-06  2:32 ` AviKav
  2021-09-06 19:04 ` ericonr
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: AviKav @ 2021-09-06  2:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by AviKav on void-packages repository

https://github.com/void-linux/void-packages/pull/32850#discussion_r702525801

Comment:
Thanks! Fixed

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] oil: bring package contents more inline with the project's install script
  2021-09-05 23:03 [PR PATCH] oil: bring package contents more inline with the project's install script AviKav
                   ` (2 preceding siblings ...)
  2021-09-06  2:32 ` [PR REVIEW] " AviKav
@ 2021-09-06 19:04 ` ericonr
  2022-05-08  5:06 ` AviKav
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-09-06 19:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32850#discussion_r703044778

Comment:
Not sure it makes sense to break people's stuff like this... Why not keep `oshc` around?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] oil: bring package contents more inline with the project's install script
  2021-09-05 23:03 [PR PATCH] oil: bring package contents more inline with the project's install script AviKav
                   ` (3 preceding siblings ...)
  2021-09-06 19:04 ` ericonr
@ 2022-05-08  5:06 ` AviKav
  2022-05-08  5:07 ` AviKav
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: AviKav @ 2022-05-08  5:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

New review comment by AviKav on void-packages repository

https://github.com/void-linux/void-packages/pull/32850#discussion_r867435513

Comment:
From the project author:

> `oshc translate` and `oshc` are mostly experimental.  The project has moved away from source translation in favor of simply running bash scripts with OSH, and allowing OSH and Oil to seamlessly interoperate.
> 
> I think the only reason to keep them would be to expose the experiments to users and hope someone takes over :)
> 
> But it should be fine to delete them; I don't think anyone is using them.  They're not really documented

https://oilshell.zulipchat.com/#narrow/stream/264891-oil-help/topic/Removing.20.60oshc.60.20from.20Void's.20packages/near/252874976

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: oil: bring package contents more inline with the project's install script
  2021-09-05 23:03 [PR PATCH] oil: bring package contents more inline with the project's install script AviKav
                   ` (4 preceding siblings ...)
  2022-05-08  5:06 ` AviKav
@ 2022-05-08  5:07 ` AviKav
  2022-05-23  6:09 ` bugcrazy
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: AviKav @ 2022-05-08  5:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by AviKav on void-packages repository

https://github.com/void-linux/void-packages/pull/32850#issuecomment-1120351216

Comment:
cc'ing maintainer @bugcrazy 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: oil: bring package contents more inline with the project's install script
  2021-09-05 23:03 [PR PATCH] oil: bring package contents more inline with the project's install script AviKav
                   ` (5 preceding siblings ...)
  2022-05-08  5:07 ` AviKav
@ 2022-05-23  6:09 ` bugcrazy
  2022-06-03  7:46 ` [PR PATCH] [Updated] " AviKav
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: bugcrazy @ 2022-05-23  6:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/32850#issuecomment-1134221961

Comment:
> cc'ing maintainer @bugcrazy

I see no problem with commit, because code works, because creator of the source code, also spoke of the change!

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] oil: bring package contents more inline with the project's install script
  2021-09-05 23:03 [PR PATCH] oil: bring package contents more inline with the project's install script AviKav
                   ` (6 preceding siblings ...)
  2022-05-23  6:09 ` bugcrazy
@ 2022-06-03  7:46 ` AviKav
  2022-08-15  9:51 ` bugcrazy
  2022-08-15 21:09 ` [PR PATCH] [Closed]: " AviKav
  9 siblings, 0 replies; 11+ messages in thread
From: AviKav @ 2022-06-03  7:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

There is an updated pull request by AviKav against master on the void-packages repository

https://github.com/AviKav/void-packages oil
https://github.com/void-linux/void-packages/pull/32850

oil: bring package contents more inline with the project's install script
 Add `oil` symlink as well as man page
Project no longer bothers to symlink `oshc` (seems to be incomplete/broken)

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/32850.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-oil-32850.patch --]
[-- Type: text/x-diff, Size: 1471 bytes --]

From 3fd1da438eb324a000bc34cd12f2691152e44e26 Mon Sep 17 00:00:00 2001
From: AviKav <avikav@avikav.net>
Date: Sun, 5 Sep 2021 16:53:29 -0400
Subject: [PATCH] oil: bring package contents more inline with the project's
 install script

include man page
add oil as a command and as a shell
remove oshc as the projects's own install script no longer installs it
---
 srcpkgs/oil/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/oil/template b/srcpkgs/oil/template
index 8866e01d7f94..15aeffc40a59 100644
--- a/srcpkgs/oil/template
+++ b/srcpkgs/oil/template
@@ -1,7 +1,7 @@
 # Template file for 'oil'
 pkgname=oil
 version=0.10.0
-revision=1
+revision=2
 build_style=configure
 configure_args="--prefix=/usr $(vopt_with readline)"
 hostmakedepends="$(vopt_if readline readline-devel)"
@@ -12,7 +12,7 @@ license="Apache-2.0"
 homepage="https://www.oilshell.org"
 distfiles="${homepage}/download/${pkgname}-${version}.tar.xz"
 checksum=cf7da9494ba9f0f101d27f0d0b5e248f8a54721ddeec13dd54652c9528580296
-register_shell="/usr/bin/osh"
+register_shell="/usr/bin/osh /usr/bin/oil"
 nocross="Build systems gets confused with host and cross toolchains/headers"
 nostrip=yes
 
@@ -27,8 +27,9 @@ pre_build() {
 do_install() {
 	# Install binaries
 	vbin _bin/oil.ovm
-	# Symlink osh, oshc to oil.ovm.
+	vman doc/osh.1
+	# Symlink osh, oil to oil.ovm.
 	cd "${DESTDIR}"/usr/bin
 	ln -s oil.ovm osh
-	ln -s oil.ovm oshc
+	ln -s oil.ovm oil
 }

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: oil: bring package contents more inline with the project's install script
  2021-09-05 23:03 [PR PATCH] oil: bring package contents more inline with the project's install script AviKav
                   ` (7 preceding siblings ...)
  2022-06-03  7:46 ` [PR PATCH] [Updated] " AviKav
@ 2022-08-15  9:51 ` bugcrazy
  2022-08-15 21:09 ` [PR PATCH] [Closed]: " AviKav
  9 siblings, 0 replies; 11+ messages in thread
From: bugcrazy @ 2022-08-15  9:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/32850#issuecomment-1214834407

Comment:
This commit is already applied to the template since version 0.11.0!

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Closed]: oil: bring package contents more inline with the project's install script
  2021-09-05 23:03 [PR PATCH] oil: bring package contents more inline with the project's install script AviKav
                   ` (8 preceding siblings ...)
  2022-08-15  9:51 ` bugcrazy
@ 2022-08-15 21:09 ` AviKav
  9 siblings, 0 replies; 11+ messages in thread
From: AviKav @ 2022-08-15 21:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

There's a closed pull request on the void-packages repository

oil: bring package contents more inline with the project's install script
https://github.com/void-linux/void-packages/pull/32850

Description:
 Add `oil` symlink as well as man page
Project no longer bothers to symlink `oshc` (seems to be incomplete/broken)

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-08-15 21:09 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-05 23:03 [PR PATCH] oil: bring package contents more inline with the project's install script AviKav
2021-09-05 23:23 ` [PR REVIEW] " Duncaen
2021-09-06  2:29 ` [PR PATCH] [Updated] " AviKav
2021-09-06  2:32 ` [PR REVIEW] " AviKav
2021-09-06 19:04 ` ericonr
2022-05-08  5:06 ` AviKav
2022-05-08  5:07 ` AviKav
2022-05-23  6:09 ` bugcrazy
2022-06-03  7:46 ` [PR PATCH] [Updated] " AviKav
2022-08-15  9:51 ` bugcrazy
2022-08-15 21:09 ` [PR PATCH] [Closed]: " AviKav

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).