Github messages for voidlinux
 help / color / mirror / Atom feed
From: JamiKettunen <JamiKettunen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: wvkbd-0.7
Date: Mon, 09 May 2022 18:36:26 +0200	[thread overview]
Message-ID: <20220509163626.8VDO5n8qKDTUV012P9gYYXgDD01ZalOc6UWx-ytLcFQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36910@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/36910#discussion_r868202391

Comment:
No need for this with `make_use_env=1`, the Makefile looks fine enough to honor most environment variables `xbps-src` sets, [for `LDFLAGS` there is a PR](https://github.com/jjsullivan5196/wvkbd/pull/27) as well and that patch can be carried here till it's merged.

  parent reply	other threads:[~2022-05-09 16:36 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 10:54 [PR PATCH] New package: wvkbd-7.0 Eloitor
2022-04-29 10:56 ` [PR PATCH] [Updated] " Eloitor
2022-04-29 11:01 ` [PR PATCH] [Updated] New package: wvkbd-0.7 Eloitor
2022-04-29 16:17 ` [PR REVIEW] " classabbyamp
2022-04-29 16:17 ` classabbyamp
2022-04-29 17:04 ` Eloitor
2022-04-29 17:10 ` classabbyamp
2022-04-29 19:28 ` [PR PATCH] [Updated] " Eloitor
2022-04-29 19:30 ` Eloitor
2022-04-30  1:36 ` [PR REVIEW] " classabbyamp
2022-04-30  4:27 ` [PR PATCH] [Updated] " Eloitor
2022-04-30  4:48 ` [PR REVIEW] " Eloitor
2022-05-09 16:32 ` JamiKettunen
2022-05-09 16:33 ` JamiKettunen
2022-05-09 16:36 ` JamiKettunen [this message]
2022-05-11 17:44 ` paper42
2022-05-20 14:12 ` JamiKettunen
2022-05-20 20:05 ` [PR PATCH] [Updated] " Eloitor
2022-05-20 20:09 ` Eloitor
2022-05-20 20:11 ` Eloitor
2022-05-22 15:52 ` [PR REVIEW] " Eloitor
2022-06-29 20:11 ` Duncaen
2022-07-01  9:30 ` JamiKettunen
2022-07-03  7:38 ` Eloitor
2022-07-04  9:38 ` [PR PATCH] [Updated] " Eloitor
2022-07-04  9:49 ` Eloitor
2022-07-04  9:55 ` Eloitor
2022-07-04  9:56 ` Eloitor
2022-07-04  9:59 ` Eloitor
2022-07-04 10:00 ` [PR PATCH] [Updated] New package: wvkbd-0.8.2 Eloitor
2022-07-04 10:48 ` JamiKettunen
2022-07-04 10:51 ` [PR PATCH] [Updated] " Eloitor
2022-07-04 10:53 ` Eloitor
2022-07-04 10:54 ` paper42
2022-07-04 10:56 ` [PR PATCH] [Updated] " Eloitor
2022-07-04 10:56 ` Eloitor
2022-07-04 10:57 ` Eloitor
2022-07-04 10:57 ` paper42
2022-07-04 10:57 ` paper42
2022-07-04 10:58 ` paper42
2022-07-04 11:04 ` [PR PATCH] [Updated] " Eloitor
2022-07-04 11:05 ` Eloitor
2022-07-04 13:12 ` paper42
2022-07-04 13:12 ` paper42
2022-07-04 13:33 ` [PR PATCH] [Updated] " Eloitor
2022-07-05  8:19 ` [PR PATCH] [Merged]: " the-maldridge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509163626.8VDO5n8qKDTUV012P9gYYXgDD01ZalOc6UWx-ytLcFQ@z \
    --to=jamikettunen@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).