Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] Fix up intl and NLS on musl and glibc (for some few packages)
@ 2021-03-24  3:05 ericonr
  2022-05-11  2:12 ` github-actions
  2022-05-25  2:14 ` [ISSUE] [CLOSED] " github-actions
  0 siblings, 2 replies; 3+ messages in thread
From: ericonr @ 2021-03-24  3:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]

New issue by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/29710

Description:
On a musl system, `xbps-query -p shlib-requires -Rs libintl` provides the list of packages that still depend on `libtintl` for some reason. Some of them hardcode usage of glibc'isms like `_nl_msg_cat_cntr`, but most don't, and we should be able to fix them to use musl's `gettext` impl. See #29240 for more details and an initial push.

musl doesn't protect programs from calling `gettex(NULL)`, which while undefined behavior per the Gettext manual, doesn't actually segfault there, so before pushing a package to not use `libintl`, please also verify that it does work cleanly with musl's gettext impl. We have a workaround patch for now (https://github.com/void-linux/void-packages/blob/edb478c1a4a0bd54d692c2296eedefb93ff885a7/srcpkgs/musl/patches/mo_lookup.patch), but I would like to remove it at some point - at least GIMP, as one of the crashing applications, has been fixed.

Furthermore, lots of templates have `--disable-nls` or similar (grepping for `-nls` might work well?) for all archs or only for musl, which is not an ideal state of affairs; ideally, we'd always have internationalization support enabled and working. So hunting down such packages and also fixing them would be nice.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix up intl and NLS on musl and glibc (for some few packages)
  2021-03-24  3:05 [ISSUE] Fix up intl and NLS on musl and glibc (for some few packages) ericonr
@ 2022-05-11  2:12 ` github-actions
  2022-05-25  2:14 ` [ISSUE] [CLOSED] " github-actions
  1 sibling, 0 replies; 3+ messages in thread
From: github-actions @ 2022-05-11  2:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/29710#issuecomment-1123102226

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ISSUE] [CLOSED] Fix up intl and NLS on musl and glibc (for some few packages)
  2021-03-24  3:05 [ISSUE] Fix up intl and NLS on musl and glibc (for some few packages) ericonr
  2022-05-11  2:12 ` github-actions
@ 2022-05-25  2:14 ` github-actions
  1 sibling, 0 replies; 3+ messages in thread
From: github-actions @ 2022-05-25  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]

Closed issue by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/29710

Description:
On a musl system, `xbps-query -p shlib-requires -Rs libintl` provides the list of packages that still depend on `libtintl` for some reason. Some of them hardcode usage of glibc'isms like `_nl_msg_cat_cntr`, but most don't, and we should be able to fix them to use musl's `gettext` impl. See #29240 for more details and an initial push.

musl doesn't protect programs from calling `gettex(NULL)`, which while undefined behavior per the Gettext manual, doesn't actually segfault there, so before pushing a package to not use `libintl`, please also verify that it does work cleanly with musl's gettext impl. We have a workaround patch for now (https://github.com/void-linux/void-packages/blob/edb478c1a4a0bd54d692c2296eedefb93ff885a7/srcpkgs/musl/patches/mo_lookup.patch), but I would like to remove it at some point - at least GIMP, as one of the crashing applications, has been fixed.

Furthermore, lots of templates have `--disable-nls` or similar (grepping for `-nls` might work well?) for all archs or only for musl, which is not an ideal state of affairs; ideally, we'd always have internationalization support enabled and working. So hunting down such packages and also fixing them would be nice.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-25  2:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24  3:05 [ISSUE] Fix up intl and NLS on musl and glibc (for some few packages) ericonr
2022-05-11  2:12 ` github-actions
2022-05-25  2:14 ` [ISSUE] [CLOSED] " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).