Github messages for voidlinux
 help / color / mirror / Atom feed
From: zen0bit <zen0bit@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: lazydocker: update to 0.17.1
Date: Thu, 12 May 2022 13:15:27 +0200	[thread overview]
Message-ID: <20220512111527.9BAnTHoXbRxemsAwCUMT5IjCtcwTL1JgBf3wqihHaJk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37065@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]

New comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/37065#issuecomment-1124865862

Comment:
> > I will wait because of [this](https://github.com/jesseduffield/lazydocker/issues/327)
> 
> That's an issue with their docker build, we are not using that, so we are not affected.
> 
> > Also, I was trying to figure out how to correct the "lazydocker unversioned"
> 
> I usually look at their Makefile or Dockerfile where they set ldflags: https://github.com/jesseduffield/lazydocker/blob/4f096c3c2b60a063d04b9b7ba9236a4d821e4563/Dockerfile#L16
> 
> @zen0bit please add `go_ldflags="-X main.version=${version}"` to the template

added...I will wait because of https://github.com/jesseduffield/lazydocker/issues/327

That's an issue with their docker build, we are not using that, so we are not affected.

    Also, I was trying to figure out how to correct the "lazydocker unversioned"

I usually look at their Makefile or Dockerfile where they set ldflags: https://github.com/jesseduffield/lazydocker/blob/4f096c3c2b60a063d04b9b7ba9236a4d821e4563/Dockerfile#L16

@zen0bit please add go_ldflags="-X main.version=${version}" to the template

  parent reply	other threads:[~2022-05-12 11:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 18:37 [PR PATCH] " zen0bit
2022-05-09 21:42 ` paper42
2022-05-10  8:23 ` benalb
2022-05-10  9:16 ` paper42
2022-05-11 12:36 ` benalb
2022-05-12 11:14 ` [PR PATCH] [Updated] " zen0bit
2022-05-12 11:15 ` zen0bit [this message]
2022-05-12 11:23 ` lazydocker: update to 0.18.1 zen0bit
2022-05-13  8:46 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220512111527.9BAnTHoXbRxemsAwCUMT5IjCtcwTL1JgBf3wqihHaJk@z \
    --to=zen0bit@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).