* [PR PATCH] wireplumber: export $XDG_STATE_HOME to a persistent location
@ 2022-04-12 2:06 Animeshz
2022-05-13 13:36 ` [PR PATCH] [Closed]: " ericonr
2022-05-13 13:36 ` ericonr
0 siblings, 2 replies; 3+ messages in thread
From: Animeshz @ 2022-04-12 2:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 955 bytes --]
There is a new pull request by Animeshz against master on the void-packages repository
https://github.com/Animeshz/void-packages wireplumber
https://github.com/void-linux/void-packages/pull/36650
wireplumber: export $XDG_STATE_HOME to a persistent location
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
In #36416 I've exported HOME to `/var/run/pipewire` but that directory gets recreated every reboot, it was able to persist volume and other configurations when the service restarts but not across system reboots.
`wireplumber` stores the state configuration in `${XDG_STATE_HOME:-$HOME/.local/state}/wireplumber`. I recently also found, `pipewire-media-session` (the builtin media router) utilized `/var/lib/pipewire` as well to persist its state across reboot. So this simply changes the export to do the same.
A patch file from https://github.com/void-linux/void-packages/pull/36650.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wireplumber-36650.patch --]
[-- Type: text/x-diff, Size: 1234 bytes --]
From c8170b3e173e6523adc90446a94bdd4334c3f4d6 Mon Sep 17 00:00:00 2001
From: Animesh Sahu <animeshsahu19@yahoo.com>
Date: Tue, 12 Apr 2022 06:49:28 +0530
Subject: [PATCH] wireplumber: export $XDG_STATE_HOME to persistent location
---
srcpkgs/wireplumber/files/wireplumber/run | 2 +-
srcpkgs/wireplumber/template | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/wireplumber/files/wireplumber/run b/srcpkgs/wireplumber/files/wireplumber/run
index ae0cf99e200b..9a28ecdbe9a4 100644
--- a/srcpkgs/wireplumber/files/wireplumber/run
+++ b/srcpkgs/wireplumber/files/wireplumber/run
@@ -6,5 +6,5 @@ sv check dbus >/dev/null 2>&1 || exit 1
exec 2>&1
-export HOME=/var/run/pipewire
+export XDG_STATE_HOME=/var/lib/pipewire
exec chpst -u _pipewire:_pipewire:audio:video -P dbus-run-session wireplumber
diff --git a/srcpkgs/wireplumber/template b/srcpkgs/wireplumber/template
index acbffa27fd8c..5d2d815d98d6 100644
--- a/srcpkgs/wireplumber/template
+++ b/srcpkgs/wireplumber/template
@@ -1,7 +1,7 @@
# Template file for 'wireplumber'
pkgname=wireplumber
version=0.4.9
-revision=1
+revision=2
build_style=meson
build_helper=gir
configure_args="-Dintrospection=enabled -Dsystem-lua=true"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PR PATCH] [Closed]: wireplumber: export $XDG_STATE_HOME to a persistent location
2022-04-12 2:06 [PR PATCH] wireplumber: export $XDG_STATE_HOME to a persistent location Animeshz
@ 2022-05-13 13:36 ` ericonr
2022-05-13 13:36 ` ericonr
1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2022-05-13 13:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
There's a closed pull request on the void-packages repository
wireplumber: export $XDG_STATE_HOME to a persistent location
https://github.com/void-linux/void-packages/pull/36650
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
In #36416 I've exported HOME to `/var/run/pipewire` but that directory gets recreated every reboot, it was able to persist volume and other configurations when the service restarts but not across system reboots.
`wireplumber` stores the state configuration in `${XDG_STATE_HOME:-$HOME/.local/state}/wireplumber`. I recently also found, `pipewire-media-session` (the builtin media router) utilized `/var/lib/pipewire` as well to persist its state across reboot. So this simply changes the export to do the same.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: wireplumber: export $XDG_STATE_HOME to a persistent location
2022-04-12 2:06 [PR PATCH] wireplumber: export $XDG_STATE_HOME to a persistent location Animeshz
2022-05-13 13:36 ` [PR PATCH] [Closed]: " ericonr
@ 2022-05-13 13:36 ` ericonr
1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2022-05-13 13:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/36650#issuecomment-1126065900
Comment:
Thanks for the PR!
Please take a look at the commit message I ended up with, it's always nice to have extra content in commit messages, especially when it's already been written for the PR itself :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-13 13:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12 2:06 [PR PATCH] wireplumber: export $XDG_STATE_HOME to a persistent location Animeshz
2022-05-13 13:36 ` [PR PATCH] [Closed]: " ericonr
2022-05-13 13:36 ` ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).