Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] avrdude: update to 7.0
@ 2022-05-09  7:09 subnut
  2022-05-13 13:55 ` [PR REVIEW] " ericonr
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: subnut @ 2022-05-09  7:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

There is a new pull request by subnut against master on the void-packages repository

https://github.com/subnut/void-packages avrdude
https://github.com/void-linux/void-packages/pull/37056

avrdude: update to 7.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37056.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-avrdude-37056.patch --]
[-- Type: text/x-diff, Size: 1786 bytes --]

From 420846fdf0f56066d08758b44c625f3e68cc3b17 Mon Sep 17 00:00:00 2001
From: Subhaditya Nath <sn03.general@gmail.com>
Date: Sun, 8 May 2022 20:41:22 +0530
Subject: [PATCH] avrdude: update to 7.0

---
 srcpkgs/avrdude/template | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/avrdude/template b/srcpkgs/avrdude/template
index 5ebe45ae47e4..ef8515a4ecd5 100644
--- a/srcpkgs/avrdude/template
+++ b/srcpkgs/avrdude/template
@@ -1,9 +1,13 @@
 # Template file for 'avrdude'
 pkgname=avrdude
-version=6.4
+version=7.0
 revision=1
 build_style=gnu-configure
-configure_args="$(vopt_enable gpio linuxgpio) $(vopt_enable spi linuxspi)"
+configure_args="
+ $(vopt_enable spi linuxspi)
+ $(vopt_enable gpio linuxgpio)
+ $(vopt_enable parport parport)
+"
 hostmakedepends="flex"
 makedepends="elfutils-devel libusb-devel libusb-compat-devel libftdi1-devel
  hidapi-devel"
@@ -12,10 +16,12 @@ short_desc="Utility to manipulate ROM and EEPROM of AVR microcontrollers"
 maintainer="Subhaditya Nath <sn03.general@gmail.com>"
 license="GPL-2.0-only"
 homepage="http://www.nongnu.org/avrdude/"
+changelog="https://raw.githubusercontent.com/avrdudes/avrdude/v${version}/NEWS"
 distfiles="$NONGNU_SITE/$pkgname/${pkgname}-$version.tar.gz"
-checksum=a9be7066f70a9dcf4bf0736fcf531db6a3250aed1a24cc643add27641b7110f9
+checksum=c0ef65d98d6040ca0b4f2b700d51463c2a1f94665441f39d15d97442dbb79b54
 conf_files="/etc/avrdude.conf"
-build_options="gpio spi"
-desc_option_spi="Enable LINUXSPI support"
-desc_option_gpio="Enable LINUXGPIO support"
+build_options="gpio spi parport"
+desc_option_spi="Enable Linux SPI support"
+desc_option_gpio="Enable Linux sysfs GPIO support"
+desc_option_parport="Enable parallel port support"
 build_options_default="${build_options}"

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] avrdude: update to 7.0
  2022-05-09  7:09 [PR PATCH] avrdude: update to 7.0 subnut
@ 2022-05-13 13:55 ` ericonr
  2022-05-13 14:02 ` subnut
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2022-05-13 13:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/37056#discussion_r872426885

Comment:
Could you explain the reason for these build options instead of just enabling them all by default?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] avrdude: update to 7.0
  2022-05-09  7:09 [PR PATCH] avrdude: update to 7.0 subnut
  2022-05-13 13:55 ` [PR REVIEW] " ericonr
@ 2022-05-13 14:02 ` subnut
  2022-05-13 14:16 ` ericonr
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: subnut @ 2022-05-13 14:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/37056#discussion_r872436337

Comment:
The build options are already explained below, in these variables -
```sh
desc_option_spi="Enable Linux SPI support"
desc_option_gpio="Enable Linux sysfs GPIO support"
desc_option_parport="Enable parallel port support"
```

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] avrdude: update to 7.0
  2022-05-09  7:09 [PR PATCH] avrdude: update to 7.0 subnut
  2022-05-13 13:55 ` [PR REVIEW] " ericonr
  2022-05-13 14:02 ` subnut
@ 2022-05-13 14:16 ` ericonr
  2022-05-13 14:59 ` [PR PATCH] [Updated] " subnut
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2022-05-13 14:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/37056#discussion_r872451989

Comment:
Yes, I see what they do. My point is, can't we simply always have `--enable-linuxspi --enable-linuxgpio --enable-parport`? That way, the template gets simpler.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] avrdude: update to 7.0
  2022-05-09  7:09 [PR PATCH] avrdude: update to 7.0 subnut
                   ` (2 preceding siblings ...)
  2022-05-13 14:16 ` ericonr
@ 2022-05-13 14:59 ` subnut
  2022-05-13 15:10 ` [PR REVIEW] " ericonr
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: subnut @ 2022-05-13 14:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

There is an updated pull request by subnut against master on the void-packages repository

https://github.com/subnut/void-packages avrdude
https://github.com/void-linux/void-packages/pull/37056

avrdude: update to 7.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37056.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-avrdude-37056.patch --]
[-- Type: text/x-diff, Size: 1659 bytes --]

From 419ffd8a364fa4100df18bbf7e939b9cdd8b3407 Mon Sep 17 00:00:00 2001
From: Subhaditya Nath <sn03.general@gmail.com>
Date: Sun, 8 May 2022 20:41:22 +0530
Subject: [PATCH] avrdude: update to 7.0, remove build_options

Build options can be added back if anybody demands. Until then, they
aren't necessary.
---
 srcpkgs/avrdude/template | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/avrdude/template b/srcpkgs/avrdude/template
index 5ebe45ae47e4..65f5d9eb4c29 100644
--- a/srcpkgs/avrdude/template
+++ b/srcpkgs/avrdude/template
@@ -1,9 +1,9 @@
 # Template file for 'avrdude'
 pkgname=avrdude
-version=6.4
+version=7.0
 revision=1
 build_style=gnu-configure
-configure_args="$(vopt_enable gpio linuxgpio) $(vopt_enable spi linuxspi)"
+configure_args="--enable-linuxspi --enable-linuxgpio --enable-parport"
 hostmakedepends="flex"
 makedepends="elfutils-devel libusb-devel libusb-compat-devel libftdi1-devel
  hidapi-devel"
@@ -12,10 +12,7 @@ short_desc="Utility to manipulate ROM and EEPROM of AVR microcontrollers"
 maintainer="Subhaditya Nath <sn03.general@gmail.com>"
 license="GPL-2.0-only"
 homepage="http://www.nongnu.org/avrdude/"
+changelog="https://raw.githubusercontent.com/avrdudes/avrdude/v${version}/NEWS"
 distfiles="$NONGNU_SITE/$pkgname/${pkgname}-$version.tar.gz"
-checksum=a9be7066f70a9dcf4bf0736fcf531db6a3250aed1a24cc643add27641b7110f9
+checksum=c0ef65d98d6040ca0b4f2b700d51463c2a1f94665441f39d15d97442dbb79b54
 conf_files="/etc/avrdude.conf"
-build_options="gpio spi"
-desc_option_spi="Enable LINUXSPI support"
-desc_option_gpio="Enable LINUXGPIO support"
-build_options_default="${build_options}"

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] avrdude: update to 7.0
  2022-05-09  7:09 [PR PATCH] avrdude: update to 7.0 subnut
                   ` (3 preceding siblings ...)
  2022-05-13 14:59 ` [PR PATCH] [Updated] " subnut
@ 2022-05-13 15:10 ` ericonr
  2022-05-13 15:10 ` ericonr
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2022-05-13 15:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/37056#discussion_r872503871

Comment:
https://raw.githubusercontent.com/avrdudes/avrdude/master/NEWS should work better, that way you can also see changelog for future versions

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] avrdude: update to 7.0
  2022-05-09  7:09 [PR PATCH] avrdude: update to 7.0 subnut
                   ` (4 preceding siblings ...)
  2022-05-13 15:10 ` [PR REVIEW] " ericonr
@ 2022-05-13 15:10 ` ericonr
  2022-05-13 15:23 ` [PR PATCH] [Updated] " subnut
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2022-05-13 15:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/37056#discussion_r872504267

Comment:
With that fixed we should be good to merge, though! Thanks :)

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] avrdude: update to 7.0
  2022-05-09  7:09 [PR PATCH] avrdude: update to 7.0 subnut
                   ` (5 preceding siblings ...)
  2022-05-13 15:10 ` ericonr
@ 2022-05-13 15:23 ` subnut
  2022-05-13 15:23 ` subnut
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: subnut @ 2022-05-13 15:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

There is an updated pull request by subnut against master on the void-packages repository

https://github.com/subnut/void-packages avrdude
https://github.com/void-linux/void-packages/pull/37056

avrdude: update to 7.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37056.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-avrdude-37056.patch --]
[-- Type: text/x-diff, Size: 1771 bytes --]

From 5615523243a7776fddbce886d10a1946df277d3d Mon Sep 17 00:00:00 2001
From: Subhaditya Nath <sn03.general@gmail.com>
Date: Sun, 8 May 2022 20:41:22 +0530
Subject: [PATCH] avrdude: update to 7.0, remove build options

Build options can be added back if anybody demands. Until then, they
aren't necessary.

Changelog should point to the latest changelog, so that users can see
what changes have been made before upgrading.
---
 srcpkgs/avrdude/template | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/avrdude/template b/srcpkgs/avrdude/template
index 5ebe45ae47e4..b30f9fb13724 100644
--- a/srcpkgs/avrdude/template
+++ b/srcpkgs/avrdude/template
@@ -1,9 +1,9 @@
 # Template file for 'avrdude'
 pkgname=avrdude
-version=6.4
+version=7.0
 revision=1
 build_style=gnu-configure
-configure_args="$(vopt_enable gpio linuxgpio) $(vopt_enable spi linuxspi)"
+configure_args="--enable-linuxspi --enable-linuxgpio --enable-parport"
 hostmakedepends="flex"
 makedepends="elfutils-devel libusb-devel libusb-compat-devel libftdi1-devel
  hidapi-devel"
@@ -12,10 +12,7 @@ short_desc="Utility to manipulate ROM and EEPROM of AVR microcontrollers"
 maintainer="Subhaditya Nath <sn03.general@gmail.com>"
 license="GPL-2.0-only"
 homepage="http://www.nongnu.org/avrdude/"
+changelog="https://raw.githubusercontent.com/avrdudes/avrdude/master/NEWS"
 distfiles="$NONGNU_SITE/$pkgname/${pkgname}-$version.tar.gz"
-checksum=a9be7066f70a9dcf4bf0736fcf531db6a3250aed1a24cc643add27641b7110f9
+checksum=c0ef65d98d6040ca0b4f2b700d51463c2a1f94665441f39d15d97442dbb79b54
 conf_files="/etc/avrdude.conf"
-build_options="gpio spi"
-desc_option_spi="Enable LINUXSPI support"
-desc_option_gpio="Enable LINUXGPIO support"
-build_options_default="${build_options}"

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: avrdude: update to 7.0
  2022-05-09  7:09 [PR PATCH] avrdude: update to 7.0 subnut
                   ` (6 preceding siblings ...)
  2022-05-13 15:23 ` [PR PATCH] [Updated] " subnut
@ 2022-05-13 15:23 ` subnut
  2022-05-14  0:41 ` [PR PATCH] [Merged]: " ericonr
  2022-05-14  0:41 ` ericonr
  9 siblings, 0 replies; 11+ messages in thread
From: subnut @ 2022-05-13 15:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/37056#issuecomment-1126173918

Comment:
@ericonr Done!

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Merged]: avrdude: update to 7.0
  2022-05-09  7:09 [PR PATCH] avrdude: update to 7.0 subnut
                   ` (7 preceding siblings ...)
  2022-05-13 15:23 ` subnut
@ 2022-05-14  0:41 ` ericonr
  2022-05-14  0:41 ` ericonr
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2022-05-14  0:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

There's a merged pull request on the void-packages repository

avrdude: update to 7.0
https://github.com/void-linux/void-packages/pull/37056

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: avrdude: update to 7.0
  2022-05-09  7:09 [PR PATCH] avrdude: update to 7.0 subnut
                   ` (8 preceding siblings ...)
  2022-05-14  0:41 ` [PR PATCH] [Merged]: " ericonr
@ 2022-05-14  0:41 ` ericonr
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2022-05-14  0:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/37056#issuecomment-1126594730

Comment:
Thank you!

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-05-14  0:41 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09  7:09 [PR PATCH] avrdude: update to 7.0 subnut
2022-05-13 13:55 ` [PR REVIEW] " ericonr
2022-05-13 14:02 ` subnut
2022-05-13 14:16 ` ericonr
2022-05-13 14:59 ` [PR PATCH] [Updated] " subnut
2022-05-13 15:10 ` [PR REVIEW] " ericonr
2022-05-13 15:10 ` ericonr
2022-05-13 15:23 ` [PR PATCH] [Updated] " subnut
2022-05-13 15:23 ` subnut
2022-05-14  0:41 ` [PR PATCH] [Merged]: " ericonr
2022-05-14  0:41 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).