[PR PATCH] update_check: also work for subpackages

[PR PATCH] update_check: also work for subpackages

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

There is a new pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages update-check-subpkgs
https://github.com/void-linux/void-packages/pull/36190

update_check: also work for subpackages
Currently `./xbps-src update-check` fails for many subpackages if the $pkgname or $pattern is not explicitly set in the update file, because it uses the subpackages $pkgname.

Example:
```
$ ./xbps-src update-check alsa-plugins-pulseaudio
NO VERSION found for alsa-plugins-pulseaudio
```

This PR tries to fix that by using $sourcepkg as the $pkgname.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36190.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-check-subpkgs-36190.patch --]
[-- Type: text/x-diff, Size: 799 bytes --]

From adc7c450937e1cdfc9baf3ba37aed43392520daf Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Thu, 17 Mar 2022 18:15:03 +0100
Subject: [PATCH] update_check: also work for subpackages

---
 common/xbps-src/shutils/update_check.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/xbps-src/shutils/update_check.sh b/common/xbps-src/shutils/update_check.sh
index 0a624274f500..47958a3af121 100644
--- a/common/xbps-src/shutils/update_check.sh
+++ b/common/xbps-src/shutils/update_check.sh
@@ -3,6 +3,7 @@
 update_check() {
     local i p url pkgurlname rx found_version consider
     local update_override=$XBPS_SRCPKGDIR/$XBPS_TARGET_PKG/update
+    local pkgname=$sourcepkg
     local original_pkgname=$pkgname
     local urlpfx urlsfx
     local -A fetchedurls

Re: [PR PATCH] [Updated] update_check: also work for subpackages

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages update-check-subpkgs
https://github.com/void-linux/void-packages/pull/36190

update_check: also work for subpackages
Currently `./xbps-src update-check` fails for many subpackages if the $pkgname or $pattern is not explicitly set in the update file, because it uses the subpackages $pkgname.

Example:
```
$ ./xbps-src update-check alsa-plugins-pulseaudio
NO VERSION found for alsa-plugins-pulseaudio
```

This PR tries to fix that by using $sourcepkg as the $pkgname.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36190.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-check-subpkgs-36190.patch --]
[-- Type: text/x-diff, Size: 800 bytes --]

From 5086938784eea616605d5e9056e528200972cf15 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Thu, 17 Mar 2022 18:15:03 +0100
Subject: [PATCH] update_check: also work for subpackages

---
 common/xbps-src/shutils/update_check.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/xbps-src/shutils/update_check.sh b/common/xbps-src/shutils/update_check.sh
index 0a624274f500..8d08464407f7 100644
--- a/common/xbps-src/shutils/update_check.sh
+++ b/common/xbps-src/shutils/update_check.sh
@@ -4,6 +4,7 @@ update_check() {
     local i p url pkgurlname rx found_version consider
     local update_override=$XBPS_SRCPKGDIR/$XBPS_TARGET_PKG/update
     local original_pkgname=$pkgname
+    local pkgname=$sourcepkg
     local urlpfx urlsfx
     local -A fetchedurls
 

Re: update_check: also work for subpackages

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/36190#issuecomment-1127004297

Comment:
ping @leahneukirchen 

Re: [PR PATCH] [Closed]: update_check: also work for subpackages

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

There's a closed pull request on the void-packages repository

update_check: also work for subpackages
https://github.com/void-linux/void-packages/pull/36190

Description:
Currently `./xbps-src update-check` fails for many subpackages if the $pkgname or $pattern is not explicitly set in the update file, because it uses the subpackages $pkgname.

Example:
```
$ ./xbps-src update-check alsa-plugins-pulseaudio
NO VERSION found for alsa-plugins-pulseaudio
```

This PR tries to fix that by using $sourcepkg as the $pkgname.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->