[PR PATCH] foot: update to 1.12.1

[PR PATCH] foot: update to 1.12.1

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

There is a new pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages foot
https://github.com/void-linux/void-packages/pull/37148

foot: update to 1.12.1
I've built and tested this on x86_64-musl.

@ifreund 

A patch file from https://github.com/void-linux/void-packages/pull/37148.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-foot-37148.patch --]
[-- Type: text/x-diff, Size: 1109 bytes --]

From c73206b18680494c88ff5224bfe54b56be91585c Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Mon, 16 May 2022 08:46:56 +0200
Subject: [PATCH] foot: update to 1.12.1

---
 srcpkgs/foot/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/foot/template b/srcpkgs/foot/template
index e1c373c43c24..8b9a19404a62 100644
--- a/srcpkgs/foot/template
+++ b/srcpkgs/foot/template
@@ -1,6 +1,6 @@
 # Template file for 'foot'
 pkgname=foot
-version=1.11.0
+version=1.12.1
 revision=1
 wrksrc=$pkgname
 build_style=meson
@@ -14,8 +14,8 @@ maintainer="Isaac Freund <mail@isaacfreund.com>"
 license="MIT"
 homepage="https://codeberg.org/dnkl/foot"
 changelog="https://codeberg.org/dnkl/foot/src/branch/master/CHANGELOG.md"
-distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=2b4f737eb4d266224e5dd0126168c6d770b0139d4b572078baf158d2f7166e4e
+distfiles="https://codeberg.org/dnkl/foot/archive/${version}.tar.gz"
+checksum=14e307ac89454b682bb9f1bc644043779f4462df656034fcc4c1e72b18fbffdd
 
 post_install() {
 	rm -f ${DESTDIR}/usr/share/doc/foot/LICENSE

Re: foot: update to 1.12.1

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/37148#issuecomment-1127295347

Comment:
The failure on x86-64 is due to
```
foot-terminfo and ncurses-term conflict for
  /usr/share/terminfo/f/foot
  /usr/share/terminfo/f/foot-direct
```

Re: foot: update to 1.12.1

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/37148#issuecomment-1127398449

Comment:
https://github.com/void-linux/void-packages/pull/36884

Re: [PR PATCH] [Closed]: foot: update to 1.12.1

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

There's a closed pull request on the void-packages repository

foot: update to 1.12.1
https://github.com/void-linux/void-packages/pull/37148

Description:
I've built and tested this on x86_64-musl.

@ifreund 

Re: foot: update to 1.12.1

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/37148#issuecomment-1127405298

Comment:
Sorry, I missed that.

Re: foot: update to 1.12.1

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/37148#issuecomment-1127422739

Comment:
No worries!

Re: foot: update to 1.12.1.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/36884#issuecomment-1131836929

Comment:
After some discussion on IRC, I decided to instead resolve the conflict by patching foot's terminfo out of ncurses as this will be the least disruptive for foot users.

Re: foot: update to 1.12.1.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/36884#issuecomment-1127491832

Comment:
Good catch @r-ricci, done.

Re: foot: update to 1.12.1.

[r-ricci]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New comment by r-ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/36884#issuecomment-1127466299

Comment:
You should add foot terminfo files to `srcpkgs/ncurses/files/base-files` in order for them to be included in `ncurses-base`. Currently they are in `ncurses-term`, which is not installed by default and it's not a dependency.

Re: foot: update to 1.12.1.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

New comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/36884#issuecomment-1127435444

Comment:
I dropped `foot-terminfo` in the latest commit, following upstream's recommendation. This should be ready for merge now as far as I'm concerned.

Re: foot: update to 1.12.1.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]

New comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/36884#issuecomment-1122313534

Comment:
Looks like an ncurses update was merged to master in the meantime and we now need to resolve the terminfo conflict one way or another. From foot's `INSTALL.md`:

> As of ncurses 2021-07-31, ncurses includes a version of foot’s terminfo. The recommendation is to use those, and only install the terminfo definitions from this git repo if the system’s ncurses predates 2021-07-31.
>
> But, note that the foot terminfo definitions in ncurses’ lack the non-standard capabilities. This mostly affects tmux; without them, terminal-overrides must be configured to enable truecolor support. For this reason, it is possible to install “our” terminfo definitions as well, either in a non-default location, or under a different name.
>
> Both have their set of issues. When installing to a non-default location, foot will set the environment variable TERMINFO in the child process. However, there are many situations where this simply does not work. See [#695](https://codeberg.org/dnkl/foot/issues/695) for details.
>
> Installing them under a different name generally works well, but will break applications that check if $TERM == foot.
>
> Hence the recommendation to simply use ncurses’ terminfo definitions if available.
>
> If packaging “our” terminfo definitions, I recommend doing that as a separate package, to allow them to be installed on remote systems without having to install foot itself.

It seems like the simplest option is to drop `foot-terminfo`, thoughts?

Re: foot: update to 1.12.1.

[camoz]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

New comment by camoz on void-packages repository

https://github.com/void-linux/void-packages/pull/36884#issuecomment-1122310608

Comment:
I just want to highlight that this upgrade (with or without the `conf_files` option) has the potential to delete the user's configuration, because `/etc/xdg/foot/foot.ini` has already been the standard location for a system-wide foot config for some time. What is new in 1.12 is just that a default config is being installed there. So if void really wants to avoid overwriting the user's config, this should not be merged in the current state.

Re: foot: update to 1.12.1.

[ifreund]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/36884#issuecomment-1122249122

Comment:
@ericonr Implemented, thanks for the ping :)

Re: foot: update to 1.12.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/36884#issuecomment-1120533186

Comment:
@ifreund ping on the `conf_files` idea?

Re: foot: update to 1.12.1.

[camoz]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

New comment by camoz on void-packages repository

https://github.com/void-linux/void-packages/pull/36884#issuecomment-1117888624

Comment:
Thinking about it, the new release now installs a config file to `/etc/xdg/foot/foot.ini`, see https://codeberg.org/dnkl/foot/pulls/1015

AFAUI a possible user config file at that location would be overwritten anyway, so why not just add it to `conf_files` now?

Re: foot: update to 1.12.1.

[ftrvxmtrx]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by ftrvxmtrx on void-packages repository

https://github.com/void-linux/void-packages/pull/36884#issuecomment-1117740640

Comment:
Tested on aarch64-musl. Works well. Very much like the new `-E` option.

Re: foot: update to 1.12.1.

[camoz]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by camoz on void-packages repository

https://github.com/void-linux/void-packages/pull/36884#issuecomment-1111413368

Comment:
The config now lives under `/etc`, but should probably not yet added to `conf_files` due to https://github.com/void-linux/xbps/issues/342