Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] github-actions: constrain PR's to cancel old duplicate actions
@ 2021-01-17  5:44 waynevanson
  2021-01-19 21:20 ` ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: waynevanson @ 2021-01-17  5:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

New issue by waynevanson on void-packages repository

https://github.com/void-linux/void-packages/issues/27972

Description:
Here's a non-hypothetical example.

- I created a PR for a new package, github actions trigger.
- I made a small change in the dependencies and force pushed to the origin, github actions trigger again.

There are now 2 actions running, using resources. I went to go cancel the first one, but was unable to due to permissions.

An ideal solution is that when a force push is applied, it creates a new github action and the old one is deleted.
I'm unsure if this is even possible.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: github-actions: constrain PR's to cancel old duplicate actions
  2021-01-17  5:44 [ISSUE] github-actions: constrain PR's to cancel old duplicate actions waynevanson
@ 2021-01-19 21:20 ` ericonr
  2021-01-25  0:50 ` waynevanson
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-01-19 21:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27972#issuecomment-763148891

Comment:
Doesn't it automatically kill the previous action? I remember observing such a behavior.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: github-actions: constrain PR's to cancel old duplicate actions
  2021-01-17  5:44 [ISSUE] github-actions: constrain PR's to cancel old duplicate actions waynevanson
  2021-01-19 21:20 ` ericonr
@ 2021-01-25  0:50 ` waynevanson
  2021-02-04 13:41 ` ericonr
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: waynevanson @ 2021-01-25  0:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

New comment by waynevanson on void-packages repository

https://github.com/void-linux/void-packages/issues/27972#issuecomment-766474063

Comment:
I don't think so. Here are the actions: https://github.com/void-linux/void-packages/actions?query=branch%3Apackage%2Fwally-cli

> Doesn't it automatically kill the previous action?

Perhaps force pushes skip this behavior. They use the commit as an identifier, so maybe because it can't tell what the previous commit was it does not know what it can and cannot cancel.

This is more of a quality of life change for the inexperience contributors or for when accidents happen.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: github-actions: constrain PR's to cancel old duplicate actions
  2021-01-17  5:44 [ISSUE] github-actions: constrain PR's to cancel old duplicate actions waynevanson
  2021-01-19 21:20 ` ericonr
  2021-01-25  0:50 ` waynevanson
@ 2021-02-04 13:41 ` ericonr
  2022-05-02  2:16 ` github-actions
  2022-05-17  2:13 ` [ISSUE] [CLOSED] " github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-02-04 13:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/27972#issuecomment-773310385

Comment:
Ugh, seems I could reproduce it:

https://github.com/void-linux/void-packages/actions/runs/537279192 and https://github.com/void-linux/void-packages/actions/runs/537280306 , just a few seconds apart.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: github-actions: constrain PR's to cancel old duplicate actions
  2021-01-17  5:44 [ISSUE] github-actions: constrain PR's to cancel old duplicate actions waynevanson
                   ` (2 preceding siblings ...)
  2021-02-04 13:41 ` ericonr
@ 2022-05-02  2:16 ` github-actions
  2022-05-17  2:13 ` [ISSUE] [CLOSED] " github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2022-05-02  2:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/27972#issuecomment-1114433318

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ISSUE] [CLOSED] github-actions: constrain PR's to cancel old duplicate actions
  2021-01-17  5:44 [ISSUE] github-actions: constrain PR's to cancel old duplicate actions waynevanson
                   ` (3 preceding siblings ...)
  2022-05-02  2:16 ` github-actions
@ 2022-05-17  2:13 ` github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2022-05-17  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Closed issue by waynevanson on void-packages repository

https://github.com/void-linux/void-packages/issues/27972

Description:
Here's a non-hypothetical example.

- I created a PR for a new package, github actions trigger.
- I made a small change in the dependencies and force pushed to the origin, github actions trigger again.

There are now 2 actions running, using resources. I went to go cancel the first one, but was unable to due to permissions.

An ideal solution is that when a force push is applied, it creates a new github action and the old one is deleted.
I'm unsure if this is even possible.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-05-17  2:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-17  5:44 [ISSUE] github-actions: constrain PR's to cancel old duplicate actions waynevanson
2021-01-19 21:20 ` ericonr
2021-01-25  0:50 ` waynevanson
2021-02-04 13:41 ` ericonr
2022-05-02  2:16 ` github-actions
2022-05-17  2:13 ` [ISSUE] [CLOSED] " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).