Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gthumb: fix to run on wlroots compositor
@ 2021-02-05 14:17 gspe
  2021-02-05 19:05 ` ericonr
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: gspe @ 2021-02-05 14:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1777 bytes --]

There is a new pull request by gspe against master on the void-packages repository

https://github.com/gspe/void-packages gthumb
https://github.com/void-linux/void-packages/pull/28520

gthumb: fix to run on wlroots compositor
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

Actually gthumb doesn't run on wlroots based compositor.
After asking on #sway irc channel they told me that this is a `clutter` problem https://gitlab.gnome.org/GNOME/clutter/-/merge_requests/5 and for now as workaround I can run gthumb with this command `CLUTTER_BACKEND=gdk gthumb`
I've tested this with wayland compositor and with X11 and it works in both cases.

So this PR just add this environmental variable to the gthumb .desktop file, obvious this only works if gthumb is launched by menu/launcher of file manager not if it is run by terminal.


A patch file from https://github.com/void-linux/void-packages/pull/28520.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gthumb-28520.patch --]
[-- Type: text/x-diff, Size: 1121 bytes --]

From f9635d127b8a02b348cd75f748d1ee8974e9caa5 Mon Sep 17 00:00:00 2001
From: Giuseppe Fierro <gspe@ae-design.ws>
Date: Fri, 5 Feb 2021 15:05:57 +0100
Subject: [PATCH] gthumb: fix to run on wlroots compositor

---
 srcpkgs/gthumb/template | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/gthumb/template b/srcpkgs/gthumb/template
index cc2a53d0796..79abeb14fc5 100644
--- a/srcpkgs/gthumb/template
+++ b/srcpkgs/gthumb/template
@@ -1,7 +1,7 @@
 # Template file for 'gthumb'
 pkgname=gthumb
 version=3.10.0
-revision=1
+revision=2
 build_style=meson
 hostmakedepends="gettext pkg-config itstool glib-devel"
 makedepends="webkit2gtk-devel json-glib-devel libsecret-devel librsvg-devel
@@ -24,6 +24,10 @@ desc_option_clutter="Enable clutter (for slideshows)"
 desc_option_soup="Enable webservices"
 build_options_default="clutter gstreamer soup"
 
+post_configure() {
+	vsed -e 's:Exec=gthumb %U:Exec=env CLUTTER_BACKEND=gdk gthumb %U:' -i data/org.gnome.gThumb.desktop.in.in
+}
+
 gthumb-devel_package() {
 	short_desc+=" - development files"
 	depends="${sourcepkg}>=${version}_${revision}"

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: gthumb: fix to run on wlroots compositor
  2021-02-05 14:17 [PR PATCH] gthumb: fix to run on wlroots compositor gspe
@ 2021-02-05 19:05 ` ericonr
  2021-02-05 19:09 ` gspe
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-02-05 19:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28520#issuecomment-774228824

Comment:
Doesn't this mean all applications that use clutter have the same issue?

```
$ xbps-query -RX clutter
abiword-3.0.4_1
cheese-3.38.0_1
clutter-devel-1.26.4_1
clutter-gst-2.0.18_2
clutter-gst3-3.0.27_2
clutter-gtk-1.8.4_4
empathy-3.12.14_2
eog-plugins-3.26.5_1
fotoxx-20.19_1
gnome-2048-3.38.2_1
gnome-nibbles-3.38.2_1
gthumb-3.10.0_1
gtkpod-2.1.5_4
io.elementary.calendar-5.0_4
io.elementary.videos-2.7.1_1
libabiword-3.0.4_1
libchamplain-0.12.20_1
libcheese-3.38.0_1
libtotem-3.38.0_1
lightsoff-3.38.0_1
mash-0.2.0_9
quadrapassel-3.38.1_1
shotwell-0.31.3_1
snappy-player-1.0_3
swell-foop-3.34.1_1
totem-3.38.0_1
```

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: gthumb: fix to run on wlroots compositor
  2021-02-05 14:17 [PR PATCH] gthumb: fix to run on wlroots compositor gspe
  2021-02-05 19:05 ` ericonr
@ 2021-02-05 19:09 ` gspe
  2021-02-06  7:47 ` travankor
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: gspe @ 2021-02-05 19:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New comment by gspe on void-packages repository

https://github.com/void-linux/void-packages/pull/28520#issuecomment-774230798

Comment:
Should be, but I have tested only gthumb and fotoxx and they don't woks.
But the only that I'm actually using gthumb.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: gthumb: fix to run on wlroots compositor
  2021-02-05 14:17 [PR PATCH] gthumb: fix to run on wlroots compositor gspe
  2021-02-05 19:05 ` ericonr
  2021-02-05 19:09 ` gspe
@ 2021-02-06  7:47 ` travankor
  2021-02-06  7:47 ` travankor
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: travankor @ 2021-02-06  7:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 597 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/28520#issuecomment-774419774

Comment:
```
emersion: yeah, clutter is a legacy toolkit, still uses wl_shell 
emersion: wl_shell removed from wlroots a long time ago 
emersion: iirc there is a MR to upgarde clutter to xdg-shell 
emersion: but it's lost in limbo  emersion: yeah, clutter is a legacy toolkit, still uses wl_shell 
emersion: wl_shell removed from wlroots a long time ago 
emersion: iirc there is a MR to upgarde clutter to xdg-shell 
emersion: but it's lost in limbo  
```

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: gthumb: fix to run on wlroots compositor
  2021-02-05 14:17 [PR PATCH] gthumb: fix to run on wlroots compositor gspe
                   ` (2 preceding siblings ...)
  2021-02-06  7:47 ` travankor
@ 2021-02-06  7:47 ` travankor
  2021-02-10  1:11 ` ericonr
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: travankor @ 2021-02-06  7:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/28520#issuecomment-774419774

Comment:
```
emersion: yeah, clutter is a legacy toolkit, still uses wl_shell 
emersion: wl_shell removed from wlroots a long time ago 
emersion: iirc there is a MR to upgarde clutter to xdg-shell 
emersion: but it's lost in limbo
```

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: gthumb: fix to run on wlroots compositor
  2021-02-05 14:17 [PR PATCH] gthumb: fix to run on wlroots compositor gspe
                   ` (3 preceding siblings ...)
  2021-02-06  7:47 ` travankor
@ 2021-02-10  1:11 ` ericonr
  2022-05-03  2:14 ` github-actions
  2022-05-17  2:14 ` [PR PATCH] [Closed]: " github-actions
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-02-10  1:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28520#issuecomment-776357726

Comment:
This PR should either:

- attempt to fix the issue for all applications using clutter
- add the patch to clutter
- be in void-docs adding the env var to docs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: gthumb: fix to run on wlroots compositor
  2021-02-05 14:17 [PR PATCH] gthumb: fix to run on wlroots compositor gspe
                   ` (4 preceding siblings ...)
  2021-02-10  1:11 ` ericonr
@ 2022-05-03  2:14 ` github-actions
  2022-05-17  2:14 ` [PR PATCH] [Closed]: " github-actions
  6 siblings, 0 replies; 8+ messages in thread
From: github-actions @ 2022-05-03  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/28520#issuecomment-1115549666

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Closed]: gthumb: fix to run on wlroots compositor
  2021-02-05 14:17 [PR PATCH] gthumb: fix to run on wlroots compositor gspe
                   ` (5 preceding siblings ...)
  2022-05-03  2:14 ` github-actions
@ 2022-05-17  2:14 ` github-actions
  6 siblings, 0 replies; 8+ messages in thread
From: github-actions @ 2022-05-17  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]

There's a closed pull request on the void-packages repository

gthumb: fix to run on wlroots compositor
https://github.com/void-linux/void-packages/pull/28520

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

Actually gthumb doesn't run on wlroots based compositor.
After asking on #sway irc channel they told me that this is a `clutter` problem https://gitlab.gnome.org/GNOME/clutter/-/merge_requests/5 and for now as workaround I can run gthumb with this command `CLUTTER_BACKEND=gdk gthumb`
I've tested this with wayland compositor and with X11 and it works in both cases.

So this PR just add this environmental variable to the gthumb .desktop file, obvious this only works if gthumb is launched by menu/launcher of file manager not if it is run by terminal.


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-05-17  2:14 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 14:17 [PR PATCH] gthumb: fix to run on wlroots compositor gspe
2021-02-05 19:05 ` ericonr
2021-02-05 19:09 ` gspe
2021-02-06  7:47 ` travankor
2021-02-06  7:47 ` travankor
2021-02-10  1:11 ` ericonr
2022-05-03  2:14 ` github-actions
2022-05-17  2:14 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).