Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New packages: libadwaita-qt adwaita-qt-devel
@ 2021-04-10  5:13 phossil
  2021-04-10 10:17 ` Chocimier
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: phossil @ 2021-04-10  5:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]

There is a new pull request by phossil against master on the void-packages repository

https://github.com/phossil/void-packages adwaita-qt
https://github.com/void-linux/void-packages/pull/30117

New packages: libadwaita-qt adwaita-qt-devel
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
- See [Package Request](https://github.com/void-linux/void-packages/issues/30099) for details.

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
  - [x] aarch64

#### changes made
- subpackages were added to `adwaita-qt`
- two libraries were added to `common/shlibs`

A patch file from https://github.com/void-linux/void-packages/pull/30117.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-adwaita-qt-30117.patch --]
[-- Type: text/x-diff, Size: 2559 bytes --]

From 0c5b6e90b39e11eeadb11f7c737d339829f32b65 Mon Sep 17 00:00:00 2001
From: Phosu Parsons <38191182+phossil@users.noreply.github.com>
Date: Fri, 9 Apr 2021 15:49:55 -0500
Subject: [PATCH] New packages: libadwaita-qt adwaita-qt-devel

---
 common/shlibs               |  2 ++
 srcpkgs/adwaita-qt-devel    |  1 +
 srcpkgs/adwaita-qt/template | 22 +++++++++++++++++++++-
 srcpkgs/libadwaita-qt       |  1 +
 4 files changed, 25 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/adwaita-qt-devel
 create mode 120000 srcpkgs/libadwaita-qt

diff --git a/common/shlibs b/common/shlibs
index 296b93e5f22b..958e475a0ce8 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3967,3 +3967,5 @@ libmd.so.0 libmd-1.0.3_1
 libldacBT_abr.so.2 ldacBT-2.0.2.3_1
 libldacBT_enc.so.2 ldacBT-2.0.2.3_1
 libgumbo.so.1 gumbo-parser-0.10.1_2
+libadwaitaqt.so.1 libadwaita-qt-1.2.1_2
+libadwaitaqtpriv.so.1 libadwaita-qt-1.2.1_2
diff --git a/srcpkgs/adwaita-qt-devel b/srcpkgs/adwaita-qt-devel
new file mode 120000
index 000000000000..b3dd98903e7a
--- /dev/null
+++ b/srcpkgs/adwaita-qt-devel
@@ -0,0 +1 @@
+adwaita-qt
\ No newline at end of file
diff --git a/srcpkgs/adwaita-qt/template b/srcpkgs/adwaita-qt/template
index 08752a9a660c..3bc1c0c28a68 100644
--- a/srcpkgs/adwaita-qt/template
+++ b/srcpkgs/adwaita-qt/template
@@ -1,13 +1,33 @@
 # Template file for 'adwaita-qt'
 pkgname=adwaita-qt
 version=1.2.1
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="qt5-host-tools qt5-qmake"
 makedepends="qt5-devel qt5-x11extras-devel"
+depends="libadwaita-qt"
 short_desc="Style to bend Qt applications to look like they belong into GNOME Shell"
 maintainer="Piotr Wójcik <chocimier@tlen.pl>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/FedoraQt/adwaita-qt"
 distfiles="https://github.com/FedoraQt/adwaita-qt/archive/${version}.tar.gz"
 checksum=0673586fe37469eb826be821b3f2c12f055e99a6ca0a8377cfa06b123543ae56
+
+libadwaita-qt_package() {
+	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - shared libraries"
+	pkg_install() {
+		vmove "usr/lib/*.so.*"
+	}
+}
+
+adwaita-qt-devel_package() {
+	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove "usr/lib/*.so"
+		vmove usr/lib/cmake
+		vmove usr/lib/pkgconfig
+	}
+}
diff --git a/srcpkgs/libadwaita-qt b/srcpkgs/libadwaita-qt
new file mode 120000
index 000000000000..b3dd98903e7a
--- /dev/null
+++ b/srcpkgs/libadwaita-qt
@@ -0,0 +1 @@
+adwaita-qt
\ No newline at end of file

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New packages: libadwaita-qt adwaita-qt-devel
  2021-04-10  5:13 [PR PATCH] New packages: libadwaita-qt adwaita-qt-devel phossil
@ 2021-04-10 10:17 ` Chocimier
  2021-04-10 11:35 ` paper42
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2021-04-10 10:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/30117#issuecomment-817112889

Comment:
Dependencies are wrong, change like below. Please also rename commit to "adwaita-qt: split libadwaita-qt and adwaita-qt-devel". Otherwise ok.

``` diff
--- a/srcpkgs/adwaita-qt/template
+++ b/srcpkgs/adwaita-qt/template
@@ -5,7 +5,6 @@ revision=2
 build_style=cmake
 hostmakedepends="qt5-host-tools qt5-qmake"
 makedepends="qt5-devel qt5-x11extras-devel"
-depends="libadwaita-qt"
 short_desc="Style to bend Qt applications to look like they belong into GNOME Shell"
 maintainer="Piotr Wójcik <chocimier@tlen.pl>"
 license="GPL-2.0-or-later"
@@ -14,7 +13,6 @@ distfiles="https://github.com/FedoraQt/adwaita-qt/archive/${version}.tar.gz"
 checksum=0673586fe37469eb826be821b3f2c12f055e99a6ca0a8377cfa06b123543ae56
 
 libadwaita-qt_package() {
-       depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
        short_desc+=" - shared libraries"
        pkg_install() {
                vmove "usr/lib/*.so.*"
@@ -22,7 +20,7 @@ libadwaita-qt_package() {
 }
 
 adwaita-qt-devel_package() {
-       depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
+       depends="${makedepends} libadwaita-qt>=${version}_${revision}"
        short_desc+=" - development files"
        pkg_install() {
                vmove usr/include
```

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New packages: libadwaita-qt adwaita-qt-devel
  2021-04-10  5:13 [PR PATCH] New packages: libadwaita-qt adwaita-qt-devel phossil
  2021-04-10 10:17 ` Chocimier
@ 2021-04-10 11:35 ` paper42
  2021-04-10 11:51 ` Chocimier
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2021-04-10 11:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/30117#issuecomment-817122193

Comment:
I see why you named the library libadwaita-qt, but I think it will soon become very confusing for users. [libadwaita](https://gitlab.gnome.org/GNOME/libadwaita/) is a name of a new GNOME library (continuation of libhandy) which will provide GTK4 widgets with the Adwaita design. Naming this package libadwaita-qt makes sense, but I can see why people could be confused by it.

from [Introducing libadwaita](https://adrienplazas.com/blog/2021/03/31/introducing-libadwaita.html):

> Adwaita is the name of GNOME’s visual language and identity, and it is already used by two projects implementing it: the Adwaita GTK stylesheet and the Adwaita icon set. This new libadwaita library intends to extend that concept by being the missing code part of Adwaita. The library will be implemented as a direct GTK 4 continuation and replacement of libhandy, and it will be developed by libhandy’s current developers.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New packages: libadwaita-qt adwaita-qt-devel
  2021-04-10  5:13 [PR PATCH] New packages: libadwaita-qt adwaita-qt-devel phossil
  2021-04-10 10:17 ` Chocimier
  2021-04-10 11:35 ` paper42
@ 2021-04-10 11:51 ` Chocimier
  2021-04-10 12:34 ` paper42
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2021-04-10 11:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/30117#issuecomment-817124492

Comment:
Unless libadwaita plan to do their own qt integration, why would _library_ name be confusing?
If you have better name for package containing `libadwaitaqt.so.1`, we could rename.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New packages: libadwaita-qt adwaita-qt-devel
  2021-04-10  5:13 [PR PATCH] New packages: libadwaita-qt adwaita-qt-devel phossil
                   ` (2 preceding siblings ...)
  2021-04-10 11:51 ` Chocimier
@ 2021-04-10 12:34 ` paper42
  2021-04-10 19:44 ` [PR PATCH] [Updated] adwaita-qt: split libadwaita-qt and adwaita-qt-devel phossil
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2021-04-10 12:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/30117#issuecomment-817129805

Comment:
I don't think they plan to have qt integration. What I meant was new users seeing two libadwaita packages and thinking they are the same thing. I don't know a better name though.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] adwaita-qt: split libadwaita-qt and adwaita-qt-devel
  2021-04-10  5:13 [PR PATCH] New packages: libadwaita-qt adwaita-qt-devel phossil
                   ` (3 preceding siblings ...)
  2021-04-10 12:34 ` paper42
@ 2021-04-10 19:44 ` phossil
  2021-04-12 15:41 ` Chocimier
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: phossil @ 2021-04-10 19:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]

There is an updated pull request by phossil against master on the void-packages repository

https://github.com/phossil/void-packages adwaita-qt
https://github.com/void-linux/void-packages/pull/30117

adwaita-qt: split libadwaita-qt and adwaita-qt-devel
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
- See [Package Request](https://github.com/void-linux/void-packages/issues/30099) for details.

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
  - [x] aarch64

#### changes made
- subpackages were added to `adwaita-qt`
- two libraries were added to `common/shlibs`

A patch file from https://github.com/void-linux/void-packages/pull/30117.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-adwaita-qt-30117.patch --]
[-- Type: text/x-diff, Size: 2559 bytes --]

From 0c5b6e90b39e11eeadb11f7c737d339829f32b65 Mon Sep 17 00:00:00 2001
From: Phosu Parsons <38191182+phossil@users.noreply.github.com>
Date: Fri, 9 Apr 2021 15:49:55 -0500
Subject: [PATCH] New packages: libadwaita-qt adwaita-qt-devel

---
 common/shlibs               |  2 ++
 srcpkgs/adwaita-qt-devel    |  1 +
 srcpkgs/adwaita-qt/template | 22 +++++++++++++++++++++-
 srcpkgs/libadwaita-qt       |  1 +
 4 files changed, 25 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/adwaita-qt-devel
 create mode 120000 srcpkgs/libadwaita-qt

diff --git a/common/shlibs b/common/shlibs
index 296b93e5f22b..958e475a0ce8 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3967,3 +3967,5 @@ libmd.so.0 libmd-1.0.3_1
 libldacBT_abr.so.2 ldacBT-2.0.2.3_1
 libldacBT_enc.so.2 ldacBT-2.0.2.3_1
 libgumbo.so.1 gumbo-parser-0.10.1_2
+libadwaitaqt.so.1 libadwaita-qt-1.2.1_2
+libadwaitaqtpriv.so.1 libadwaita-qt-1.2.1_2
diff --git a/srcpkgs/adwaita-qt-devel b/srcpkgs/adwaita-qt-devel
new file mode 120000
index 000000000000..b3dd98903e7a
--- /dev/null
+++ b/srcpkgs/adwaita-qt-devel
@@ -0,0 +1 @@
+adwaita-qt
\ No newline at end of file
diff --git a/srcpkgs/adwaita-qt/template b/srcpkgs/adwaita-qt/template
index 08752a9a660c..3bc1c0c28a68 100644
--- a/srcpkgs/adwaita-qt/template
+++ b/srcpkgs/adwaita-qt/template
@@ -1,13 +1,33 @@
 # Template file for 'adwaita-qt'
 pkgname=adwaita-qt
 version=1.2.1
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="qt5-host-tools qt5-qmake"
 makedepends="qt5-devel qt5-x11extras-devel"
+depends="libadwaita-qt"
 short_desc="Style to bend Qt applications to look like they belong into GNOME Shell"
 maintainer="Piotr Wójcik <chocimier@tlen.pl>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/FedoraQt/adwaita-qt"
 distfiles="https://github.com/FedoraQt/adwaita-qt/archive/${version}.tar.gz"
 checksum=0673586fe37469eb826be821b3f2c12f055e99a6ca0a8377cfa06b123543ae56
+
+libadwaita-qt_package() {
+	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - shared libraries"
+	pkg_install() {
+		vmove "usr/lib/*.so.*"
+	}
+}
+
+adwaita-qt-devel_package() {
+	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove "usr/lib/*.so"
+		vmove usr/lib/cmake
+		vmove usr/lib/pkgconfig
+	}
+}
diff --git a/srcpkgs/libadwaita-qt b/srcpkgs/libadwaita-qt
new file mode 120000
index 000000000000..b3dd98903e7a
--- /dev/null
+++ b/srcpkgs/libadwaita-qt
@@ -0,0 +1 @@
+adwaita-qt
\ No newline at end of file

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: adwaita-qt: split libadwaita-qt and adwaita-qt-devel
  2021-04-10  5:13 [PR PATCH] New packages: libadwaita-qt adwaita-qt-devel phossil
                   ` (4 preceding siblings ...)
  2021-04-10 19:44 ` [PR PATCH] [Updated] adwaita-qt: split libadwaita-qt and adwaita-qt-devel phossil
@ 2021-04-12 15:41 ` Chocimier
  2022-05-17  2:15 ` github-actions
  2022-06-01  2:14 ` [PR PATCH] [Closed]: " github-actions
  7 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2021-04-12 15:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/30117#issuecomment-817916566

Comment:
@phossil ping me when you apply whole patch.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: adwaita-qt: split libadwaita-qt and adwaita-qt-devel
  2021-04-10  5:13 [PR PATCH] New packages: libadwaita-qt adwaita-qt-devel phossil
                   ` (5 preceding siblings ...)
  2021-04-12 15:41 ` Chocimier
@ 2022-05-17  2:15 ` github-actions
  2022-06-01  2:14 ` [PR PATCH] [Closed]: " github-actions
  7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2022-05-17  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/30117#issuecomment-1128327779

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Closed]: adwaita-qt: split libadwaita-qt and adwaita-qt-devel
  2021-04-10  5:13 [PR PATCH] New packages: libadwaita-qt adwaita-qt-devel phossil
                   ` (6 preceding siblings ...)
  2022-05-17  2:15 ` github-actions
@ 2022-06-01  2:14 ` github-actions
  7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2022-06-01  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1675 bytes --]

There's a closed pull request on the void-packages repository

adwaita-qt: split libadwaita-qt and adwaita-qt-devel
https://github.com/void-linux/void-packages/pull/30117

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
- See [Package Request](https://github.com/void-linux/void-packages/issues/30099) for details.

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
  - [x] aarch64

#### changes made
- subpackages were added to `adwaita-qt`
- two libraries were added to `common/shlibs`

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-06-01  2:14 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-10  5:13 [PR PATCH] New packages: libadwaita-qt adwaita-qt-devel phossil
2021-04-10 10:17 ` Chocimier
2021-04-10 11:35 ` paper42
2021-04-10 11:51 ` Chocimier
2021-04-10 12:34 ` paper42
2021-04-10 19:44 ` [PR PATCH] [Updated] adwaita-qt: split libadwaita-qt and adwaita-qt-devel phossil
2021-04-12 15:41 ` Chocimier
2022-05-17  2:15 ` github-actions
2022-06-01  2:14 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).