Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9
@ 2022-04-13 17:14 QuadPiece
  2022-04-13 22:46 ` dmarto
                   ` (11 more replies)
  0 siblings, 12 replies; 16+ messages in thread
From: QuadPiece @ 2022-04-13 17:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]

There is a new pull request by QuadPiece against master on the void-packages repository

https://github.com/QuadPiece/void-packages added-tuxedo-keyboard-dkms
https://github.com/void-linux/void-packages/pull/36673

New package: tuxedo-keyboard-dkms-3.0.9
***This is my first void package, please be strict.***

Same PR as #36465, but I actually remembered to branch it off this time.

DKMS modules developed by Tuxedo Computers for their laptops.  
They provide drivers for many device-specific things such as keyboard backlight, fan control and fn-keys.

Due to the nature of Tuxedo laptops, this module usually also works on other laptops using the same Clevo or TongFang designs.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** (On [InfinityBook Pro 14](https://www.tuxedocomputers.com/en/Linux-Hardware/Linux-Notebooks/10-14-inch/TUXEDO-InfinityBook-Pro-14-Gen6-US-ANSI-Edition.tuxedo))

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture (x86_64-musl)


A patch file from https://github.com/void-linux/void-packages/pull/36673.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-added-tuxedo-keyboard-dkms-36673.patch --]
[-- Type: text/x-diff, Size: 1309 bytes --]

From 10b9b71bfe9b62b268529eb31fb127581c78f151 Mon Sep 17 00:00:00 2001
From: Quad <contact@quad.moe>
Date: Wed, 13 Apr 2022 19:11:55 +0200
Subject: [PATCH] New package: tuxedo-keyboard-dkms-3.0.9

---
 srcpkgs/tuxedo-keyboard-dkms/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/tuxedo-keyboard-dkms/template

diff --git a/srcpkgs/tuxedo-keyboard-dkms/template b/srcpkgs/tuxedo-keyboard-dkms/template
new file mode 100644
index 000000000000..4025a0eeac60
--- /dev/null
+++ b/srcpkgs/tuxedo-keyboard-dkms/template
@@ -0,0 +1,22 @@
+# Template file for 'tuxedo-keyboard-dkms'
+pkgname=tuxedo-keyboard-dkms
+version=3.0.9
+revision=1
+archs="x86_64 x86_64-musl"
+wrksrc="tuxedo-keyboard-${version}"
+
+short_desc="Kernel drivers for certain Tuxedo laptops and other Clevo designs"
+maintainer="Quad <contact@quad.moe>"
+
+license="GPL-3.0-or-later"
+homepage="https://github.com/tuxedocomputers/tuxedo-keyboard"
+distfiles="https://github.com/tuxedocomputers/tuxedo-keyboard/archive/refs/tags/v${version}.tar.gz"
+checksum=2ecaadf55e51c135679869c4fe251626d1bd26765de7622a9d109884c458a584
+
+dkms_modules="tuxedo-keyboard ${version}"
+depends="dkms"
+
+do_install() {
+	vmkdir usr/src/tuxedo-keyboard-${version}
+	vcopy "*" usr/src/tuxedo-keyboard-${version}
+}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
@ 2022-04-13 22:46 ` dmarto
  2022-04-14  8:39 ` QuadPiece
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: dmarto @ 2022-04-13 22:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

New comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/36673#issuecomment-1098550986

Comment:
You would want to install [xtools](https://github.com/leahneukirchen/xtools) and run `xlint tuxedo..` on the template, as right now it is non conforming to the expected style (whitespace, order of fields, etc.)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
  2022-04-13 22:46 ` dmarto
@ 2022-04-14  8:39 ` QuadPiece
  2022-04-14  9:05 ` dmarto
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: QuadPiece @ 2022-04-14  8:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

New comment by QuadPiece on void-packages repository

https://github.com/void-linux/void-packages/pull/36673#issuecomment-1098859520

Comment:
Am I missing something? `xlint` doesn't seem to give me any output when I run it. I know it finds the template since it gives me a "no such template" error if I run it elsewhere.

![Screenshot_20220414_103400](https://user-images.githubusercontent.com/6379091/163347487-32cc09f0-9505-467e-b272-8047c7f5fb85.png)

Are these formatting requirements noted down somewhere else so I can apply them manually?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
  2022-04-13 22:46 ` dmarto
  2022-04-14  8:39 ` QuadPiece
@ 2022-04-14  9:05 ` dmarto
  2022-04-14  9:08 ` dmarto
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: dmarto @ 2022-04-14  9:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

New comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/36673#issuecomment-1098894609

Comment:
Ah, yes, I think that `xlint` stops executing on the first empty new line (as that is the expected separator between the fields and the potential step functions), remove the empty new lines, and it will start complaining.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
                   ` (2 preceding siblings ...)
  2022-04-14  9:05 ` dmarto
@ 2022-04-14  9:08 ` dmarto
  2022-04-14  9:22 ` [PR REVIEW] " dmarto
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: dmarto @ 2022-04-14  9:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

New comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/36673#issuecomment-1098894609

Comment:
Ah, yes, I think that `xlint` stops executing on the first empty new line (as that is the expected separator between the fields and the potential step functions), remove the empty new lines, and it will start complaining.

About where you can read, I am sure 100% sure if it is written somewhere, but the best approach is to read https://github.com/void-linux/void-packages/blob/master/Manual.md and when in doubt check the source of `xlint`, `xbps-src` and other templates.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
                   ` (3 preceding siblings ...)
  2022-04-14  9:08 ` dmarto
@ 2022-04-14  9:22 ` dmarto
  2022-04-15  7:02 ` [PR PATCH] [Updated] " QuadPiece
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: dmarto @ 2022-04-14  9:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/36673#discussion_r850256475

Comment:
I believe `x86_64*` is preferred.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
                   ` (4 preceding siblings ...)
  2022-04-14  9:22 ` [PR REVIEW] " dmarto
@ 2022-04-15  7:02 ` QuadPiece
  2022-04-15  7:04 ` QuadPiece
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: QuadPiece @ 2022-04-15  7:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]

There is an updated pull request by QuadPiece against master on the void-packages repository

https://github.com/QuadPiece/void-packages added-tuxedo-keyboard-dkms
https://github.com/void-linux/void-packages/pull/36673

New package: tuxedo-keyboard-dkms-3.0.9
***This is my first void package, please be strict.***

Same PR as #36465, but I actually remembered to branch it off this time.

DKMS modules developed by Tuxedo Computers for their laptops.  
They provide drivers for many device-specific things such as keyboard backlight, fan control and fn-keys.

Due to the nature of Tuxedo laptops, this module usually also works on other laptops using the same Clevo or TongFang designs.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** (On [InfinityBook Pro 14](https://www.tuxedocomputers.com/en/Linux-Hardware/Linux-Notebooks/10-14-inch/TUXEDO-InfinityBook-Pro-14-Gen6-US-ANSI-Edition.tuxedo))

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture (x86_64-musl)


A patch file from https://github.com/void-linux/void-packages/pull/36673.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-added-tuxedo-keyboard-dkms-36673.patch --]
[-- Type: text/x-diff, Size: 2477 bytes --]

From 10b9b71bfe9b62b268529eb31fb127581c78f151 Mon Sep 17 00:00:00 2001
From: Quad <contact@quad.moe>
Date: Wed, 13 Apr 2022 19:11:55 +0200
Subject: [PATCH 1/2] New package: tuxedo-keyboard-dkms-3.0.9

---
 srcpkgs/tuxedo-keyboard-dkms/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/tuxedo-keyboard-dkms/template

diff --git a/srcpkgs/tuxedo-keyboard-dkms/template b/srcpkgs/tuxedo-keyboard-dkms/template
new file mode 100644
index 000000000000..4025a0eeac60
--- /dev/null
+++ b/srcpkgs/tuxedo-keyboard-dkms/template
@@ -0,0 +1,22 @@
+# Template file for 'tuxedo-keyboard-dkms'
+pkgname=tuxedo-keyboard-dkms
+version=3.0.9
+revision=1
+archs="x86_64 x86_64-musl"
+wrksrc="tuxedo-keyboard-${version}"
+
+short_desc="Kernel drivers for certain Tuxedo laptops and other Clevo designs"
+maintainer="Quad <contact@quad.moe>"
+
+license="GPL-3.0-or-later"
+homepage="https://github.com/tuxedocomputers/tuxedo-keyboard"
+distfiles="https://github.com/tuxedocomputers/tuxedo-keyboard/archive/refs/tags/v${version}.tar.gz"
+checksum=2ecaadf55e51c135679869c4fe251626d1bd26765de7622a9d109884c458a584
+
+dkms_modules="tuxedo-keyboard ${version}"
+depends="dkms"
+
+do_install() {
+	vmkdir usr/src/tuxedo-keyboard-${version}
+	vcopy "*" usr/src/tuxedo-keyboard-${version}
+}

From ef6e66c74171754c7a9163070efcb2d6f6fc7e90 Mon Sep 17 00:00:00 2001
From: Quad <contact@quad.moe>
Date: Fri, 15 Apr 2022 09:01:39 +0200
Subject: [PATCH 2/2] tuxedo-keyboard-dkms: Reorder template file

---
 srcpkgs/tuxedo-keyboard-dkms/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/tuxedo-keyboard-dkms/template b/srcpkgs/tuxedo-keyboard-dkms/template
index 4025a0eeac60..e3ca4df49e7e 100644
--- a/srcpkgs/tuxedo-keyboard-dkms/template
+++ b/srcpkgs/tuxedo-keyboard-dkms/template
@@ -4,17 +4,14 @@ version=3.0.9
 revision=1
 archs="x86_64 x86_64-musl"
 wrksrc="tuxedo-keyboard-${version}"
-
+depends="dkms"
 short_desc="Kernel drivers for certain Tuxedo laptops and other Clevo designs"
 maintainer="Quad <contact@quad.moe>"
-
 license="GPL-3.0-or-later"
 homepage="https://github.com/tuxedocomputers/tuxedo-keyboard"
 distfiles="https://github.com/tuxedocomputers/tuxedo-keyboard/archive/refs/tags/v${version}.tar.gz"
 checksum=2ecaadf55e51c135679869c4fe251626d1bd26765de7622a9d109884c458a584
-
 dkms_modules="tuxedo-keyboard ${version}"
-depends="dkms"
 
 do_install() {
 	vmkdir usr/src/tuxedo-keyboard-${version}

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
                   ` (5 preceding siblings ...)
  2022-04-15  7:02 ` [PR PATCH] [Updated] " QuadPiece
@ 2022-04-15  7:04 ` QuadPiece
  2022-04-15  7:05 ` [PR REVIEW] " QuadPiece
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: QuadPiece @ 2022-04-15  7:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]

There is an updated pull request by QuadPiece against master on the void-packages repository

https://github.com/QuadPiece/void-packages added-tuxedo-keyboard-dkms
https://github.com/void-linux/void-packages/pull/36673

New package: tuxedo-keyboard-dkms-3.0.9
***This is my first void package, please be strict.***

Same PR as #36465, but I actually remembered to branch it off this time.

DKMS modules developed by Tuxedo Computers for their laptops.  
They provide drivers for many device-specific things such as keyboard backlight, fan control and fn-keys.

Due to the nature of Tuxedo laptops, this module usually also works on other laptops using the same Clevo or TongFang designs.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** (On [InfinityBook Pro 14](https://www.tuxedocomputers.com/en/Linux-Hardware/Linux-Notebooks/10-14-inch/TUXEDO-InfinityBook-Pro-14-Gen6-US-ANSI-Edition.tuxedo))

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture (x86_64-musl)


A patch file from https://github.com/void-linux/void-packages/pull/36673.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-added-tuxedo-keyboard-dkms-36673.patch --]
[-- Type: text/x-diff, Size: 3251 bytes --]

From 10b9b71bfe9b62b268529eb31fb127581c78f151 Mon Sep 17 00:00:00 2001
From: Quad <contact@quad.moe>
Date: Wed, 13 Apr 2022 19:11:55 +0200
Subject: [PATCH 1/3] New package: tuxedo-keyboard-dkms-3.0.9

---
 srcpkgs/tuxedo-keyboard-dkms/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/tuxedo-keyboard-dkms/template

diff --git a/srcpkgs/tuxedo-keyboard-dkms/template b/srcpkgs/tuxedo-keyboard-dkms/template
new file mode 100644
index 000000000000..4025a0eeac60
--- /dev/null
+++ b/srcpkgs/tuxedo-keyboard-dkms/template
@@ -0,0 +1,22 @@
+# Template file for 'tuxedo-keyboard-dkms'
+pkgname=tuxedo-keyboard-dkms
+version=3.0.9
+revision=1
+archs="x86_64 x86_64-musl"
+wrksrc="tuxedo-keyboard-${version}"
+
+short_desc="Kernel drivers for certain Tuxedo laptops and other Clevo designs"
+maintainer="Quad <contact@quad.moe>"
+
+license="GPL-3.0-or-later"
+homepage="https://github.com/tuxedocomputers/tuxedo-keyboard"
+distfiles="https://github.com/tuxedocomputers/tuxedo-keyboard/archive/refs/tags/v${version}.tar.gz"
+checksum=2ecaadf55e51c135679869c4fe251626d1bd26765de7622a9d109884c458a584
+
+dkms_modules="tuxedo-keyboard ${version}"
+depends="dkms"
+
+do_install() {
+	vmkdir usr/src/tuxedo-keyboard-${version}
+	vcopy "*" usr/src/tuxedo-keyboard-${version}
+}

From ef6e66c74171754c7a9163070efcb2d6f6fc7e90 Mon Sep 17 00:00:00 2001
From: Quad <contact@quad.moe>
Date: Fri, 15 Apr 2022 09:01:39 +0200
Subject: [PATCH 2/3] tuxedo-keyboard-dkms: Reorder template file

---
 srcpkgs/tuxedo-keyboard-dkms/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/tuxedo-keyboard-dkms/template b/srcpkgs/tuxedo-keyboard-dkms/template
index 4025a0eeac60..e3ca4df49e7e 100644
--- a/srcpkgs/tuxedo-keyboard-dkms/template
+++ b/srcpkgs/tuxedo-keyboard-dkms/template
@@ -4,17 +4,14 @@ version=3.0.9
 revision=1
 archs="x86_64 x86_64-musl"
 wrksrc="tuxedo-keyboard-${version}"
-
+depends="dkms"
 short_desc="Kernel drivers for certain Tuxedo laptops and other Clevo designs"
 maintainer="Quad <contact@quad.moe>"
-
 license="GPL-3.0-or-later"
 homepage="https://github.com/tuxedocomputers/tuxedo-keyboard"
 distfiles="https://github.com/tuxedocomputers/tuxedo-keyboard/archive/refs/tags/v${version}.tar.gz"
 checksum=2ecaadf55e51c135679869c4fe251626d1bd26765de7622a9d109884c458a584
-
 dkms_modules="tuxedo-keyboard ${version}"
-depends="dkms"
 
 do_install() {
 	vmkdir usr/src/tuxedo-keyboard-${version}

From 5e4d018fcea535a463f3ad5943bddcea92004b75 Mon Sep 17 00:00:00 2001
From: Quad <contact@quad.moe>
Date: Fri, 15 Apr 2022 09:03:02 +0200
Subject: [PATCH 3/3] tuxedo-keyboard-dkms: Fix archs in template

---
 srcpkgs/tuxedo-keyboard-dkms/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/tuxedo-keyboard-dkms/template b/srcpkgs/tuxedo-keyboard-dkms/template
index e3ca4df49e7e..65a87a0b1cf3 100644
--- a/srcpkgs/tuxedo-keyboard-dkms/template
+++ b/srcpkgs/tuxedo-keyboard-dkms/template
@@ -2,7 +2,7 @@
 pkgname=tuxedo-keyboard-dkms
 version=3.0.9
 revision=1
-archs="x86_64 x86_64-musl"
+archs="x86_64*"
 wrksrc="tuxedo-keyboard-${version}"
 depends="dkms"
 short_desc="Kernel drivers for certain Tuxedo laptops and other Clevo designs"

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
                   ` (6 preceding siblings ...)
  2022-04-15  7:04 ` QuadPiece
@ 2022-04-15  7:05 ` QuadPiece
  2022-04-15 14:05 ` newbluemoon
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: QuadPiece @ 2022-04-15  7:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by QuadPiece on void-packages repository

https://github.com/void-linux/void-packages/pull/36673#discussion_r851100623

Comment:
Fixed, pushed and verified that it still builds

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
                   ` (7 preceding siblings ...)
  2022-04-15  7:05 ` [PR REVIEW] " QuadPiece
@ 2022-04-15 14:05 ` newbluemoon
  2022-04-18 13:48 ` QuadPiece
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 16+ messages in thread
From: newbluemoon @ 2022-04-15 14:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/36673#issuecomment-1100129488

Comment:
Duplicate of #36122  ;)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
                   ` (8 preceding siblings ...)
  2022-04-15 14:05 ` newbluemoon
@ 2022-04-18 13:48 ` QuadPiece
  2022-05-19 20:04 ` [PR PATCH] [Closed]: " QuadPiece
  2022-05-19 20:04 ` QuadPiece
  11 siblings, 0 replies; 16+ messages in thread
From: QuadPiece @ 2022-04-18 13:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by QuadPiece on void-packages repository

https://github.com/void-linux/void-packages/pull/36673#issuecomment-1101422995

Comment:
Not sure how I managed to miss this being a duplicate. Feel free to close and follow #36122 if that's how duplicated are handled

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Closed]: New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
                   ` (9 preceding siblings ...)
  2022-04-18 13:48 ` QuadPiece
@ 2022-05-19 20:04 ` QuadPiece
  2022-05-19 20:04 ` QuadPiece
  11 siblings, 0 replies; 16+ messages in thread
From: QuadPiece @ 2022-05-19 20:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]

There's a closed pull request on the void-packages repository

New package: tuxedo-keyboard-dkms-3.0.9
https://github.com/void-linux/void-packages/pull/36673

Description:
***This is my first void package, please be strict.***

Same PR as #36465, but I actually remembered to branch it off this time.

DKMS modules developed by Tuxedo Computers for their laptops.  
They provide drivers for many device-specific things such as keyboard backlight, fan control and fn-keys.

Due to the nature of Tuxedo laptops, this module usually also works on other laptops using the same Clevo or TongFang designs.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** (On [InfinityBook Pro 14](https://www.tuxedocomputers.com/en/Linux-Hardware/Linux-Notebooks/10-14-inch/TUXEDO-InfinityBook-Pro-14-Gen6-US-ANSI-Edition.tuxedo))

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture (x86_64-musl)


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
                   ` (10 preceding siblings ...)
  2022-05-19 20:04 ` [PR PATCH] [Closed]: " QuadPiece
@ 2022-05-19 20:04 ` QuadPiece
  11 siblings, 0 replies; 16+ messages in thread
From: QuadPiece @ 2022-05-19 20:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by QuadPiece on void-packages repository

https://github.com/void-linux/void-packages/pull/36673#issuecomment-1132145988

Comment:
Closing instead of updating to 3.0.10. Track #36122 instead

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-02 15:00 [PR PATCH] " QuadPiece
  2022-04-13 17:02 ` QuadPiece
  2022-04-13 17:05 ` wael444
@ 2022-04-13 17:06 ` QuadPiece
  2 siblings, 0 replies; 16+ messages in thread
From: QuadPiece @ 2022-04-13 17:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

New comment by QuadPiece on void-packages repository

https://github.com/void-linux/void-packages/pull/36465#issuecomment-1098287170

Comment:
Yes, I thought I made an `added-<package name>` branch. But apparently I didn't and accidentally did some other stuff to master it was my mistake.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-02 15:00 [PR PATCH] " QuadPiece
  2022-04-13 17:02 ` QuadPiece
@ 2022-04-13 17:05 ` wael444
  2022-04-13 17:06 ` QuadPiece
  2 siblings, 0 replies; 16+ messages in thread
From: wael444 @ 2022-04-13 17:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/36465#issuecomment-1098285848

Comment:
i would always suggest to make a new package under a different branch.
for example i fork `void-packages` and don't touch the master branch.
i make a new branch from master named after the package i would want to submit.

it is also generally unrecommended to make a new New package PR after you have already made one, but seems somethign went wrong so..

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: New package: tuxedo-keyboard-dkms-3.0.9
  2022-04-02 15:00 [PR PATCH] " QuadPiece
@ 2022-04-13 17:02 ` QuadPiece
  2022-04-13 17:05 ` wael444
  2022-04-13 17:06 ` QuadPiece
  2 siblings, 0 replies; 16+ messages in thread
From: QuadPiece @ 2022-04-13 17:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by QuadPiece on void-packages repository

https://github.com/void-linux/void-packages/pull/36465#issuecomment-1098283232

Comment:
I managed to break this PR because I forgot to branch my changes. Will resubmit properly.

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2022-05-19 20:04 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13 17:14 [PR PATCH] New package: tuxedo-keyboard-dkms-3.0.9 QuadPiece
2022-04-13 22:46 ` dmarto
2022-04-14  8:39 ` QuadPiece
2022-04-14  9:05 ` dmarto
2022-04-14  9:08 ` dmarto
2022-04-14  9:22 ` [PR REVIEW] " dmarto
2022-04-15  7:02 ` [PR PATCH] [Updated] " QuadPiece
2022-04-15  7:04 ` QuadPiece
2022-04-15  7:05 ` [PR REVIEW] " QuadPiece
2022-04-15 14:05 ` newbluemoon
2022-04-18 13:48 ` QuadPiece
2022-05-19 20:04 ` [PR PATCH] [Closed]: " QuadPiece
2022-05-19 20:04 ` QuadPiece
  -- strict thread matches above, loose matches on Subject: below --
2022-04-02 15:00 [PR PATCH] " QuadPiece
2022-04-13 17:02 ` QuadPiece
2022-04-13 17:05 ` wael444
2022-04-13 17:06 ` QuadPiece

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).