Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New packages: lite-xl and reproc (dep).
@ 2022-05-21 12:27 mobinmob
  2022-05-21 12:36 ` mobinmob
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: mobinmob @ 2022-05-21 12:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

There is a new pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages lite-xl
https://github.com/void-linux/void-packages/pull/37218

New packages: lite-xl and reproc (dep).
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

Cross-compile does not work - meson cannot find sdl2-config.


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37218.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lite-xl-37218.patch --]
[-- Type: text/x-diff, Size: 3247 bytes --]

From ce76fa765276351b99d3ebec5b41166bbb50b603 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sat, 21 May 2022 15:23:58 +0300
Subject: [PATCH 1/2] New package: reproc-14.2.4

---
 common/shlibs           |  2 ++
 srcpkgs/reproc-devel    |  1 +
 srcpkgs/reproc/template | 28 ++++++++++++++++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 120000 srcpkgs/reproc-devel
 create mode 100644 srcpkgs/reproc/template

diff --git a/common/shlibs b/common/shlibs
index 7f3e1458f7a6..9bc27f286a49 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4170,3 +4170,5 @@ libThread.so root-6.24.06_1
 libTMVA.so root-6.24.06_1
 libMathCore.so root-6.24.06_1
 liblowdown.so lowdown-0.11.2_1
+libreproc.so.14 reproc-14.2.4_1
+libreproc++.so.14 reproc-14.2.4_1
diff --git a/srcpkgs/reproc-devel b/srcpkgs/reproc-devel
new file mode 120000
index 000000000000..ea2ee2920788
--- /dev/null
+++ b/srcpkgs/reproc-devel
@@ -0,0 +1 @@
+reproc
\ No newline at end of file
diff --git a/srcpkgs/reproc/template b/srcpkgs/reproc/template
new file mode 100644
index 000000000000..ff1530e7df2e
--- /dev/null
+++ b/srcpkgs/reproc/template
@@ -0,0 +1,28 @@
+# Template file for 'reproc'
+pkgname=reproc
+version=14.2.4
+revision=1
+build_style=cmake
+configure_args=" -DCMAKE_INSTALL_LIBDIR=lib -DBUILD_SHARED_LIBS=ON -DREPROC++=ON  -DREPROC_TEST=ON"
+short_desc="Cross-platform (C99/C++11) process library"
+maintainer="mobinmob <mobinmob@disroot.org>"
+license="MIT"
+homepage="https://github.com/DaanDeMeyer/reproc"
+changelog="https://raw.githubusercontent.com/DaanDeMeyer/reproc/main/CHANGELOG.md"
+distfiles="https://github.com/DaanDeMeyer/reproc/archive/refs/tags/v${version}.tar.gz"
+checksum=55c780f7faa5c8cabd83ebbb84b68e5e0e09732de70a129f6b3c801e905415dd
+
+post_install() {
+	vlicense LICENSE
+}
+
+reproc-devel_package() {
+	depends="reproc>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove usr/lib/pkgconfig
+		vmove "usr/lib/*.so"
+		vmove usr/lib/cmake
+		}
+}

From 8fddd67ae93b2a5aa06bb35707390c02394b7933 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Sat, 21 May 2022 15:24:03 +0300
Subject: [PATCH 2/2] New package: lite-xl-2.0.5

---
 srcpkgs/lite-xl/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/lite-xl/template

diff --git a/srcpkgs/lite-xl/template b/srcpkgs/lite-xl/template
new file mode 100644
index 000000000000..d72c4ae6f3b4
--- /dev/null
+++ b/srcpkgs/lite-xl/template
@@ -0,0 +1,23 @@
+# Template file for 'lite-xl'
+pkgname=lite-xl
+version=2.0.5
+revision=1
+build_style=meson
+configure_args=" --wrap-mode=default"
+hostmakedepends="pkg-config git"
+makedepends="lua52-devel pcre2-devel SDL2-devel freetype-devel agg-devel reproc-devel"
+#depends="LuaJIT"
+short_desc="Lightweight text editor written in Lua"
+maintainer="mobinmob <mobinmob@disroot.org>"
+license="MIT"
+homepage="https://lite-xl.com/"
+distfiles="https://github.com/lite-xl/lite-xl/archive/refs/tags/v${version}.tar.gz"
+checksum=ded5c3861d4aab51859f82010c8d40567e6157cb699cbdc5d35fdaa68ba058fb
+
+if [ -n "$CROSS_BUILD" ]; then
+	hostmakedepends+=" SDL2-devel"
+fi
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New packages: lite-xl and reproc (dep).
  2022-05-21 12:27 [PR PATCH] New packages: lite-xl and reproc (dep) mobinmob
@ 2022-05-21 12:36 ` mobinmob
  2022-05-21 12:45 ` FollieHiyuki
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: mobinmob @ 2022-05-21 12:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/37218#issuecomment-1133627096

Comment:
Any help with cross-compiling will be greatly appreciated :)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New packages: lite-xl and reproc (dep).
  2022-05-21 12:27 [PR PATCH] New packages: lite-xl and reproc (dep) mobinmob
  2022-05-21 12:36 ` mobinmob
@ 2022-05-21 12:45 ` FollieHiyuki
  2022-05-21 12:49 ` FollieHiyuki
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: FollieHiyuki @ 2022-05-21 12:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/37218#issuecomment-1133628376

Comment:
Thanks for taking over my abandoned PR!

I'd probably wait for [2.1 release](https://github.com/lite-xl/lite-xl/pull/897). It will drop `agg` and `reproc` dependencies so we don't need to introduce 1 more new package.

Apparently Alpine is [successful at cross-compiling](https://pkgs.alpinelinux.org/packages?name=lite-xl&branch=edge). You may take a look at how they do it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New packages: lite-xl and reproc (dep).
  2022-05-21 12:27 [PR PATCH] New packages: lite-xl and reproc (dep) mobinmob
  2022-05-21 12:36 ` mobinmob
  2022-05-21 12:45 ` FollieHiyuki
@ 2022-05-21 12:49 ` FollieHiyuki
  2022-05-21 13:05 ` mobinmob
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: FollieHiyuki @ 2022-05-21 12:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/37218#issuecomment-1133628376

Comment:
Closes #30953 and #22101.

I'd probably wait for [2.1 release](https://github.com/lite-xl/lite-xl/pull/897). It will drop `agg` and `reproc` dependencies so we don't need to introduce 1 more new package.

Apparently Alpine is [successful at cross-compiling](https://pkgs.alpinelinux.org/packages?name=lite-xl&branch=edge). You may take a look at how they do it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New packages: lite-xl and reproc (dep).
  2022-05-21 12:27 [PR PATCH] New packages: lite-xl and reproc (dep) mobinmob
                   ` (2 preceding siblings ...)
  2022-05-21 12:49 ` FollieHiyuki
@ 2022-05-21 13:05 ` mobinmob
  2022-05-21 15:27 ` classabbyamp
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: mobinmob @ 2022-05-21 13:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/37218#issuecomment-1133630967

Comment:
> Closes #30953 and #22101.
> 
> I'd probably wait for [2.1 release](https://github.com/lite-xl/lite-xl/pull/897). It will drop `agg` and `reproc` dependencies so we don't need to introduce 1 more new package.
> 
> Apparently Alpine is [successful at cross-compiling](https://pkgs.alpinelinux.org/packages?name=lite-xl&branch=edge). You may take a look at how they do it.

I did not search for previous PRs :(
The APKBUILD does not have anything special: https://git.alpinelinux.org/aports/tree/testing/lite-xl/APKBUILD



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New packages: lite-xl and reproc (dep).
  2022-05-21 12:27 [PR PATCH] New packages: lite-xl and reproc (dep) mobinmob
                   ` (3 preceding siblings ...)
  2022-05-21 13:05 ` mobinmob
@ 2022-05-21 15:27 ` classabbyamp
  2022-05-26 19:19 ` eli-schwartz
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2022-05-21 15:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37218#issuecomment-1133652536

Comment:
> Apparently Alpine is [successful at cross-compiling](https://pkgs.alpinelinux.org/packages?name=lite-xl&branch=edge)

iirc alpine builds most of their packages natively on all arches (i may be wrong though)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New packages: lite-xl and reproc (dep).
  2022-05-21 12:27 [PR PATCH] New packages: lite-xl and reproc (dep) mobinmob
                   ` (4 preceding siblings ...)
  2022-05-21 15:27 ` classabbyamp
@ 2022-05-26 19:19 ` eli-schwartz
  2022-07-09 11:52 ` mobinmob
  2022-07-09 11:52 ` [PR PATCH] [Closed]: " mobinmob
  7 siblings, 0 replies; 9+ messages in thread
From: eli-schwartz @ 2022-05-26 19:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

New comment by eli-schwartz on void-packages repository

https://github.com/void-linux/void-packages/pull/37218#issuecomment-1138927130

Comment:
> Cross-compile does not work - meson cannot find sdl2.

This is an upstream lite-xl bug in the sdl2 dependency lookup -- it hardcodes using sdl2-config, which may not work.

I actually fixed this in https://github.com/lite-xl/lite-xl/pull/778 but it is not in a tagged version. The relevant diff hunk for your use case is deleting the `method: 'config-tool'` kwarg.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New packages: lite-xl and reproc (dep).
  2022-05-21 12:27 [PR PATCH] New packages: lite-xl and reproc (dep) mobinmob
                   ` (5 preceding siblings ...)
  2022-05-26 19:19 ` eli-schwartz
@ 2022-07-09 11:52 ` mobinmob
  2022-07-09 11:52 ` [PR PATCH] [Closed]: " mobinmob
  7 siblings, 0 replies; 9+ messages in thread
From: mobinmob @ 2022-07-09 11:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/37218#issuecomment-1179530489

Comment:
> > Cross-compile does not work - meson cannot find sdl2.
> 
> This is an upstream lite-xl bug in the sdl2 dependency lookup -- it hardcodes using sdl2-config, which may not work.
> 
> I actually fixed this in [lite-xl/lite-xl#778](https://github.com/lite-xl/lite-xl/pull/778) but it is not in a tagged version. The relevant diff hunk for your use case is deleting the `method: 'config-tool'` kwarg.

Thanks you :)
I will close this PR and wait for the next release, hoping that  they will drop add and reproc as @FollieHiyuki wrote...

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Closed]: New packages: lite-xl and reproc (dep).
  2022-05-21 12:27 [PR PATCH] New packages: lite-xl and reproc (dep) mobinmob
                   ` (6 preceding siblings ...)
  2022-07-09 11:52 ` mobinmob
@ 2022-07-09 11:52 ` mobinmob
  7 siblings, 0 replies; 9+ messages in thread
From: mobinmob @ 2022-07-09 11:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]

There's a closed pull request on the void-packages repository

New packages: lite-xl and reproc (dep).
https://github.com/void-linux/void-packages/pull/37218

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

Cross-compile does not work - meson cannot find sdl2.


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-07-09 11:52 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-21 12:27 [PR PATCH] New packages: lite-xl and reproc (dep) mobinmob
2022-05-21 12:36 ` mobinmob
2022-05-21 12:45 ` FollieHiyuki
2022-05-21 12:49 ` FollieHiyuki
2022-05-21 13:05 ` mobinmob
2022-05-21 15:27 ` classabbyamp
2022-05-26 19:19 ` eli-schwartz
2022-07-09 11:52 ` mobinmob
2022-07-09 11:52 ` [PR PATCH] [Closed]: " mobinmob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).