Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] xbps-src update-check: curl does not decompress responses
@ 2021-03-13  5:49 unspecd
  2021-04-27 23:48 ` ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: unspecd @ 2021-03-13  5:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]

New issue by unspecd on void-packages repository

https://github.com/void-linux/void-packages/issues/29429

Description:
### Steps to reproduce the behavior
```console
$ ./xbps-src update-check llvm11
NO VERSION found for llvm11
```
```console
$ curl https://releases.llvm.org
Warning: Binary output can mess up your terminal. Use "--output -" to tell 
Warning: curl to output it to your terminal anyway, or consider "--output 
Warning: <FILE>" to save to a file.
$ curl -sI https://releases.llvm.org | grep encoding
content-encoding: gzip
```
### Possible solution
```diff
@@ -85,7 +85,7 @@ update_check() {
                 echo "(folder) fetching $urlpfx" 1>&2
             fi
             skipdirs=
-            curl -A "xbps-src-update-check/$XBPS_SRC_VERSION" --max-time 10 -Lsk "$urlpfx" |
+            curl --compressed -A "xbps-src-update-check/$XBPS_SRC_VERSION" --max-time 10 -Lsk "$urlpfx" |
                 grep -Po -i "$rx" |
                 # sort -V places 1.1/ before 1/, but 1A/ before 1.1A/
                 sed -e 's:$:A:' -e 's:/A$:A/:' | sort -Vru | sed -e 's:A/$:/A:' -e 's:A$::' |
@@ -171,7 +171,7 @@ update_check() {
         if [ -n "$XBPS_UPDATE_CHECK_VERBOSE" ]; then
             echo "fetching $url" 1>&2
         fi
-        curl -H 'Accept: text/html,application/xhtml+xml,application/xml,text/plain,application/rss+xml' -A "xbps-src-update-check/$XBPS_SRC_VERSION" --max-time 10 -Lsk "$url" |
+        curl --compressed -H 'Accept: text/html,application/xhtml+xml,application/xml,text/plain,application/rss+xml' -A "xbps-src-update-check/$XBPS_SRC_VERSION" --max-time 10 -Lsk "$url" |
             grep -Po -i "$rx"
         fetchedurls[$url]=yes
     done |
```

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: xbps-src update-check: curl does not decompress responses
  2021-03-13  5:49 [ISSUE] xbps-src update-check: curl does not decompress responses unspecd
@ 2021-04-27 23:48 ` ericonr
  2021-04-30  9:29 ` unspecd
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-04-27 23:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/29429#issuecomment-828029887

Comment:
Could you please PR this? Makes for easier discussion.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: xbps-src update-check: curl does not decompress responses
  2021-03-13  5:49 [ISSUE] xbps-src update-check: curl does not decompress responses unspecd
  2021-04-27 23:48 ` ericonr
@ 2021-04-30  9:29 ` unspecd
  2021-05-17  8:01 ` Johnnynator
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: unspecd @ 2021-04-30  9:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by unspecd on void-packages repository

https://github.com/void-linux/void-packages/issues/29429#issuecomment-829968044

Comment:
@ericonr, the PR is here: #30590.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: xbps-src update-check: curl does not decompress responses
  2021-03-13  5:49 [ISSUE] xbps-src update-check: curl does not decompress responses unspecd
  2021-04-27 23:48 ` ericonr
  2021-04-30  9:29 ` unspecd
@ 2021-05-17  8:01 ` Johnnynator
  2022-05-08  2:12 ` github-actions
  2022-05-23  2:11 ` [ISSUE] [CLOSED] " github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: Johnnynator @ 2021-05-17  8:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/issues/29429#issuecomment-842106235

Comment:
This looks to me like the llvm webserver is misbehaving, and sending always gzip encoded responses, even if `gzip` is not even in the `Accept-encoding` header.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: xbps-src update-check: curl does not decompress responses
  2021-03-13  5:49 [ISSUE] xbps-src update-check: curl does not decompress responses unspecd
                   ` (2 preceding siblings ...)
  2021-05-17  8:01 ` Johnnynator
@ 2022-05-08  2:12 ` github-actions
  2022-05-23  2:11 ` [ISSUE] [CLOSED] " github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2022-05-08  2:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/29429#issuecomment-1120334387

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ISSUE] [CLOSED] xbps-src update-check: curl does not decompress responses
  2021-03-13  5:49 [ISSUE] xbps-src update-check: curl does not decompress responses unspecd
                   ` (3 preceding siblings ...)
  2022-05-08  2:12 ` github-actions
@ 2022-05-23  2:11 ` github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2022-05-23  2:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1782 bytes --]

Closed issue by unspecd on void-packages repository

https://github.com/void-linux/void-packages/issues/29429

Description:
### Steps to reproduce the behavior
```console
$ ./xbps-src update-check llvm11
NO VERSION found for llvm11
```
```console
$ curl https://releases.llvm.org
Warning: Binary output can mess up your terminal. Use "--output -" to tell 
Warning: curl to output it to your terminal anyway, or consider "--output 
Warning: <FILE>" to save to a file.
$ curl -sI https://releases.llvm.org | grep encoding
content-encoding: gzip
```
### Possible solution
File: common/xbps-src/shutils/update_check.sh.
```diff
@@ -85,7 +85,7 @@ update_check() {
                 echo "(folder) fetching $urlpfx" 1>&2
             fi
             skipdirs=
-            curl -A "xbps-src-update-check/$XBPS_SRC_VERSION" --max-time 10 -Lsk "$urlpfx" |
+            curl --compressed -A "xbps-src-update-check/$XBPS_SRC_VERSION" --max-time 10 -Lsk "$urlpfx" |
                 grep -Po -i "$rx" |
                 # sort -V places 1.1/ before 1/, but 1A/ before 1.1A/
                 sed -e 's:$:A:' -e 's:/A$:A/:' | sort -Vru | sed -e 's:A/$:/A:' -e 's:A$::' |
@@ -171,7 +171,7 @@ update_check() {
         if [ -n "$XBPS_UPDATE_CHECK_VERBOSE" ]; then
             echo "fetching $url" 1>&2
         fi
-        curl -H 'Accept: text/html,application/xhtml+xml,application/xml,text/plain,application/rss+xml' -A "xbps-src-update-check/$XBPS_SRC_VERSION" --max-time 10 -Lsk "$url" |
+        curl --compressed -H 'Accept: text/html,application/xhtml+xml,application/xml,text/plain,application/rss+xml' -A "xbps-src-update-check/$XBPS_SRC_VERSION" --max-time 10 -Lsk "$url" |
             grep -Po -i "$rx"
         fetchedurls[$url]=yes
     done |
```

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-05-23  2:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-13  5:49 [ISSUE] xbps-src update-check: curl does not decompress responses unspecd
2021-04-27 23:48 ` ericonr
2021-04-30  9:29 ` unspecd
2021-05-17  8:01 ` Johnnynator
2022-05-08  2:12 ` github-actions
2022-05-23  2:11 ` [ISSUE] [CLOSED] " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).