* [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
@ 2022-05-20 15:00 Barbaross93
2022-05-24 2:09 ` [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 [ci skip] abenson
` (16 more replies)
0 siblings, 17 replies; 18+ messages in thread
From: Barbaross93 @ 2022-05-20 15:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]
There is a new pull request by Barbaross93 against master on the void-packages repository
https://github.com/Barbaross93/void-packages wyrd
https://github.com/void-linux/void-packages/pull/37214
New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86-64)
See https://github.com/void-linux/void-packages/issues/35401 for my thoughts/progress packaging this. Also closes https://github.com/void-linux/void-packages/issues/35401.
As mentioned in the linked issue, the build process for the documentation required me to hit enter a few times. I'm not sure how to automate it entirely. Feedback greatly appreciated.
A patch file from https://github.com/void-linux/void-packages/pull/37214.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wyrd-37214.patch --]
[-- Type: text/x-diff, Size: 2505 bytes --]
From d864730f96dfb986e54a6008b2b38419c2c147f0 Mon Sep 17 00:00:00 2001
From: Barbaross <cullenrss@gmail.com>
Date: Fri, 20 May 2022 10:55:30 -0400
Subject: [PATCH 1/2] New package: ocaml-curses-1.0.10
---
srcpkgs/ocaml-curses/template | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 srcpkgs/ocaml-curses/template
diff --git a/srcpkgs/ocaml-curses/template b/srcpkgs/ocaml-curses/template
new file mode 100644
index 000000000000..b84891d67333
--- /dev/null
+++ b/srcpkgs/ocaml-curses/template
@@ -0,0 +1,22 @@
+# Template file for 'ocaml-curses'
+pkgname=ocaml-curses
+version=1.0.10
+revision=1
+wrksrc="curses-${version}"
+hostmakedepends="dune base-devel"
+makedepends="ncurses-devel"
+short_desc="Objective Caml libs for curses"
+maintainer="Barbaross <cullenrss@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/mbacarella/curses"
+distfiles="${homepage}/archive/refs/tags/${version}.tar.gz"
+checksum=f09c9fe714f6b0895a5d2238418188e945be928d223c2bda4e9566c32e53f848
+
+do_build() {
+ dune build --display=short
+}
+
+do_install() {
+ dune install --prefix=/usr --destdir="$DESTDIR" \
+ --libdir=/usr/lib/ocaml --docdir=/usr/share/doc
+}
From ca92f844825f41eebd5c72ad9e72fc7efd77cfd4 Mon Sep 17 00:00:00 2001
From: Barbaross <cullenrss@gmail.com>
Date: Fri, 20 May 2022 10:56:19 -0400
Subject: [PATCH 2/2] New package: wyrd-1.5.3
---
srcpkgs/wyrd/template | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
create mode 100644 srcpkgs/wyrd/template
diff --git a/srcpkgs/wyrd/template b/srcpkgs/wyrd/template
new file mode 100644
index 000000000000..8faaf1f30ad2
--- /dev/null
+++ b/srcpkgs/wyrd/template
@@ -0,0 +1,28 @@
+# Template file for 'wyrd'
+pkgname=wyrd
+version=1.5.3
+revision=1
+build_style=gnu-configure
+#configure_args=""
+#make_build_args=""
+#make_install_args=""
+hostmakedepends="ocaml camlp5 ocaml-curses texlive texlive-LuaTeX python opam base-devel"
+makedepends="ncurses-devel"
+depends="remind"
+conf_files="/etc/wyrdrc"
+short_desc="Ncurses front-end to Remind"
+maintainer="Barbaross <cullenrss@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://gitlab.com/wyrd-calendar/wyrd"
+distfiles="${homepage}/-/archive/${version}/wyrd-${version}.tar.gz"
+checksum=1d7936dd10b795a17bbce06ae14079eb36120f26fd7bd27b522f8df5196790e7
+
+pre_configure() {
+ ./prep-devtree.sh
+}
+
+pre_build() {
+ opam init -y --compiler=ocaml-system --disable-sandboxing
+ eval $(opam env)
+ opam install -y hevea
+}
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 [ci skip]
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
@ 2022-05-24 2:09 ` abenson
2022-05-24 2:10 ` abenson
` (15 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: abenson @ 2022-05-24 2:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 165 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r879995657
Comment:
Remove these lines
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 [ci skip]
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
2022-05-24 2:09 ` [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 [ci skip] abenson
@ 2022-05-24 2:10 ` abenson
2022-05-24 2:21 ` Barbaross93
` (14 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: abenson @ 2022-05-24 2:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r879995998
Comment:
Can this be built with python3? We're trying to avoid python2.x going forward.
Also, I believe `base-devel` isn't needed here.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 [ci skip]
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
2022-05-24 2:09 ` [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 [ci skip] abenson
2022-05-24 2:10 ` abenson
@ 2022-05-24 2:21 ` Barbaross93
2022-05-24 2:27 ` Barbaross93
` (13 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Barbaross93 @ 2022-05-24 2:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 218 bytes --]
New review comment by Barbaross93 on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r880000210
Comment:
I'm confused, aren't those lines necessary? Did you mean lines 6-8?
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 [ci skip]
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (2 preceding siblings ...)
2022-05-24 2:21 ` Barbaross93
@ 2022-05-24 2:27 ` Barbaross93
2022-05-24 12:10 ` [PR PATCH] [Updated] " Barbaross93
` (12 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Barbaross93 @ 2022-05-24 2:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
New review comment by Barbaross93 on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r880002793
Comment:
Good catch, I'll try right switching it to python3 now. I think some of the development tools starting popping up one after another and so I just used `base-devel` as a catchall. I'll be more explicit instead.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR PATCH] [Updated] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 [ci skip]
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (3 preceding siblings ...)
2022-05-24 2:27 ` Barbaross93
@ 2022-05-24 12:10 ` Barbaross93
2022-05-24 12:10 ` Barbaross93
` (11 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Barbaross93 @ 2022-05-24 12:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1476 bytes --]
There is an updated pull request by Barbaross93 against master on the void-packages repository
https://github.com/Barbaross93/void-packages wyrd
https://github.com/void-linux/void-packages/pull/37214
New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 [ci skip]
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86-64)
See https://github.com/void-linux/void-packages/issues/35401 for my thoughts/progress packaging this. Also closes https://github.com/void-linux/void-packages/issues/35401.
As mentioned in the linked issue, the build process for the documentation required me to hit enter a few times. I'm not sure how to automate it entirely. Feedback greatly appreciated.
A patch file from https://github.com/void-linux/void-packages/pull/37214.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wyrd-37214.patch --]
[-- Type: text/x-diff, Size: 3333 bytes --]
From d864730f96dfb986e54a6008b2b38419c2c147f0 Mon Sep 17 00:00:00 2001
From: Barbaross <cullenrss@gmail.com>
Date: Fri, 20 May 2022 10:55:30 -0400
Subject: [PATCH 1/3] New package: ocaml-curses-1.0.10
---
srcpkgs/ocaml-curses/template | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 srcpkgs/ocaml-curses/template
diff --git a/srcpkgs/ocaml-curses/template b/srcpkgs/ocaml-curses/template
new file mode 100644
index 000000000000..b84891d67333
--- /dev/null
+++ b/srcpkgs/ocaml-curses/template
@@ -0,0 +1,22 @@
+# Template file for 'ocaml-curses'
+pkgname=ocaml-curses
+version=1.0.10
+revision=1
+wrksrc="curses-${version}"
+hostmakedepends="dune base-devel"
+makedepends="ncurses-devel"
+short_desc="Objective Caml libs for curses"
+maintainer="Barbaross <cullenrss@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/mbacarella/curses"
+distfiles="${homepage}/archive/refs/tags/${version}.tar.gz"
+checksum=f09c9fe714f6b0895a5d2238418188e945be928d223c2bda4e9566c32e53f848
+
+do_build() {
+ dune build --display=short
+}
+
+do_install() {
+ dune install --prefix=/usr --destdir="$DESTDIR" \
+ --libdir=/usr/lib/ocaml --docdir=/usr/share/doc
+}
From ca92f844825f41eebd5c72ad9e72fc7efd77cfd4 Mon Sep 17 00:00:00 2001
From: Barbaross <cullenrss@gmail.com>
Date: Fri, 20 May 2022 10:56:19 -0400
Subject: [PATCH 2/3] New package: wyrd-1.5.3
---
srcpkgs/wyrd/template | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
create mode 100644 srcpkgs/wyrd/template
diff --git a/srcpkgs/wyrd/template b/srcpkgs/wyrd/template
new file mode 100644
index 000000000000..8faaf1f30ad2
--- /dev/null
+++ b/srcpkgs/wyrd/template
@@ -0,0 +1,28 @@
+# Template file for 'wyrd'
+pkgname=wyrd
+version=1.5.3
+revision=1
+build_style=gnu-configure
+#configure_args=""
+#make_build_args=""
+#make_install_args=""
+hostmakedepends="ocaml camlp5 ocaml-curses texlive texlive-LuaTeX python opam base-devel"
+makedepends="ncurses-devel"
+depends="remind"
+conf_files="/etc/wyrdrc"
+short_desc="Ncurses front-end to Remind"
+maintainer="Barbaross <cullenrss@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://gitlab.com/wyrd-calendar/wyrd"
+distfiles="${homepage}/-/archive/${version}/wyrd-${version}.tar.gz"
+checksum=1d7936dd10b795a17bbce06ae14079eb36120f26fd7bd27b522f8df5196790e7
+
+pre_configure() {
+ ./prep-devtree.sh
+}
+
+pre_build() {
+ opam init -y --compiler=ocaml-system --disable-sandboxing
+ eval $(opam env)
+ opam install -y hevea
+}
From bdc1e97bfe120ba614fc1dd0c6cc5e7349838396 Mon Sep 17 00:00:00 2001
From: Barbaross <cullenrss@gmail.com>
Date: Tue, 24 May 2022 08:09:48 -0400
Subject: [PATCH 3/3] New package: wyrd-1.5.3
---
srcpkgs/wyrd/template | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/srcpkgs/wyrd/template b/srcpkgs/wyrd/template
index 8faaf1f30ad2..fb99a148d3e0 100644
--- a/srcpkgs/wyrd/template
+++ b/srcpkgs/wyrd/template
@@ -3,10 +3,7 @@ pkgname=wyrd
version=1.5.3
revision=1
build_style=gnu-configure
-#configure_args=""
-#make_build_args=""
-#make_install_args=""
-hostmakedepends="ocaml camlp5 ocaml-curses texlive texlive-LuaTeX python opam base-devel"
+hostmakedepends="ocaml camlp5 ocaml-curses texlive texlive-LuaTeX python3 opam"
makedepends="ncurses-devel"
depends="remind"
conf_files="/etc/wyrdrc"
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR PATCH] [Updated] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 [ci skip]
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (4 preceding siblings ...)
2022-05-24 12:10 ` [PR PATCH] [Updated] " Barbaross93
@ 2022-05-24 12:10 ` Barbaross93
2022-06-26 13:06 ` [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 rrbq
` (10 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Barbaross93 @ 2022-05-24 12:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1476 bytes --]
There is an updated pull request by Barbaross93 against master on the void-packages repository
https://github.com/Barbaross93/void-packages wyrd
https://github.com/void-linux/void-packages/pull/37214
New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 [ci skip]
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86-64)
See https://github.com/void-linux/void-packages/issues/35401 for my thoughts/progress packaging this. Also closes https://github.com/void-linux/void-packages/issues/35401.
As mentioned in the linked issue, the build process for the documentation required me to hit enter a few times. I'm not sure how to automate it entirely. Feedback greatly appreciated.
A patch file from https://github.com/void-linux/void-packages/pull/37214.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wyrd-37214.patch --]
[-- Type: text/x-diff, Size: 2428 bytes --]
From d864730f96dfb986e54a6008b2b38419c2c147f0 Mon Sep 17 00:00:00 2001
From: Barbaross <cullenrss@gmail.com>
Date: Fri, 20 May 2022 10:55:30 -0400
Subject: [PATCH 1/2] New package: ocaml-curses-1.0.10
---
srcpkgs/ocaml-curses/template | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 srcpkgs/ocaml-curses/template
diff --git a/srcpkgs/ocaml-curses/template b/srcpkgs/ocaml-curses/template
new file mode 100644
index 000000000000..b84891d67333
--- /dev/null
+++ b/srcpkgs/ocaml-curses/template
@@ -0,0 +1,22 @@
+# Template file for 'ocaml-curses'
+pkgname=ocaml-curses
+version=1.0.10
+revision=1
+wrksrc="curses-${version}"
+hostmakedepends="dune base-devel"
+makedepends="ncurses-devel"
+short_desc="Objective Caml libs for curses"
+maintainer="Barbaross <cullenrss@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/mbacarella/curses"
+distfiles="${homepage}/archive/refs/tags/${version}.tar.gz"
+checksum=f09c9fe714f6b0895a5d2238418188e945be928d223c2bda4e9566c32e53f848
+
+do_build() {
+ dune build --display=short
+}
+
+do_install() {
+ dune install --prefix=/usr --destdir="$DESTDIR" \
+ --libdir=/usr/lib/ocaml --docdir=/usr/share/doc
+}
From bb723e80180dd04b0e53fc5ce399f3b6fe8a8c45 Mon Sep 17 00:00:00 2001
From: Barbaross <cullenrss@gmail.com>
Date: Fri, 20 May 2022 10:56:19 -0400
Subject: [PATCH 2/2] New package: wyrd-1.5.3
---
srcpkgs/wyrd/template | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 srcpkgs/wyrd/template
diff --git a/srcpkgs/wyrd/template b/srcpkgs/wyrd/template
new file mode 100644
index 000000000000..fb99a148d3e0
--- /dev/null
+++ b/srcpkgs/wyrd/template
@@ -0,0 +1,25 @@
+# Template file for 'wyrd'
+pkgname=wyrd
+version=1.5.3
+revision=1
+build_style=gnu-configure
+hostmakedepends="ocaml camlp5 ocaml-curses texlive texlive-LuaTeX python3 opam"
+makedepends="ncurses-devel"
+depends="remind"
+conf_files="/etc/wyrdrc"
+short_desc="Ncurses front-end to Remind"
+maintainer="Barbaross <cullenrss@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://gitlab.com/wyrd-calendar/wyrd"
+distfiles="${homepage}/-/archive/${version}/wyrd-${version}.tar.gz"
+checksum=1d7936dd10b795a17bbce06ae14079eb36120f26fd7bd27b522f8df5196790e7
+
+pre_configure() {
+ ./prep-devtree.sh
+}
+
+pre_build() {
+ opam init -y --compiler=ocaml-system --disable-sandboxing
+ eval $(opam env)
+ opam install -y hevea
+}
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (5 preceding siblings ...)
2022-05-24 12:10 ` Barbaross93
@ 2022-06-26 13:06 ` rrbq
2022-06-26 13:07 ` rrbq
` (9 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: rrbq @ 2022-06-26 13:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
New review comment by rrbq on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r906812616
Comment:
Try the tarball at "${homepage}/-/jobs/artifacts/${version}/raw/wyrd-${version}.tar.xz?job=release" .
It contains a pre-built copy of the manual, so you can skip building it yourself and only build the `wyrd` executable with `make wyrd`, no need to run `prep-devtree.sh` as well.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (6 preceding siblings ...)
2022-06-26 13:06 ` [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 rrbq
@ 2022-06-26 13:07 ` rrbq
2022-06-26 13:13 ` jspricke
` (8 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: rrbq @ 2022-06-26 13:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 428 bytes --]
New review comment by rrbq on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r906812616
Comment:
Try the tarball at `"${homepage}/-/jobs/artifacts/${version}/raw/wyrd-${version}.tar.xz?job=release"` .
It contains a pre-built copy of the manual, so you can skip building it yourself and only build the `wyrd` executable with `make wyrd`, no need to run `prep-devtree.sh` as well.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (7 preceding siblings ...)
2022-06-26 13:07 ` rrbq
@ 2022-06-26 13:13 ` jspricke
2022-06-26 13:16 ` jspricke
` (7 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: jspricke @ 2022-06-26 13:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New review comment by jspricke on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r906813585
Comment:
this is only needed with autoconf, not with dune (or the release tarball).
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (8 preceding siblings ...)
2022-06-26 13:13 ` jspricke
@ 2022-06-26 13:16 ` jspricke
2022-06-26 13:16 ` jspricke
` (6 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: jspricke @ 2022-06-26 13:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
New review comment by jspricke on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r906813914
Comment:
GPL-2.0-only
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (9 preceding siblings ...)
2022-06-26 13:16 ` jspricke
@ 2022-06-26 13:16 ` jspricke
2022-06-26 13:16 ` jspricke
` (5 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: jspricke @ 2022-06-26 13:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
New review comment by jspricke on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r906813914
Comment:
GPL-2.0-only
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (10 preceding siblings ...)
2022-06-26 13:16 ` jspricke
@ 2022-06-26 13:16 ` jspricke
2022-06-26 13:18 ` jspricke
` (4 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: jspricke @ 2022-06-26 13:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
New review comment by jspricke on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r906814032
Comment:
GPL-2.0-only
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (11 preceding siblings ...)
2022-06-26 13:16 ` jspricke
@ 2022-06-26 13:18 ` jspricke
2022-06-26 13:18 ` rrbq
` (3 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: jspricke @ 2022-06-26 13:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
New review comment by jspricke on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r906814245
Comment:
LGPL-2.1
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (12 preceding siblings ...)
2022-06-26 13:18 ` jspricke
@ 2022-06-26 13:18 ` rrbq
2022-06-26 13:38 ` jspricke
` (2 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: rrbq @ 2022-06-26 13:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
New review comment by rrbq on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r906814269
Comment:
Should be `"LGPL-2.1-or-later"`, according to https://github.com/mbacarella/curses/blob/main/curses.opam#L7
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (13 preceding siblings ...)
2022-06-26 13:18 ` rrbq
@ 2022-06-26 13:38 ` jspricke
2022-09-25 2:14 ` github-actions
2022-10-10 2:14 ` [PR PATCH] [Closed]: " github-actions
16 siblings, 0 replies; 18+ messages in thread
From: jspricke @ 2022-06-26 13:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
New review comment by jspricke on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#discussion_r906816903
Comment:
there should be no need for python3
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (14 preceding siblings ...)
2022-06-26 13:38 ` jspricke
@ 2022-09-25 2:14 ` github-actions
2022-10-10 2:14 ` [PR PATCH] [Closed]: " github-actions
16 siblings, 0 replies; 18+ messages in thread
From: github-actions @ 2022-09-25 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/37214#issuecomment-1257101501
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR PATCH] [Closed]: New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
` (15 preceding siblings ...)
2022-09-25 2:14 ` github-actions
@ 2022-10-10 2:14 ` github-actions
16 siblings, 0 replies; 18+ messages in thread
From: github-actions @ 2022-10-10 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]
There's a closed pull request on the void-packages repository
New packages: wyrd-1.5.3 and ocaml-curses-1.0.10
https://github.com/void-linux/void-packages/pull/37214
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86-64)
See https://github.com/void-linux/void-packages/issues/35401 for my thoughts/progress packaging this. Also closes https://github.com/void-linux/void-packages/issues/35401.
As mentioned in the linked issue, the build process for the documentation required me to hit enter a few times. I'm not sure how to automate it entirely. Feedback greatly appreciated.
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2022-10-10 2:14 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-20 15:00 [PR PATCH] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 Barbaross93
2022-05-24 2:09 ` [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 [ci skip] abenson
2022-05-24 2:10 ` abenson
2022-05-24 2:21 ` Barbaross93
2022-05-24 2:27 ` Barbaross93
2022-05-24 12:10 ` [PR PATCH] [Updated] " Barbaross93
2022-05-24 12:10 ` Barbaross93
2022-06-26 13:06 ` [PR REVIEW] New packages: wyrd-1.5.3 and ocaml-curses-1.0.10 rrbq
2022-06-26 13:07 ` rrbq
2022-06-26 13:13 ` jspricke
2022-06-26 13:16 ` jspricke
2022-06-26 13:16 ` jspricke
2022-06-26 13:16 ` jspricke
2022-06-26 13:18 ` jspricke
2022-06-26 13:18 ` rrbq
2022-06-26 13:38 ` jspricke
2022-09-25 2:14 ` github-actions
2022-10-10 2:14 ` [PR PATCH] [Closed]: " github-actions
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).