Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] zita-convolver-devel: add fftw-devel dependency
@ 2021-06-26 16:03 Logarithmus
  2021-06-26 19:34 ` [PR REVIEW] " ericonr
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: Logarithmus @ 2021-06-26 16:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

There is a new pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages fix-zita-convolver-devel
https://github.com/void-linux/void-packages/pull/31666

zita-convolver-devel: add fftw-devel dependency
<!-- Mark items with [x] where applicable -->

Without this change the packages which depend on `zita-convolver-devel` doesn't compile due to missing `ftw3.h` header.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31666.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-zita-convolver-devel-31666.patch --]
[-- Type: text/x-diff, Size: 1562 bytes --]

From eae9d87865689fe3650a4b12ba0a4d42fa7df78a Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Fri, 25 Jun 2021 22:07:03 +0300
Subject: [PATCH] zita-convolver-devel: add fftw-devel dependency

---
 srcpkgs/zita-convolver/template | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/zita-convolver/template b/srcpkgs/zita-convolver/template
index fb0371162b03..603fbd5099c1 100644
--- a/srcpkgs/zita-convolver/template
+++ b/srcpkgs/zita-convolver/template
@@ -1,11 +1,11 @@
 # Template file for 'zita-convolver'
 pkgname=zita-convolver
 version=4.0.3
-revision=2
+revision=3
 build_wrksrc="source"
 build_style=gnu-makefile
 make_install_args="LIBDIR=/usr/lib"
-hostmakedepends="pkg-config"
+hostmakedepends="pkgconf"
 makedepends="fftw-devel"
 short_desc="Fast partitioned convolution engine library"
 maintainer="silvernode <mollusk@homebutter.com>"
@@ -14,7 +14,9 @@ homepage="http://kokkinizita.linuxaudio.org/linuxaudio/"
 distfiles="http://kokkinizita.linuxaudio.org/linuxaudio/downloads/${pkgname}-${version}.tar.bz2"
 checksum=9aa11484fb30b4e6ef00c8a3281eebcfad9221e3937b1beb5fe21b748d89325f
 
-CXXFLAGS="-fPIC -ffast-math -funroll-loops"
+pre_build() {
+	CXXFLAGS="$CXXFLAGS -fPIC"
+}
 
 post_install() {
 	# add missing symlink
@@ -22,7 +24,7 @@ post_install() {
 }
 
 zita-convolver-devel_package() {
-	depends="${sourcepkg}-${version}_${revision}"
+	depends="${sourcepkg}-${version}_${revision} fftw-devel"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] zita-convolver-devel: add fftw-devel dependency
  2021-06-26 16:03 [PR PATCH] zita-convolver-devel: add fftw-devel dependency Logarithmus
  2021-06-26 19:34 ` [PR REVIEW] " ericonr
@ 2021-06-26 19:34 ` ericonr
  2021-06-26 19:34 ` ericonr
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-06-26 19:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31666#discussion_r659215323

Comment:
```suggestion
	depends="${sourcepkg}>=${version}_${revision} fftw-devel"
```

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] zita-convolver-devel: add fftw-devel dependency
  2021-06-26 16:03 [PR PATCH] zita-convolver-devel: add fftw-devel dependency Logarithmus
@ 2021-06-26 19:34 ` ericonr
  2021-06-26 19:34 ` ericonr
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-06-26 19:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31666#discussion_r659215305

Comment:
Why change this? Removing `-ffast-math` is fine tho.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] zita-convolver-devel: add fftw-devel dependency
  2021-06-26 16:03 [PR PATCH] zita-convolver-devel: add fftw-devel dependency Logarithmus
  2021-06-26 19:34 ` [PR REVIEW] " ericonr
  2021-06-26 19:34 ` ericonr
@ 2021-06-26 19:34 ` ericonr
  2021-06-27 15:49 ` [PR PATCH] [Updated] " Logarithmus
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-06-26 19:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31666#discussion_r659215246

Comment:
There is a certain thing called distro policy, please respect it.

#3391

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] zita-convolver-devel: add fftw-devel dependency
  2021-06-26 16:03 [PR PATCH] zita-convolver-devel: add fftw-devel dependency Logarithmus
                   ` (2 preceding siblings ...)
  2021-06-26 19:34 ` ericonr
@ 2021-06-27 15:49 ` Logarithmus
  2021-06-27 15:53 ` [PR REVIEW] zita-convolver: add fftw-devel dependency to zita-convolver-devel Logarithmus
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Logarithmus @ 2021-06-27 15:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

There is an updated pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages fix-zita-convolver-devel
https://github.com/void-linux/void-packages/pull/31666

zita-convolver-devel: add fftw-devel dependency
<!-- Mark items with [x] where applicable -->

Without this change the packages which depend on `zita-convolver-devel` fail to compile due to missing `ftw3.h` header.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31666.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-zita-convolver-devel-31666.patch --]
[-- Type: text/x-diff, Size: 1402 bytes --]

From f7bb6ef9387ccd515561923cfe614a9acd12adc7 Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Fri, 25 Jun 2021 22:07:03 +0300
Subject: [PATCH] zita-convolver: add fftw-devel dependency to
 zita-convolver-devel

---
 srcpkgs/zita-convolver/template | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/zita-convolver/template b/srcpkgs/zita-convolver/template
index fb0371162b03..fa0cf5918293 100644
--- a/srcpkgs/zita-convolver/template
+++ b/srcpkgs/zita-convolver/template
@@ -1,7 +1,7 @@
 # Template file for 'zita-convolver'
 pkgname=zita-convolver
 version=4.0.3
-revision=2
+revision=3
 build_wrksrc="source"
 build_style=gnu-makefile
 make_install_args="LIBDIR=/usr/lib"
@@ -14,15 +14,13 @@ homepage="http://kokkinizita.linuxaudio.org/linuxaudio/"
 distfiles="http://kokkinizita.linuxaudio.org/linuxaudio/downloads/${pkgname}-${version}.tar.bz2"
 checksum=9aa11484fb30b4e6ef00c8a3281eebcfad9221e3937b1beb5fe21b748d89325f
 
-CXXFLAGS="-fPIC -ffast-math -funroll-loops"
-
 post_install() {
 	# add missing symlink
 	ln -s libzita-convolver.so.${version} ${PKGDESTDIR}/usr/lib/libzita-convolver.so.${version%%.*}
 }
 
 zita-convolver-devel_package() {
-	depends="${sourcepkg}-${version}_${revision}"
+	depends="${sourcepkg}>=${version}_${revision} fftw-devel"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] zita-convolver: add fftw-devel dependency to zita-convolver-devel
  2021-06-26 16:03 [PR PATCH] zita-convolver-devel: add fftw-devel dependency Logarithmus
                   ` (3 preceding siblings ...)
  2021-06-27 15:49 ` [PR PATCH] [Updated] " Logarithmus
@ 2021-06-27 15:53 ` Logarithmus
  2021-06-27 15:55 ` [PR PATCH] [Updated] " Logarithmus
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Logarithmus @ 2021-06-27 15:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31666#discussion_r659341382

Comment:
```
/usr/bin/ld: zita-convolver.o: relocation R_X86_64_PC32 against symbol `_ZN9Convlevel11static_mainEPv' can not be used when making a shared object; recompile with -fPIC
```

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] zita-convolver: add fftw-devel dependency to zita-convolver-devel
  2021-06-26 16:03 [PR PATCH] zita-convolver-devel: add fftw-devel dependency Logarithmus
                   ` (4 preceding siblings ...)
  2021-06-27 15:53 ` [PR REVIEW] zita-convolver: add fftw-devel dependency to zita-convolver-devel Logarithmus
@ 2021-06-27 15:55 ` Logarithmus
  2021-06-27 15:58 ` [PR REVIEW] " Logarithmus
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Logarithmus @ 2021-06-27 15:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

There is an updated pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages fix-zita-convolver-devel
https://github.com/void-linux/void-packages/pull/31666

zita-convolver: add fftw-devel dependency to zita-convolver-devel
<!-- Mark items with [x] where applicable -->

Without this change the packages which depend on `zita-convolver-devel` fail to compile due to missing `ftw3.h` header.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31666.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-zita-convolver-devel-31666.patch --]
[-- Type: text/x-diff, Size: 1365 bytes --]

From 2d3eff3d4bea2e0f688e9d79dbcff464142d28b0 Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Fri, 25 Jun 2021 22:07:03 +0300
Subject: [PATCH] zita-convolver: add fftw-devel dependency to
 zita-convolver-devel

---
 srcpkgs/zita-convolver/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/zita-convolver/template b/srcpkgs/zita-convolver/template
index fb0371162b03..39bc33d20a09 100644
--- a/srcpkgs/zita-convolver/template
+++ b/srcpkgs/zita-convolver/template
@@ -1,7 +1,7 @@
 # Template file for 'zita-convolver'
 pkgname=zita-convolver
 version=4.0.3
-revision=2
+revision=3
 build_wrksrc="source"
 build_style=gnu-makefile
 make_install_args="LIBDIR=/usr/lib"
@@ -14,7 +14,7 @@ homepage="http://kokkinizita.linuxaudio.org/linuxaudio/"
 distfiles="http://kokkinizita.linuxaudio.org/linuxaudio/downloads/${pkgname}-${version}.tar.bz2"
 checksum=9aa11484fb30b4e6ef00c8a3281eebcfad9221e3937b1beb5fe21b748d89325f
 
-CXXFLAGS="-fPIC -ffast-math -funroll-loops"
+CXXFLAGS="$CXXFLAGS -fPIC"
 
 post_install() {
 	# add missing symlink
@@ -22,7 +22,7 @@ post_install() {
 }
 
 zita-convolver-devel_package() {
-	depends="${sourcepkg}-${version}_${revision}"
+	depends="${sourcepkg}>=${version}_${revision} fftw-devel"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] zita-convolver: add fftw-devel dependency to zita-convolver-devel
  2021-06-26 16:03 [PR PATCH] zita-convolver-devel: add fftw-devel dependency Logarithmus
                   ` (5 preceding siblings ...)
  2021-06-27 15:55 ` [PR PATCH] [Updated] " Logarithmus
@ 2021-06-27 15:58 ` Logarithmus
  2022-05-24  2:13 ` github-actions
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Logarithmus @ 2021-06-27 15:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31666#discussion_r659341947

Comment:
https://github.com/void-linux/void-packages/pull/31666/checks?check_run_id=2925832556#step:8:60

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: zita-convolver: add fftw-devel dependency to zita-convolver-devel
  2021-06-26 16:03 [PR PATCH] zita-convolver-devel: add fftw-devel dependency Logarithmus
                   ` (6 preceding siblings ...)
  2021-06-27 15:58 ` [PR REVIEW] " Logarithmus
@ 2022-05-24  2:13 ` github-actions
  2022-05-24 12:06 ` paper42
  2022-05-24 12:06 ` [PR PATCH] [Closed]: " paper42
  9 siblings, 0 replies; 11+ messages in thread
From: github-actions @ 2022-05-24  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/31666#issuecomment-1135323104

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: zita-convolver: add fftw-devel dependency to zita-convolver-devel
  2021-06-26 16:03 [PR PATCH] zita-convolver-devel: add fftw-devel dependency Logarithmus
                   ` (7 preceding siblings ...)
  2022-05-24  2:13 ` github-actions
@ 2022-05-24 12:06 ` paper42
  2022-05-24 12:06 ` [PR PATCH] [Closed]: " paper42
  9 siblings, 0 replies; 11+ messages in thread
From: paper42 @ 2022-05-24 12:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31666#issuecomment-1135831944

Comment:
done in 1abee3c5b77b4795543852417f55f99932d43b0a

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Closed]: zita-convolver: add fftw-devel dependency to zita-convolver-devel
  2021-06-26 16:03 [PR PATCH] zita-convolver-devel: add fftw-devel dependency Logarithmus
                   ` (8 preceding siblings ...)
  2022-05-24 12:06 ` paper42
@ 2022-05-24 12:06 ` paper42
  9 siblings, 0 replies; 11+ messages in thread
From: paper42 @ 2022-05-24 12:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]

There's a closed pull request on the void-packages repository

zita-convolver: add fftw-devel dependency to zita-convolver-devel
https://github.com/void-linux/void-packages/pull/31666

Description:
<!-- Mark items with [x] where applicable -->

Without this change the packages which depend on `zita-convolver-devel` fail to compile due to missing `ftw3.h` header.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-05-24 12:06 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-26 16:03 [PR PATCH] zita-convolver-devel: add fftw-devel dependency Logarithmus
2021-06-26 19:34 ` [PR REVIEW] " ericonr
2021-06-26 19:34 ` ericonr
2021-06-26 19:34 ` ericonr
2021-06-27 15:49 ` [PR PATCH] [Updated] " Logarithmus
2021-06-27 15:53 ` [PR REVIEW] zita-convolver: add fftw-devel dependency to zita-convolver-devel Logarithmus
2021-06-27 15:55 ` [PR PATCH] [Updated] " Logarithmus
2021-06-27 15:58 ` [PR REVIEW] " Logarithmus
2022-05-24  2:13 ` github-actions
2022-05-24 12:06 ` paper42
2022-05-24 12:06 ` [PR PATCH] [Closed]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).