[PR PATCH] New package : kdenetwork-filesharing

[PR PATCH] New package : kdenetwork-filesharing

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]

There is a new pull request by pandom79 against master on the void-packages repository

https://github.com/pandom79/void-packages kdenetwork-filesharing
https://github.com/void-linux/void-packages/pull/31956

New package : kdenetwork-filesharing
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31956.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kdenetwork-filesharing-31956.patch --]
[-- Type: text/x-diff, Size: 1870 bytes --]

From c80602214451586dab65e1f3b76f23d43ac113bc Mon Sep 17 00:00:00 2001
From: Domenico Panella <pandom79@gmail.com>
Date: Tue, 13 Jul 2021 19:08:52 +0200
Subject: [PATCH] New package : kdenetwork-filesharing

---
 common/shlibs                           |  1 +
 srcpkgs/kdenetwork-filesharing/template | 20 ++++++++++++++++++++
 2 files changed, 21 insertions(+)
 create mode 100644 srcpkgs/kdenetwork-filesharing/template

diff --git a/common/shlibs b/common/shlibs
index 9df122c0edfe..d3b07bec622e 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4018,3 +4018,4 @@ libXcompshad.so.3 nx-libs-3.5.99.24_1
 libNX_X11.so.6 nx-libs-3.5.99.24_1
 librnnoise.so.0 rnnoise-0.4.1_1
 liblhasa.so.0 lhasa-0.3.1_2
+sambausershareplugin.so kdenetwork-filesharing-21.04.3_1
diff --git a/srcpkgs/kdenetwork-filesharing/template b/srcpkgs/kdenetwork-filesharing/template
new file mode 100644
index 000000000000..c6f6b4b07d52
--- /dev/null
+++ b/srcpkgs/kdenetwork-filesharing/template
@@ -0,0 +1,20 @@
+# Template file for 'kdenetwork-filesharing'
+pkgname=kdenetwork-filesharing
+version=21.04.3
+revision=1
+build_style=cmake
+hostmakedepends="extra-cmake-modules qt5-qmake qt5-host-tools kcoreaddons
+ $(vopt_if samba 'samba') gettext ki18n kauth"
+makedepends="kconfig-devel kio-devel kdeclarative-devel
+ $(vopt_if samba 'samba-devel')"
+depends="dolphin $(vopt_if samba 'samba')"
+short_desc="Samba file sharing plugin for file properties"
+maintainer="Domenico Panella <pandom79@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://apps.kde.org/kdenetwork_filesharing"
+distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
+checksum=51bea2651b9d59ab254d3fb0e031c31ccb77143bb9f5e97e8e8df6d120c3814f
+shlib_provides="sambausershareplugin.so"
+build_options="samba"
+build_options_default="samba"
+desc_option_samba="Enable support for samba"

Re: [PR REVIEW] New package : kdenetwork-filesharing

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31956#discussion_r669607115

Comment:
same for this.

Re: [PR REVIEW] New package : kdenetwork-filesharing

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31956#discussion_r669605697

Comment:
Shouldn't samba be detected automatically here?

Re: [PR REVIEW] New package : kdenetwork-filesharing

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31956#discussion_r669606476

Comment:
Please put a new line here.

Re: [PR REVIEW] New package : kdenetwork-filesharing

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31956#discussion_r669607038

Comment:
Is this actually necessary? If it's just to silence a warning, please don't add it.

Re: [PR REVIEW] New package : kdenetwork-filesharing

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31956#discussion_r669606110

Comment:
No need to quote the packages inside the `vopt_if` blocks.

Re: [PR PATCH] [Updated] New package : kdenetwork-filesharing

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

There is an updated pull request by pandom79 against master on the void-packages repository

https://github.com/pandom79/void-packages kdenetwork-filesharing
https://github.com/void-linux/void-packages/pull/31956

New package : kdenetwork-filesharing
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31956.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kdenetwork-filesharing-31956.patch --]
[-- Type: text/x-diff, Size: 1408 bytes --]

From f2079f7f3cca3d20238bb9c95fffccbb28eb9ed3 Mon Sep 17 00:00:00 2001
From: Domenico Panella <pandom79@gmail.com>
Date: Tue, 13 Jul 2021 19:08:52 +0200
Subject: [PATCH] New package : kdenetwork-filesharing

---
 srcpkgs/kdenetwork-filesharing/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/kdenetwork-filesharing/template

diff --git a/srcpkgs/kdenetwork-filesharing/template b/srcpkgs/kdenetwork-filesharing/template
new file mode 100644
index 000000000000..0016113f2d5d
--- /dev/null
+++ b/srcpkgs/kdenetwork-filesharing/template
@@ -0,0 +1,19 @@
+# Template file for 'kdenetwork-filesharing'
+pkgname=kdenetwork-filesharing
+version=21.04.3
+revision=1
+build_style=cmake
+hostmakedepends="extra-cmake-modules qt5-qmake qt5-host-tools kcoreaddons
+ $(vopt_if samba 'samba') gettext ki18n kauth"
+makedepends="kconfig-devel kio-devel kdeclarative-devel"
+depends="dolphin $(vopt_if samba 'samba')"
+short_desc="Samba file sharing plugin for file properties"
+maintainer="Domenico Panella <pandom79@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://apps.kde.org/kdenetwork_filesharing"
+distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
+checksum=51bea2651b9d59ab254d3fb0e031c31ccb77143bb9f5e97e8e8df6d120c3814f
+
+build_options="samba"
+build_options_default="samba"
+desc_option_samba="Enable support for samba"

Re: [PR REVIEW] New package : kdenetwork-filesharing

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New review comment by pandom79 on void-packages repository

https://github.com/void-linux/void-packages/pull/31956#discussion_r669649412

Comment:
No. It is not added automatically to the "run" depends. 

Re: [PR REVIEW] New package : kdenetwork-filesharing

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New review comment by pandom79 on void-packages repository

https://github.com/void-linux/void-packages/pull/31956#discussion_r669657402

Comment:
Sorry but I'd prefer leave it there because improves the readability distinguishing well the build condition from the package/s which will be installed mostly when the build condition and package name are equal. 

Re: [PR PATCH] [Updated] New package : kdenetwork-filesharing

[pandom79]

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

There is an updated pull request by pandom79 against master on the void-packages repository

https://github.com/pandom79/void-packages kdenetwork-filesharing
https://github.com/void-linux/void-packages/pull/31956

New package : kdenetwork-filesharing
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31956.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kdenetwork-filesharing-31956.patch --]
[-- Type: text/x-diff, Size: 1416 bytes --]

From 7c1e2b268e5ce5159ca6d67bc6ebcbdde7b99c7d Mon Sep 17 00:00:00 2001
From: Domenico Panella <pandom79@gmail.com>
Date: Tue, 13 Jul 2021 19:08:52 +0200
Subject: [PATCH] New package : kdenetwork-filesharing-21.04.3

---
 srcpkgs/kdenetwork-filesharing/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/kdenetwork-filesharing/template

diff --git a/srcpkgs/kdenetwork-filesharing/template b/srcpkgs/kdenetwork-filesharing/template
new file mode 100644
index 000000000000..0016113f2d5d
--- /dev/null
+++ b/srcpkgs/kdenetwork-filesharing/template
@@ -0,0 +1,19 @@
+# Template file for 'kdenetwork-filesharing'
+pkgname=kdenetwork-filesharing
+version=21.04.3
+revision=1
+build_style=cmake
+hostmakedepends="extra-cmake-modules qt5-qmake qt5-host-tools kcoreaddons
+ $(vopt_if samba 'samba') gettext ki18n kauth"
+makedepends="kconfig-devel kio-devel kdeclarative-devel"
+depends="dolphin $(vopt_if samba 'samba')"
+short_desc="Samba file sharing plugin for file properties"
+maintainer="Domenico Panella <pandom79@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://apps.kde.org/kdenetwork_filesharing"
+distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
+checksum=51bea2651b9d59ab254d3fb0e031c31ccb77143bb9f5e97e8e8df6d120c3814f
+
+build_options="samba"
+build_options_default="samba"
+desc_option_samba="Enable support for samba"

Re: New package : kdenetwork-filesharing-21.04.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/31956#issuecomment-1136640257

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package : kdenetwork-filesharing-21.04.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

There's a closed pull request on the void-packages repository

New package : kdenetwork-filesharing-21.04.3
https://github.com/void-linux/void-packages/pull/31956

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->