Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] spdlog: update to 1.10.0.
@ 2022-04-05 16:14 skmpz
  2022-05-28 22:51 ` [PR PATCH] [Merged]: " Piraty
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: skmpz @ 2022-04-05 16:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

There is a new pull request by skmpz against master on the void-packages repository

https://github.com/skmpz/void-packages spdlog-1.10.0
https://github.com/void-linux/void-packages/pull/36533

spdlog: update to 1.10.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36533.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spdlog-1.10.0-36533.patch --]
[-- Type: text/x-diff, Size: 1935 bytes --]

From 2923f8ba82884059952a737bbe60781064d9a0b8 Mon Sep 17 00:00:00 2001
From: skmpz <dem.procopiou@gmail.com>
Date: Tue, 5 Apr 2022 20:14:16 +0400
Subject: [PATCH] spdlog: update to 1.10.0.

---
 srcpkgs/spdlog/patches/fix-pkgconfig.patch | 12 ------------
 srcpkgs/spdlog/template                    |  4 ++--
 2 files changed, 2 insertions(+), 14 deletions(-)
 delete mode 100644 srcpkgs/spdlog/patches/fix-pkgconfig.patch

diff --git a/srcpkgs/spdlog/patches/fix-pkgconfig.patch b/srcpkgs/spdlog/patches/fix-pkgconfig.patch
deleted file mode 100644
index 99c8b7ff1068..000000000000
--- a/srcpkgs/spdlog/patches/fix-pkgconfig.patch
+++ /dev/null
@@ -1,12 +0,0 @@
-Index: spdlog-1.8.2/cmake/spdlog.pc.in
-===================================================================
---- spdlog-1.8.2.orig/cmake/spdlog.pc.in
-+++ spdlog-1.8.2/cmake/spdlog.pc.in
-@@ -8,6 +8,6 @@ Description: Fast C++ logging library.
- URL: https://github.com/gabime/@PROJECT_NAME@
- Version: @SPDLOG_VERSION@
- CFlags: -I${includedir} @PKG_CONFIG_DEFINES@
--Libs: -L${libdir} -lspdlog -pthread
-+Libs: -L${libdir} -lspdlog -lfmt -pthread
- Requires: @PKG_CONFIG_REQUIRES@
- 
diff --git a/srcpkgs/spdlog/template b/srcpkgs/spdlog/template
index ec19e89f5f7a..187ec0d0eb6e 100644
--- a/srcpkgs/spdlog/template
+++ b/srcpkgs/spdlog/template
@@ -1,6 +1,6 @@
 # Template file for 'spdlog'
 pkgname=spdlog
-version=1.9.2
+version=1.10.0
 revision=1
 build_style=cmake
 configure_args="-DSPDLOG_BUILD_EXAMPLE=OFF -DSPDLOG_FMT_EXTERNAL=ON
@@ -13,7 +13,7 @@ maintainer="skmpz <dem.procopiou@gmail.com>"
 license="MIT"
 homepage="https://github.com/gabime/spdlog"
 distfiles="https://github.com/gabime/spdlog/archive/v${version}.tar.gz"
-checksum=6fff9215f5cb81760be4cc16d033526d1080427d236e86d70bb02994f85e3d38
+checksum=697f91700237dbae2326b90469be32b876b2b44888302afbc7aceb68bcfe8224
 
 if [ "$XBPS_CHECK_PKGS" ]; then
 	configure_args+=" -DSPDLOG_BUILD_TESTS_HO=ON"

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Merged]: spdlog: update to 1.10.0.
  2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
@ 2022-05-28 22:51 ` Piraty
  2022-05-31 17:08 ` Johnnynator
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Piraty @ 2022-05-28 22:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

There's a merged pull request on the void-packages repository

spdlog: update to 1.10.0.
https://github.com/void-linux/void-packages/pull/36533

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: spdlog: update to 1.10.0.
  2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
  2022-05-28 22:51 ` [PR PATCH] [Merged]: " Piraty
@ 2022-05-31 17:08 ` Johnnynator
  2022-05-31 17:15 ` skmpz
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Johnnynator @ 2022-05-31 17:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/36533#issuecomment-1142396681

Comment:
You should always check some dependents of a library when updating it, spdlog did break ABI and therefore nheko, MangoHud, cryfs and gerbera did need to be recompiled.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: spdlog: update to 1.10.0.
  2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
  2022-05-28 22:51 ` [PR PATCH] [Merged]: " Piraty
  2022-05-31 17:08 ` Johnnynator
@ 2022-05-31 17:15 ` skmpz
  2022-05-31 17:35 ` skmpz
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: skmpz @ 2022-05-31 17:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by skmpz on void-packages repository

https://github.com/void-linux/void-packages/pull/36533#issuecomment-1142402901

Comment:
hm.. correct, but out of curiosity, why aren't those listed with `xbps-query -X spdlog`

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: spdlog: update to 1.10.0.
  2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
                   ` (2 preceding siblings ...)
  2022-05-31 17:15 ` skmpz
@ 2022-05-31 17:35 ` skmpz
  2022-05-31 17:35 ` skmpz
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: skmpz @ 2022-05-31 17:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New comment by skmpz on void-packages repository

https://github.com/void-linux/void-packages/pull/36533#issuecomment-1142402901

Comment:
hm.. correct, but out of curiosity, why aren't those listed with `xbps-query -X spdlog`.. Is that one only for packages that have spdlog in `depends` ?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: spdlog: update to 1.10.0.
  2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
                   ` (3 preceding siblings ...)
  2022-05-31 17:35 ` skmpz
@ 2022-05-31 17:35 ` skmpz
  2022-05-31 17:41 ` skmpz
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: skmpz @ 2022-05-31 17:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New comment by skmpz on void-packages repository

https://github.com/void-linux/void-packages/pull/36533#issuecomment-1142402901

Comment:
hm.. correct, but out of curiosity, why aren't those listed with `xbps-query -X spdlog`.. Is that one only for packages that have spdlog in `depends=..` ?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: spdlog: update to 1.10.0.
  2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
                   ` (4 preceding siblings ...)
  2022-05-31 17:35 ` skmpz
@ 2022-05-31 17:41 ` skmpz
  2022-05-31 17:57 ` Johnnynator
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: skmpz @ 2022-05-31 17:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

New comment by skmpz on void-packages repository

https://github.com/void-linux/void-packages/pull/36533#issuecomment-1142402901

Comment:
hm.. correct, but out of curiosity, why aren't those listed with `xbps-query -X spdlog`.. Is that one only for packages that have spdlog in `depends=..` ? and also, is there any other flag on xbps to detect those or just do it manually?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: spdlog: update to 1.10.0.
  2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
                   ` (5 preceding siblings ...)
  2022-05-31 17:41 ` skmpz
@ 2022-05-31 17:57 ` Johnnynator
  2022-05-31 18:15 ` skmpz
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Johnnynator @ 2022-05-31 17:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/36533#issuecomment-1142441056

Comment:
You need to use -RX to also list packages that aren't installed on your system.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: spdlog: update to 1.10.0.
  2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
                   ` (6 preceding siblings ...)
  2022-05-31 17:57 ` Johnnynator
@ 2022-05-31 18:15 ` skmpz
  2022-05-31 18:27 ` skmpz
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: skmpz @ 2022-05-31 18:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

New comment by skmpz on void-packages repository

https://github.com/void-linux/void-packages/pull/36533#issuecomment-1142463943

Comment:
this will also show reverse runtime dependencies though and not build dependencies right ?
```
$ sudo xbps-query -RX spdlog
coeurl-devel-0.1.1_1
```
Just wondering if there's any other way other than just grepping through the srcpkgs folder to find reverse build dependencies..

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: spdlog: update to 1.10.0.
  2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
                   ` (7 preceding siblings ...)
  2022-05-31 18:15 ` skmpz
@ 2022-05-31 18:27 ` skmpz
  2022-05-31 19:23 ` Johnnynator
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: skmpz @ 2022-05-31 18:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

New comment by skmpz on void-packages repository

https://github.com/void-linux/void-packages/pull/36533#issuecomment-1142508185

Comment:
just another question.. when getting 
```
$ xrevshlib spdlog
Bear
coeurl
cryfs
gerbera
MangoHud
nheko
Waybar
```
Is there a way to figure out which packages need to be recompiled?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: spdlog: update to 1.10.0.
  2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
                   ` (8 preceding siblings ...)
  2022-05-31 18:27 ` skmpz
@ 2022-05-31 19:23 ` Johnnynator
  2022-05-31 20:02 ` skmpz
  2022-05-31 21:45 ` Piraty
  11 siblings, 0 replies; 13+ messages in thread
From: Johnnynator @ 2022-05-31 19:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/36533#issuecomment-1142554758

Comment:
> 

Ideally a package does increase the so version (the number behind `.so` as listed in e.g. `common/shlibs` in xbps-src).
spdlog did not do that in 1.10.0 ( https://github.com/gabime/spdlog/issues/2369 ), but they changed their build system to also include minor version in there, so this specific issue is unlikely to happen again.

> Is there a way to figure out which packages need to be recompiled?

Void currently doesn't have tooling in xbps-src to track symbols, so no automatic way for detecting this.
You (or a script) could in theory just install all of these packages and check if all the symbols do resolve.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: spdlog: update to 1.10.0.
  2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
                   ` (9 preceding siblings ...)
  2022-05-31 19:23 ` Johnnynator
@ 2022-05-31 20:02 ` skmpz
  2022-05-31 21:45 ` Piraty
  11 siblings, 0 replies; 13+ messages in thread
From: skmpz @ 2022-05-31 20:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by skmpz on void-packages repository

https://github.com/void-linux/void-packages/pull/36533#issuecomment-1142589182

Comment:
ah ok got it.. thanks again..

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: spdlog: update to 1.10.0.
  2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
                   ` (10 preceding siblings ...)
  2022-05-31 20:02 ` skmpz
@ 2022-05-31 21:45 ` Piraty
  11 siblings, 0 replies; 13+ messages in thread
From: Piraty @ 2022-05-31 21:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/36533#issuecomment-1142668083

Comment:
https://abi-laboratory.pro/index.php?view=abi-tracker comes to mind

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-05-31 21:45 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-05 16:14 [PR PATCH] spdlog: update to 1.10.0 skmpz
2022-05-28 22:51 ` [PR PATCH] [Merged]: " Piraty
2022-05-31 17:08 ` Johnnynator
2022-05-31 17:15 ` skmpz
2022-05-31 17:35 ` skmpz
2022-05-31 17:35 ` skmpz
2022-05-31 17:41 ` skmpz
2022-05-31 17:57 ` Johnnynator
2022-05-31 18:15 ` skmpz
2022-05-31 18:27 ` skmpz
2022-05-31 19:23 ` Johnnynator
2022-05-31 20:02 ` skmpz
2022-05-31 21:45 ` Piraty

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).