[PR PATCH] nfdump: add nfcapd service script

[PR PATCH] nfdump: add nfcapd service script

[ailiop-git]

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]

There is a new pull request by ailiop-git against master on the void-packages repository

https://github.com/ailiop-git/void-packages nfdump
https://github.com/void-linux/void-packages/pull/29835

nfdump: add nfcapd service script
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29835.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nfdump-29835.patch --]
[-- Type: text/x-diff, Size: 1560 bytes --]

From 8433ea1d8cc47fd84acc9fe5bec9f51cec7dfb5c Mon Sep 17 00:00:00 2001
From: Anthony Iliopoulos <ailiop@altatus.com>
Date: Mon, 29 Mar 2021 00:08:11 +0200
Subject: [PATCH] nfdump: add nfcapd service script

---
 srcpkgs/nfdump/files/nfcapd/run | 3 +++
 srcpkgs/nfdump/template         | 5 ++++-
 2 files changed, 7 insertions(+), 1 deletion(-)
 create mode 100755 srcpkgs/nfdump/files/nfcapd/run

diff --git a/srcpkgs/nfdump/files/nfcapd/run b/srcpkgs/nfdump/files/nfcapd/run
new file mode 100755
index 000000000000..17458f240b72
--- /dev/null
+++ b/srcpkgs/nfdump/files/nfcapd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+[ -r conf ] && . ./conf
+exec nfcapd -u _nfcapd -g _nfcapd -l /var/log/nfdump $OPTS
diff --git a/srcpkgs/nfdump/template b/srcpkgs/nfdump/template
index b2d73d25fed5..276ad9f3fc69 100644
--- a/srcpkgs/nfdump/template
+++ b/srcpkgs/nfdump/template
@@ -1,7 +1,7 @@
 # Template file for 'nfdump'
 pkgname=nfdump
 version=1.6.22
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="automake flex libtool pkg-config"
 makedepends="bzip2-devel libpcap-devel"
@@ -12,6 +12,8 @@ homepage="https://github.com/phaag/nfdump"
 distfiles="https://github.com/phaag/nfdump/archive/v${version}.tar.gz"
 checksum=437536acb02258f8e2cd1e63c801428c65e1c33100e349acbf718c5b04734bd0
 configure_args+="--enable-sflow --enable-readpcap --enable-nfcapd"
+system_accounts="_nfcapd"
+make_dirs="/var/log/nfdump 750 _nfcapd _nfcapd"
 
 pre_configure() {
 	autoreconf -fi
@@ -19,4 +21,5 @@ pre_configure() {
 
 post_install() {
 	vlicense LICENSE
+	vsv nfcapd
 }

Re: [PR REVIEW] nfdump: add nfcapd service script

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/29835#discussion_r603550642

Comment:
Should probably just be `${OPTS:--l /var/log/nfdump}`.

Re: [PR PATCH] [Updated] nfdump: add nfcapd service script

[ailiop-git]

[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]

There is an updated pull request by ailiop-git against master on the void-packages repository

https://github.com/ailiop-git/void-packages nfdump
https://github.com/void-linux/void-packages/pull/29835

nfdump: add nfcapd service script
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29835.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nfdump-29835.patch --]
[-- Type: text/x-diff, Size: 1563 bytes --]

From 8f47032a08fbd5d9279710f5c5c0394f6141f44f Mon Sep 17 00:00:00 2001
From: Anthony Iliopoulos <ailiop@altatus.com>
Date: Mon, 29 Mar 2021 00:08:11 +0200
Subject: [PATCH] nfdump: add nfcapd service script

---
 srcpkgs/nfdump/files/nfcapd/run | 3 +++
 srcpkgs/nfdump/template         | 5 ++++-
 2 files changed, 7 insertions(+), 1 deletion(-)
 create mode 100755 srcpkgs/nfdump/files/nfcapd/run

diff --git a/srcpkgs/nfdump/files/nfcapd/run b/srcpkgs/nfdump/files/nfcapd/run
new file mode 100755
index 000000000000..6037ffc892a9
--- /dev/null
+++ b/srcpkgs/nfdump/files/nfcapd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+[ -r conf ] && . ./conf
+exec nfcapd -u _nfcapd -g _nfcapd ${OPTS:--l /var/log/nfdump}
diff --git a/srcpkgs/nfdump/template b/srcpkgs/nfdump/template
index b2d73d25fed5..276ad9f3fc69 100644
--- a/srcpkgs/nfdump/template
+++ b/srcpkgs/nfdump/template
@@ -1,7 +1,7 @@
 # Template file for 'nfdump'
 pkgname=nfdump
 version=1.6.22
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="automake flex libtool pkg-config"
 makedepends="bzip2-devel libpcap-devel"
@@ -12,6 +12,8 @@ homepage="https://github.com/phaag/nfdump"
 distfiles="https://github.com/phaag/nfdump/archive/v${version}.tar.gz"
 checksum=437536acb02258f8e2cd1e63c801428c65e1c33100e349acbf718c5b04734bd0
 configure_args+="--enable-sflow --enable-readpcap --enable-nfcapd"
+system_accounts="_nfcapd"
+make_dirs="/var/log/nfdump 750 _nfcapd _nfcapd"
 
 pre_configure() {
 	autoreconf -fi
@@ -19,4 +21,5 @@ pre_configure() {
 
 post_install() {
 	vlicense LICENSE
+	vsv nfcapd
 }

Re: nfdump: add nfcapd service script

[abenson]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/29835#issuecomment-812207637

Comment:
The tests seem to fail on time-based issues, not really sure what's going on.

Re: nfdump: add nfcapd service script

[ailiop-git]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

New comment by ailiop-git on void-packages repository

https://github.com/void-linux/void-packages/pull/29835#issuecomment-812463512

Comment:
> The tests seem to fail on time-based issues, not really sure what's going on.

Probably unmaintained tests, haven't really looked into it since it is otherwise working fine. The test failure has always been there anyway, it's just that this is the first update after enabling the checking stages.

Re: nfdump: add nfcapd service script

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29835#issuecomment-813114424

Comment:
@Duncaen or @abenson, ok to merge?

Re: nfdump: add nfcapd service script

[abenson]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/29835#issuecomment-813132705

Comment:
I feel comfortable yeah

Re: nfdump: add nfcapd service script

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/29835#issuecomment-1126843765

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: nfdump: add nfcapd service script

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]

There's a closed pull request on the void-packages repository

nfdump: add nfcapd service script
https://github.com/void-linux/void-packages/pull/29835

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->