Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] libcgroup upgrade to 2.0
@ 2021-08-22  4:29 wibed
  2021-08-22  7:38 ` paper42
                   ` (15 more replies)
  0 siblings, 16 replies; 35+ messages in thread
From: wibed @ 2021-08-22  4:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

There is a new pull request by wibed against master on the void-packages repository

https://github.com/wibed/void-packages libcgroupUpgrade
https://github.com/void-linux/void-packages/pull/32623

libcgroup upgrade to 2.0
<!-- Mark items with [x] where applicable -->

#### General
- [ x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ x] I built this PR locally for my native architecture, (ARCH-MUSL)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libcgroupUpgrade-32623.patch --]
[-- Type: text/x-diff, Size: 1924 bytes --]

From b428a366d9be122b290e374649eb3916bf9eecca Mon Sep 17 00:00:00 2001
From: wibed <wibe@tutanota.com>
Date: Sun, 22 Aug 2021 06:25:48 +0200
Subject: [PATCH] upgrade to 2.0

---
 srcpkgs/libcgroup/template | 18 +++++++-----------
 srcpkgs/libcgroup/update   |  1 -
 2 files changed, 7 insertions(+), 12 deletions(-)
 delete mode 100644 srcpkgs/libcgroup/update

diff --git a/srcpkgs/libcgroup/template b/srcpkgs/libcgroup/template
index c9c19120e597..8fcf111224af 100644
--- a/srcpkgs/libcgroup/template
+++ b/srcpkgs/libcgroup/template
@@ -1,17 +1,16 @@
 # Template file for 'libcgroup'
 pkgname=libcgroup
-version=0.41
-revision=8
+version=2
+revision=1
 build_style=gnu-configure
-configure_args="--sbindir=/usr/bin --enable-pam-module-dir=/usr/lib/security"
-hostmakedepends="flex automake libtool"
+hostmakedepends="flex"
 makedepends="pam-devel"
 short_desc="Library that abstracts the control group file system in Linux"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="LGPL-2.1"
-homepage="http://libcg.sourceforge.net"
-distfiles="${SOURCEFORGE_SITE}/libcg/${pkgname}-${version}.tar.bz2"
-checksum=e4e38bdc7ef70645ce33740ddcca051248d56b53283c0dc6d404e17706f6fb51
+license="LGPL-2.1-only"
+homepage="https://github.com/libcgroup/libcgroup"
+distfiles="https://github.com/libcgroup/libcgroup/releases/download/v${version}/libcgroup-${version}.tar.gz"
+checksum=aecc501a9ea6a97da0673585db5081df912ae607dec36d5f6f7ab14f69d48ab8
 
 case "$XBPS_TARGET_MACHINE" in
 	*-musl)	# Add musl-fts implementation
@@ -20,9 +19,6 @@ case "$XBPS_TARGET_MACHINE" in
 		;;
 esac
 
-pre_configure() {
-	autoreconf -if
-}
 post_configure() {
 	# Disable tests
 	sed -i Makefile -e "/SUBDIRS =/ s; tests;;"
diff --git a/srcpkgs/libcgroup/update b/srcpkgs/libcgroup/update
deleted file mode 100644
index d395a5b230c3..000000000000
--- a/srcpkgs/libcgroup/update
+++ /dev/null
@@ -1 +0,0 @@
-pattern="${pkgname}-v?\K[\d.]+(?=\.tar)"

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup upgrade to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
@ 2021-08-22  7:38 ` paper42
  2021-08-22  9:09 ` [PR PATCH] [Updated] libcgroup: update " wibed
                   ` (14 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: paper42 @ 2021-08-22  7:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32623#issuecomment-903227556

Comment:
continuation of #32231

the commit message is wrong, it should be `libcgroup: update to 2.0`

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PR PATCH] [Updated] libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
  2021-08-22  7:38 ` paper42
@ 2021-08-22  9:09 ` wibed
  2021-08-22  9:11 ` wibed
                   ` (13 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-22  9:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

There is an updated pull request by wibed against master on the void-packages repository

https://github.com/wibed/void-packages libcgroupUpgrade
https://github.com/void-linux/void-packages/pull/32623

libcgroup: update to 2.0
<!-- Mark items with [x] where applicable -->

#### General
- [ x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ x] I built this PR locally for my native architecture, (ARCH-MUSL)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libcgroupUpgrade-32623.patch --]
[-- Type: text/x-diff, Size: 2524 bytes --]

From b428a366d9be122b290e374649eb3916bf9eecca Mon Sep 17 00:00:00 2001
From: wibed <wibe@tutanota.com>
Date: Sun, 22 Aug 2021 06:25:48 +0200
Subject: [PATCH 1/2] upgrade to 2.0

---
 srcpkgs/libcgroup/template | 18 +++++++-----------
 srcpkgs/libcgroup/update   |  1 -
 2 files changed, 7 insertions(+), 12 deletions(-)
 delete mode 100644 srcpkgs/libcgroup/update

diff --git a/srcpkgs/libcgroup/template b/srcpkgs/libcgroup/template
index c9c19120e597..8fcf111224af 100644
--- a/srcpkgs/libcgroup/template
+++ b/srcpkgs/libcgroup/template
@@ -1,17 +1,16 @@
 # Template file for 'libcgroup'
 pkgname=libcgroup
-version=0.41
-revision=8
+version=2
+revision=1
 build_style=gnu-configure
-configure_args="--sbindir=/usr/bin --enable-pam-module-dir=/usr/lib/security"
-hostmakedepends="flex automake libtool"
+hostmakedepends="flex"
 makedepends="pam-devel"
 short_desc="Library that abstracts the control group file system in Linux"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="LGPL-2.1"
-homepage="http://libcg.sourceforge.net"
-distfiles="${SOURCEFORGE_SITE}/libcg/${pkgname}-${version}.tar.bz2"
-checksum=e4e38bdc7ef70645ce33740ddcca051248d56b53283c0dc6d404e17706f6fb51
+license="LGPL-2.1-only"
+homepage="https://github.com/libcgroup/libcgroup"
+distfiles="https://github.com/libcgroup/libcgroup/releases/download/v${version}/libcgroup-${version}.tar.gz"
+checksum=aecc501a9ea6a97da0673585db5081df912ae607dec36d5f6f7ab14f69d48ab8
 
 case "$XBPS_TARGET_MACHINE" in
 	*-musl)	# Add musl-fts implementation
@@ -20,9 +19,6 @@ case "$XBPS_TARGET_MACHINE" in
 		;;
 esac
 
-pre_configure() {
-	autoreconf -if
-}
 post_configure() {
 	# Disable tests
 	sed -i Makefile -e "/SUBDIRS =/ s; tests;;"
diff --git a/srcpkgs/libcgroup/update b/srcpkgs/libcgroup/update
deleted file mode 100644
index d395a5b230c3..000000000000
--- a/srcpkgs/libcgroup/update
+++ /dev/null
@@ -1 +0,0 @@
-pattern="${pkgname}-v?\K[\d.]+(?=\.tar)"

From e6f280625d2ff34d3064e530a924b1dbbbd2eb51 Mon Sep 17 00:00:00 2001
From: wibed <wibe@tutanota.com>
Date: Sun, 22 Aug 2021 06:25:48 +0200
Subject: [PATCH 2/2] upgrade to 2.0

---
 srcpkgs/libcgroup/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/libcgroup/template b/srcpkgs/libcgroup/template
index 8fcf111224af..70dccea0068f 100644
--- a/srcpkgs/libcgroup/template
+++ b/srcpkgs/libcgroup/template
@@ -1,6 +1,6 @@
 # Template file for 'libcgroup'
 pkgname=libcgroup
-version=2
+version=2.0
 revision=1
 build_style=gnu-configure
 hostmakedepends="flex"

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PR PATCH] [Updated] libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
  2021-08-22  7:38 ` paper42
  2021-08-22  9:09 ` [PR PATCH] [Updated] libcgroup: update " wibed
@ 2021-08-22  9:11 ` wibed
  2021-08-22  9:20 ` paper42
                   ` (12 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-22  9:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

There is an updated pull request by wibed against master on the void-packages repository

https://github.com/wibed/void-packages libcgroupUpgrade
https://github.com/void-linux/void-packages/pull/32623

libcgroup: update to 2.0
<!-- Mark items with [x] where applicable -->

#### General
- [ x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ x] I built this PR locally for my native architecture, (ARCH-MUSL)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libcgroupUpgrade-32623.patch --]
[-- Type: text/x-diff, Size: 1941 bytes --]

From c7b103261e3ae3ca04df941f4df6bbee4a7371d9 Mon Sep 17 00:00:00 2001
From: wibed <wibe@tutanota.com>
Date: Sun, 22 Aug 2021 06:25:48 +0200
Subject: [PATCH] upgrade to 2.0

upgrade to 2.0
---
 srcpkgs/libcgroup/template | 18 +++++++-----------
 srcpkgs/libcgroup/update   |  1 -
 2 files changed, 7 insertions(+), 12 deletions(-)
 delete mode 100644 srcpkgs/libcgroup/update

diff --git a/srcpkgs/libcgroup/template b/srcpkgs/libcgroup/template
index c9c19120e597..70dccea0068f 100644
--- a/srcpkgs/libcgroup/template
+++ b/srcpkgs/libcgroup/template
@@ -1,17 +1,16 @@
 # Template file for 'libcgroup'
 pkgname=libcgroup
-version=0.41
-revision=8
+version=2.0
+revision=1
 build_style=gnu-configure
-configure_args="--sbindir=/usr/bin --enable-pam-module-dir=/usr/lib/security"
-hostmakedepends="flex automake libtool"
+hostmakedepends="flex"
 makedepends="pam-devel"
 short_desc="Library that abstracts the control group file system in Linux"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="LGPL-2.1"
-homepage="http://libcg.sourceforge.net"
-distfiles="${SOURCEFORGE_SITE}/libcg/${pkgname}-${version}.tar.bz2"
-checksum=e4e38bdc7ef70645ce33740ddcca051248d56b53283c0dc6d404e17706f6fb51
+license="LGPL-2.1-only"
+homepage="https://github.com/libcgroup/libcgroup"
+distfiles="https://github.com/libcgroup/libcgroup/releases/download/v${version}/libcgroup-${version}.tar.gz"
+checksum=aecc501a9ea6a97da0673585db5081df912ae607dec36d5f6f7ab14f69d48ab8
 
 case "$XBPS_TARGET_MACHINE" in
 	*-musl)	# Add musl-fts implementation
@@ -20,9 +19,6 @@ case "$XBPS_TARGET_MACHINE" in
 		;;
 esac
 
-pre_configure() {
-	autoreconf -if
-}
 post_configure() {
 	# Disable tests
 	sed -i Makefile -e "/SUBDIRS =/ s; tests;;"
diff --git a/srcpkgs/libcgroup/update b/srcpkgs/libcgroup/update
deleted file mode 100644
index d395a5b230c3..000000000000
--- a/srcpkgs/libcgroup/update
+++ /dev/null
@@ -1 +0,0 @@
-pattern="${pkgname}-v?\K[\d.]+(?=\.tar)"

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (2 preceding siblings ...)
  2021-08-22  9:11 ` wibed
@ 2021-08-22  9:20 ` paper42
  2021-08-22  9:23 ` [PR PATCH] [Updated] " wibed
                   ` (11 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: paper42 @ 2021-08-22  9:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32623#issuecomment-903239242

Comment:
No, run git commit --amend and fix the commit message there.


The build is failing now, did you test it on your machine? I think we removed the failing patch in the previous PR, didn't we?

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PR PATCH] [Updated] libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (3 preceding siblings ...)
  2021-08-22  9:20 ` paper42
@ 2021-08-22  9:23 ` wibed
  2021-08-22  9:26 ` wibed
                   ` (10 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-22  9:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

There is an updated pull request by wibed against master on the void-packages repository

https://github.com/wibed/void-packages libcgroupUpgrade
https://github.com/void-linux/void-packages/pull/32623

libcgroup: update to 2.0
<!-- Mark items with [x] where applicable -->

#### General
- [ x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ x] I built this PR locally for my native architecture, (ARCH-MUSL)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libcgroupUpgrade-32623.patch --]
[-- Type: text/x-diff, Size: 4609 bytes --]

From ec5cd87e952557b4c131f813265e8212cec99d90 Mon Sep 17 00:00:00 2001
From: wibed <wibe@tutanota.com>
Date: Sun, 22 Aug 2021 06:25:48 +0200
Subject: [PATCH] upgrade to 2.0

upgrade to 2.0
---
 srcpkgs/libcgroup/patches/CVE-2018-14348.patch |  4 ++--
 .../patches/api.c-fix-infinite-loop.patch      |  4 ++--
 srcpkgs/libcgroup/patches/musl-decls.patch     |  4 ++--
 .../libcgroup/patches/musl-strerror_r.patch    |  4 ++--
 srcpkgs/libcgroup/template                     | 18 +++++++-----------
 srcpkgs/libcgroup/update                       |  1 -
 6 files changed, 15 insertions(+), 20 deletions(-)
 delete mode 100644 srcpkgs/libcgroup/update

diff --git a/srcpkgs/libcgroup/patches/CVE-2018-14348.patch b/srcpkgs/libcgroup/patches/CVE-2018-14348.patch
index bd083c2aad97..0aa1f906ff63 100644
--- a/srcpkgs/libcgroup/patches/CVE-2018-14348.patch
+++ b/srcpkgs/libcgroup/patches/CVE-2018-14348.patch
@@ -1,5 +1,5 @@
---- a/src/daemon/cgrulesengd.c
-+++ b/src/daemon/cgrulesengd.c
+--- src/daemon/cgrulesengd.c
++++ src/daemon/cgrulesengd.c
 @@ -889,9 +889,6 @@
  		} else if (pid > 0) {
  			exit(EXIT_SUCCESS);
diff --git a/srcpkgs/libcgroup/patches/api.c-fix-infinite-loop.patch b/srcpkgs/libcgroup/patches/api.c-fix-infinite-loop.patch
index 12ee0eeebc84..13be3795dfd3 100644
--- a/srcpkgs/libcgroup/patches/api.c-fix-infinite-loop.patch
+++ b/srcpkgs/libcgroup/patches/api.c-fix-infinite-loop.patch
@@ -11,8 +11,8 @@ to the next iteration.
 
 diff --git a/src/api.c b/src/api.c
 index d6c9d3a..ef796ac 100644
---- a/src/api.c
-+++ b/src/api.c
+--- src/api.c
++++ src/api.c
 @@ -2775,13 +2775,17 @@ static struct cgroup_rule *cgroup_find_matching_rule_uid_gid(uid_t uid,
  			/* Get the group data. */
  			sp = &(rule->username[1]);
diff --git a/srcpkgs/libcgroup/patches/musl-decls.patch b/srcpkgs/libcgroup/patches/musl-decls.patch
index eacf4e618d93..eaebdb8936c3 100644
--- a/srcpkgs/libcgroup/patches/musl-decls.patch
+++ b/srcpkgs/libcgroup/patches/musl-decls.patch
@@ -1,8 +1,8 @@
 In musl libc these macros are defined in the deprecated
 include file sys/cdefs.h
 
---- a/include/libcgroup.h	2014-01-13 15:05:56.000000000 +0100
-+++ b/include/libcgroup.h	2015-10-25 14:03:32.921207668 +0100
+--- include/libcgroup.h	2014-01-13 15:05:56.000000000 +0100
++++ include/libcgroup.h	2015-10-25 14:03:32.921207668 +0100
 @@ -16,6 +16,16 @@
  #ifndef _LIBCGROUP_H
  #define _LIBCGROUP_H
diff --git a/srcpkgs/libcgroup/patches/musl-strerror_r.patch b/srcpkgs/libcgroup/patches/musl-strerror_r.patch
index 0f54e12b05d2..eac640ba994f 100644
--- a/srcpkgs/libcgroup/patches/musl-strerror_r.patch
+++ b/srcpkgs/libcgroup/patches/musl-strerror_r.patch
@@ -1,8 +1,8 @@
 The musl libc strerror_r(3) semantics are different from
 GNU libc's if _GNU_SOURCE is defined.
 
---- a/src/api.c	2014-01-13 15:05:56.000000000 +0100
-+++ b/src/api.c	2015-10-25 14:09:18.690232596 +0100
+--- src/api.c	2014-01-13 15:05:56.000000000 +0100
++++ src/api.c	2015-10-25 14:09:18.690232596 +0100
 @@ -3332,8 +3332,16 @@
  
  const char *cgroup_strerror(int code)
diff --git a/srcpkgs/libcgroup/template b/srcpkgs/libcgroup/template
index c9c19120e597..70dccea0068f 100644
--- a/srcpkgs/libcgroup/template
+++ b/srcpkgs/libcgroup/template
@@ -1,17 +1,16 @@
 # Template file for 'libcgroup'
 pkgname=libcgroup
-version=0.41
-revision=8
+version=2.0
+revision=1
 build_style=gnu-configure
-configure_args="--sbindir=/usr/bin --enable-pam-module-dir=/usr/lib/security"
-hostmakedepends="flex automake libtool"
+hostmakedepends="flex"
 makedepends="pam-devel"
 short_desc="Library that abstracts the control group file system in Linux"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="LGPL-2.1"
-homepage="http://libcg.sourceforge.net"
-distfiles="${SOURCEFORGE_SITE}/libcg/${pkgname}-${version}.tar.bz2"
-checksum=e4e38bdc7ef70645ce33740ddcca051248d56b53283c0dc6d404e17706f6fb51
+license="LGPL-2.1-only"
+homepage="https://github.com/libcgroup/libcgroup"
+distfiles="https://github.com/libcgroup/libcgroup/releases/download/v${version}/libcgroup-${version}.tar.gz"
+checksum=aecc501a9ea6a97da0673585db5081df912ae607dec36d5f6f7ab14f69d48ab8
 
 case "$XBPS_TARGET_MACHINE" in
 	*-musl)	# Add musl-fts implementation
@@ -20,9 +19,6 @@ case "$XBPS_TARGET_MACHINE" in
 		;;
 esac
 
-pre_configure() {
-	autoreconf -if
-}
 post_configure() {
 	# Disable tests
 	sed -i Makefile -e "/SUBDIRS =/ s; tests;;"
diff --git a/srcpkgs/libcgroup/update b/srcpkgs/libcgroup/update
deleted file mode 100644
index d395a5b230c3..000000000000
--- a/srcpkgs/libcgroup/update
+++ /dev/null
@@ -1 +0,0 @@
-pattern="${pkgname}-v?\K[\d.]+(?=\.tar)"

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (4 preceding siblings ...)
  2021-08-22  9:23 ` [PR PATCH] [Updated] " wibed
@ 2021-08-22  9:26 ` wibed
  2021-08-22 18:17 ` paper42
                   ` (9 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-22  9:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32623#issuecomment-903239905

Comment:
git commit --amend  is what i run

i have adjusted the patches to be compatible with git patches

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (5 preceding siblings ...)
  2021-08-22  9:26 ` wibed
@ 2021-08-22 18:17 ` paper42
  2021-08-23  9:01 ` [PR PATCH] [Updated] " wibed
                   ` (8 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: paper42 @ 2021-08-22 18:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32623#issuecomment-903309272

Comment:
> > No, run git commit --amend and fix the commit message there.
>
> git commit --amend is what i run

but for some reason you are not editing the commit message
* did an editor open for you?
* did you edit the message in it?
* did you save the file in the editor?

`git show` will tell you the commit message.

If you are not able to edit the commit message interactively, this command should work:
```
git commit --amend --no-edit -m "message"
```

> i have adjusted the patches to be compatible with git patches

:+1:

> The build is failing now, did you test it on your machine? I think we removed the failing patch in the previous PR, didn't we?

CVE-2018-14348 affects only versions up to (and including) 0.41, so we don't need the patch for 2.0. Didn't we already discuss this? Could you build it on your machine before pushing here to make sure simple mistakes like this don't happen?

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PR PATCH] [Updated] libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (6 preceding siblings ...)
  2021-08-22 18:17 ` paper42
@ 2021-08-23  9:01 ` wibed
  2021-08-23 16:20 ` paper42
                   ` (7 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-23  9:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

There is an updated pull request by wibed against master on the void-packages repository

https://github.com/wibed/void-packages libcgroupUpgrade
https://github.com/void-linux/void-packages/pull/32623

libcgroup: update to 2.0
<!-- Mark items with [x] where applicable -->

#### General
- [ x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ x] I built this PR locally for my native architecture, (ARCH-MUSL)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libcgroupUpgrade-32623.patch --]
[-- Type: text/x-diff, Size: 4049 bytes --]

From 55dd1ad81939d363f849f86b71bb6e8b141dbd49 Mon Sep 17 00:00:00 2001
From: wibed <wibe@tutanota.com>
Date: Sun, 22 Aug 2021 06:25:48 +0200
Subject: [PATCH] removing deprecated patches

---
 .../libcgroup/patches/CVE-2018-14348.patch    | 12 ------
 .../patches/api.c-fix-infinite-loop.patch     | 38 -------------------
 srcpkgs/libcgroup/template                    | 18 ++++-----
 srcpkgs/libcgroup/update                      |  1 -
 4 files changed, 7 insertions(+), 62 deletions(-)
 delete mode 100644 srcpkgs/libcgroup/patches/CVE-2018-14348.patch
 delete mode 100644 srcpkgs/libcgroup/patches/api.c-fix-infinite-loop.patch
 delete mode 100644 srcpkgs/libcgroup/update

diff --git a/srcpkgs/libcgroup/patches/CVE-2018-14348.patch b/srcpkgs/libcgroup/patches/CVE-2018-14348.patch
deleted file mode 100644
index bd083c2aad97..000000000000
--- a/srcpkgs/libcgroup/patches/CVE-2018-14348.patch
+++ /dev/null
@@ -1,12 +0,0 @@
---- a/src/daemon/cgrulesengd.c
-+++ b/src/daemon/cgrulesengd.c
-@@ -889,9 +889,6 @@
- 		} else if (pid > 0) {
- 			exit(EXIT_SUCCESS);
- 		}
--
--		/* Change the file mode mask. */
--		umask(0);
- 	} else {
- 		flog(LOG_DEBUG, "Not using daemon mode\n");
- 		pid = getpid();<Paste>
diff --git a/srcpkgs/libcgroup/patches/api.c-fix-infinite-loop.patch b/srcpkgs/libcgroup/patches/api.c-fix-infinite-loop.patch
deleted file mode 100644
index 12ee0eeebc84..000000000000
--- a/srcpkgs/libcgroup/patches/api.c-fix-infinite-loop.patch
+++ /dev/null
@@ -1,38 +0,0 @@
-Date: Tue, 8 Dec 2015 16:53:41 +0100
-Subject: [PATCH] api.c: fix infinite loop
-
-If getgrnam or getpwuid functions failed, the program entered
-an infinite loop, because the rule pointer was never advanced.
-This is now fixed by updating the pointer before continuing
-to the next iteration.
----
- src/api.c | 8 ++++++--
- 1 file changed, 6 insertions(+), 2 deletions(-)
-
-diff --git a/src/api.c b/src/api.c
-index d6c9d3a..ef796ac 100644
---- a/src/api.c
-+++ b/src/api.c
-@@ -2775,13 +2775,17 @@ static struct cgroup_rule *cgroup_find_matching_rule_uid_gid(uid_t uid,
- 			/* Get the group data. */
- 			sp = &(rule->username[1]);
- 			grp = getgrnam(sp);
--			if (!grp)
-+			if (!grp) {
-+				rule = rule->next;
- 				continue;
-+			}
- 
- 			/* Get the data for UID. */
- 			usr = getpwuid(uid);
--			if (!usr)
-+			if (!usr) {
-+				rule = rule->next;
- 				continue;
-+			}
- 
- 			/* If UID is a member of group, we matched. */
- 			for (i = 0; grp->gr_mem[i]; i++) {
--- 
-2.10.2
-
diff --git a/srcpkgs/libcgroup/template b/srcpkgs/libcgroup/template
index c9c19120e597..70dccea0068f 100644
--- a/srcpkgs/libcgroup/template
+++ b/srcpkgs/libcgroup/template
@@ -1,17 +1,16 @@
 # Template file for 'libcgroup'
 pkgname=libcgroup
-version=0.41
-revision=8
+version=2.0
+revision=1
 build_style=gnu-configure
-configure_args="--sbindir=/usr/bin --enable-pam-module-dir=/usr/lib/security"
-hostmakedepends="flex automake libtool"
+hostmakedepends="flex"
 makedepends="pam-devel"
 short_desc="Library that abstracts the control group file system in Linux"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="LGPL-2.1"
-homepage="http://libcg.sourceforge.net"
-distfiles="${SOURCEFORGE_SITE}/libcg/${pkgname}-${version}.tar.bz2"
-checksum=e4e38bdc7ef70645ce33740ddcca051248d56b53283c0dc6d404e17706f6fb51
+license="LGPL-2.1-only"
+homepage="https://github.com/libcgroup/libcgroup"
+distfiles="https://github.com/libcgroup/libcgroup/releases/download/v${version}/libcgroup-${version}.tar.gz"
+checksum=aecc501a9ea6a97da0673585db5081df912ae607dec36d5f6f7ab14f69d48ab8
 
 case "$XBPS_TARGET_MACHINE" in
 	*-musl)	# Add musl-fts implementation
@@ -20,9 +19,6 @@ case "$XBPS_TARGET_MACHINE" in
 		;;
 esac
 
-pre_configure() {
-	autoreconf -if
-}
 post_configure() {
 	# Disable tests
 	sed -i Makefile -e "/SUBDIRS =/ s; tests;;"
diff --git a/srcpkgs/libcgroup/update b/srcpkgs/libcgroup/update
deleted file mode 100644
index d395a5b230c3..000000000000
--- a/srcpkgs/libcgroup/update
+++ /dev/null
@@ -1 +0,0 @@
-pattern="${pkgname}-v?\K[\d.]+(?=\.tar)"

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (7 preceding siblings ...)
  2021-08-23  9:01 ` [PR PATCH] [Updated] " wibed
@ 2021-08-23 16:20 ` paper42
  2021-08-23 18:26 ` [PR PATCH] [Updated] " wibed
                   ` (6 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: paper42 @ 2021-08-23 16:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32623#issuecomment-903921423

Comment:
fix the commit message

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PR PATCH] [Updated] libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (8 preceding siblings ...)
  2021-08-23 16:20 ` paper42
@ 2021-08-23 18:26 ` wibed
  2021-08-24  7:02 ` wibed
                   ` (5 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-23 18:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

There is an updated pull request by wibed against master on the void-packages repository

https://github.com/wibed/void-packages libcgroupUpgrade
https://github.com/void-linux/void-packages/pull/32623

libcgroup: update to 2.0
<!-- Mark items with [x] where applicable -->

#### General
- [ x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ x] I built this PR locally for my native architecture, (ARCH-MUSL)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libcgroupUpgrade-32623.patch --]
[-- Type: text/x-diff, Size: 4046 bytes --]

From d876a1996bc229cb0c1e6d8e1f0b9cea877cbb36 Mon Sep 17 00:00:00 2001
From: wibed <wibe@tutanota.com>
Date: Sun, 22 Aug 2021 06:25:48 +0200
Subject: [PATCH] libcgroup: update to 2.0

---
 .../libcgroup/patches/CVE-2018-14348.patch    | 12 ------
 .../patches/api.c-fix-infinite-loop.patch     | 38 -------------------
 srcpkgs/libcgroup/template                    | 18 ++++-----
 srcpkgs/libcgroup/update                      |  1 -
 4 files changed, 7 insertions(+), 62 deletions(-)
 delete mode 100644 srcpkgs/libcgroup/patches/CVE-2018-14348.patch
 delete mode 100644 srcpkgs/libcgroup/patches/api.c-fix-infinite-loop.patch
 delete mode 100644 srcpkgs/libcgroup/update

diff --git a/srcpkgs/libcgroup/patches/CVE-2018-14348.patch b/srcpkgs/libcgroup/patches/CVE-2018-14348.patch
deleted file mode 100644
index bd083c2aad97..000000000000
--- a/srcpkgs/libcgroup/patches/CVE-2018-14348.patch
+++ /dev/null
@@ -1,12 +0,0 @@
---- a/src/daemon/cgrulesengd.c
-+++ b/src/daemon/cgrulesengd.c
-@@ -889,9 +889,6 @@
- 		} else if (pid > 0) {
- 			exit(EXIT_SUCCESS);
- 		}
--
--		/* Change the file mode mask. */
--		umask(0);
- 	} else {
- 		flog(LOG_DEBUG, "Not using daemon mode\n");
- 		pid = getpid();<Paste>
diff --git a/srcpkgs/libcgroup/patches/api.c-fix-infinite-loop.patch b/srcpkgs/libcgroup/patches/api.c-fix-infinite-loop.patch
deleted file mode 100644
index 12ee0eeebc84..000000000000
--- a/srcpkgs/libcgroup/patches/api.c-fix-infinite-loop.patch
+++ /dev/null
@@ -1,38 +0,0 @@
-Date: Tue, 8 Dec 2015 16:53:41 +0100
-Subject: [PATCH] api.c: fix infinite loop
-
-If getgrnam or getpwuid functions failed, the program entered
-an infinite loop, because the rule pointer was never advanced.
-This is now fixed by updating the pointer before continuing
-to the next iteration.
----
- src/api.c | 8 ++++++--
- 1 file changed, 6 insertions(+), 2 deletions(-)
-
-diff --git a/src/api.c b/src/api.c
-index d6c9d3a..ef796ac 100644
---- a/src/api.c
-+++ b/src/api.c
-@@ -2775,13 +2775,17 @@ static struct cgroup_rule *cgroup_find_matching_rule_uid_gid(uid_t uid,
- 			/* Get the group data. */
- 			sp = &(rule->username[1]);
- 			grp = getgrnam(sp);
--			if (!grp)
-+			if (!grp) {
-+				rule = rule->next;
- 				continue;
-+			}
- 
- 			/* Get the data for UID. */
- 			usr = getpwuid(uid);
--			if (!usr)
-+			if (!usr) {
-+				rule = rule->next;
- 				continue;
-+			}
- 
- 			/* If UID is a member of group, we matched. */
- 			for (i = 0; grp->gr_mem[i]; i++) {
--- 
-2.10.2
-
diff --git a/srcpkgs/libcgroup/template b/srcpkgs/libcgroup/template
index c9c19120e597..70dccea0068f 100644
--- a/srcpkgs/libcgroup/template
+++ b/srcpkgs/libcgroup/template
@@ -1,17 +1,16 @@
 # Template file for 'libcgroup'
 pkgname=libcgroup
-version=0.41
-revision=8
+version=2.0
+revision=1
 build_style=gnu-configure
-configure_args="--sbindir=/usr/bin --enable-pam-module-dir=/usr/lib/security"
-hostmakedepends="flex automake libtool"
+hostmakedepends="flex"
 makedepends="pam-devel"
 short_desc="Library that abstracts the control group file system in Linux"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="LGPL-2.1"
-homepage="http://libcg.sourceforge.net"
-distfiles="${SOURCEFORGE_SITE}/libcg/${pkgname}-${version}.tar.bz2"
-checksum=e4e38bdc7ef70645ce33740ddcca051248d56b53283c0dc6d404e17706f6fb51
+license="LGPL-2.1-only"
+homepage="https://github.com/libcgroup/libcgroup"
+distfiles="https://github.com/libcgroup/libcgroup/releases/download/v${version}/libcgroup-${version}.tar.gz"
+checksum=aecc501a9ea6a97da0673585db5081df912ae607dec36d5f6f7ab14f69d48ab8
 
 case "$XBPS_TARGET_MACHINE" in
 	*-musl)	# Add musl-fts implementation
@@ -20,9 +19,6 @@ case "$XBPS_TARGET_MACHINE" in
 		;;
 esac
 
-pre_configure() {
-	autoreconf -if
-}
 post_configure() {
 	# Disable tests
 	sed -i Makefile -e "/SUBDIRS =/ s; tests;;"
diff --git a/srcpkgs/libcgroup/update b/srcpkgs/libcgroup/update
deleted file mode 100644
index d395a5b230c3..000000000000
--- a/srcpkgs/libcgroup/update
+++ /dev/null
@@ -1 +0,0 @@
-pattern="${pkgname}-v?\K[\d.]+(?=\.tar)"

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (9 preceding siblings ...)
  2021-08-23 18:26 ` [PR PATCH] [Updated] " wibed
@ 2021-08-24  7:02 ` wibed
  2021-08-24 19:25 ` paper42
                   ` (4 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-24  7:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32623#issuecomment-904376687

Comment:
does the commit message has to contain something special i am currently not aware of?

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (10 preceding siblings ...)
  2021-08-24  7:02 ` wibed
@ 2021-08-24 19:25 ` paper42
  2021-08-24 19:38 ` paper42
                   ` (3 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: paper42 @ 2021-08-24 19:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32623#issuecomment-904913441

Comment:
> does the commit message has to contain something special i am currently not aware of?

The commit message is correct now, thanks.

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (11 preceding siblings ...)
  2021-08-24 19:25 ` paper42
@ 2021-08-24 19:38 ` paper42
  2021-08-28 10:59 ` wibed
                   ` (2 subsequent siblings)
  15 siblings, 0 replies; 35+ messages in thread
From: paper42 @ 2021-08-24 19:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32623#issuecomment-904921146

Comment:
@wibed could you test if qomui and mininet still work with this version of libcgroup?

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (12 preceding siblings ...)
  2021-08-24 19:38 ` paper42
@ 2021-08-28 10:59 ` wibed
  2022-06-02  2:15 ` github-actions
  2022-06-17  2:13 ` [PR PATCH] [Closed]: " github-actions
  15 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-28 10:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32623#issuecomment-907609919

Comment:
ill have a look tomorrow if i get to it

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (13 preceding siblings ...)
  2021-08-28 10:59 ` wibed
@ 2022-06-02  2:15 ` github-actions
  2022-06-17  2:13 ` [PR PATCH] [Closed]: " github-actions
  15 siblings, 0 replies; 35+ messages in thread
From: github-actions @ 2022-06-02  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/32623#issuecomment-1144344947

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PR PATCH] [Closed]: libcgroup: update to 2.0
  2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
                   ` (14 preceding siblings ...)
  2022-06-02  2:15 ` github-actions
@ 2022-06-17  2:13 ` github-actions
  15 siblings, 0 replies; 35+ messages in thread
From: github-actions @ 2022-06-17  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

There's a closed pull request on the void-packages repository

libcgroup: update to 2.0
https://github.com/void-linux/void-packages/pull/32623

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ x] I built this PR locally for my native architecture, (ARCH-MUSL)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (16 preceding siblings ...)
  2021-08-21  3:07 ` wibed
@ 2021-08-22  4:07 ` wibed
  17 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-22  4:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-903210352

Comment:
ill reopen a new pr

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (15 preceding siblings ...)
  2021-08-21  1:33 ` wibed
@ 2021-08-21  3:07 ` wibed
  2021-08-22  4:07 ` wibed
  17 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-21  3:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-903032696

Comment:
@ericonr 

i usually do a : `git rebase -i HEAD~N` .

but i have accidentally interleaved other commits, which makes it impossible to squash

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (14 preceding siblings ...)
  2021-08-20 15:56 ` ericonr
@ 2021-08-21  1:33 ` wibed
  2021-08-21  3:07 ` wibed
  2021-08-22  4:07 ` wibed
  17 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-21  1:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-903032696

Comment:
@ericonr 

i usually do a : `git rebase -i HEAD~N` .

but i get all the other commits, because i am not in my own branch.
overreaching my pr.

is there another way i am not aware of?

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (13 preceding siblings ...)
  2021-08-20  1:57 ` wibed
@ 2021-08-20 15:56 ` ericonr
  2021-08-21  1:33 ` wibed
                   ` (2 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: ericonr @ 2021-08-20 15:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-902792270

Comment:
How are you trying to rebase and squash the commits? We have a lot of comments in PRs here explaining how to do it correctly, if you need the exact commands.

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (12 preceding siblings ...)
  2021-08-20  1:09 ` wibed
@ 2021-08-20  1:57 ` wibed
  2021-08-20 15:56 ` ericonr
                   ` (3 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-20  1:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-902371213

Comment:
it is getting late

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (11 preceding siblings ...)
  2021-08-20  1:09 ` wibed
@ 2021-08-20  1:09 ` wibed
  2021-08-20  1:57 ` wibed
                   ` (4 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-20  1:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-902355000

Comment:
okey, despise the "no push" commit message. i have reverted the commit back to 2a257f4, because i have committed and pushed from root directory in 977070c. after that i have rebased to master and pushed again with ef1055f.

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (10 preceding siblings ...)
  2021-08-20  1:07 ` wibed
@ 2021-08-20  1:09 ` wibed
  2021-08-20  1:09 ` wibed
                   ` (5 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-20  1:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-902355000

Comment:
okey, despise the "no push" commit message. i have reverted the commit back to 2a257f4, because i have committed and pushed from root directory in 977070c. after that i have rebased to master and pushed up again.

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (9 preceding siblings ...)
  2021-08-18 16:13 ` paper42
@ 2021-08-20  1:07 ` wibed
  2021-08-20  1:09 ` wibed
                   ` (6 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-20  1:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-902355000

Comment:
okey, despise the "no push" commit message. i have reverted the commit back to 2a257f4, because i have committed and pushed from root directory. after that i have rebased to master and pushed up again.

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (8 preceding siblings ...)
  2021-08-18  8:45 ` wibed
@ 2021-08-18 16:13 ` paper42
  2021-08-20  1:07 ` wibed
                   ` (7 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: paper42 @ 2021-08-18 16:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-901244882

Comment:
> @mt3 it seems the checksum should be updated

yes, that should fix the CI

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (7 preceding siblings ...)
  2021-08-18  3:40 ` wibed
@ 2021-08-18  8:45 ` wibed
  2021-08-18 16:13 ` paper42
                   ` (8 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-18  8:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-900935335

Comment:
@mt3 it seems the checksum should be updated

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (6 preceding siblings ...)
  2021-08-13  7:36 ` wibed
@ 2021-08-18  3:40 ` wibed
  2021-08-18  8:45 ` wibed
                   ` (9 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-18  3:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-900788438

Comment:
@mt3 you just comitted literally when i was to to push my changes upstream

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (5 preceding siblings ...)
  2021-08-12 17:11 ` paper42
@ 2021-08-13  7:36 ` wibed
  2021-08-18  3:40 ` wibed
                   ` (10 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-08-13  7:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-898254086

Comment:
> @wibed are you still interested in continuing to work on this PR?

@paper42 i do, please be patient.

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (4 preceding siblings ...)
  2021-07-28 20:29 ` paper42
@ 2021-08-12 17:11 ` paper42
  2021-08-13  7:36 ` wibed
                   ` (11 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: paper42 @ 2021-08-12 17:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-897814476

Comment:
@wibed are you still interested in continuing to work on this PR?

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (3 preceding siblings ...)
  2021-07-28 17:03 ` wibed
@ 2021-07-28 20:29 ` paper42
  2021-08-12 17:11 ` paper42
                   ` (12 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: paper42 @ 2021-07-28 20:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-888600324

Comment:
> > > pre_configure is not necessary, because you use a tarball with pregenerated configure script. The commit message body is not necessary.
> > 
> > yes and you might be able to remove the hostmakedepends variable then
> 
> without the pre_configure block it builds fine
> but it depends on the hostmakedepends variable

sorry, I forgot about flex, we can drop automake and libtool, but have to leave flex there

```
hostmakedepends="flex"
```

Can you also fix the lint issue from CI?

> srcpkgs/libcgroup/template:10: use SPDX id for 'LGPL-2.1' license or see Manual.md

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
                   ` (2 preceding siblings ...)
  2021-07-28 16:59 ` paper42
@ 2021-07-28 17:03 ` wibed
  2021-07-28 20:29 ` paper42
                   ` (13 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-07-28 17:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-888472285

Comment:
> > > pre_configure is not necessary, because you use a tarball with pregenerated configure script. The commit message body is not necessary.
> > 
> > 
> > do you mean the block?
> > ```
> > pre_configure() {
> >   autoreconf -if
> > }
> > ```
> 
> yes and you might be able to remove the hostmakedepends variable then

without the pre_configure block it builds fine
but it depends on the hostmakedepends variable

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
  2021-07-28 16:01 ` paper42
  2021-07-28 16:49 ` wibed
@ 2021-07-28 16:59 ` paper42
  2021-07-28 17:03 ` wibed
                   ` (14 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: paper42 @ 2021-07-28 16:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-888469500

Comment:
> > pre_configure is not necessary, because you use a tarball with pregenerated configure script. The commit message body is not necessary.
> 
> do you mean the block?
> 
> ```
> pre_configure() {
>   autoreconf -if
> }
> ```

yes and you might be able to remove the hostmakedepends variable then

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
  2021-07-28 16:01 ` paper42
@ 2021-07-28 16:49 ` wibed
  2021-07-28 16:59 ` paper42
                   ` (15 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: wibed @ 2021-07-28 16:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

New comment by wibed on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-888463058

Comment:
> pre_configure is not necessary, because you use a tarball with pregenerated configure script. The commit message body is not necessary.

do you mean the block? 
```
pre_configure() {
  autoreconf -if
}
```

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: libcgroup: update to 2.0.
  2021-07-28 15:54 [PR PATCH] " wibed
@ 2021-07-28 16:01 ` paper42
  2021-07-28 16:49 ` wibed
                   ` (16 subsequent siblings)
  17 siblings, 0 replies; 35+ messages in thread
From: paper42 @ 2021-07-28 16:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32231#issuecomment-888429401

Comment:
pre_configure is not necessary, because you use a tarball with pregenerated configure script. The commit message body is not necessary.

^ permalink raw reply	[flat|nested] 35+ messages in thread

end of thread, other threads:[~2022-06-17  2:13 UTC | newest]

Thread overview: 35+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-22  4:29 [PR PATCH] libcgroup upgrade to 2.0 wibed
2021-08-22  7:38 ` paper42
2021-08-22  9:09 ` [PR PATCH] [Updated] libcgroup: update " wibed
2021-08-22  9:11 ` wibed
2021-08-22  9:20 ` paper42
2021-08-22  9:23 ` [PR PATCH] [Updated] " wibed
2021-08-22  9:26 ` wibed
2021-08-22 18:17 ` paper42
2021-08-23  9:01 ` [PR PATCH] [Updated] " wibed
2021-08-23 16:20 ` paper42
2021-08-23 18:26 ` [PR PATCH] [Updated] " wibed
2021-08-24  7:02 ` wibed
2021-08-24 19:25 ` paper42
2021-08-24 19:38 ` paper42
2021-08-28 10:59 ` wibed
2022-06-02  2:15 ` github-actions
2022-06-17  2:13 ` [PR PATCH] [Closed]: " github-actions
  -- strict thread matches above, loose matches on Subject: below --
2021-07-28 15:54 [PR PATCH] " wibed
2021-07-28 16:01 ` paper42
2021-07-28 16:49 ` wibed
2021-07-28 16:59 ` paper42
2021-07-28 17:03 ` wibed
2021-07-28 20:29 ` paper42
2021-08-12 17:11 ` paper42
2021-08-13  7:36 ` wibed
2021-08-18  3:40 ` wibed
2021-08-18  8:45 ` wibed
2021-08-18 16:13 ` paper42
2021-08-20  1:07 ` wibed
2021-08-20  1:09 ` wibed
2021-08-20  1:09 ` wibed
2021-08-20  1:57 ` wibed
2021-08-20 15:56 ` ericonr
2021-08-21  1:33 ` wibed
2021-08-21  3:07 ` wibed
2021-08-22  4:07 ` wibed

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).