Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: source-serif-pro-4.004_1
@ 2021-05-03 21:49 nmukhachev
  2021-05-03 23:26 ` [PR REVIEW] " kwshi
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: nmukhachev @ 2021-05-03 21:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

There is a new pull request by nmukhachev against master on the void-packages repository

https://github.com/nmukhachev/void-packages master
https://github.com/void-linux/void-packages/pull/30660

New package: source-serif-pro-4.004_1
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30660.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-30660.patch --]
[-- Type: text/x-diff, Size: 1357 bytes --]

From da78055eaf439049e2c3ad25ec5eb0973eecf5c1 Mon Sep 17 00:00:00 2001
From: Nikolay Mukhachev <nikolay-mukhachev@yandex.ru>
Date: Tue, 4 May 2021 00:38:29 +0300
Subject: [PATCH] New package: source-serif-pro-4.004_1

---
 srcpkgs/source-serif-pro/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/source-serif-pro/template

diff --git a/srcpkgs/source-serif-pro/template b/srcpkgs/source-serif-pro/template
new file mode 100644
index 000000000000..3bbfa2cfbeb9
--- /dev/null
+++ b/srcpkgs/source-serif-pro/template
@@ -0,0 +1,20 @@
+# Template file for 'source-serif-pro'
+pkgname=source-serif-pro
+version=4.004
+revision=1
+wrksrc="source-serif-${version}R"
+depends="font-util"
+short_desc="Serif font family for user interface environments"
+maintainer="Nikolay Mukhachev <nikolay-mukhachev@yandex.ru>"
+license="OFL-1.1"
+homepage="https://adobe-fonts.github.io/source-serif/"
+distfiles="https://github.com/adobe-fonts/source-serif/archive/${version}R.tar.gz"
+checksum=dfb364735699cb830caad534cf7741234804d28e4b6fc5e4736b2401f6131aba
+font-dirs="/usr/share/fonts/OTF /usr/share/fonts/TTF"
+
+do_install() {
+	vmkdir usr/share/fonts/TTF
+	vmkdir usr/share/fonts/OTF
+	install -m644 ${wrksrc}/TTF/*.ttf ${DESTDIR}/usr/share/fonts/TTF
+	install -m644 ${wrksrc}/OTF/*.otf ${DESTDIR}/usr/share/fonts/OTF
+}

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] New package: source-serif-pro-4.004_1
  2021-05-03 21:49 [PR PATCH] New package: source-serif-pro-4.004_1 nmukhachev
@ 2021-05-03 23:26 ` kwshi
  2021-05-04 20:20 ` [PR PATCH] [Updated] " nmukhachev
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: kwshi @ 2021-05-03 23:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New review comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/30660#discussion_r625427776

Comment:
I think these two lines should use [`vinstall`](https://github.com/void-linux/void-packages/blob/master/Manual.md#global-functions) instead of `install`?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] New package: source-serif-pro-4.004_1
  2021-05-03 21:49 [PR PATCH] New package: source-serif-pro-4.004_1 nmukhachev
  2021-05-03 23:26 ` [PR REVIEW] " kwshi
@ 2021-05-04 20:20 ` nmukhachev
  2021-05-04 20:22 ` [PR REVIEW] " nmukhachev
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: nmukhachev @ 2021-05-04 20:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1609 bytes --]

There is an updated pull request by nmukhachev against master on the void-packages repository

https://github.com/nmukhachev/void-packages master
https://github.com/void-linux/void-packages/pull/30660

New package: source-serif-pro-4.004_1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30660.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-30660.patch --]
[-- Type: text/x-diff, Size: 1403 bytes --]

From ece76fde8744c7023eb12f42eb1ce77c36295bc3 Mon Sep 17 00:00:00 2001
From: Nikolay Mukhachev <nikolay-mukhachev@yandex.ru>
Date: Tue, 4 May 2021 00:38:29 +0300
Subject: [PATCH] New package: source-serif-pro-4.004_1

---
 srcpkgs/source-serif-pro/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/source-serif-pro/template

diff --git a/srcpkgs/source-serif-pro/template b/srcpkgs/source-serif-pro/template
new file mode 100644
index 000000000000..06af08b8bcfe
--- /dev/null
+++ b/srcpkgs/source-serif-pro/template
@@ -0,0 +1,24 @@
+# Template file for 'source-serif-pro'
+pkgname=source-serif-pro
+version=4.004
+revision=1
+wrksrc="source-serif-${version}R"
+depends="font-util"
+short_desc="Serif font family for user interface environments"
+maintainer="Nikolay Mukhachev <nikolay-mukhachev@yandex.ru>"
+license="OFL-1.1"
+homepage="https://adobe-fonts.github.io/source-serif/"
+distfiles="https://github.com/adobe-fonts/source-serif/archive/${version}R.tar.gz"
+checksum=dfb364735699cb830caad534cf7741234804d28e4b6fc5e4736b2401f6131aba
+font-dirs="/usr/share/fonts/OTF /usr/share/fonts/TTF"
+
+do_install() {
+	vmkdir usr/share/fonts/TTF
+	vmkdir usr/share/fonts/OTF
+  for f in ${wrksrc}/TTF/*.ttf; do
+    vinstall "$f" 644 usr/share/fonts/TTF
+  done
+  for f in  ${wrksrc}/OTF/*.otf; do
+    vinstall  "$f" 644 usr/share/fonts/OTF
+  done
+}

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] New package: source-serif-pro-4.004_1
  2021-05-03 21:49 [PR PATCH] New package: source-serif-pro-4.004_1 nmukhachev
  2021-05-03 23:26 ` [PR REVIEW] " kwshi
  2021-05-04 20:20 ` [PR PATCH] [Updated] " nmukhachev
@ 2021-05-04 20:22 ` nmukhachev
  2021-05-17 19:57 ` Chocimier
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: nmukhachev @ 2021-05-04 20:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by nmukhachev on void-packages repository

https://github.com/void-linux/void-packages/pull/30660#discussion_r626079160

Comment:
Thanks for your advice.
I've fixed the template

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: New package: source-serif-pro-4.004_1
  2021-05-03 21:49 [PR PATCH] New package: source-serif-pro-4.004_1 nmukhachev
                   ` (2 preceding siblings ...)
  2021-05-04 20:22 ` [PR REVIEW] " nmukhachev
@ 2021-05-17 19:57 ` Chocimier
  2021-05-17 21:08 ` ericonr
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2021-05-17 19:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/30660#issuecomment-842590811

Comment:
Do this really conforms to the linked quality requirements for fonts?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: New package: source-serif-pro-4.004_1
  2021-05-03 21:49 [PR PATCH] New package: source-serif-pro-4.004_1 nmukhachev
                   ` (3 preceding siblings ...)
  2021-05-17 19:57 ` Chocimier
@ 2021-05-17 21:08 ` ericonr
  2022-05-19  2:16 ` github-actions
  2022-06-03  2:11 ` [PR PATCH] [Closed]: " github-actions
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-05-17 21:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30660#issuecomment-842640436

Comment:
I considered packaging this font when I was looking into splitting fonts from the `libreoffice` package, but then I realized it'd be a *lot* of extra packages, so I gave up on that idea.

The only argument I see for it is that we carry `source-sans-pro` already, but idk.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: New package: source-serif-pro-4.004_1
  2021-05-03 21:49 [PR PATCH] New package: source-serif-pro-4.004_1 nmukhachev
                   ` (4 preceding siblings ...)
  2021-05-17 21:08 ` ericonr
@ 2022-05-19  2:16 ` github-actions
  2022-06-03  2:11 ` [PR PATCH] [Closed]: " github-actions
  6 siblings, 0 replies; 8+ messages in thread
From: github-actions @ 2022-05-19  2:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/30660#issuecomment-1131014174

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Closed]: New package: source-serif-pro-4.004_1
  2021-05-03 21:49 [PR PATCH] New package: source-serif-pro-4.004_1 nmukhachev
                   ` (5 preceding siblings ...)
  2022-05-19  2:16 ` github-actions
@ 2022-06-03  2:11 ` github-actions
  6 siblings, 0 replies; 8+ messages in thread
From: github-actions @ 2022-06-03  2:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]

There's a closed pull request on the void-packages repository

New package: source-serif-pro-4.004_1
https://github.com/void-linux/void-packages/pull/30660

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-06-03  2:11 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-03 21:49 [PR PATCH] New package: source-serif-pro-4.004_1 nmukhachev
2021-05-03 23:26 ` [PR REVIEW] " kwshi
2021-05-04 20:20 ` [PR PATCH] [Updated] " nmukhachev
2021-05-04 20:22 ` [PR REVIEW] " nmukhachev
2021-05-17 19:57 ` Chocimier
2021-05-17 21:08 ` ericonr
2022-05-19  2:16 ` github-actions
2022-06-03  2:11 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).