Github messages for voidlinux
 help / color / mirror / Atom feed
From: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: iptables: adjust run scripts for more configuration flexibility
Date: Sat, 04 Jun 2022 04:08:51 +0200	[thread overview]
Message-ID: <20220604020851.O6VTsdPBk5B58BH9HVts-eujYW1Z39G1LdHhl_xCqYA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31145@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2342 bytes --]

There's a closed pull request on the void-packages repository

iptables: adjust run scripts for more configuration flexibility
https://github.com/void-linux/void-packages/pull/31145

Description:
The single configuration file approach that the iptables services
provide precludes using it in more complicated buildouts such as ones
defined with config management tools. This change takes a hybrid
approach of the old method (to preserve backwards compatibility, etc)
and the method taken with void-ansible-roles/network.

Changes:
No longer flush tables prior to loading new data - rely on finish in all
  cases
Load data from /etc/iptables/iptables.rules and all found
  /etc/iptables.d/\*.rules
Ditto ip6 equivalents (ip6rules.rules, ip6tables.d/\*.{,6}rules)
Flush nat table in both v4 and v6 mode (nat table supported on v6 since
  kernel 3.7)

Caveats: the ip6tables.d match is overly explicit since dash does not
provide brace expansion and there is no particularly clean way to match
a single character or empty when expanding globs.

@ailiop-git 
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



      parent reply	other threads:[~2022-06-04  2:08 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27  4:29 [PR PATCH] " heliocat
2021-05-27  4:30 ` heliocat
2021-05-27  4:39 ` [PR PATCH] [Updated] " heliocat
2021-05-27  4:44 ` [PR REVIEW] " the-maldridge
2021-05-27  4:44 ` the-maldridge
2021-05-27  4:44 ` the-maldridge
2021-05-27  4:54 ` [PR PATCH] [Updated] " heliocat
2021-05-27  4:54 ` [PR REVIEW] " heliocat
2021-05-27  4:55 ` [PR PATCH] [Updated] " heliocat
2021-05-27  4:58 ` [PR REVIEW] " heliocat
2021-05-27  4:58 ` heliocat
2021-05-27  5:02 ` [PR PATCH] [Updated] " heliocat
2021-05-27  5:07 ` heliocat
2021-05-27 11:20 ` ailiop-git
2021-05-27 11:24 ` ailiop-git
2021-05-27 17:42 ` heliocat
2021-05-27 22:26 ` heliocat
2021-05-28  7:27 ` the-maldridge
2021-05-28  7:30 ` heliocat
2021-05-28  7:32 ` heliocat
2021-05-28  9:00 ` ailiop-git
2021-05-28 18:31 ` heliocat
2021-06-07 15:48 ` heliocat
2021-06-10  4:38 ` [PR PATCH] [Updated] " heliocat
2021-06-18  6:25 ` heliocat
2022-05-20  2:12 ` github-actions
2022-06-04  2:08 ` github-actions [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220604020851.O6VTsdPBk5B58BH9HVts-eujYW1Z39G1LdHhl_xCqYA@z \
    --to=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).