Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] [WIP] New package: ydotool-0.2.0
@ 2021-06-01  3:13 noarchwastaken
  2021-06-02  7:57 ` steinex
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: noarchwastaken @ 2021-06-01  3:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2197 bytes --]

There is a new pull request by noarchwastaken against master on the void-packages repository

https://github.com/noarchwastaken/void-packages ydotool
https://github.com/void-linux/void-packages/pull/31237

[WIP] New package: ydotool-0.2.0
It seems like the package uses CPM in its CMake config for statically linking `libevdevPlus` and `libuInputPlus`, both are versioned newer than the existing ones in Void, with breaking changes. There's another dependency called `IODash` which doesn't exist in Void yet.

Is it OK to simply use CPM? Or should we update the first two and add the last one into Void, then build with those? Pinging @steinex for opinions.

We already have #25341, but it's an older version and apparently have some unfixed problems... So I wish this is a friendly takeover of that PR.

closes #31163

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31237.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ydotool-31237.patch --]
[-- Type: text/x-diff, Size: 2187 bytes --]

From 8c9e8620b3a085af8a908c8004cc5b50bd8ea140 Mon Sep 17 00:00:00 2001
From: noarchwastaken <noarch@n0ar.ch>
Date: Mon, 31 May 2021 22:27:36 -0400
Subject: [PATCH] New package: ydotool-0.2.0

---
 srcpkgs/ydotool/files/80-uinput.rules |  3 +++
 srcpkgs/ydotool/files/ydotoold/run    |  2 ++
 srcpkgs/ydotool/template              | 31 +++++++++++++++++++++++++++
 3 files changed, 36 insertions(+)
 create mode 100644 srcpkgs/ydotool/files/80-uinput.rules
 create mode 100644 srcpkgs/ydotool/files/ydotoold/run
 create mode 100644 srcpkgs/ydotool/template

diff --git a/srcpkgs/ydotool/files/80-uinput.rules b/srcpkgs/ydotool/files/80-uinput.rules
new file mode 100644
index 000000000000..988d34547f52
--- /dev/null
+++ b/srcpkgs/ydotool/files/80-uinput.rules
@@ -0,0 +1,3 @@
+## ydotoold fix
+## https://github.com/ReimuNotMoe/ydotool/issues/25#issuecomment-535842993
+KERNEL=="uinput", GROUP="input", MODE="0660", OPTIONS+="static_node=uinput"
diff --git a/srcpkgs/ydotool/files/ydotoold/run b/srcpkgs/ydotool/files/ydotoold/run
new file mode 100644
index 000000000000..2425089b3bea
--- /dev/null
+++ b/srcpkgs/ydotool/files/ydotoold/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec chpst -u root:input ydotoold --socket-perm 660 2>&1
diff --git a/srcpkgs/ydotool/template b/srcpkgs/ydotool/template
new file mode 100644
index 000000000000..50aa368cb35f
--- /dev/null
+++ b/srcpkgs/ydotool/template
@@ -0,0 +1,31 @@
+# Template file for 'ydotool'
+pkgname=ydotool
+version=0.2.0
+revision=1
+build_style=cmake
+hostmakedepends="git scdoc"
+short_desc="Generic command-line automation tool, works on Wayland and X11"
+maintainer="noarchwastaken <noarch@n0ar.ch>"
+license="AGPL-3.0-or-later"
+homepage="https://github.com/ReimuNotMoe/ydotool"
+distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+checksum=2311b003d2ff383f3348f17101f0df74f56616d530d66d0a014a52ba85a5dcf1
+
+do_install() {
+	vbin build/ydotool
+	vbin build/ydotoold
+}
+
+post_install() {
+	vsv ydotoold
+
+	vinstall ${FILESDIR}/80-uinput.rules 644 usr/lib/udev/rules.d
+
+	scdoc < manpage/ydotool.1.scd > ydotool.1
+	scdoc < manpage/ydotoold.8.scd > ydotoold.8
+
+	vman ydotool.1
+	vman ydotoold.8
+
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [WIP] New package: ydotool-0.2.0
  2021-06-01  3:13 [PR PATCH] [WIP] New package: ydotool-0.2.0 noarchwastaken
@ 2021-06-02  7:57 ` steinex
  2021-06-02 20:45 ` noarchwastaken
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: steinex @ 2021-06-02  7:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/31237#issuecomment-852826949

Comment:
Updating `libevdevPlus` and `libuInputPlus` is fine, there are no packages in the repo currently which depend on these. I guess I added them back in the day to package ydotool and then left Wayland, so feel free.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [WIP] New package: ydotool-0.2.0
  2021-06-01  3:13 [PR PATCH] [WIP] New package: ydotool-0.2.0 noarchwastaken
  2021-06-02  7:57 ` steinex
@ 2021-06-02 20:45 ` noarchwastaken
  2021-06-02 21:00 ` noarchwastaken
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: noarchwastaken @ 2021-06-02 20:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

New comment by noarchwastaken on void-packages repository

https://github.com/void-linux/void-packages/pull/31237#issuecomment-853370978

Comment:
> Updating `libevdevPlus` and `libuInputPlus` is fine, there are no packages in the repo currently which depend on these. I guess I added them back in the day to package ydotool and then left Wayland, so feel free.

The problem is that both of them became static libraries now... I don't think that there's a point to package them anymore.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [WIP] New package: ydotool-0.2.0
  2021-06-01  3:13 [PR PATCH] [WIP] New package: ydotool-0.2.0 noarchwastaken
  2021-06-02  7:57 ` steinex
  2021-06-02 20:45 ` noarchwastaken
@ 2021-06-02 21:00 ` noarchwastaken
  2021-06-03  9:58 ` steinex
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: noarchwastaken @ 2021-06-02 21:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

New comment by noarchwastaken on void-packages repository

https://github.com/void-linux/void-packages/pull/31237#issuecomment-853370978

Comment:
> Updating `libevdevPlus` and `libuInputPlus` is fine, there are no packages in the repo currently which depend on these. I guess I added them back in the day to package ydotool and then left Wayland, so feel free.

The problem is that both of them became static libraries now... I don't see a point to package them anymore.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [WIP] New package: ydotool-0.2.0
  2021-06-01  3:13 [PR PATCH] [WIP] New package: ydotool-0.2.0 noarchwastaken
                   ` (2 preceding siblings ...)
  2021-06-02 21:00 ` noarchwastaken
@ 2021-06-03  9:58 ` steinex
  2021-06-06 22:30 ` [PR PATCH] [Updated] " noarchwastaken
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: steinex @ 2021-06-03  9:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/31237#issuecomment-853746843

Comment:
I'll leave it to the team to decide if it's fine to use CPM. If they agree, I'm fine with removing `libevdevPlus` / `libuInputPlus` altogether. 👍

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] [WIP] New package: ydotool-0.2.0
  2021-06-01  3:13 [PR PATCH] [WIP] New package: ydotool-0.2.0 noarchwastaken
                   ` (3 preceding siblings ...)
  2021-06-03  9:58 ` steinex
@ 2021-06-06 22:30 ` noarchwastaken
  2021-06-06 22:37 ` noarchwastaken
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: noarchwastaken @ 2021-06-06 22:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2202 bytes --]

There is an updated pull request by noarchwastaken against master on the void-packages repository

https://github.com/noarchwastaken/void-packages ydotool
https://github.com/void-linux/void-packages/pull/31237

[WIP] New package: ydotool-0.2.0
It seems like the package uses CPM in its CMake config for statically linking `libevdevPlus` and `libuInputPlus`, both are versioned newer than the existing ones in Void, with breaking changes. There's another dependency called `IODash` which doesn't exist in Void yet.

Is it OK to simply use CPM? Or should we update the first two and add the last one into Void, then build with those? Pinging @steinex for opinions.

We already have #25341, but it's an older version and apparently have some unfixed problems... So I wish this is a friendly takeover of that PR.

closes #31163

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31237.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ydotool-31237.patch --]
[-- Type: text/x-diff, Size: 3254 bytes --]

From 7ec393a756daee04c1b32cf5f23d355dd176bfb1 Mon Sep 17 00:00:00 2001
From: noarchwastaken <noarch@n0ar.ch>
Date: Mon, 31 May 2021 22:27:36 -0400
Subject: [PATCH] New package: ydotool-0.2.0

---
 srcpkgs/ydotool/files/80-uinput.rules   |  3 +++
 srcpkgs/ydotool/files/iodash-musl.patch | 24 +++++++++++++++++
 srcpkgs/ydotool/files/ydotoold/run      |  2 ++
 srcpkgs/ydotool/template                | 36 +++++++++++++++++++++++++
 4 files changed, 65 insertions(+)
 create mode 100644 srcpkgs/ydotool/files/80-uinput.rules
 create mode 100644 srcpkgs/ydotool/files/iodash-musl.patch
 create mode 100644 srcpkgs/ydotool/files/ydotoold/run
 create mode 100644 srcpkgs/ydotool/template

diff --git a/srcpkgs/ydotool/files/80-uinput.rules b/srcpkgs/ydotool/files/80-uinput.rules
new file mode 100644
index 000000000000..988d34547f52
--- /dev/null
+++ b/srcpkgs/ydotool/files/80-uinput.rules
@@ -0,0 +1,3 @@
+## ydotoold fix
+## https://github.com/ReimuNotMoe/ydotool/issues/25#issuecomment-535842993
+KERNEL=="uinput", GROUP="input", MODE="0660", OPTIONS+="static_node=uinput"
diff --git a/srcpkgs/ydotool/files/iodash-musl.patch b/srcpkgs/ydotool/files/iodash-musl.patch
new file mode 100644
index 000000000000..d6a599927d14
--- /dev/null
+++ b/srcpkgs/ydotool/files/iodash-musl.patch
@@ -0,0 +1,24 @@
+upstream PR: https://github.com/YukiWorkshop/IODash/pull/3
+
+--- build/_deps/iodash-src/IODash/Serial.hpp
++++ build/_deps/iodash-src/IODash/Serial.hpp
+@@ -16,6 +16,7 @@
+ #include <system_error>
+ #include <unordered_map>
+ 
++#include <asm/ioctls.h>
+ #include <sys/ioctl.h>
+ 
+ #ifdef __linux__
+
+--- build/_deps/iodash-src/IODash/SocketAddress.hpp
++++ build/_deps/iodash-src/IODash/SocketAddress.hpp
+@@ -18,6 +18,7 @@
+ #include <vector>
+ 
+ #include <cinttypes>
++#include <cstring>
+ 
+ #include <sys/types.h>
+ #include <sys/socket.h>
+
diff --git a/srcpkgs/ydotool/files/ydotoold/run b/srcpkgs/ydotool/files/ydotoold/run
new file mode 100644
index 000000000000..2425089b3bea
--- /dev/null
+++ b/srcpkgs/ydotool/files/ydotoold/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec chpst -u root:input ydotoold --socket-perm 660 2>&1
diff --git a/srcpkgs/ydotool/template b/srcpkgs/ydotool/template
new file mode 100644
index 000000000000..ee3dbec6e012
--- /dev/null
+++ b/srcpkgs/ydotool/template
@@ -0,0 +1,36 @@
+# Template file for 'ydotool'
+pkgname=ydotool
+version=0.2.0
+revision=1
+build_style=cmake
+hostmakedepends="git scdoc"
+short_desc="Generic command-line automation tool, works on Wayland and X11"
+maintainer="noarchwastaken <noarch@n0ar.ch>"
+license="AGPL-3.0-or-later"
+homepage="https://github.com/ReimuNotMoe/ydotool"
+distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+checksum=2311b003d2ff383f3348f17101f0df74f56616d530d66d0a014a52ba85a5dcf1
+
+# patches a dependency pulled by CPM, so it must be done after configure
+post_configure() {
+	patch -sl -Np0 -i ${FILESDIR}/iodash-musl.patch 2>/dev/null
+}
+
+do_install() {
+	vbin build/ydotool
+	vbin build/ydotoold
+}
+
+post_install() {
+	vsv ydotoold
+
+	vinstall ${FILESDIR}/80-uinput.rules 644 usr/lib/udev/rules.d
+
+	scdoc < manpage/ydotool.1.scd > ydotool.1
+	scdoc < manpage/ydotoold.8.scd > ydotoold.8
+
+	vman ydotool.1
+	vman ydotoold.8
+
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: ydotool-0.2.0
  2021-06-01  3:13 [PR PATCH] [WIP] New package: ydotool-0.2.0 noarchwastaken
                   ` (4 preceding siblings ...)
  2021-06-06 22:30 ` [PR PATCH] [Updated] " noarchwastaken
@ 2021-06-06 22:37 ` noarchwastaken
  2021-06-06 23:14 ` [PR PATCH] [Updated] " noarchwastaken
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: noarchwastaken @ 2021-06-06 22:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

New comment by noarchwastaken on void-packages repository

https://github.com/void-linux/void-packages/pull/31237#issuecomment-855473860

Comment:
I fixed the musl build problem, and this package is ready for review!

Note that it statically links against dependencies on CPM. It looks like we accept this for other languages like Rust and Go (static linking against external packages), so I guess it's fine here...

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: ydotool-0.2.0
  2021-06-01  3:13 [PR PATCH] [WIP] New package: ydotool-0.2.0 noarchwastaken
                   ` (5 preceding siblings ...)
  2021-06-06 22:37 ` noarchwastaken
@ 2021-06-06 23:14 ` noarchwastaken
  2021-06-06 23:21 ` noarchwastaken
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: noarchwastaken @ 2021-06-06 23:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2196 bytes --]

There is an updated pull request by noarchwastaken against master on the void-packages repository

https://github.com/noarchwastaken/void-packages ydotool
https://github.com/void-linux/void-packages/pull/31237

New package: ydotool-0.2.0
It seems like the package uses CPM in its CMake config for statically linking `libevdevPlus` and `libuInputPlus`, both are versioned newer than the existing ones in Void, with breaking changes. There's another dependency called `IODash` which doesn't exist in Void yet.

Is it OK to simply use CPM? Or should we update the first two and add the last one into Void, then build with those? Pinging @steinex for opinions.

We already have #25341, but it's an older version and apparently have some unfixed problems... So I wish this is a friendly takeover of that PR.

closes #31163

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31237.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ydotool-31237.patch --]
[-- Type: text/x-diff, Size: 3313 bytes --]

From 0e753257baf59aa0485ec6db13cd66485e12254b Mon Sep 17 00:00:00 2001
From: noarchwastaken <noarch@n0ar.ch>
Date: Mon, 31 May 2021 22:27:36 -0400
Subject: [PATCH] New package: ydotool-0.2.0

---
 srcpkgs/ydotool/files/80-uinput.rules   |  3 ++
 srcpkgs/ydotool/files/iodash-musl.patch | 24 +++++++++++++++
 srcpkgs/ydotool/files/ydotoold/run      |  2 ++
 srcpkgs/ydotool/template                | 39 +++++++++++++++++++++++++
 4 files changed, 68 insertions(+)
 create mode 100644 srcpkgs/ydotool/files/80-uinput.rules
 create mode 100644 srcpkgs/ydotool/files/iodash-musl.patch
 create mode 100644 srcpkgs/ydotool/files/ydotoold/run
 create mode 100644 srcpkgs/ydotool/template

diff --git a/srcpkgs/ydotool/files/80-uinput.rules b/srcpkgs/ydotool/files/80-uinput.rules
new file mode 100644
index 000000000000..988d34547f52
--- /dev/null
+++ b/srcpkgs/ydotool/files/80-uinput.rules
@@ -0,0 +1,3 @@
+## ydotoold fix
+## https://github.com/ReimuNotMoe/ydotool/issues/25#issuecomment-535842993
+KERNEL=="uinput", GROUP="input", MODE="0660", OPTIONS+="static_node=uinput"
diff --git a/srcpkgs/ydotool/files/iodash-musl.patch b/srcpkgs/ydotool/files/iodash-musl.patch
new file mode 100644
index 000000000000..d6a599927d14
--- /dev/null
+++ b/srcpkgs/ydotool/files/iodash-musl.patch
@@ -0,0 +1,24 @@
+upstream PR: https://github.com/YukiWorkshop/IODash/pull/3
+
+--- build/_deps/iodash-src/IODash/Serial.hpp
++++ build/_deps/iodash-src/IODash/Serial.hpp
+@@ -16,6 +16,7 @@
+ #include <system_error>
+ #include <unordered_map>
+ 
++#include <asm/ioctls.h>
+ #include <sys/ioctl.h>
+ 
+ #ifdef __linux__
+
+--- build/_deps/iodash-src/IODash/SocketAddress.hpp
++++ build/_deps/iodash-src/IODash/SocketAddress.hpp
+@@ -18,6 +18,7 @@
+ #include <vector>
+ 
+ #include <cinttypes>
++#include <cstring>
+ 
+ #include <sys/types.h>
+ #include <sys/socket.h>
+
diff --git a/srcpkgs/ydotool/files/ydotoold/run b/srcpkgs/ydotool/files/ydotoold/run
new file mode 100644
index 000000000000..b9dc8c51bc2f
--- /dev/null
+++ b/srcpkgs/ydotool/files/ydotoold/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec chpst -u _ydotoold:input ydotoold --socket-perm 660 2>&1
diff --git a/srcpkgs/ydotool/template b/srcpkgs/ydotool/template
new file mode 100644
index 000000000000..09820095ef81
--- /dev/null
+++ b/srcpkgs/ydotool/template
@@ -0,0 +1,39 @@
+# Template file for 'ydotool'
+pkgname=ydotool
+version=0.2.0
+revision=1
+build_style=cmake
+hostmakedepends="git scdoc"
+short_desc="Generic command-line automation tool, works on Wayland and X11"
+maintainer="noarchwastaken <noarch@n0ar.ch>"
+license="AGPL-3.0-or-later"
+homepage="https://github.com/ReimuNotMoe/ydotool"
+distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+checksum=2311b003d2ff383f3348f17101f0df74f56616d530d66d0a014a52ba85a5dcf1
+
+system_accounts="_ydotoold"
+_ydotoold_groups="input"
+
+# patches a dependency pulled by CPM, so it must be done after configure
+post_configure() {
+	patch -sl -Np0 -i ${FILESDIR}/iodash-musl.patch 2>/dev/null
+}
+
+do_install() {
+	vbin build/ydotool
+	vbin build/ydotoold
+}
+
+post_install() {
+	vsv ydotoold
+
+	vinstall ${FILESDIR}/80-uinput.rules 644 usr/lib/udev/rules.d
+
+	scdoc < manpage/ydotool.1.scd > ydotool.1
+	scdoc < manpage/ydotoold.8.scd > ydotoold.8
+
+	vman ydotool.1
+	vman ydotoold.8
+
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: ydotool-0.2.0
  2021-06-01  3:13 [PR PATCH] [WIP] New package: ydotool-0.2.0 noarchwastaken
                   ` (6 preceding siblings ...)
  2021-06-06 23:14 ` [PR PATCH] [Updated] " noarchwastaken
@ 2021-06-06 23:21 ` noarchwastaken
  2021-07-21  3:47 ` [PR REVIEW] " ericonr
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: noarchwastaken @ 2021-06-06 23:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

New comment by noarchwastaken on void-packages repository

https://github.com/void-linux/void-packages/pull/31237#issuecomment-855473860

Comment:
I fixed the musl build problem, and this package is ready for review!

Note that it statically links against dependencies with CPM. It looks like we accept this for other languages like Rust and Go (static linking against external packages), so I guess it's fine here...

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: ydotool-0.2.0
  2021-06-01  3:13 [PR PATCH] [WIP] New package: ydotool-0.2.0 noarchwastaken
                   ` (7 preceding siblings ...)
  2021-06-06 23:21 ` noarchwastaken
@ 2021-07-21  3:47 ` ericonr
  2022-05-21  2:00 ` github-actions
  2022-06-04  2:09 ` [PR PATCH] [Closed]: " github-actions
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-07-21  3:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31237#discussion_r673639329

Comment:
CPM shouldn't be allowed to pull in dependencies. You need to manually download the tarball or package the dependency.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: ydotool-0.2.0
  2021-06-01  3:13 [PR PATCH] [WIP] New package: ydotool-0.2.0 noarchwastaken
                   ` (8 preceding siblings ...)
  2021-07-21  3:47 ` [PR REVIEW] " ericonr
@ 2022-05-21  2:00 ` github-actions
  2022-06-04  2:09 ` [PR PATCH] [Closed]: " github-actions
  10 siblings, 0 replies; 12+ messages in thread
From: github-actions @ 2022-05-21  2:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/31237#issuecomment-1133500124

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Closed]: New package: ydotool-0.2.0
  2021-06-01  3:13 [PR PATCH] [WIP] New package: ydotool-0.2.0 noarchwastaken
                   ` (9 preceding siblings ...)
  2022-05-21  2:00 ` github-actions
@ 2022-06-04  2:09 ` github-actions
  10 siblings, 0 replies; 12+ messages in thread
From: github-actions @ 2022-06-04  2:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2026 bytes --]

There's a closed pull request on the void-packages repository

New package: ydotool-0.2.0
https://github.com/void-linux/void-packages/pull/31237

Description:
It seems like the package uses CPM in its CMake config for statically linking `libevdevPlus` and `libuInputPlus`, both are versioned newer than the existing ones in Void, with breaking changes. There's another dependency called `IODash` which doesn't exist in Void yet.

Is it OK to simply use CPM? Or should we update the first two and add the last one into Void, then build with those? Pinging @steinex for opinions.

We already have #25341, but it's an older version and apparently have some unfixed problems... So I wish this is a friendly takeover of that PR.

closes #31163

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-06-04  2:09 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01  3:13 [PR PATCH] [WIP] New package: ydotool-0.2.0 noarchwastaken
2021-06-02  7:57 ` steinex
2021-06-02 20:45 ` noarchwastaken
2021-06-02 21:00 ` noarchwastaken
2021-06-03  9:58 ` steinex
2021-06-06 22:30 ` [PR PATCH] [Updated] " noarchwastaken
2021-06-06 22:37 ` noarchwastaken
2021-06-06 23:14 ` [PR PATCH] [Updated] " noarchwastaken
2021-06-06 23:21 ` noarchwastaken
2021-07-21  3:47 ` [PR REVIEW] " ericonr
2022-05-21  2:00 ` github-actions
2022-06-04  2:09 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).