[PR PATCH] New package: zam-plugins-3.14

[PR PATCH] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

There is a new pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages zam-plugins
https://github.com/void-linux/void-packages/pull/31665

New package: zam-plugins-3.14
<!-- Mark items with [x] where applicable -->

Required for `pulseeffects` Maximizer effect.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zam-plugins-31665.patch --]
[-- Type: text/x-diff, Size: 7283 bytes --]

From f5c434827c21280b4fabaf9fae55360292b5cb3c Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Sat, 26 Jun 2021 04:00:10 +0300
Subject: [PATCH] New package: zam-plugins-3.14

---
 .../zam-plugins/files/zam-plugins.directory   |   5 +
 srcpkgs/zam-plugins/files/zam-plugins.menu    |  30 +++++
 srcpkgs/zam-plugins/template                  | 103 ++++++++++++++++++
 3 files changed, 138 insertions(+)
 create mode 100644 srcpkgs/zam-plugins/files/zam-plugins.directory
 create mode 100644 srcpkgs/zam-plugins/files/zam-plugins.menu
 create mode 100644 srcpkgs/zam-plugins/template

diff --git a/srcpkgs/zam-plugins/files/zam-plugins.directory b/srcpkgs/zam-plugins/files/zam-plugins.directory
new file mode 100644
index 000000000000..df902aee57a8
--- /dev/null
+++ b/srcpkgs/zam-plugins/files/zam-plugins.directory
@@ -0,0 +1,5 @@
+[Desktop Entry]
+Name=zam-plugins
+Icon=zam-plugins
+Type=Directory
+Keywords=audio;sound;jackd;zam-plugins;
diff --git a/srcpkgs/zam-plugins/files/zam-plugins.menu b/srcpkgs/zam-plugins/files/zam-plugins.menu
new file mode 100644
index 000000000000..85963cd12796
--- /dev/null
+++ b/srcpkgs/zam-plugins/files/zam-plugins.menu
@@ -0,0 +1,30 @@
+<!DOCTYPE Menu PUBLIC "-//freedesktop//DTD Menu 1.0//EN" "http://www.freedesktop.org/standards/menu-spec/menu-1.0.dtd">
+<Menu>
+  <Name>Applications</Name>
+  <Menu>
+    <Name>Multimedia</Name>
+    <Menu>
+      <Name>zam-plugins</Name>
+      <Directory>zam-plugins.directory</Directory>
+      <Include>
+        <Filename>com.zamaudio.zamautosat.desktop</Filename>
+        <Filename>com.zamaudio.zamaximx2.desktop</Filename>
+        <Filename>com.zamaudio.zamcomp.desktop</Filename>
+        <Filename>com.zamaudio.zamcompx2.desktop</Filename>
+        <Filename>com.zamaudio.zamdelay.desktop</Filename>
+        <Filename>com.zamaudio.zamdynamiceq.desktop</Filename>
+        <Filename>com.zamaudio.zameq2.desktop</Filename>
+        <Filename>com.zamaudio.zamgate.desktop</Filename>
+        <Filename>com.zamaudio.zamgatex2.desktop</Filename>
+        <Filename>com.zamaudio.zamgeq31.desktop</Filename>
+        <Filename>com.zamaudio.zamgrains.desktop</Filename>
+        <Filename>com.zamaudio.zamheadx2.desktop</Filename>
+        <Filename>com.zamaudio.zammulticompx2.desktop</Filename>
+        <Filename>com.zamaudio.zamphono.desktop</Filename>
+        <Filename>com.zamaudio.zamtube.desktop</Filename>
+        <Filename>com.zamaudio.zamulticomp.desktop</Filename>
+        <Filename>com.zamaudio.zamverb.desktop</Filename>
+      </Include>
+    </Menu>
+  </Menu>
+</Menu>
diff --git a/srcpkgs/zam-plugins/template b/srcpkgs/zam-plugins/template
new file mode 100644
index 000000000000..383b3105d6b0
--- /dev/null
+++ b/srcpkgs/zam-plugins/template
@@ -0,0 +1,103 @@
+# Template file for 'zam-plugins'
+pkgname=zam-plugins
+version=3.14
+revision=1
+build_style=gnu-makefile
+make_use_env=yes
+make_build_args="HAVE_ZITA_CONVOLVER=true"
+hostmakedepends="pkgconf git gendesk"
+makedepends="libX11-devel libglvnd-devel liblo-devel jack-devel ladspa-sdk
+ libsamplerate-devel zita-convolver-devel"
+# Use system zita-convolver instead of the vendored one
+short_desc="LADSPA/LV2/VST/JACK audio plugins for high-quality processing"
+maintainer="Artur Sinila <freesoftware@logarithmus.dev>"
+license="GPL-2.0-or-later"
+homepage="http://zamaudio.com/"
+changelog="https://github.com/zamaudio/zam-plugins/blob/${version}/changelog"
+
+do_fetch() {
+	git clone --depth 1 --branch ${version} --single-branch \
+	--recurse-submodules --shallow-submodules https://github.com/zamaudio/zam-plugins \
+	zam-plugins-${version}
+}
+
+# Huge thanks to David Runge <dvzrv@archlinux.org>, maintainer of zam-plugins in Arch Linux
+post_install() {
+	_names=('zamaximx2' 'zamulticomp' 'zammulticompx2' 'zamautosat' 'zamcomp'
+		'zamcompx2' 'zamdelay' 'zamdynamiceq' 'zameq2' 'zamgeq31' 'zamgate'
+		'zamgatex2' 'zamgrains' 'zamheadx2' 'zamphono' 'zamtube' 'zamverb')
+
+	declare -A exec_names=(
+		["zamaximx2"]="ZaMaximX2"
+		["zamulticomp"]="ZaMultiComp"
+		["zamulticompx2"]="ZaMultiCompX2"
+		["zamautosat"]="ZamAutoSat"
+		["zamcomp"]="ZamComp"
+		["zamcompx2"]="ZamCompX2"
+		["zamdelay"]="ZamDelay"
+		["zamdynamiceq"]="ZamDynamicEQ"
+		["zameq2"]="ZamEQ2"
+		["zamgeq31"]="ZamGEQ31"
+		["zamgate"]="ZamGate"
+		["zamgatex2"]="ZamGateX2"
+		["zamgrains"]="ZamGrains"
+		["zamheadx2"]="ZamHeadX2"
+		["zamphono"]="ZamPhono"
+		["zamtube"]="ZamTube"
+		["zamverb"]="ZamVerb"
+	)
+	declare -A comments=(
+		["zamaximx2"]="Acts as a brickwall limiter for mastering in its default state, but can also be tweaked to raise the average level as a stereo maximizer without ever clipping"
+		["zamulticomp"]="Mono multiband compressor, with 3 adjustable bands."
+		["zamulticompx2"]="Stereo version of ZaMultiComp, with individual threshold controls for each band and real-time visualisation of comp curves."
+		["zamautosat"]="An automatic saturation plugin, has been known to provide smooth levelling to live mic channels."
+		["zamcomp"]="A powerful mono compressor strip"
+		["zamcompx2"]="Stereo version of ZamComp with knee slew control"
+		["zamdelay"]="A simple feedback delay unit with sync-to-host BPM feature and filter."
+		["zamdynamiceq"]="A dynamic equalizer that changes its gain based on detecting a narrow band of frequencies."
+		["zameq2"]="Two band parametric equaliser with high and low shelving circuits."
+		["zamgeq31"]="31 band graphic equaliser, good for eq of live spaces, removing unwanted noise from a track etc."
+		["zamgate"]="Gate plugin for ducking low gain sounds."
+		["zamgatex2"]="Gate plugin for ducking low gain sounds, stereo version."
+		["zamgrains"]="Granular Synthesizer"
+		["zamheadx2"]="HRTF acoustic filtering plugin for directional sound."
+		["zamphono"]="A collection of phono filters for restoring vinyl records, or preparing to cut new ones."
+		["zamtube"]="Wave digital filter physical model of a triode tube amplifier stage, with modelled tone stacks from real guitar amplifiers"
+		["zamverb"]="Reverb"
+	)
+	declare -A generic=(
+		["zamaximx2"]="Maximizer and brickwall limiter"
+		["zamulticomp"]="Mono Multiband Compressor"
+		["zamulticompx2"]="Stereo Multiband Compressor"
+		["zamautosat"]="Automatic Saturation"
+		["zamcomp"]="Mono Compressor"
+		["zamcompx2"]="Stereo Compressor"
+		["zamdelay"]="Delay"
+		["zamdynamiceq"]="Dynamic Equalizer"
+		["zameq2"]="2 Band Parametric Equalizer"
+		["zamgeq31"]="31 Band Graphic Equalizer"
+		["zamgate"]="Mono Gate"
+		["zamgatex2"]="Stereo Gate"
+		["zamgrains"]="Granular Synthesizer"
+		["zamheadx2"]="HRTF Acoustic Filtering"
+		["zamphono"]="Phono Filters"
+		["zamtube"]="Tube Amplifier"
+		["zamverb"]="Reverb"
+	)
+
+	# Generate *.desktop files for each plugin
+	for name in "${_names[@]}"; do
+		gendesk -n \
+			--pkgname "com.zamaudio.${name}" \
+			--name "${name}" \
+			--exec "${exec_names[$name]}" \
+			--pkgdesc "${comments[$name]}" \
+			--genericname "${generic[$name]}"
+	done
+
+	install -vDm 644 *.desktop -t ${DESTDIR}/usr/share/applications/
+	vinstall ${FILESDIR}/zam-plugins.directory 644 usr/share/desktop-directories/
+	vinstall ${FILESDIR}/zam-plugins.menu 644 etc/xdg/menus/applications-merged/
+	vdoc README.md
+	vdoc changelog
+}

Re: [PR REVIEW] New package: zam-plugins-3.14

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659214506

Comment:
We use `pkg-config` always.

Re: [PR REVIEW] New package: zam-plugins-3.14

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659214583

Comment:
And this one? Vendoring in such stuff doesn't make sense, improve upstream to make them ship this stuff instead.

Re: [PR REVIEW] New package: zam-plugins-3.14

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659214780

Comment:
Again, upstream should provide a makefile and/or script, having this logic in template is insanity.

Make upstream handle their side of business, packagers shouldn't have to implement this. Also this should go in `post_build`.

Re: [PR REVIEW] New package: zam-plugins-3.14

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659214530

Comment:
Don't they provide this file?

Re: [PR REVIEW] New package: zam-plugins-3.14

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659214704

Comment:
It should be possible to download tarballs for all submodules or ask them to publish useful tarballs. Cloning a branch name is susceptible to force pushes and you should use commit hashes instead.

If there are too many submodules, reconsider if this is really packageable.

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659342213

Comment:
They don't provide it. I've taken this file from Arch Linux package, and credited it's maintainer in `template`.

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659342258

Comment:
See https://github.com/void-linux/void-packages/pull/31665#discussion_r659342213

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659342539

Comment:
OK, I'll remove it from the package and create a PR in upstream repo when I'll have time for that.

Re: [PR PATCH] [Updated] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

There is an updated pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages zam-plugins
https://github.com/void-linux/void-packages/pull/31665

New package: zam-plugins-3.14
<!-- Mark items with [x] where applicable -->

Required by `pulseeffects` maximizer effect.
Blocked by https://github.com/void-linux/void-packages/pull/31666.

TODO: fix cross-compilation.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zam-plugins-31665.patch --]
[-- Type: text/x-diff, Size: 3661 bytes --]

From c0f51cbe9d6911eedc9133ed670a2d32238ecd98 Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Sat, 26 Jun 2021 04:00:10 +0300
Subject: [PATCH] New package: zam-plugins-3.14

---
 .../zam-plugins/files/zam-plugins.directory   |  5 ++++
 srcpkgs/zam-plugins/files/zam-plugins.menu    | 30 +++++++++++++++++++
 srcpkgs/zam-plugins/template                  | 22 ++++++++++++++
 3 files changed, 57 insertions(+)
 create mode 100644 srcpkgs/zam-plugins/files/zam-plugins.directory
 create mode 100644 srcpkgs/zam-plugins/files/zam-plugins.menu
 create mode 100644 srcpkgs/zam-plugins/template

diff --git a/srcpkgs/zam-plugins/files/zam-plugins.directory b/srcpkgs/zam-plugins/files/zam-plugins.directory
new file mode 100644
index 000000000000..df902aee57a8
--- /dev/null
+++ b/srcpkgs/zam-plugins/files/zam-plugins.directory
@@ -0,0 +1,5 @@
+[Desktop Entry]
+Name=zam-plugins
+Icon=zam-plugins
+Type=Directory
+Keywords=audio;sound;jackd;zam-plugins;
diff --git a/srcpkgs/zam-plugins/files/zam-plugins.menu b/srcpkgs/zam-plugins/files/zam-plugins.menu
new file mode 100644
index 000000000000..85963cd12796
--- /dev/null
+++ b/srcpkgs/zam-plugins/files/zam-plugins.menu
@@ -0,0 +1,30 @@
+<!DOCTYPE Menu PUBLIC "-//freedesktop//DTD Menu 1.0//EN" "http://www.freedesktop.org/standards/menu-spec/menu-1.0.dtd">
+<Menu>
+  <Name>Applications</Name>
+  <Menu>
+    <Name>Multimedia</Name>
+    <Menu>
+      <Name>zam-plugins</Name>
+      <Directory>zam-plugins.directory</Directory>
+      <Include>
+        <Filename>com.zamaudio.zamautosat.desktop</Filename>
+        <Filename>com.zamaudio.zamaximx2.desktop</Filename>
+        <Filename>com.zamaudio.zamcomp.desktop</Filename>
+        <Filename>com.zamaudio.zamcompx2.desktop</Filename>
+        <Filename>com.zamaudio.zamdelay.desktop</Filename>
+        <Filename>com.zamaudio.zamdynamiceq.desktop</Filename>
+        <Filename>com.zamaudio.zameq2.desktop</Filename>
+        <Filename>com.zamaudio.zamgate.desktop</Filename>
+        <Filename>com.zamaudio.zamgatex2.desktop</Filename>
+        <Filename>com.zamaudio.zamgeq31.desktop</Filename>
+        <Filename>com.zamaudio.zamgrains.desktop</Filename>
+        <Filename>com.zamaudio.zamheadx2.desktop</Filename>
+        <Filename>com.zamaudio.zammulticompx2.desktop</Filename>
+        <Filename>com.zamaudio.zamphono.desktop</Filename>
+        <Filename>com.zamaudio.zamtube.desktop</Filename>
+        <Filename>com.zamaudio.zamulticomp.desktop</Filename>
+        <Filename>com.zamaudio.zamverb.desktop</Filename>
+      </Include>
+    </Menu>
+  </Menu>
+</Menu>
diff --git a/srcpkgs/zam-plugins/template b/srcpkgs/zam-plugins/template
new file mode 100644
index 000000000000..6f81c755d5ff
--- /dev/null
+++ b/srcpkgs/zam-plugins/template
@@ -0,0 +1,22 @@
+# Template file for 'zam-plugins'
+pkgname=zam-plugins
+version=3.14
+revision=1
+build_style=gnu-makefile
+make_use_env=yes
+make_build_args="HAVE_ZITA_CONVOLVER=true"
+hostmakedepends="pkgconf git gendesk"
+makedepends="libX11-devel libglvnd-devel liblo-devel jack-devel ladspa-sdk
+ libsamplerate-devel zita-convolver-devel"
+# Use system zita-convolver instead of the vendored one
+short_desc="LADSPA/LV2/VST/JACK audio plugins for high-quality processing"
+maintainer="Artur Sinila <freesoftware@logarithmus.dev>"
+license="GPL-2.0-or-later"
+homepage="http://zamaudio.com/"
+changelog="https://raw.githubusercontent.com/zamaudio/zam-plugins/master/changelog"
+
+do_fetch() {
+	git clone --depth 1 --branch ${version} --single-branch \
+	--recurse-submodules --shallow-submodules https://github.com/zamaudio/zam-plugins \
+	zam-plugins-${version}
+}

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659348039

Comment:
> It should be possible to download tarballs for all submodules or ask them to publish useful tarballs. Cloning a branch name is susceptible to force pushes and you should use commit hashes instead.

There isn't any difference between shallow-cloning a tag vs. downloading it in a tarball.
Specially for this case I've just conducted a little experiment to proof that force pushing doesn't alter a commit hash to which tag points to: https://github.com/Logarithmus/test-tag-force-push

> If there are too many submodules, reconsider if this is really packageable.

I don't really see why having submodules is an issue for being packageable. And please don't insist it's a distro policy to have no submodules. There are too many hidden "distro policies", don't you think? Why those policies are nowhere documented? Please, put them into `CONTRIBUTING.md` to avoid further misunderstandings.

AFAIK this package has a single submodule, which is not a problem even if your points were true.

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659348039

Comment:
> It should be possible to download tarballs for all submodules or ask them to publish useful tarballs. Cloning a branch name is susceptible to force pushes and you should use commit hashes instead.

There isn't any difference between shallow-cloning a tag vs. downloading it in a tarball.
Specially for this case I've just conducted a little experiment to proof that force pushing doesn't alter a commit hash to which tag points to: https://github.com/Logarithmus/test-tag-force-push

> If there are too many submodules, reconsider if this is really packageable.

I don't really see why having submodules is an issue for being packageable. And please don't insist it's a distro policy to have no submodules. There are too many hidden "distro policies", don't you think? Why those policies are nowhere documented? Please, put them into `CONTRIBUTING.md` to avoid further misunderstandings.

AFAIK this package has a single submodule, which makes your complains even more irrelevant.

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659348039

Comment:
> It should be possible to download tarballs for all submodules or ask them to publish useful tarballs. Cloning a branch name is susceptible to force pushes and you should use commit hashes instead.

There isn't any difference between shallow-cloning a tag vs. downloading it in a tarball.
Specially for this case I've just conducted a little experiment to proof that force pushing doesn't alter a commit hash to which tag points to: https://github.com/Logarithmus/test-tag-force-push

> If there are too many submodules, reconsider if this is really packageable.

I don't really see why having submodules is an issue for being packageable. And please don't insist it's a distro policy to have no submodules. There are too many hidden "distro policies", don't you think? Why those policies are nowhere documented? Please, put them into `CONTRIBUTING.md` to avoid further misunderstandings.

AFAIK this package has a single submodule, which makes your complaints even more irrelevant.

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659348039

Comment:
> It should be possible to download tarballs for all submodules or ask them to publish useful tarballs. Cloning a branch name is susceptible to force pushes and you should use commit hashes instead.

There isn't any difference between shallow-cloning a tag vs. downloading it in a tarball.
Specially for this case I've just conducted a little experiment to proof that force pushing doesn't alter a commit hash to which tag points to: https://github.com/Logarithmus/test-tag-force-push

> If there are too many submodules, reconsider if this is really packageable.

I don't really see why having submodules is an issue for being packageable. And please don't insist it's a distro policy to have no submodules. There are too many hidden "distro policies", don't you think? Why those policies are nowhere documented? Please, put them into `CONTRIBUTING.md` to avoid further misunderstandings.

AFAIK this package has a single submodule, which makes your complaints even more irrelevant.

Yes, surely it's possibly to manually extract commit hashes of each submodule and hardcode them into `template` file and then also manually correct them after each new version is released, but why do this unneded manual work if you can just assign it to `git`?

And AFAIK GitHub doesn't allow you to download a tarball for an arbitrary commit. 

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659348039

Comment:
> It should be possible to download tarballs for all submodules or ask them to publish useful tarballs. Cloning a branch name is susceptible to force pushes and you should use commit hashes instead.

There isn't any difference between shallow-cloning a tag vs. downloading it in a tarball.
Specially for this case I've just conducted a little experiment to proof that force pushing doesn't alter a commit hash to which tag points to: https://github.com/Logarithmus/test-tag-force-push

> If there are too many submodules, reconsider if this is really packageable.

I don't really see why having submodules is an issue for being packageable. And please don't insist it's a distro policy to have no submodules. There are too many hidden "distro policies", don't you think? Why those policies are nowhere documented? Please, put them into `CONTRIBUTING.md` to avoid further misunderstandings.

AFAIK this package has a single submodule, which makes your complaints even more irrelevant.

Yes, surely it's possibly to manually extract commit hashes of each submodule and hardcode them into `template` file and then also manually correct them after each new version is released, but why do this unneded manual work if you can just assign it to `git`?

And AFAIK GitHub doesn't allow you to download a tarball for an arbitrary commit, only for a tag.  

Re: [PR PATCH] [Updated] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

There is an updated pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages zam-plugins
https://github.com/void-linux/void-packages/pull/31665

New package: zam-plugins-3.14
<!-- Mark items with [x] where applicable -->

Required by `pulseeffects` maximizer effect.
Blocked by https://github.com/void-linux/void-packages/pull/31666.

TODO: fix cross-compilation.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zam-plugins-31665.patch --]
[-- Type: text/x-diff, Size: 1405 bytes --]

From acc14a75e33c35d5a531e743ca28d56d0ce8f889 Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Sat, 26 Jun 2021 04:00:10 +0300
Subject: [PATCH] New package: zam-plugins-3.14

---
 srcpkgs/zam-plugins/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/zam-plugins/template

diff --git a/srcpkgs/zam-plugins/template b/srcpkgs/zam-plugins/template
new file mode 100644
index 000000000000..d2a09fc9bbf1
--- /dev/null
+++ b/srcpkgs/zam-plugins/template
@@ -0,0 +1,22 @@
+# Template file for 'zam-plugins'
+pkgname=zam-plugins
+version=3.14
+revision=1
+build_style=gnu-makefile
+make_use_env=yes
+make_build_args="HAVE_ZITA_CONVOLVER=true"
+hostmakedepends="pkg-config git gendesk"
+makedepends="libX11-devel libglvnd-devel liblo-devel jack-devel ladspa-sdk
+ libsamplerate-devel zita-convolver-devel"
+# Use system zita-convolver instead of the vendored one
+short_desc="LADSPA/LV2/VST/JACK audio plugins for high-quality processing"
+maintainer="Artur Sinila <freesoftware@logarithmus.dev>"
+license="GPL-2.0-or-later"
+homepage="http://zamaudio.com/"
+changelog="https://raw.githubusercontent.com/zamaudio/zam-plugins/master/changelog"
+
+do_fetch() {
+	git clone --depth 1 --branch ${version} --single-branch \
+	--recurse-submodules --shallow-submodules https://github.com/zamaudio/zam-plugins \
+	zam-plugins-${version}
+}

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659348039

Comment:
> It should be possible to download tarballs for all submodules or ask them to publish useful tarballs. Cloning a branch name is susceptible to force pushes and you should use commit hashes instead.

There isn't any difference between shallow-cloning a tag vs. downloading it in a tarball.
Specially for this case I've just conducted a little experiment to proof that force pushing doesn't alter a commit hash to which tag points to: https://github.com/Logarithmus/test-tag-force-push

> If there are too many submodules, reconsider if this is really packageable.

I don't really see why having submodules is an issue for being packageable. And please don't insist it's a distro policy to have no submodules. There are too many hidden "distro policies", don't you think? Why those policies are nowhere documented? Please, put them into `CONTRIBUTING.md` to avoid further misunderstandings.

AFAIK this package has only a single submodule, which makes your complaints even more irrelevant.

Yes, surely it's possibly to manually extract commit hashes of each submodule and hardcode them into `template` file and then also manually correct them after each new version is released, but why do this unneded manual work if you can just assign it to `git`?

And AFAIK GitHub doesn't allow you to download a tarball for an arbitrary commit, only for a tag.  

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1673 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659348039

Comment:
> It should be possible to download tarballs for all submodules or ask them to publish useful tarballs. Cloning a branch name is susceptible to force pushes and you should use commit hashes instead.

There isn't any difference between shallow-cloning a tag vs. downloading it in a tarball.
Specially for this case I've just conducted a little experiment to proof that force pushing doesn't alter a commit hash to which tag points to: https://github.com/Logarithmus/test-tag-force-push (just compare a hash of the single commit `main` branch vs. `v1.0` tag's hash, as you can see, after force push to `main` the tag's hash remained unchanged).

> If there are too many submodules, reconsider if this is really packageable.

I don't really see why having submodules is an issue for being packageable. And please don't insist it's a distro policy to have no submodules. There are too many hidden "distro policies", don't you think? Why those policies are nowhere documented? Please, put them into `CONTRIBUTING.md` to avoid further misunderstandings.

AFAIK this package has only a single submodule, which makes your complaints even more irrelevant.

Yes, surely it's possibly to manually extract commit hashes of each submodule and hardcode them into `template` file and then also manually correct them after each new version is released, but why do this unneded manual work if you can just assign it to `git`?

And AFAIK GitHub doesn't allow you to download a tarball for an arbitrary commit, only for a tag.  

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1693 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659348039

Comment:
> It should be possible to download tarballs for all submodules or ask them to publish useful tarballs. Cloning a branch name is susceptible to force pushes and you should use commit hashes instead.

There isn't any difference between shallow-cloning a tag vs. downloading it in a tarball.
Specially for this case I've just conducted a little experiment to proof that force pushing doesn't alter a commit hash to which tag points to: https://github.com/Logarithmus/test-tag-force-push (just compare a hash of the single commit `main` branch vs. `v1.0` tag's hash, as you can see, after force push to `main` the tag's hash remained unchanged, as well as tarball).

> If there are too many submodules, reconsider if this is really packageable.

I don't really see why having submodules is an issue for being packageable. And please don't insist it's a distro policy to have no submodules. There are too many hidden "distro policies", don't you think? Why those policies are nowhere documented? Please, put them into `CONTRIBUTING.md` to avoid further misunderstandings.

AFAIK this package has only a single submodule, which makes your complaints even more irrelevant.

Yes, surely it's possibly to manually extract commit hashes of each submodule and hardcode them into `template` file and then also manually correct them after each new version is released, but why do this unneded manual work if you can just assign it to `git`?

And AFAIK GitHub doesn't allow you to download a tarball for an arbitrary commit, only for a tag.  

Re: [PR REVIEW] New package: zam-plugins-3.14

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659354850

Comment:
I strongly disagree with this policy and consider it upstream's responsibility to have such files. Otherwise all distros have to carry the same mess; instead, the files should be upstreamed (and ideally installed automatically).

Re: [PR REVIEW] New package: zam-plugins-3.14

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659354863

Comment:
Same comment applies.

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659355146

Comment:
I've removed them already

Re: [PR REVIEW] New package: zam-plugins-3.14

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659356115

Comment:
> There isn't any difference between shallow-cloning a tag vs. downloading it in a tarball.

Yes there is, we have checksums for the tarball.

Package policy is documented in the Manual; many other packages use submodules by downloading each tarball and moving to the specific place.

> And AFAIK GitHub doesn't allow you to download a tarball for an arbitrary commit, only for a tag.

Did you try? We use this functionality in multiple places.

Anyhow, the issue with being "packageable" is that if writing a reasonable template is too much trouble, then it isn't packageable. It isn't that it has submodules or anything else.

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659359692

Comment:
> Yes there is, we have checksums for the tarball.

Please, read my message again. You were afraid of force pushes suddenly changing the tag contents. My little experiment proved that tag remains untouched.
**UPD** Now I've came up with this case: author deletes tag completely and then creates it again, but points it to another commit. So maybe you are right that it's better to have a hash in `template` because the package can silently break.

> Package policy is documented in the Manual; many other packages use submodules by downloading each tarball and moving to the specific place.

I don't see using `git` directly instead of tarballs being prohibited in `Manual.md`. Moreover, it documents that `do_fetch` is used to fetch sources when `distfiles` is not set. If you so strongly insist on using tarballs only, then what's the purpose of `do_fetch` then? Let's remove it altogether from `xbps-src` 

> Did you try? We use this functionality in multiple places.

Hmm... OK, looks like `https://github.com/<name>/<repo>/archive/<hash>.tar.gz` works.

> Anyhow, the issue with being "packageable" is that if writing a reasonable template is too much trouble, then it isn't packageable. It isn't that it has submodules or anything else.

There isn't any trouble in writing a template for packages with many submodules. You can just use `do_fetch` and let `git` do it's job, instead of manually copy-pasting commit hashes for each submodule every time the package updates.

Re: [PR REVIEW] New package: zam-plugins-3.14

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659360970

Comment:
Yes, I meant retagging as the main issue.

I guess someone has to document these policies, then. They do exist.

`do_fetch` can exist, but it's very much undesired. That a workaround exists for specific templates doesn't mean it should be used all the time.

And we prefer to use submodules explicitly rather than telling git to do things.

Re: [PR REVIEW] New package: zam-plugins-3.14

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659362853

Comment:
`distfiles=` are cached by xbps-src and there is no such mechanism for git/do_fetch.

Re: [PR REVIEW] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#discussion_r659363006

Comment:
@Duncaen thank you for another argument for tarballs

Re: [PR PATCH] [Updated] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

There is an updated pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages zam-plugins
https://github.com/void-linux/void-packages/pull/31665

New package: zam-plugins-3.14
<!-- Mark items with [x] where applicable -->

Required by `pulseeffects` maximizer effect.
Blocked by https://github.com/void-linux/void-packages/pull/31666.

TODO: fix cross-compilation.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zam-plugins-31665.patch --]
[-- Type: text/x-diff, Size: 1694 bytes --]

From 90a67f11740de2712608c0878e4a709dcda8fbf6 Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Sat, 26 Jun 2021 04:00:10 +0300
Subject: [PATCH] New package: zam-plugins-3.14

---
 srcpkgs/zam-plugins/template | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 srcpkgs/zam-plugins/template

diff --git a/srcpkgs/zam-plugins/template b/srcpkgs/zam-plugins/template
new file mode 100644
index 000000000000..aeb20fcfc406
--- /dev/null
+++ b/srcpkgs/zam-plugins/template
@@ -0,0 +1,27 @@
+# Template file for 'zam-plugins'
+pkgname=zam-plugins
+version=3.14
+revision=1
+create_wrksrc=yes
+build_wrksrc=${pkgname}-${version}
+build_style=gnu-makefile
+make_use_env=yes
+make_build_args="HAVE_ZITA_CONVOLVER=true"
+hostmakedepends="pkg-config git gendesk"
+makedepends="libX11-devel libglvnd-devel liblo-devel jack-devel ladspa-sdk
+ libsamplerate-devel zita-convolver-devel"
+# Use system zita-convolver instead of the vendored one
+short_desc="LADSPA/LV2/VST/JACK audio plugins for high-quality processing"
+maintainer="Artur Sinila <freesoftware@logarithmus.dev>"
+license="GPL-2.0-or-later"
+homepage="http://zamaudio.com/"
+changelog="https://raw.githubusercontent.com/zamaudio/zam-plugins/master/changelog"
+_dpf_commit="08669d1bc30c6e971fde800eade4ca40104ba8b2"
+distfiles="https://github.com/zamaudio/zam-plugins/archive/refs/tags/${version}.tar.gz
+ https://github.com/DISTRHO/DPF/archive/${_dpf_commit}.tar.gz"
+checksum="4a73a73fa03cc6d7faf2d65840349d2a33e7aaef5a13c6345f534b6c434e7b42
+ c4359020d1defb7ae2547b5dbdc0cf33f6e0e9cdd3ef75300533b4c4c9f1b9f4"
+
+post_extract() {
+	mv DPF-${_dpf_commit}/* $build_wrksrc/dpf
+}

Re: New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#issuecomment-869216151

Comment:
@ericonr I need your help. Cross builds fail because `zam-plugins` require to run `lv2_ttl_generator` which should be built for a host machine architecture instead of the target one (see [CI run](https://github.com/void-linux/void-packages/pull/31665/checks?check_run_id=2926485359#step:8:639)). How to achieve this? A stupid solution is to replace `$(CC) -> gcc` in [this file](https://github.com/DISTRHO/DPF/blob/08669d1bc30c6e971fde800eade4ca40104ba8b2/utils/lv2-ttl-generator/GNUmakefile), how to do it right?

Re: [PR PATCH] [Updated] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

There is an updated pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages zam-plugins
https://github.com/void-linux/void-packages/pull/31665

New package: zam-plugins-3.14
<!-- Mark items with [x] where applicable -->

Required by `pulseeffects` maximizer effect.
Blocked by https://github.com/void-linux/void-packages/pull/31666.

TODO: fix cross-compilation.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zam-plugins-31665.patch --]
[-- Type: text/x-diff, Size: 2424 bytes --]

From c0bf59e0933c1a1222c5df86ff648bedb9d58235 Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Sat, 26 Jun 2021 04:00:10 +0300
Subject: [PATCH] New package: zam-plugins-3.14

---
 .../zam-plugins/patches/00-fix-cross.patch    | 11 ++++++++
 srcpkgs/zam-plugins/template                  | 28 +++++++++++++++++++
 2 files changed, 39 insertions(+)
 create mode 100644 srcpkgs/zam-plugins/patches/00-fix-cross.patch
 create mode 100644 srcpkgs/zam-plugins/template

diff --git a/srcpkgs/zam-plugins/patches/00-fix-cross.patch b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
new file mode 100644
index 000000000000..a354739ada7e
--- /dev/null
+++ b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
@@ -0,0 +1,11 @@
+--- a/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
++++ b/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
+@@ -21,7 +21,7 @@ endif
+ build: ../lv2_ttl_generator
+ 
+ ../lv2_ttl_generator: lv2_ttl_generator.c
+-	$(CC) $< $(CFLAGS) -o $@ $(LDFLAGS)
++	gcc $< $(CFLAGS) -o $@ $(LDFLAGS)
+ 
+ endif # WINDOWS
+ 
diff --git a/srcpkgs/zam-plugins/template b/srcpkgs/zam-plugins/template
new file mode 100644
index 000000000000..4f6a94431a44
--- /dev/null
+++ b/srcpkgs/zam-plugins/template
@@ -0,0 +1,28 @@
+# Template file for 'zam-plugins'
+pkgname=zam-plugins
+version=3.14
+revision=1
+create_wrksrc=yes
+build_wrksrc=${pkgname}
+build_style=gnu-makefile
+make_use_env=yes
+make_build_args="HAVE_ZITA_CONVOLVER=true"
+hostmakedepends="pkg-config git gendesk"
+makedepends="libX11-devel libglvnd-devel liblo-devel jack-devel ladspa-sdk
+ libsamplerate-devel zita-convolver-devel"
+# Use system zita-convolver instead of the vendored one
+short_desc="LADSPA/LV2/VST/JACK audio plugins for high-quality processing"
+maintainer="Artur Sinila <freesoftware@logarithmus.dev>"
+license="GPL-2.0-or-later"
+homepage="http://zamaudio.com/"
+changelog="https://raw.githubusercontent.com/zamaudio/zam-plugins/master/changelog"
+_dpf_commit="08669d1bc30c6e971fde800eade4ca40104ba8b2"
+distfiles="https://github.com/zamaudio/zam-plugins/archive/refs/tags/${version}.tar.gz
+ https://github.com/DISTRHO/DPF/archive/${_dpf_commit}.tar.gz"
+checksum="4a73a73fa03cc6d7faf2d65840349d2a33e7aaef5a13c6345f534b6c434e7b42
+ c4359020d1defb7ae2547b5dbdc0cf33f6e0e9cdd3ef75300533b4c4c9f1b9f4"
+
+post_extract() {
+	mv ${pkgname}-${version} $pkgname
+	mv DPF-${_dpf_commit}/* $build_wrksrc/dpf
+}

Re: [PR PATCH] [Updated] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

There is an updated pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages zam-plugins
https://github.com/void-linux/void-packages/pull/31665

New package: zam-plugins-3.14
<!-- Mark items with [x] where applicable -->

Required by `pulseeffects` maximizer effect.
Blocked by https://github.com/void-linux/void-packages/pull/31666.

TODO: fix cross-compilation.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zam-plugins-31665.patch --]
[-- Type: text/x-diff, Size: 2542 bytes --]

From f0bf822d4cb374347209a22914dead0c4bb93eec Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Sat, 26 Jun 2021 04:00:10 +0300
Subject: [PATCH] New package: zam-plugins-3.14

---
 .../zam-plugins/patches/00-fix-cross.patch    | 17 +++++++++++
 srcpkgs/zam-plugins/template                  | 28 +++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 srcpkgs/zam-plugins/patches/00-fix-cross.patch
 create mode 100644 srcpkgs/zam-plugins/template

diff --git a/srcpkgs/zam-plugins/patches/00-fix-cross.patch b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
new file mode 100644
index 000000000000..35bcc53fd294
--- /dev/null
+++ b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
@@ -0,0 +1,17 @@
+--- a/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
++++ b/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
+@@ -20,6 +20,14 @@ endif
+ 
+ build: ../lv2_ttl_generator
+ 
++ifdef CROSS_BUILD
++
++CC := gcc
++CFLAGS := $(patsubst -I%, -I/usr/include, $(filter-out -march=%, $(CFLAGS)))
++LDFLAGS := $(patsubst -L%, -L/usr/lib, $(LDFLAGS))
++
++endif
++
+ ../lv2_ttl_generator: lv2_ttl_generator.c
+ 	$(CC) $< $(CFLAGS) -o $@ $(LDFLAGS)
+ 
diff --git a/srcpkgs/zam-plugins/template b/srcpkgs/zam-plugins/template
new file mode 100644
index 000000000000..a433dce9d35e
--- /dev/null
+++ b/srcpkgs/zam-plugins/template
@@ -0,0 +1,28 @@
+# Template file for 'zam-plugins'
+pkgname=zam-plugins
+version=3.14
+revision=1
+create_wrksrc=yes
+build_wrksrc=${pkgname}
+build_style=gnu-makefile
+make_use_env=yes
+make_build_args="HAVE_ZITA_CONVOLVER=true"
+hostmakedepends="pkg-config"
+makedepends="libX11-devel libglvnd-devel liblo-devel jack-devel ladspa-sdk
+ libsamplerate-devel zita-convolver-devel"
+# Use system zita-convolver instead of the vendored one
+short_desc="LADSPA/LV2/VST/JACK audio plugins for high-quality processing"
+maintainer="Artur Sinila <freesoftware@logarithmus.dev>"
+license="GPL-2.0-or-later"
+homepage="http://zamaudio.com/"
+changelog="https://raw.githubusercontent.com/zamaudio/zam-plugins/master/changelog"
+_dpf_commit="08669d1bc30c6e971fde800eade4ca40104ba8b2"
+distfiles="https://github.com/zamaudio/zam-plugins/archive/refs/tags/${version}.tar.gz
+ https://github.com/DISTRHO/DPF/archive/${_dpf_commit}.tar.gz"
+checksum="4a73a73fa03cc6d7faf2d65840349d2a33e7aaef5a13c6345f534b6c434e7b42
+ c4359020d1defb7ae2547b5dbdc0cf33f6e0e9cdd3ef75300533b4c4c9f1b9f4"
+
+post_extract() {
+	mv ${pkgname}-${version} $pkgname
+	mv DPF-${_dpf_commit}/* $build_wrksrc/dpf
+}

Re: [PR PATCH] [Updated] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

There is an updated pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages zam-plugins
https://github.com/void-linux/void-packages/pull/31665

New package: zam-plugins-3.14
<!-- Mark items with [x] where applicable -->

Required by `pulseeffects` maximizer effect.
Blocked by https://github.com/void-linux/void-packages/pull/31666.

TODO: fix cross-compilation.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zam-plugins-31665.patch --]
[-- Type: text/x-diff, Size: 2466 bytes --]

From 242c584f0f0d640463546ed383e019eda1b61caa Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Sat, 26 Jun 2021 04:00:10 +0300
Subject: [PATCH] New package: zam-plugins-3.14

---
 .../zam-plugins/patches/00-fix-cross.patch    | 17 +++++++++++
 srcpkgs/zam-plugins/template                  | 28 +++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 srcpkgs/zam-plugins/patches/00-fix-cross.patch
 create mode 100644 srcpkgs/zam-plugins/template

diff --git a/srcpkgs/zam-plugins/patches/00-fix-cross.patch b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
new file mode 100644
index 000000000000..50f9ad6b8fb1
--- /dev/null
+++ b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
@@ -0,0 +1,17 @@
+--- a/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
++++ b/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
+@@ -20,6 +20,14 @@ endif
+ 
+ build: ../lv2_ttl_generator
+ 
++ifdef CROSS_BUILD
++
++CC := gcc
++CFLAGS := $(XBPS_CFLAGS)
++LDFLAGS := $(XBPS_LDFLAGS)
++
++endif
++
+ ../lv2_ttl_generator: lv2_ttl_generator.c
+ 	$(CC) $< $(CFLAGS) -o $@ $(LDFLAGS)
+ 
diff --git a/srcpkgs/zam-plugins/template b/srcpkgs/zam-plugins/template
new file mode 100644
index 000000000000..a433dce9d35e
--- /dev/null
+++ b/srcpkgs/zam-plugins/template
@@ -0,0 +1,28 @@
+# Template file for 'zam-plugins'
+pkgname=zam-plugins
+version=3.14
+revision=1
+create_wrksrc=yes
+build_wrksrc=${pkgname}
+build_style=gnu-makefile
+make_use_env=yes
+make_build_args="HAVE_ZITA_CONVOLVER=true"
+hostmakedepends="pkg-config"
+makedepends="libX11-devel libglvnd-devel liblo-devel jack-devel ladspa-sdk
+ libsamplerate-devel zita-convolver-devel"
+# Use system zita-convolver instead of the vendored one
+short_desc="LADSPA/LV2/VST/JACK audio plugins for high-quality processing"
+maintainer="Artur Sinila <freesoftware@logarithmus.dev>"
+license="GPL-2.0-or-later"
+homepage="http://zamaudio.com/"
+changelog="https://raw.githubusercontent.com/zamaudio/zam-plugins/master/changelog"
+_dpf_commit="08669d1bc30c6e971fde800eade4ca40104ba8b2"
+distfiles="https://github.com/zamaudio/zam-plugins/archive/refs/tags/${version}.tar.gz
+ https://github.com/DISTRHO/DPF/archive/${_dpf_commit}.tar.gz"
+checksum="4a73a73fa03cc6d7faf2d65840349d2a33e7aaef5a13c6345f534b6c434e7b42
+ c4359020d1defb7ae2547b5dbdc0cf33f6e0e9cdd3ef75300533b4c4c9f1b9f4"
+
+post_extract() {
+	mv ${pkgname}-${version} $pkgname
+	mv DPF-${_dpf_commit}/* $build_wrksrc/dpf
+}

Re: [PR PATCH] [Updated] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

There is an updated pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages zam-plugins
https://github.com/void-linux/void-packages/pull/31665

New package: zam-plugins-3.14
<!-- Mark items with [x] where applicable -->

Required by `pulseeffects` maximizer effect.
Blocked by https://github.com/void-linux/void-packages/pull/31666.

TODO: fix cross-compilation.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zam-plugins-31665.patch --]
[-- Type: text/x-diff, Size: 2451 bytes --]

From 6cfa04b541dfbad05fed0a83986c77c6090b24a4 Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Sat, 26 Jun 2021 04:00:10 +0300
Subject: [PATCH] New package: zam-plugins-3.14

---
 .../zam-plugins/patches/00-fix-cross.patch    | 17 +++++++++++
 srcpkgs/zam-plugins/template                  | 28 +++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 srcpkgs/zam-plugins/patches/00-fix-cross.patch
 create mode 100644 srcpkgs/zam-plugins/template

diff --git a/srcpkgs/zam-plugins/patches/00-fix-cross.patch b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
new file mode 100644
index 000000000000..6e4773056641
--- /dev/null
+++ b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
@@ -0,0 +1,17 @@
+--- a/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
++++ b/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
+@@ -20,6 +20,14 @@ endif
+ 
+ build: ../lv2_ttl_generator
+ 
++ifdef CROSS_BUILD
++
++CC := gcc
++CFLAGS := -sss
++LDFLAGS := -ssss -ldl
++
++endif
++
+ ../lv2_ttl_generator: lv2_ttl_generator.c
+ 	$(CC) $< $(CFLAGS) -o $@ $(LDFLAGS)
+ 
diff --git a/srcpkgs/zam-plugins/template b/srcpkgs/zam-plugins/template
new file mode 100644
index 000000000000..a433dce9d35e
--- /dev/null
+++ b/srcpkgs/zam-plugins/template
@@ -0,0 +1,28 @@
+# Template file for 'zam-plugins'
+pkgname=zam-plugins
+version=3.14
+revision=1
+create_wrksrc=yes
+build_wrksrc=${pkgname}
+build_style=gnu-makefile
+make_use_env=yes
+make_build_args="HAVE_ZITA_CONVOLVER=true"
+hostmakedepends="pkg-config"
+makedepends="libX11-devel libglvnd-devel liblo-devel jack-devel ladspa-sdk
+ libsamplerate-devel zita-convolver-devel"
+# Use system zita-convolver instead of the vendored one
+short_desc="LADSPA/LV2/VST/JACK audio plugins for high-quality processing"
+maintainer="Artur Sinila <freesoftware@logarithmus.dev>"
+license="GPL-2.0-or-later"
+homepage="http://zamaudio.com/"
+changelog="https://raw.githubusercontent.com/zamaudio/zam-plugins/master/changelog"
+_dpf_commit="08669d1bc30c6e971fde800eade4ca40104ba8b2"
+distfiles="https://github.com/zamaudio/zam-plugins/archive/refs/tags/${version}.tar.gz
+ https://github.com/DISTRHO/DPF/archive/${_dpf_commit}.tar.gz"
+checksum="4a73a73fa03cc6d7faf2d65840349d2a33e7aaef5a13c6345f534b6c434e7b42
+ c4359020d1defb7ae2547b5dbdc0cf33f6e0e9cdd3ef75300533b4c4c9f1b9f4"
+
+post_extract() {
+	mv ${pkgname}-${version} $pkgname
+	mv DPF-${_dpf_commit}/* $build_wrksrc/dpf
+}

Re: [PR PATCH] [Updated] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

There is an updated pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages zam-plugins
https://github.com/void-linux/void-packages/pull/31665

New package: zam-plugins-3.14
<!-- Mark items with [x] where applicable -->

Required by `pulseeffects` maximizer effect.
Blocked by https://github.com/void-linux/void-packages/pull/31666.

TODO: fix cross-compilation.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zam-plugins-31665.patch --]
[-- Type: text/x-diff, Size: 2490 bytes --]

From 0b16c24a84c53f87bb7e6e92a364fa7dc838b157 Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Sat, 26 Jun 2021 04:00:10 +0300
Subject: [PATCH] New package: zam-plugins-3.14

---
 .../zam-plugins/patches/00-fix-cross.patch    | 17 +++++++++++
 srcpkgs/zam-plugins/template                  | 28 +++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 srcpkgs/zam-plugins/patches/00-fix-cross.patch
 create mode 100644 srcpkgs/zam-plugins/template

diff --git a/srcpkgs/zam-plugins/patches/00-fix-cross.patch b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
new file mode 100644
index 000000000000..d46a7e26ef3b
--- /dev/null
+++ b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
@@ -0,0 +1,17 @@
+--- a/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
++++ b/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
+@@ -20,6 +20,14 @@ endif
+ 
+ build: ../lv2_ttl_generator
+ 
++ifdef CROSS_BUILD
++
++CC := gcc
++CFLAGS := $(XBPS_CFLAGS)
++LDFLAGS := $(patsubst -L%, -L/usr/lib, $(LDFLAGS))
++
++endif
++
+ ../lv2_ttl_generator: lv2_ttl_generator.c
+ 	$(CC) $< $(CFLAGS) -o $@ $(LDFLAGS)
+ 
diff --git a/srcpkgs/zam-plugins/template b/srcpkgs/zam-plugins/template
new file mode 100644
index 000000000000..a433dce9d35e
--- /dev/null
+++ b/srcpkgs/zam-plugins/template
@@ -0,0 +1,28 @@
+# Template file for 'zam-plugins'
+pkgname=zam-plugins
+version=3.14
+revision=1
+create_wrksrc=yes
+build_wrksrc=${pkgname}
+build_style=gnu-makefile
+make_use_env=yes
+make_build_args="HAVE_ZITA_CONVOLVER=true"
+hostmakedepends="pkg-config"
+makedepends="libX11-devel libglvnd-devel liblo-devel jack-devel ladspa-sdk
+ libsamplerate-devel zita-convolver-devel"
+# Use system zita-convolver instead of the vendored one
+short_desc="LADSPA/LV2/VST/JACK audio plugins for high-quality processing"
+maintainer="Artur Sinila <freesoftware@logarithmus.dev>"
+license="GPL-2.0-or-later"
+homepage="http://zamaudio.com/"
+changelog="https://raw.githubusercontent.com/zamaudio/zam-plugins/master/changelog"
+_dpf_commit="08669d1bc30c6e971fde800eade4ca40104ba8b2"
+distfiles="https://github.com/zamaudio/zam-plugins/archive/refs/tags/${version}.tar.gz
+ https://github.com/DISTRHO/DPF/archive/${_dpf_commit}.tar.gz"
+checksum="4a73a73fa03cc6d7faf2d65840349d2a33e7aaef5a13c6345f534b6c434e7b42
+ c4359020d1defb7ae2547b5dbdc0cf33f6e0e9cdd3ef75300533b4c4c9f1b9f4"
+
+post_extract() {
+	mv ${pkgname}-${version} $pkgname
+	mv DPF-${_dpf_commit}/* $build_wrksrc/dpf
+}

Re: [PR PATCH] [Updated] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

There is an updated pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages zam-plugins
https://github.com/void-linux/void-packages/pull/31665

New package: zam-plugins-3.14
<!-- Mark items with [x] where applicable -->

Required by `pulseeffects` maximizer effect.
Blocked by https://github.com/void-linux/void-packages/pull/31666.

TODO: fix cross-compilation.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zam-plugins-31665.patch --]
[-- Type: text/x-diff, Size: 2582 bytes --]

From 5edf1329e5e942bc5306e11b96eafc035c69ae79 Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Sat, 26 Jun 2021 04:00:10 +0300
Subject: [PATCH] New package: zam-plugins-3.14

---
 .../zam-plugins/patches/00-fix-cross.patch    | 20 +++++++++++++
 srcpkgs/zam-plugins/template                  | 28 +++++++++++++++++++
 2 files changed, 48 insertions(+)
 create mode 100644 srcpkgs/zam-plugins/patches/00-fix-cross.patch
 create mode 100644 srcpkgs/zam-plugins/template

diff --git a/srcpkgs/zam-plugins/patches/00-fix-cross.patch b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
new file mode 100644
index 000000000000..238ecfce65e9
--- /dev/null
+++ b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
@@ -0,0 +1,20 @@
+--- a/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
++++ b/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
+@@ -20,8 +20,16 @@ endif
+ 
+ build: ../lv2_ttl_generator
+ 
++ifdef CROSS_BUILD
++
++HOST_CC := gcc
++HOST_CFLAGS := $(XBPS_CFLAGS)
++HOST_LDFLAGS := $(patsubst -L%, -L/usr/lib, $(LDFLAGS))
++
++endif
++
+ ../lv2_ttl_generator: lv2_ttl_generator.c
+-	$(CC) $< $(CFLAGS) -o $@ $(LDFLAGS)
++	$(HOST_CC) $< $(HOST_CFLAGS) -o $@ $(HOST_LDFLAGS)
+ 
+ endif # WINDOWS
+ 
diff --git a/srcpkgs/zam-plugins/template b/srcpkgs/zam-plugins/template
new file mode 100644
index 000000000000..a433dce9d35e
--- /dev/null
+++ b/srcpkgs/zam-plugins/template
@@ -0,0 +1,28 @@
+# Template file for 'zam-plugins'
+pkgname=zam-plugins
+version=3.14
+revision=1
+create_wrksrc=yes
+build_wrksrc=${pkgname}
+build_style=gnu-makefile
+make_use_env=yes
+make_build_args="HAVE_ZITA_CONVOLVER=true"
+hostmakedepends="pkg-config"
+makedepends="libX11-devel libglvnd-devel liblo-devel jack-devel ladspa-sdk
+ libsamplerate-devel zita-convolver-devel"
+# Use system zita-convolver instead of the vendored one
+short_desc="LADSPA/LV2/VST/JACK audio plugins for high-quality processing"
+maintainer="Artur Sinila <freesoftware@logarithmus.dev>"
+license="GPL-2.0-or-later"
+homepage="http://zamaudio.com/"
+changelog="https://raw.githubusercontent.com/zamaudio/zam-plugins/master/changelog"
+_dpf_commit="08669d1bc30c6e971fde800eade4ca40104ba8b2"
+distfiles="https://github.com/zamaudio/zam-plugins/archive/refs/tags/${version}.tar.gz
+ https://github.com/DISTRHO/DPF/archive/${_dpf_commit}.tar.gz"
+checksum="4a73a73fa03cc6d7faf2d65840349d2a33e7aaef5a13c6345f534b6c434e7b42
+ c4359020d1defb7ae2547b5dbdc0cf33f6e0e9cdd3ef75300533b4c4c9f1b9f4"
+
+post_extract() {
+	mv ${pkgname}-${version} $pkgname
+	mv DPF-${_dpf_commit}/* $build_wrksrc/dpf
+}

Re: [PR PATCH] [Updated] New package: zam-plugins-3.14

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

There is an updated pull request by Logarithmus against master on the void-packages repository

https://github.com/Logarithmus/void-packages zam-plugins
https://github.com/void-linux/void-packages/pull/31665

New package: zam-plugins-3.14
<!-- Mark items with [x] where applicable -->

Required by `pulseeffects` maximizer effect.
Blocked by https://github.com/void-linux/void-packages/pull/31666.

TODO: fix cross-compilation.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zam-plugins-31665.patch --]
[-- Type: text/x-diff, Size: 2674 bytes --]

From d045baa741139122c7a5359497ae7d5244654077 Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Sat, 26 Jun 2021 04:00:10 +0300
Subject: [PATCH] New package: zam-plugins-3.14

---
 .../zam-plugins/patches/00-fix-cross.patch    | 26 +++++++++++++++++
 srcpkgs/zam-plugins/template                  | 28 +++++++++++++++++++
 2 files changed, 54 insertions(+)
 create mode 100644 srcpkgs/zam-plugins/patches/00-fix-cross.patch
 create mode 100644 srcpkgs/zam-plugins/template

diff --git a/srcpkgs/zam-plugins/patches/00-fix-cross.patch b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
new file mode 100644
index 000000000000..23f705f1e7e5
--- /dev/null
+++ b/srcpkgs/zam-plugins/patches/00-fix-cross.patch
@@ -0,0 +1,26 @@
+--- a/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
++++ b/zam-plugins/dpf/utils/lv2-ttl-generator/GNUmakefile
+@@ -20,8 +20,22 @@ endif
+ 
+ build: ../lv2_ttl_generator
+ 
++ifdef CROSS_BUILD
++
++HOST_CC := gcc
++HOST_CFLAGS := $(XBPS_CFLAGS)
++HOST_LDFLAGS := $(patsubst -L%, -L/usr/lib, $(LDFLAGS))
++
++else
++
++HOST_CC := $(CC)
++HOST_CFLAGS := $(CFLAGS)
++HOST_LDFLAGS := $(LDFLAGS)
++
++endif
++
+ ../lv2_ttl_generator: lv2_ttl_generator.c
+-	$(CC) $< $(CFLAGS) -o $@ $(LDFLAGS)
++	$(HOST_CC) $< $(HOST_CFLAGS) -o $@ $(HOST_LDFLAGS)
+ 
+ endif # WINDOWS
+ 
diff --git a/srcpkgs/zam-plugins/template b/srcpkgs/zam-plugins/template
new file mode 100644
index 000000000000..a433dce9d35e
--- /dev/null
+++ b/srcpkgs/zam-plugins/template
@@ -0,0 +1,28 @@
+# Template file for 'zam-plugins'
+pkgname=zam-plugins
+version=3.14
+revision=1
+create_wrksrc=yes
+build_wrksrc=${pkgname}
+build_style=gnu-makefile
+make_use_env=yes
+make_build_args="HAVE_ZITA_CONVOLVER=true"
+hostmakedepends="pkg-config"
+makedepends="libX11-devel libglvnd-devel liblo-devel jack-devel ladspa-sdk
+ libsamplerate-devel zita-convolver-devel"
+# Use system zita-convolver instead of the vendored one
+short_desc="LADSPA/LV2/VST/JACK audio plugins for high-quality processing"
+maintainer="Artur Sinila <freesoftware@logarithmus.dev>"
+license="GPL-2.0-or-later"
+homepage="http://zamaudio.com/"
+changelog="https://raw.githubusercontent.com/zamaudio/zam-plugins/master/changelog"
+_dpf_commit="08669d1bc30c6e971fde800eade4ca40104ba8b2"
+distfiles="https://github.com/zamaudio/zam-plugins/archive/refs/tags/${version}.tar.gz
+ https://github.com/DISTRHO/DPF/archive/${_dpf_commit}.tar.gz"
+checksum="4a73a73fa03cc6d7faf2d65840349d2a33e7aaef5a13c6345f534b6c434e7b42
+ c4359020d1defb7ae2547b5dbdc0cf33f6e0e9cdd3ef75300533b4c4c9f1b9f4"
+
+post_extract() {
+	mv ${pkgname}-${version} $pkgname
+	mv DPF-${_dpf_commit}/* $build_wrksrc/dpf
+}

Re: New package: zam-plugins-3.14

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/31665#issuecomment-1134091835

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: zam-plugins-3.14

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]

There's a closed pull request on the void-packages repository

New package: zam-plugins-3.14
https://github.com/void-linux/void-packages/pull/31665

Description:
<!-- Mark items with [x] where applicable -->

Required by `pulseeffects` maximizer effect.
Blocked by https://github.com/void-linux/void-packages/pull/31666.

TODO: fix cross-compilation.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->