Github messages for voidlinux
 help / color / mirror / Atom feed
From: oliver-cfc <oliver-cfc@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: python3-loguru-0.6.0
Date: Thu, 09 Jun 2022 01:47:08 +0200	[thread overview]
Message-ID: <20220608234708.MEg7j5sMFwz5hsPBcvobCXuiqgtt-SmY49dA33mJKBs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37434@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

New comment by oliver-cfc on void-packages repository

https://github.com/void-linux/void-packages/pull/37434#issuecomment-1150522525

Comment:
I think this is the good one.  I added python3-colorama to checkdepends (along with python3-pytest) because xbps-src check fails without it but it's not needed for python3-loguru to run. Also added hostmakedepends and checkdepends.  

```
# Template file for 'python3-loguru'
pkgname=python3-loguru
version=0.6.0
revision=1
wrksrc="loguru-${version}"
build_style=python3-module
hostmakedepends="python3-setuptools"
checkdepends="python3-pytest python3-colorama"
short_desc="Library which aims to bring enjoyable logging in Python"
maintainer="oliver <oliver@tuta.io>"
license="MIT"
homepage="https://github.com/Delgan/loguru"
changelog="https://raw.githubusercontent.com/Delgan/loguru/master/CHANGELOG.rst"
distfiles="${PYPI_SITE}/l/loguru/loguru-$version.tar.gz"
checksum=066bd06758d0a513e9836fd9c6b5a75bfb3fd36841f4b996bc60b547a309d41c

post_install() {
        vlicense LICENSE
}
```

Are these the correct next steps (while in my branch)?
1) git add ./srcpkgs/python3-loguru/template
2) git commit --amend
3) git rebase -i HEAD~2
4) git push origin <my branch>

  parent reply	other threads:[~2022-06-08 23:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 14:07 [PR PATCH] " oliver-cfc
2022-06-07 14:11 ` [PR REVIEW] " classabbyamp
2022-06-07 15:10 ` classabbyamp
2022-06-07 20:07 ` [PR REVIEW] " classabbyamp
2022-06-07 20:07 ` classabbyamp
2022-06-08 14:59 ` oliver-cfc
2022-06-08 15:20 ` classabbyamp
2022-06-08 23:47 ` oliver-cfc [this message]
2022-06-09  0:01 ` classabbyamp
2022-06-09 12:39 ` [PR PATCH] [Updated] " oliver-cfc
2022-06-10 15:15 ` oliver-cfc
2022-06-11 12:22 ` [PR PATCH] [Updated] " oliver-cfc
2022-09-10  2:14 ` github-actions
2022-09-25  2:14 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220608234708.MEg7j5sMFwz5hsPBcvobCXuiqgtt-SmY49dA33mJKBs@z \
    --to=oliver-cfc@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).