Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] python3-gnupg: update to 0.4.8.
@ 2022-03-22  9:51 jcgruenhage
  2022-03-22  9:55 ` [PR REVIEW] " jcgruenhage
                   ` (16 more replies)
  0 siblings, 17 replies; 18+ messages in thread
From: jcgruenhage @ 2022-03-22  9:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

There is a new pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages python3-gnupg-0.4.8_1
https://github.com/void-linux/void-packages/pull/36276

python3-gnupg: update to 0.4.8.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36276.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-gnupg-0.4.8_1-36276.patch --]
[-- Type: text/x-diff, Size: 3559 bytes --]

From c623f22477955a17d391feba7557822ba5a0fc03 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Tue, 22 Mar 2022 10:46:32 +0100
Subject: [PATCH] python3-gnupg: update to 0.4.8.

---
 ...aemon-attribute-instead-of-setDaemon.patch | 50 +++++++++++++++++++
 srcpkgs/python3-gnupg/template                | 13 +++--
 2 files changed, 59 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/python3-gnupg/patches/0001-set-daemon-attribute-instead-of-setDaemon.patch

diff --git a/srcpkgs/python3-gnupg/patches/0001-set-daemon-attribute-instead-of-setDaemon.patch b/srcpkgs/python3-gnupg/patches/0001-set-daemon-attribute-instead-of-setDaemon.patch
new file mode 100644
index 000000000000..601834c994a4
--- /dev/null
+++ b/srcpkgs/python3-gnupg/patches/0001-set-daemon-attribute-instead-of-setDaemon.patch
@@ -0,0 +1,50 @@
+From 6fb3874786d04bc05cbf6f1a1073d698b9d447f2 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Tue, 22 Mar 2022 10:39:38 +0100
+Subject: [PATCH]  set daemon attribute, instead of setDaemon()
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+> DeprecationWarning: setDaemon() is deprecated, set the daemon
+> attribute instead
+
+Signed-off-by: Jan Christian Grünhage <jan.christian@gruenhage.xyz>
+---
+ gnupg.py | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/gnupg.py b/gnupg.py
+index 8d16739..94073d2 100644
+--- a/gnupg.py
++++ b/gnupg.py
+@@ -169,7 +169,7 @@ def _copy_data(instream, outstream):
+ 
+ def _threaded_copy_data(instream, outstream):
+     wr = threading.Thread(target=_copy_data, args=(instream, outstream))
+-    wr.setDaemon(True)
++    wr.daemon = True
+     logger.debug('data copier: %r, %r, %r', wr, instream, outstream)
+     wr.start()
+     return wr
+@@ -1021,14 +1021,14 @@ class GPG(object):
+         """
+         stderr = codecs.getreader(self.encoding)(process.stderr)
+         rr = threading.Thread(target=self._read_response, args=(stderr, result))
+-        rr.setDaemon(True)
++        rr.daemon = True
+         logger.debug('stderr reader: %r', rr)
+         rr.start()
+ 
+         stdout = process.stdout
+         dr = threading.Thread(target=self._read_data, args=(stdout, result,
+                               self.on_data))
+-        dr.setDaemon(True)
++        dr.daemon = True
+         logger.debug('stdout reader: %r', dr)
+         dr.start()
+ 
+-- 
+2.35.1
+
diff --git a/srcpkgs/python3-gnupg/template b/srcpkgs/python3-gnupg/template
index 4470b8bed028..536f89b954ef 100644
--- a/srcpkgs/python3-gnupg/template
+++ b/srcpkgs/python3-gnupg/template
@@ -1,18 +1,23 @@
 # Template file for 'python3-gnupg'
 pkgname=python3-gnupg
 _pkgname=python-gnupg
-version=0.4.6
-revision=4
+version=0.4.8
+revision=1
 wrksrc=$_pkgname-$version
 build_style=python3-module
 hostmakedepends="python3-setuptools"
+checkdepends="gnupg"
 depends="python3 gnupg"
 short_desc="Python3 wrapper for GnuPG"
 maintainer="Lon Willett <xgit@lonw.net>"
 license="BSD-3-Clause"
-homepage="https://bitbucket.org/vinay.sajip/python-gnupg"
+homepage="https://github.com/vsajip/python-gnupg"
 distfiles="${PYPI_SITE}/p/${_pkgname}/${_pkgname}-${version}.tar.gz"
-checksum=3aa0884b3bd414652c2385b9df39e7b87272c2eca1b8fcc3089bc9e58652019a
+checksum=b64de1ae5cedf872b437201a566fa2c62ce0c95ea2e30177eb53aee1258507d7
+
+pre_check() {
+	export NO_EXTERNAL_TESTS=1
+}
 
 post_install() {
 	vlicense LICENSE.txt

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] python3-gnupg: update to 0.4.8.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
  2022-03-22  9:55 ` [PR REVIEW] " jcgruenhage
@ 2022-03-22  9:55 ` jcgruenhage
  2022-03-22  9:55 ` jcgruenhage
                   ` (14 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-03-22  9:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/36276#discussion_r831980197

Comment:
The bitbucket page says this has been migrated to that other repo

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] python3-gnupg: update to 0.4.8.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
@ 2022-03-22  9:55 ` jcgruenhage
  2022-03-22  9:55 ` jcgruenhage
                   ` (15 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-03-22  9:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/36276#discussion_r831979718

Comment:
patch already submitted upstream as https://github.com/vsajip/python-gnupg/pull/174.

This doesn't make any actual difference, it's just been putting tons and tons of warnings out when running the tests so I patched it.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] python3-gnupg: update to 0.4.8.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
  2022-03-22  9:55 ` [PR REVIEW] " jcgruenhage
  2022-03-22  9:55 ` jcgruenhage
@ 2022-03-22  9:55 ` jcgruenhage
  2022-03-22 10:06 ` [PR PATCH] [Updated] " jcgruenhage
                   ` (13 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-03-22  9:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/36276#discussion_r831978014

Comment:
These tests require stuff manually set up by the developer on their dev machine. It's disabled in CI by upstream as well, using this env var.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] python3-gnupg: update to 0.4.8.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (2 preceding siblings ...)
  2022-03-22  9:55 ` jcgruenhage
@ 2022-03-22 10:06 ` jcgruenhage
  2022-03-26 11:45 ` jcgruenhage
                   ` (12 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-03-22 10:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages python3-gnupg-0.4.8_1
https://github.com/void-linux/void-packages/pull/36276

python3-gnupg: update to 0.4.8.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36276.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-gnupg-0.4.8_1-36276.patch --]
[-- Type: text/x-diff, Size: 3559 bytes --]

From a24816538efa529fb5c53d8dc8fa765a8a5a349c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Tue, 22 Mar 2022 10:46:32 +0100
Subject: [PATCH] python3-gnupg: update to 0.4.8.

---
 ...aemon-attribute-instead-of-setDaemon.patch | 50 +++++++++++++++++++
 srcpkgs/python3-gnupg/template                | 13 +++--
 2 files changed, 59 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/python3-gnupg/patches/0001-set-daemon-attribute-instead-of-setDaemon.patch

diff --git a/srcpkgs/python3-gnupg/patches/0001-set-daemon-attribute-instead-of-setDaemon.patch b/srcpkgs/python3-gnupg/patches/0001-set-daemon-attribute-instead-of-setDaemon.patch
new file mode 100644
index 000000000000..601834c994a4
--- /dev/null
+++ b/srcpkgs/python3-gnupg/patches/0001-set-daemon-attribute-instead-of-setDaemon.patch
@@ -0,0 +1,50 @@
+From 6fb3874786d04bc05cbf6f1a1073d698b9d447f2 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Tue, 22 Mar 2022 10:39:38 +0100
+Subject: [PATCH]  set daemon attribute, instead of setDaemon()
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+> DeprecationWarning: setDaemon() is deprecated, set the daemon
+> attribute instead
+
+Signed-off-by: Jan Christian Grünhage <jan.christian@gruenhage.xyz>
+---
+ gnupg.py | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/gnupg.py b/gnupg.py
+index 8d16739..94073d2 100644
+--- a/gnupg.py
++++ b/gnupg.py
+@@ -169,7 +169,7 @@ def _copy_data(instream, outstream):
+ 
+ def _threaded_copy_data(instream, outstream):
+     wr = threading.Thread(target=_copy_data, args=(instream, outstream))
+-    wr.setDaemon(True)
++    wr.daemon = True
+     logger.debug('data copier: %r, %r, %r', wr, instream, outstream)
+     wr.start()
+     return wr
+@@ -1021,14 +1021,14 @@ class GPG(object):
+         """
+         stderr = codecs.getreader(self.encoding)(process.stderr)
+         rr = threading.Thread(target=self._read_response, args=(stderr, result))
+-        rr.setDaemon(True)
++        rr.daemon = True
+         logger.debug('stderr reader: %r', rr)
+         rr.start()
+ 
+         stdout = process.stdout
+         dr = threading.Thread(target=self._read_data, args=(stdout, result,
+                               self.on_data))
+-        dr.setDaemon(True)
++        dr.daemon = True
+         logger.debug('stdout reader: %r', dr)
+         dr.start()
+ 
+-- 
+2.35.1
+
diff --git a/srcpkgs/python3-gnupg/template b/srcpkgs/python3-gnupg/template
index 4470b8bed028..d63eca0d2284 100644
--- a/srcpkgs/python3-gnupg/template
+++ b/srcpkgs/python3-gnupg/template
@@ -1,18 +1,23 @@
 # Template file for 'python3-gnupg'
 pkgname=python3-gnupg
 _pkgname=python-gnupg
-version=0.4.6
-revision=4
+version=0.4.8
+revision=1
 wrksrc=$_pkgname-$version
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3 gnupg"
+checkdepends="gnupg"
 short_desc="Python3 wrapper for GnuPG"
 maintainer="Lon Willett <xgit@lonw.net>"
 license="BSD-3-Clause"
-homepage="https://bitbucket.org/vinay.sajip/python-gnupg"
+homepage="https://github.com/vsajip/python-gnupg"
 distfiles="${PYPI_SITE}/p/${_pkgname}/${_pkgname}-${version}.tar.gz"
-checksum=3aa0884b3bd414652c2385b9df39e7b87272c2eca1b8fcc3089bc9e58652019a
+checksum=b64de1ae5cedf872b437201a566fa2c62ce0c95ea2e30177eb53aee1258507d7
+
+pre_check() {
+	export NO_EXTERNAL_TESTS=1
+}
 
 post_install() {
 	vlicense LICENSE.txt

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] python3-gnupg: update to 0.4.8.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (3 preceding siblings ...)
  2022-03-22 10:06 ` [PR PATCH] [Updated] " jcgruenhage
@ 2022-03-26 11:45 ` jcgruenhage
  2022-05-31 18:53 ` [PR REVIEW] " paper42
                   ` (11 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-03-26 11:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages python3-gnupg-0.4.8_1
https://github.com/void-linux/void-packages/pull/36276

python3-gnupg: update to 0.4.8.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36276.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-gnupg-0.4.8_1-36276.patch --]
[-- Type: text/x-diff, Size: 4857 bytes --]

From f8027a757f84e2a0704e72661ed25a4080dd3c73 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Tue, 22 Mar 2022 10:46:32 +0100
Subject: [PATCH] python3-gnupg: update to 0.4.8.

---
 ...aemon-attribute-instead-of-setDaemon.patch | 50 +++++++++++++++++++
 .../0002-skip-test-failing-in-void-CI.patch   | 25 ++++++++++
 srcpkgs/python3-gnupg/template                | 13 +++--
 3 files changed, 84 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/python3-gnupg/patches/0001-set-daemon-attribute-instead-of-setDaemon.patch
 create mode 100644 srcpkgs/python3-gnupg/patches/0002-skip-test-failing-in-void-CI.patch

diff --git a/srcpkgs/python3-gnupg/patches/0001-set-daemon-attribute-instead-of-setDaemon.patch b/srcpkgs/python3-gnupg/patches/0001-set-daemon-attribute-instead-of-setDaemon.patch
new file mode 100644
index 000000000000..48ccbcace763
--- /dev/null
+++ b/srcpkgs/python3-gnupg/patches/0001-set-daemon-attribute-instead-of-setDaemon.patch
@@ -0,0 +1,50 @@
+From 6fb3874786d04bc05cbf6f1a1073d698b9d447f2 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Tue, 22 Mar 2022 10:39:38 +0100
+Subject: [PATCH 1/2]  set daemon attribute, instead of setDaemon()
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+> DeprecationWarning: setDaemon() is deprecated, set the daemon
+> attribute instead
+
+Signed-off-by: Jan Christian Grünhage <jan.christian@gruenhage.xyz>
+---
+ gnupg.py | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/gnupg.py b/gnupg.py
+index 8d16739..94073d2 100644
+--- a/gnupg.py
++++ b/gnupg.py
+@@ -169,7 +169,7 @@ def _copy_data(instream, outstream):
+ 
+ def _threaded_copy_data(instream, outstream):
+     wr = threading.Thread(target=_copy_data, args=(instream, outstream))
+-    wr.setDaemon(True)
++    wr.daemon = True
+     logger.debug('data copier: %r, %r, %r', wr, instream, outstream)
+     wr.start()
+     return wr
+@@ -1021,14 +1021,14 @@ class GPG(object):
+         """
+         stderr = codecs.getreader(self.encoding)(process.stderr)
+         rr = threading.Thread(target=self._read_response, args=(stderr, result))
+-        rr.setDaemon(True)
++        rr.daemon = True
+         logger.debug('stderr reader: %r', rr)
+         rr.start()
+ 
+         stdout = process.stdout
+         dr = threading.Thread(target=self._read_data, args=(stdout, result,
+                               self.on_data))
+-        dr.setDaemon(True)
++        dr.daemon = True
+         logger.debug('stdout reader: %r', dr)
+         dr.start()
+ 
+-- 
+2.35.1
+
diff --git a/srcpkgs/python3-gnupg/patches/0002-skip-test-failing-in-void-CI.patch b/srcpkgs/python3-gnupg/patches/0002-skip-test-failing-in-void-CI.patch
new file mode 100644
index 000000000000..42adc74b5052
--- /dev/null
+++ b/srcpkgs/python3-gnupg/patches/0002-skip-test-failing-in-void-CI.patch
@@ -0,0 +1,25 @@
+From dbd7fe95d8c319aa934447c9daaac521200255db Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sat, 26 Mar 2022 12:41:28 +0100
+Subject: [PATCH 2/2] skip test failing in void CI
+
+---
+ test_gnupg.py | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/test_gnupg.py b/test_gnupg.py
+index 3608f77..1a1e29b 100644
+--- a/test_gnupg.py
++++ b/test_gnupg.py
+@@ -985,6 +985,7 @@ class GPGTestCase(unittest.TestCase):
+         logger.debug("test_file_encryption_and_decryption ends")
+ 
+     @skipIf(os.name == 'nt', 'Test not suitable for Windows')
++    @unittest.skip("Doesn't work in voidlinux CI")
+     def test_invalid_outputs(self):
+         "Test encrypting to invalid output files"
+         encfno, encfname = tempfile.mkstemp()
+-- 
+2.35.1
+
diff --git a/srcpkgs/python3-gnupg/template b/srcpkgs/python3-gnupg/template
index 4470b8bed028..d63eca0d2284 100644
--- a/srcpkgs/python3-gnupg/template
+++ b/srcpkgs/python3-gnupg/template
@@ -1,18 +1,23 @@
 # Template file for 'python3-gnupg'
 pkgname=python3-gnupg
 _pkgname=python-gnupg
-version=0.4.6
-revision=4
+version=0.4.8
+revision=1
 wrksrc=$_pkgname-$version
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3 gnupg"
+checkdepends="gnupg"
 short_desc="Python3 wrapper for GnuPG"
 maintainer="Lon Willett <xgit@lonw.net>"
 license="BSD-3-Clause"
-homepage="https://bitbucket.org/vinay.sajip/python-gnupg"
+homepage="https://github.com/vsajip/python-gnupg"
 distfiles="${PYPI_SITE}/p/${_pkgname}/${_pkgname}-${version}.tar.gz"
-checksum=3aa0884b3bd414652c2385b9df39e7b87272c2eca1b8fcc3089bc9e58652019a
+checksum=b64de1ae5cedf872b437201a566fa2c62ce0c95ea2e30177eb53aee1258507d7
+
+pre_check() {
+	export NO_EXTERNAL_TESTS=1
+}
 
 post_install() {
 	vlicense LICENSE.txt

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] python3-gnupg: update to 0.4.8.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (4 preceding siblings ...)
  2022-03-26 11:45 ` jcgruenhage
@ 2022-05-31 18:53 ` paper42
  2022-05-31 18:53 ` paper42
                   ` (10 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: paper42 @ 2022-05-31 18:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36276#discussion_r886022627

Comment:
0.4.9 is out

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] python3-gnupg: update to 0.4.8.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (5 preceding siblings ...)
  2022-05-31 18:53 ` [PR REVIEW] " paper42
@ 2022-05-31 18:53 ` paper42
  2022-06-10 15:21 ` [PR PATCH] [Updated] " jcgruenhage
                   ` (9 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: paper42 @ 2022-05-31 18:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36276#discussion_r886023317

Comment:
we can use make_check_pre instead of pre_check
```
make_check_pre="NO_EXTERNAL_TESTS=1"
```

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] python3-gnupg: update to 0.4.8.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (6 preceding siblings ...)
  2022-05-31 18:53 ` paper42
@ 2022-06-10 15:21 ` jcgruenhage
  2022-06-10 15:24 ` [PR REVIEW] python3-gnupg: update to 0.4.9 jcgruenhage
                   ` (8 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-06-10 15:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages python3-gnupg-0.4.8_1
https://github.com/void-linux/void-packages/pull/36276

python3-gnupg: update to 0.4.8.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36276.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-gnupg-0.4.8_1-36276.patch --]
[-- Type: text/x-diff, Size: 2926 bytes --]

From ad9683dc9d4746bbd641ea62524c56945c6089be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Tue, 22 Mar 2022 10:46:32 +0100
Subject: [PATCH] python3-gnupg: update to 0.4.9.

---
 .../0001-skip-test-failing-in-void-CI.patch   | 25 +++++++++++++++++++
 srcpkgs/python3-gnupg/template                | 20 ++++++++-------
 2 files changed, 36 insertions(+), 9 deletions(-)
 create mode 100644 srcpkgs/python3-gnupg/patches/0001-skip-test-failing-in-void-CI.patch

diff --git a/srcpkgs/python3-gnupg/patches/0001-skip-test-failing-in-void-CI.patch b/srcpkgs/python3-gnupg/patches/0001-skip-test-failing-in-void-CI.patch
new file mode 100644
index 000000000000..60c356bf78d3
--- /dev/null
+++ b/srcpkgs/python3-gnupg/patches/0001-skip-test-failing-in-void-CI.patch
@@ -0,0 +1,25 @@
+From 7386c3d8e1dbc332ae3d4eda57d4133b309e5645 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sat, 26 Mar 2022 12:41:28 +0100
+Subject: [PATCH] skip test failing in void CI
+
+---
+ test_gnupg.py | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/test_gnupg.py b/test_gnupg.py
+index 4e8f685..2df2285 100644
+--- a/test_gnupg.py
++++ b/test_gnupg.py
+@@ -1204,6 +1204,7 @@ class GPGTestCase(unittest.TestCase):
+         self.do_file_encryption_and_decryption(encfname, decfname)
+ 
+     @skipIf(os.name == 'nt', 'Test not suitable for Windows')
++    @unittest.skip("Doesn't work in voidlinux CI")
+     def test_invalid_outputs(self):
+         "Test encrypting to invalid output files"
+         encfno, encfname = tempfile.mkstemp()
+-- 
+2.36.1
+
diff --git a/srcpkgs/python3-gnupg/template b/srcpkgs/python3-gnupg/template
index 4470b8bed028..fef916b96362 100644
--- a/srcpkgs/python3-gnupg/template
+++ b/srcpkgs/python3-gnupg/template
@@ -1,18 +1,20 @@
 # Template file for 'python3-gnupg'
 pkgname=python3-gnupg
-_pkgname=python-gnupg
-version=0.4.6
-revision=4
-wrksrc=$_pkgname-$version
-build_style=python3-module
-hostmakedepends="python3-setuptools"
+version=0.4.9
+revision=1
+wrksrc=${pkgname/3/}-$version
+build_style=python3-pep517
+make_install_target=python_gnupg-${version}-py2.py3-none-any.whl
+hostmakedepends="python3-setuptools python3-wheel"
 depends="python3 gnupg"
+checkdepends="${depends}"
 short_desc="Python3 wrapper for GnuPG"
 maintainer="Lon Willett <xgit@lonw.net>"
 license="BSD-3-Clause"
-homepage="https://bitbucket.org/vinay.sajip/python-gnupg"
-distfiles="${PYPI_SITE}/p/${_pkgname}/${_pkgname}-${version}.tar.gz"
-checksum=3aa0884b3bd414652c2385b9df39e7b87272c2eca1b8fcc3089bc9e58652019a
+homepage="https://github.com/vsajip/python-gnupg"
+distfiles="${PYPI_SITE}/p/${pkgname/3/}/${pkgname/3/}-${version}.tar.gz"
+checksum=aaa748795572591aaf127b4ac8985684f3673ff82b39f370c836b006e68fc537
+make_check_pre="NO_EXTERNAL_TESTS=1"
 
 post_install() {
 	vlicense LICENSE.txt

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] python3-gnupg: update to 0.4.9.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (7 preceding siblings ...)
  2022-06-10 15:21 ` [PR PATCH] [Updated] " jcgruenhage
@ 2022-06-10 15:24 ` jcgruenhage
  2022-06-10 15:24 ` jcgruenhage
                   ` (7 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-06-10 15:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/36276#discussion_r894647611

Comment:
Done

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] python3-gnupg: update to 0.4.9.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (8 preceding siblings ...)
  2022-06-10 15:24 ` [PR REVIEW] python3-gnupg: update to 0.4.9 jcgruenhage
@ 2022-06-10 15:24 ` jcgruenhage
  2022-06-10 15:25 ` jcgruenhage
                   ` (6 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-06-10 15:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/36276#discussion_r894647816

Comment:
Updated


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] python3-gnupg: update to 0.4.9.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (9 preceding siblings ...)
  2022-06-10 15:24 ` jcgruenhage
@ 2022-06-10 15:25 ` jcgruenhage
  2022-06-10 15:30 ` paper42
                   ` (5 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-06-10 15:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/36276#discussion_r894648460

Comment:
Similar patch was accepted upstream and is included in the version used now.


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] python3-gnupg: update to 0.4.9.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (10 preceding siblings ...)
  2022-06-10 15:25 ` jcgruenhage
@ 2022-06-10 15:30 ` paper42
  2022-06-10 15:37 ` jcgruenhage
                   ` (4 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: paper42 @ 2022-06-10 15:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36276#discussion_r894655380

Comment:
Do you think using pytest could fix this?
```
=> python3-gnupg-0.4.9_1: running do_check ...
=> WARNING: Unable to determine tests for PEP517 Python templates=> python3-gnupg-0.4.9_1: running pre-install hook: 00-libdir ...
```

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] python3-gnupg: update to 0.4.9.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (11 preceding siblings ...)
  2022-06-10 15:30 ` paper42
@ 2022-06-10 15:37 ` jcgruenhage
  2022-06-10 15:44 ` jcgruenhage
                   ` (3 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-06-10 15:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/36276#discussion_r894661319

Comment:
Good catch! I didn't see that it wasn't running the tests after switching to pep517 for the 0.4.9 update.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] python3-gnupg: update to 0.4.9.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (12 preceding siblings ...)
  2022-06-10 15:37 ` jcgruenhage
@ 2022-06-10 15:44 ` jcgruenhage
  2022-06-10 16:09 ` [PR PATCH] [Updated] " jcgruenhage
                   ` (2 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-06-10 15:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/36276#discussion_r894667824

Comment:
I'm a bit lost here, with

```suggestion
checkdepends="${depends} python3-pytest"
```
I now get this:

```text
=> python3-gnupg-0.4.9_1: running do_check ...
/void-packages/common/build-style/python3-pep517.sh: line 21: NO_EXTERNAL_TESTS=1: command not found
=> ERROR: python3-gnupg-0.4.9_1: do_check: '${make_check_pre} python3 -m pytest ${testjobs} ${make_check_args} ${make_check_target}' exited with 127
=> ERROR:   in do_check() at common/build-style/python3-pep517.sh:21
```

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] python3-gnupg: update to 0.4.9.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (13 preceding siblings ...)
  2022-06-10 15:44 ` jcgruenhage
@ 2022-06-10 16:09 ` jcgruenhage
  2022-06-10 18:34 ` [PR REVIEW] " jcgruenhage
  2022-06-10 19:59 ` [PR PATCH] [Merged]: " paper42
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-06-10 16:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages python3-gnupg-0.4.8_1
https://github.com/void-linux/void-packages/pull/36276

python3-gnupg: update to 0.4.9.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36276.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-gnupg-0.4.8_1-36276.patch --]
[-- Type: text/x-diff, Size: 2945 bytes --]

From 699293ccfb84e4b224048684e32f486d573a3e59 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Tue, 22 Mar 2022 10:46:32 +0100
Subject: [PATCH] python3-gnupg: update to 0.4.9.

---
 .../0001-skip-test-failing-in-void-CI.patch   | 25 +++++++++++++++++++
 srcpkgs/python3-gnupg/template                | 20 ++++++++-------
 2 files changed, 36 insertions(+), 9 deletions(-)
 create mode 100644 srcpkgs/python3-gnupg/patches/0001-skip-test-failing-in-void-CI.patch

diff --git a/srcpkgs/python3-gnupg/patches/0001-skip-test-failing-in-void-CI.patch b/srcpkgs/python3-gnupg/patches/0001-skip-test-failing-in-void-CI.patch
new file mode 100644
index 000000000000..60c356bf78d3
--- /dev/null
+++ b/srcpkgs/python3-gnupg/patches/0001-skip-test-failing-in-void-CI.patch
@@ -0,0 +1,25 @@
+From 7386c3d8e1dbc332ae3d4eda57d4133b309e5645 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sat, 26 Mar 2022 12:41:28 +0100
+Subject: [PATCH] skip test failing in void CI
+
+---
+ test_gnupg.py | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/test_gnupg.py b/test_gnupg.py
+index 4e8f685..2df2285 100644
+--- a/test_gnupg.py
++++ b/test_gnupg.py
+@@ -1204,6 +1204,7 @@ class GPGTestCase(unittest.TestCase):
+         self.do_file_encryption_and_decryption(encfname, decfname)
+ 
+     @skipIf(os.name == 'nt', 'Test not suitable for Windows')
++    @unittest.skip("Doesn't work in voidlinux CI")
+     def test_invalid_outputs(self):
+         "Test encrypting to invalid output files"
+         encfno, encfname = tempfile.mkstemp()
+-- 
+2.36.1
+
diff --git a/srcpkgs/python3-gnupg/template b/srcpkgs/python3-gnupg/template
index 4470b8bed028..2e34b5bf7552 100644
--- a/srcpkgs/python3-gnupg/template
+++ b/srcpkgs/python3-gnupg/template
@@ -1,18 +1,20 @@
 # Template file for 'python3-gnupg'
 pkgname=python3-gnupg
-_pkgname=python-gnupg
-version=0.4.6
-revision=4
-wrksrc=$_pkgname-$version
-build_style=python3-module
-hostmakedepends="python3-setuptools"
+version=0.4.9
+revision=1
+wrksrc=${pkgname/3/}-$version
+build_style=python3-pep517
+make_install_target=python_gnupg-${version}-py2.py3-none-any.whl
+hostmakedepends="python3-setuptools python3-wheel"
 depends="python3 gnupg"
+checkdepends="${depends} python3-pytest"
 short_desc="Python3 wrapper for GnuPG"
 maintainer="Lon Willett <xgit@lonw.net>"
 license="BSD-3-Clause"
-homepage="https://bitbucket.org/vinay.sajip/python-gnupg"
-distfiles="${PYPI_SITE}/p/${_pkgname}/${_pkgname}-${version}.tar.gz"
-checksum=3aa0884b3bd414652c2385b9df39e7b87272c2eca1b8fcc3089bc9e58652019a
+homepage="https://github.com/vsajip/python-gnupg"
+distfiles="${PYPI_SITE}/p/${pkgname/3/}/${pkgname/3/}-${version}.tar.gz"
+checksum=aaa748795572591aaf127b4ac8985684f3673ff82b39f370c836b006e68fc537
+make_check_pre="env NO_EXTERNAL_TESTS=1"
 
 post_install() {
 	vlicense LICENSE.txt

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] python3-gnupg: update to 0.4.9.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (14 preceding siblings ...)
  2022-06-10 16:09 ` [PR PATCH] [Updated] " jcgruenhage
@ 2022-06-10 18:34 ` jcgruenhage
  2022-06-10 19:59 ` [PR PATCH] [Merged]: " paper42
  16 siblings, 0 replies; 18+ messages in thread
From: jcgruenhage @ 2022-06-10 18:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/36276#discussion_r894801458

Comment:
resolved! pytest is now used, and with `env` in front of the variable, it works correctly.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Merged]: python3-gnupg: update to 0.4.9.
  2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
                   ` (15 preceding siblings ...)
  2022-06-10 18:34 ` [PR REVIEW] " jcgruenhage
@ 2022-06-10 19:59 ` paper42
  16 siblings, 0 replies; 18+ messages in thread
From: paper42 @ 2022-06-10 19:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

There's a merged pull request on the void-packages repository

python3-gnupg: update to 0.4.9.
https://github.com/void-linux/void-packages/pull/36276

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2022-06-10 19:59 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-22  9:51 [PR PATCH] python3-gnupg: update to 0.4.8 jcgruenhage
2022-03-22  9:55 ` [PR REVIEW] " jcgruenhage
2022-03-22  9:55 ` jcgruenhage
2022-03-22  9:55 ` jcgruenhage
2022-03-22 10:06 ` [PR PATCH] [Updated] " jcgruenhage
2022-03-26 11:45 ` jcgruenhage
2022-05-31 18:53 ` [PR REVIEW] " paper42
2022-05-31 18:53 ` paper42
2022-06-10 15:21 ` [PR PATCH] [Updated] " jcgruenhage
2022-06-10 15:24 ` [PR REVIEW] python3-gnupg: update to 0.4.9 jcgruenhage
2022-06-10 15:24 ` jcgruenhage
2022-06-10 15:25 ` jcgruenhage
2022-06-10 15:30 ` paper42
2022-06-10 15:37 ` jcgruenhage
2022-06-10 15:44 ` jcgruenhage
2022-06-10 16:09 ` [PR PATCH] [Updated] " jcgruenhage
2022-06-10 18:34 ` [PR REVIEW] " jcgruenhage
2022-06-10 19:59 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).