Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Update kate5 to 22.04.2 to fix filesystem/settings crash
@ 2022-06-13  0:16 nyanpasu64
  2022-06-13  0:19 ` abenson
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: nyanpasu64 @ 2022-06-13  0:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]

There is a new pull request by nyanpasu64 against master on the void-packages repository

https://github.com/nyanpasu64/void-packages patch-1
https://github.com/void-linux/void-packages/pull/37539

Update kate5 to 22.04.2 to fix filesystem/settings crash
Kate 22.04 shipped with a crash when opening the filesystem panel or settings (which accesses filesystem panel settings internally) would crash. There was an attempt to fix it in 22.04.1 (the current Void Linux Kate version), but it still crashed due to dereferencing a null-ish `KConfigPrivate` pointer ([bug report](https://bugs.kde.org/show_bug.cgi?id=453234)). 22.04.2 reverted the changes altogether, fixing the crash ([commits](https://invent.kde.org/utilities/kate/-/commits/v22.04.2/addons/filebrowser/katefilebrowserplugin.cpp)).

This PR updates kate5 to 22.04.2 to fix the crash.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/37539.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-37539.patch --]
[-- Type: text/x-diff, Size: 1258 bytes --]

From ca47d25ca0c2ef7e1e850a3c9e9a1c32379ed0cb Mon Sep 17 00:00:00 2001
From: nyanpasu64 <nyanpasu64@tuta.io>
Date: Sun, 12 Jun 2022 16:37:28 -0700
Subject: [PATCH] Update kate5 to 22.04.2 to fix filesystem/settings crash

See https://invent.kde.org/utilities/kate/-/commits/v22.04.2/addons/filebrowser/katefilebrowserplugin.cpp
for details.
---
 srcpkgs/kate5/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/kate5/template b/srcpkgs/kate5/template
index dd4240f84fb4..84c794ca852e 100644
--- a/srcpkgs/kate5/template
+++ b/srcpkgs/kate5/template
@@ -1,6 +1,6 @@
 # Template file for 'kate5'
 pkgname=kate5
-version=22.04.1
+version=22.04.2
 revision=1
 wrksrc="${pkgname%5}-${version}"
 build_style=cmake
@@ -14,7 +14,7 @@ maintainer="John <me@johnnynator.dev>"
 license="GPL-3.0-or-later, LGPL-2.0-or-later, GPL-2.0-or-later"
 homepage="https://kde.org/applications/en/utilities/org.kde.kate"
 distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname%5}-${version}.tar.xz"
-checksum=f46ec33d7edf8032efcd489cc431ebf3f93e703e0e7d88a51e93941fd8509849
+checksum=7cfec8b6391d89914aa73ead3902fdafab92f73368e0e26743cd4aab1ef117de
 
 if [ "$CROSS_BUILD" ]; then
 	configure_args+=" -DKF5_HOST_TOOLING=/usr/lib/cmake"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Update kate5 to 22.04.2 to fix filesystem/settings crash
  2022-06-13  0:16 [PR PATCH] Update kate5 to 22.04.2 to fix filesystem/settings crash nyanpasu64
@ 2022-06-13  0:19 ` abenson
  2022-06-13  0:26 ` [PR PATCH] [Updated] " nyanpasu64
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: abenson @ 2022-06-13  0:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/37539#issuecomment-1153331979

Comment:
Edit the commit message to follow [conventions](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes).

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] Update kate5 to 22.04.2 to fix filesystem/settings crash
  2022-06-13  0:16 [PR PATCH] Update kate5 to 22.04.2 to fix filesystem/settings crash nyanpasu64
  2022-06-13  0:19 ` abenson
@ 2022-06-13  0:26 ` nyanpasu64
  2022-06-28 23:34 ` kate5: update to 22.04.2 nyanpasu64
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: nyanpasu64 @ 2022-06-13  0:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1537 bytes --]

There is an updated pull request by nyanpasu64 against master on the void-packages repository

https://github.com/nyanpasu64/void-packages patch-1
https://github.com/void-linux/void-packages/pull/37539

Update kate5 to 22.04.2 to fix filesystem/settings crash
Kate 22.04 shipped with a crash when opening the filesystem panel or settings (which accesses filesystem panel settings internally) would crash. There was an attempt to fix it in 22.04.1 (the current Void Linux Kate version), but it still crashed due to dereferencing a null-ish `KConfigPrivate` pointer ([bug report](https://bugs.kde.org/show_bug.cgi?id=453234)). 22.04.2 reverted the changes altogether, fixing the crash ([commits](https://invent.kde.org/utilities/kate/-/commits/v22.04.2/addons/filebrowser/katefilebrowserplugin.cpp)).

This PR updates kate5 to 22.04.2 to fix the crash.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/37539.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-37539.patch --]
[-- Type: text/x-diff, Size: 1108 bytes --]

From 3f1519ce52b7856abcf6598a02f73f76b2881557 Mon Sep 17 00:00:00 2001
From: nyanpasu64 <nyanpasu64@tuta.io>
Date: Sun, 12 Jun 2022 17:26:17 -0700
Subject: [PATCH] kate5: update to 22.04.2.

---
 srcpkgs/kate5/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/kate5/template b/srcpkgs/kate5/template
index dd4240f84fb4..84c794ca852e 100644
--- a/srcpkgs/kate5/template
+++ b/srcpkgs/kate5/template
@@ -1,6 +1,6 @@
 # Template file for 'kate5'
 pkgname=kate5
-version=22.04.1
+version=22.04.2
 revision=1
 wrksrc="${pkgname%5}-${version}"
 build_style=cmake
@@ -14,7 +14,7 @@ maintainer="John <me@johnnynator.dev>"
 license="GPL-3.0-or-later, LGPL-2.0-or-later, GPL-2.0-or-later"
 homepage="https://kde.org/applications/en/utilities/org.kde.kate"
 distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname%5}-${version}.tar.xz"
-checksum=f46ec33d7edf8032efcd489cc431ebf3f93e703e0e7d88a51e93941fd8509849
+checksum=7cfec8b6391d89914aa73ead3902fdafab92f73368e0e26743cd4aab1ef117de
 
 if [ "$CROSS_BUILD" ]; then
 	configure_args+=" -DKF5_HOST_TOOLING=/usr/lib/cmake"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: kate5: update to 22.04.2.
  2022-06-13  0:16 [PR PATCH] Update kate5 to 22.04.2 to fix filesystem/settings crash nyanpasu64
  2022-06-13  0:19 ` abenson
  2022-06-13  0:26 ` [PR PATCH] [Updated] " nyanpasu64
@ 2022-06-28 23:34 ` nyanpasu64
  2022-06-28 23:34 ` nyanpasu64
  2022-06-30 15:19 ` [PR PATCH] [Merged]: " Duncaen
  4 siblings, 0 replies; 6+ messages in thread
From: nyanpasu64 @ 2022-06-28 23:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

New comment by nyanpasu64 on void-packages repository

https://github.com/void-linux/void-packages/pull/37539#issuecomment-1169386801

Comment:
bump

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: kate5: update to 22.04.2.
  2022-06-13  0:16 [PR PATCH] Update kate5 to 22.04.2 to fix filesystem/settings crash nyanpasu64
                   ` (2 preceding siblings ...)
  2022-06-28 23:34 ` kate5: update to 22.04.2 nyanpasu64
@ 2022-06-28 23:34 ` nyanpasu64
  2022-06-30 15:19 ` [PR PATCH] [Merged]: " Duncaen
  4 siblings, 0 replies; 6+ messages in thread
From: nyanpasu64 @ 2022-06-28 23:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by nyanpasu64 on void-packages repository

https://github.com/void-linux/void-packages/pull/37539#issuecomment-1169386801

Comment:
bump

22.04.2 is still the most recent release as of now (https://invent.kde.org/utilities/kate/-/tags). I don't know if 22.04.3 will be released soon or not.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: kate5: update to 22.04.2.
  2022-06-13  0:16 [PR PATCH] Update kate5 to 22.04.2 to fix filesystem/settings crash nyanpasu64
                   ` (3 preceding siblings ...)
  2022-06-28 23:34 ` nyanpasu64
@ 2022-06-30 15:19 ` Duncaen
  4 siblings, 0 replies; 6+ messages in thread
From: Duncaen @ 2022-06-30 15:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

There's a merged pull request on the void-packages repository

kate5: update to 22.04.2.
https://github.com/void-linux/void-packages/pull/37539

Description:
Kate 22.04 shipped with a crash when opening the filesystem panel or settings (which accesses filesystem panel settings internally) would crash. There was an attempt to fix it in 22.04.1 (the current Void Linux Kate version), but it still crashed due to dereferencing a null-ish `KConfigPrivate` pointer ([bug report](https://bugs.kde.org/show_bug.cgi?id=453234)). 22.04.2 reverted the changes altogether, fixing the crash ([commits](https://invent.kde.org/utilities/kate/-/commits/v22.04.2/addons/filebrowser/katefilebrowserplugin.cpp)).

This PR updates kate5 to 22.04.2 to fix the crash.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: (edit) **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-06-30 15:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-13  0:16 [PR PATCH] Update kate5 to 22.04.2 to fix filesystem/settings crash nyanpasu64
2022-06-13  0:19 ` abenson
2022-06-13  0:26 ` [PR PATCH] [Updated] " nyanpasu64
2022-06-28 23:34 ` kate5: update to 22.04.2 nyanpasu64
2022-06-28 23:34 ` nyanpasu64
2022-06-30 15:19 ` [PR PATCH] [Merged]: " Duncaen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).