From: abenson <abenson@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: flightgear: update to 2020.3.13
Date: Tue, 14 Jun 2022 02:20:03 +0200 [thread overview]
Message-ID: <20220614002003.Xo0PvgIXGcDVWBeh-pa_5QRNbF2vXzwWbpwFR3bGokg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37106@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
There's a closed pull request on the void-packages repository
flightgear: update to 2020.3.13
https://github.com/void-linux/void-packages/pull/37106
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
I removed the qt option because: 1) according to the git history, building without qt allowed cross builds, but it's not necessary now; 2) the package is big anyway; 3) nobody complained that's it's currently broken, so I think nobody uses it.
The time64 patch for musl 1.2 was dropped by Alpine, so I guess Void won't need it either.
I figured out how to build the test suites for both packages, but they segfault (on previous versions too), though the installed program works fine. I'll probably open an issue upstream later.
Does it make sense to enable the tests and add `make_check=no`?
prev parent reply other threads:[~2022-06-14 0:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 16:59 [PR PATCH] " 4ricci
2022-05-13 17:08 ` [PR PATCH] [Updated] " 4ricci
2022-06-12 14:49 ` r-ricci
2022-06-14 0:20 ` abenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614002003.Xo0PvgIXGcDVWBeh-pa_5QRNbF2vXzwWbpwFR3bGokg@z \
--to=abenson@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).