Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] dconf: remove systemd unit
@ 2021-08-08 21:38 ardadem
  2021-08-10 12:43 ` ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: ardadem @ 2021-08-08 21:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

There is a new pull request by ardadem against master on the void-packages repository

https://github.com/ardadem/void-packages pr-dconf-systemd
https://github.com/void-linux/void-packages/pull/32415

dconf: remove systemd unit
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32415.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr-dconf-systemd-32415.patch --]
[-- Type: text/x-diff, Size: 1119 bytes --]

From f71013c2a7e84eed598daafd872f6a6a614ba70c Mon Sep 17 00:00:00 2001
From: Arda Demir <ddmirarda@gmail.com>
Date: Mon, 9 Aug 2021 00:36:49 +0300
Subject: [PATCH] dconf: remove systemd unit

---
 srcpkgs/dconf/template | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/dconf/template b/srcpkgs/dconf/template
index a23a2d0e03cf..75eb2c7e276b 100644
--- a/srcpkgs/dconf/template
+++ b/srcpkgs/dconf/template
@@ -1,7 +1,7 @@
 # Template file for 'dconf'
 pkgname=dconf
 version=0.40.0
-revision=1
+revision=2
 build_style=meson
 hostmakedepends="docbook-xsl glib-devel libxslt pkg-config vala"
 makedepends="dbus-devel libglib-devel gtk+3-devel libxml2-devel vala-devel
@@ -14,6 +14,10 @@ homepage="https://wiki.gnome.org/Projects/dconf"
 distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
 checksum=cf7f22a4c9200421d8d3325c5c1b8b93a36843650c9f95d6451e20f0bcb24533
 
+post_install() {
+	rm -r ${DESTDIR}/usr/lib/systemd
+}
+
 dconf-devel_package() {
 	depends="libglib-devel vala-devel>=0.24 dconf>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: dconf: remove systemd unit
  2021-08-08 21:38 [PR PATCH] dconf: remove systemd unit ardadem
@ 2021-08-10 12:43 ` ericonr
  2021-08-10 12:48 ` Duncaen
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-08-10 12:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32415#issuecomment-895996146

Comment:
@Duncaen what was the deal with keeping systemd files around as documentation?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: dconf: remove systemd unit
  2021-08-08 21:38 [PR PATCH] dconf: remove systemd unit ardadem
  2021-08-10 12:43 ` ericonr
@ 2021-08-10 12:48 ` Duncaen
  2021-08-12 17:06 ` paper42
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Duncaen @ 2021-08-10 12:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/32415#issuecomment-895999185

Comment:
I personally think there is no good reason to not ship those files, don't think there is any agreed policy tho.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: dconf: remove systemd unit
  2021-08-08 21:38 [PR PATCH] dconf: remove systemd unit ardadem
  2021-08-10 12:43 ` ericonr
  2021-08-10 12:48 ` Duncaen
@ 2021-08-12 17:06 ` paper42
  2022-06-01  2:15 ` github-actions
  2022-06-15  2:16 ` [PR PATCH] [Closed]: " github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2021-08-12 17:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32415#issuecomment-897811310

Comment:
> I personally think there is no good reason to not ship those files, don't think there is any agreed policy tho.

We should decide this, the current way is too messy. @Duncaen would you like to make an RFC issue since you came up with this idea?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: dconf: remove systemd unit
  2021-08-08 21:38 [PR PATCH] dconf: remove systemd unit ardadem
                   ` (2 preceding siblings ...)
  2021-08-12 17:06 ` paper42
@ 2022-06-01  2:15 ` github-actions
  2022-06-15  2:16 ` [PR PATCH] [Closed]: " github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2022-06-01  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/32415#issuecomment-1143044619

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: dconf: remove systemd unit
  2021-08-08 21:38 [PR PATCH] dconf: remove systemd unit ardadem
                   ` (3 preceding siblings ...)
  2022-06-01  2:15 ` github-actions
@ 2022-06-15  2:16 ` github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2022-06-15  2:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

There's a closed pull request on the void-packages repository

dconf: remove systemd unit
https://github.com/void-linux/void-packages/pull/32415

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-06-15  2:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-08 21:38 [PR PATCH] dconf: remove systemd unit ardadem
2021-08-10 12:43 ` ericonr
2021-08-10 12:48 ` Duncaen
2021-08-12 17:06 ` paper42
2022-06-01  2:15 ` github-actions
2022-06-15  2:16 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).