New review comment by subnut on void-packages repository https://github.com/void-linux/void-packages/pull/37139#discussion_r903860393 Comment: > `printf %s "some string"` -> `printf "some string"`; the format insertion is unnecessary here If `some string` contains any printf directives, then printf would misbehave when invoked as ``` printf "some string" ``` To avoid that problem, it's generally recommended to invoke printf as ``` printf %s "some string" ``` https://github.com/koalaman/shellcheck/wiki/SC2059 --- **EDIT:** Also, your above example doesn't print the `done.` or `FAILED!` message after the `"Cleaning up DKMS module $modname-$modver... "` --- In your suggestion, `modname` and `modver` are undefined in lines 30-31. > Use a case statement instead of a pair of test invocations to match built and installed modules Why is `case` better? I genuinely don't see any difference between using `case` and `elif [ ... ] || [ ... ]`