Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] vscode package broken
@ 2021-02-27 22:51 selfisekai
  2021-02-27 23:05 ` Johnnynator
                   ` (14 more replies)
  0 siblings, 15 replies; 16+ messages in thread
From: selfisekai @ 2021-02-27 22:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

New issue by selfisekai on void-packages repository

https://github.com/void-linux/void-packages/issues/29105

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

* xuname:  `Void 5.10.19_1 x86_64-musl AuthenticAMD uptodate rF`
  *output of ``xuname`` (part of xtools)*
* package:  `vscode-1.53.2_1`
  *affected package(s) including the version*: ``xbps-query -p pkgver <pkgname>``

### Expected behavior
Run the VS Code

### Actual behavior
```
[laura@suzumiya ~]$ code-oss
Warning: 'app' is not in the list of known options, but still passed to Electron/Chromium.
```

### Steps to reproduce the behavior
run `code-oss`


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: vscode package broken
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
@ 2021-02-27 23:05 ` Johnnynator
  2021-02-27 23:09 ` selfisekai
                   ` (13 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: Johnnynator @ 2021-02-27 23:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-787201312

Comment:
my guess would be that electron 9 is the usual culprit. I really should find some time to get it more reliably on musl. Can you check if running just `electron9` would result in a segfault? It probably will.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: vscode package broken
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
  2021-02-27 23:05 ` Johnnynator
@ 2021-02-27 23:09 ` selfisekai
  2021-02-27 23:33 ` electron{9,10}: broken on musl ericonr
                   ` (12 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: selfisekai @ 2021-02-27 23:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by selfisekai on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-787201784

Comment:
it does after printing the help contents

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
  2021-02-27 23:05 ` Johnnynator
  2021-02-27 23:09 ` selfisekai
@ 2021-02-27 23:33 ` ericonr
  2021-02-27 23:33 ` ericonr
                   ` (11 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-02-27 23:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-787204013

Comment:
electron10 can work on musl, it's just random luck that makes it work or not. For the record, running `electron10` segfaults when I'm using an external monitor but works when I'm on my laptop's built-in one.

@fosslinux was looking into it, but we didn't reach any conclusion.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
                   ` (2 preceding siblings ...)
  2021-02-27 23:33 ` electron{9,10}: broken on musl ericonr
@ 2021-02-27 23:33 ` ericonr
  2021-02-27 23:42 ` ericonr
                   ` (10 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-02-27 23:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-787204013

Comment:
electron10 can work on musl, it's just random luck that makes it work or not. For the record, running `electron10` segfaults when I'm using an external monitor but works when I'm on my laptop's built-in one. `element-desktop` just works.

@fosslinux was looking into it, but we didn't reach any conclusion.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
                   ` (3 preceding siblings ...)
  2021-02-27 23:33 ` ericonr
@ 2021-02-27 23:42 ` ericonr
  2021-02-28  2:01 ` fosslinux
                   ` (9 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-02-27 23:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-787204013

Comment:
electron10 can work on musl, it's just random luck that makes it work or not. For the record, running `electron10` segfaults when I'm using an external monitor but works when I'm on my laptop's built-in one. `element-desktop` just works (for me).

@fosslinux was looking into it, but we didn't reach any conclusion.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
                   ` (4 preceding siblings ...)
  2021-02-27 23:42 ` ericonr
@ 2021-02-28  2:01 ` fosslinux
  2021-02-28  2:02 ` fosslinux
                   ` (8 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: fosslinux @ 2021-02-28  2:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 819 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-787219097

Comment:
Oh, another person! Can you test if `electron10` also results in a segfault? I haven't had much time to look into it recently, but I have a couple of ideas, let me enumerate some of them for everyone.

- I am almost sure this is an issue with the difference between TLS (thread local storage) in musl and glibc. See https://wiki.musl-libc.org/design-concepts.html.
- https://www.openwall.com/lists/musl/2021/02/03/1 seems to be related.
- To test: `-femulated-tls`: This will slow it down but may fix it.

It is *not* a stack-size issue, I am almost completely sure of this, I expanded the stack using pthread and also set a very high default stack size when building.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
                   ` (5 preceding siblings ...)
  2021-02-28  2:01 ` fosslinux
@ 2021-02-28  2:02 ` fosslinux
  2021-02-28  3:13 ` selfisekai
                   ` (7 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: fosslinux @ 2021-02-28  2:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-787219097

Comment:
Oh, another person! Can you test if `electron10` also results in a segfault? I haven't had much time to look into it recently, but I have a couple of ideas, let me enumerate some of them for everyone.

- I am almost sure this is an issue with the difference between TLS (thread local storage) in musl and glibc. See https://wiki.musl-libc.org/design-concepts.html.
- https://www.openwall.com/lists/musl/2021/02/03/1 seems to be related.
- To test: `-femulated-tls`: This will slow it down but may fix it.
- Also another test, we can see if applying this patch https://www.openwall.com/lists/musl/2021/02/17/3 to musl helps at all (but we wouldn't want that in our musl package until it is merged into upstream).

It is *not* a stack-size issue, I am almost completely sure of this, I expanded the stack using pthread and also set a very high default stack size when building.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
                   ` (6 preceding siblings ...)
  2021-02-28  2:02 ` fosslinux
@ 2021-02-28  3:13 ` selfisekai
  2021-02-28  7:41 ` fosslinux
                   ` (6 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: selfisekai @ 2021-02-28  3:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

New comment by selfisekai on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-787237481

Comment:
@fosslinux `electron10` segfaults, but `element-desktop` works fine tho...
I installed glibc void because of this issue (+ no JetBrains support for musl), so I guess I won't be really helpful anymore

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
                   ` (7 preceding siblings ...)
  2021-02-28  3:13 ` selfisekai
@ 2021-02-28  7:41 ` fosslinux
  2021-02-28  7:41 ` fosslinux
                   ` (5 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: fosslinux @ 2021-02-28  7:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-787411484

Comment:
Same as my experience, essentially; thanks for the datapoint, it alone is helpful.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
                   ` (8 preceding siblings ...)
  2021-02-28  7:41 ` fosslinux
@ 2021-02-28  7:41 ` fosslinux
  2021-02-28 13:55 ` selfisekai
                   ` (4 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: fosslinux @ 2021-02-28  7:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-787411484

Comment:
Same as my experience, essentially; thanks for the datapoint, it alone is helpful.

BTW, one thing that might help, what WM/DE were you running, and on Wayland/Xorg?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
                   ` (9 preceding siblings ...)
  2021-02-28  7:41 ` fosslinux
@ 2021-02-28 13:55 ` selfisekai
  2021-03-05  5:46 ` kawaiiamber
                   ` (3 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: selfisekai @ 2021-02-28 13:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by selfisekai on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-787456296

Comment:
MATE with Xorg

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
                   ` (10 preceding siblings ...)
  2021-02-28 13:55 ` selfisekai
@ 2021-03-05  5:46 ` kawaiiamber
  2022-03-24 10:06 ` git-bruh
                   ` (2 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2021-03-05  5:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-791172321

Comment:
> electron10 can work on musl, it's just random luck that makes it work or not. For the record, running `electron10` segfaults when I'm using an external monitor but works when I'm on my laptop's built-in one. `element-desktop` just works (for me).
> 
> @fosslinux was looking into it, but we didn't reach any conclusion.

The `element-desktop` package works for me, as well. But, the `vscode` package produces the exact same behaviour as @selfisekai on my musl machine. `electron10` seg faults for me, too.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
                   ` (11 preceding siblings ...)
  2021-03-05  5:46 ` kawaiiamber
@ 2022-03-24 10:06 ` git-bruh
  2022-06-23  2:15 ` github-actions
  2022-06-25  6:10 ` fosslinux
  14 siblings, 0 replies; 16+ messages in thread
From: git-bruh @ 2022-03-24 10:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

New comment by git-bruh on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-1077453076

Comment:
> Oh, another person! Can you test if `electron10` also results in a segfault? I haven't had much time to look into it recently, but I have a couple of ideas, let me enumerate some of them for everyone.
> 
>     * I am almost sure this is an issue with the difference between TLS (thread local storage) in musl and glibc. See https://wiki.musl-libc.org/design-concepts.html.
> 
>     * https://www.openwall.com/lists/musl/2021/02/03/1 seems to be related.
> 
>     * To test: `-femulated-tls`: This will slow it down but may fix it.
> 
>     * Also another test, we can see if applying this patch https://www.openwall.com/lists/musl/2021/02/17/3 to musl helps at all (but we wouldn't want that in our musl package until it is merged into upstream).
> 
> 
> It is _not_ a stack-size issue, I am almost completely sure of this, I expanded the stack using pthread and also set a very high default stack size when building.

It was indeed a TID caching related issue, see this [patch](https://gitlab.alpinelinux.org/alpine/aports/-/blob/be2a047681e607a97c6378a3ce070e2a44b61e43/community/chromium/musl-tid-caching.patch) for a hacky fix.

[discussion](https://gitlab.alpinelinux.org/alpine/aports/-/issues/13579#note_224393)
[crbug](https://bugs.chromium.org/p/chromium/issues/detail?id=1309235)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
                   ` (12 preceding siblings ...)
  2022-03-24 10:06 ` git-bruh
@ 2022-06-23  2:15 ` github-actions
  2022-06-25  6:10 ` fosslinux
  14 siblings, 0 replies; 16+ messages in thread
From: github-actions @ 2022-06-23  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-1163846946

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: electron{9,10}: broken on musl
  2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
                   ` (13 preceding siblings ...)
  2022-06-23  2:15 ` github-actions
@ 2022-06-25  6:10 ` fosslinux
  14 siblings, 0 replies; 16+ messages in thread
From: fosslinux @ 2022-06-25  6:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/issues/29105#issuecomment-1166201695

Comment:
not fixed


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2022-06-25  6:10 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-27 22:51 [ISSUE] vscode package broken selfisekai
2021-02-27 23:05 ` Johnnynator
2021-02-27 23:09 ` selfisekai
2021-02-27 23:33 ` electron{9,10}: broken on musl ericonr
2021-02-27 23:33 ` ericonr
2021-02-27 23:42 ` ericonr
2021-02-28  2:01 ` fosslinux
2021-02-28  2:02 ` fosslinux
2021-02-28  3:13 ` selfisekai
2021-02-28  7:41 ` fosslinux
2021-02-28  7:41 ` fosslinux
2021-02-28 13:55 ` selfisekai
2021-03-05  5:46 ` kawaiiamber
2022-03-24 10:06 ` git-bruh
2022-06-23  2:15 ` github-actions
2022-06-25  6:10 ` fosslinux

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).