From: icp1994 <icp1994@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: black: update to 22.3.0.
Date: Thu, 23 Jun 2022 12:03:06 +0200 [thread overview]
Message-ID: <20220623100306.hk4uHbe2zwBENXk1b0a3ZXa-yhMQ-DXpIR2bj0WSWqc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34520@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
New comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/34520#issuecomment-1164199013
Comment:
For `black-22.3.0` a couple of the `depends` and `checkdepends` seem redundant. Same with the `make_check_args` and `pre_build()`.
As for the tests, you need to have a custom `do_check()` running the tests twice, with the jupyter dependencies disabled and enabled, as outlined in their [tox.ini](https://github.com/psf/black/blob/ae2c0758c9e61a385df9700dc9c231bf54887041/tox.ini#L37). With that, only one test should fail due to it's incompatibility with `python3-ipython-8.4.0`. It has already been [fixed upstream](https://github.com/psf/black/commit/712f8b37fb12a40ec6ea86903f44c2d0750f56a3) so I'd say it's fair to deselect this particular one.
I have a [working local build](https://github.com/icp1994/void-packages/blob/d93dce4fb97d00b62fe941346fe693b3e90ce77b/srcpkgs/black/template) but unsure whether moving a sub-directory in and out of `<masterdir>` during a `do_check()` is acceptable or not.
next prev parent reply other threads:[~2022-06-23 10:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
2022-06-18 2:13 ` github-actions
2022-06-19 7:11 ` [PR PATCH] [Updated] " Goorzhel
2022-06-19 7:11 ` Goorzhel
2022-06-19 7:23 ` [PR PATCH] [Updated] " Goorzhel
2022-06-19 17:52 ` paper42
2022-06-20 0:02 ` jcgruenhage
2022-06-20 1:21 ` jcgruenhage
2022-06-20 3:03 ` Goorzhel
2022-06-20 3:03 ` [PR PATCH] [Updated] black: update to 22.3.0 Goorzhel
2022-06-20 3:05 ` Goorzhel
2022-06-20 8:57 ` paper42
2022-06-23 9:53 ` icp1994
2022-06-23 10:03 ` icp1994 [this message]
2022-06-23 12:08 ` mhmdanas
2022-06-23 12:09 ` mhmdanas
2022-06-25 0:34 ` Goorzhel
2022-06-25 6:36 ` icp1994
2022-06-25 6:38 ` [PR PATCH] [Closed]: " Goorzhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623100306.hk4uHbe2zwBENXk1b0a3ZXa-yhMQ-DXpIR2bj0WSWqc@z \
--to=icp1994@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).