From: adrian-bl <adrian-bl@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: ZFS 2.1.5_1 breaks boot on non zfs-on-root systems
Date: Fri, 24 Jun 2022 12:47:03 +0200 [thread overview]
Message-ID: <20220624104703.j6POP1RI6dJeOR7qGnIoiLm_157-jEkx8-KEfbsYxsA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37667@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
New comment by adrian-bl on void-packages repository
https://github.com/void-linux/void-packages/issues/37667#issuecomment-1165450907
Comment:
Digging around, the issue seems to be in zfs-lib.sh overwriting `root` with an old value.
I hacked up the following patch which fixes the issue for me:
```
--- zfs-lib.sh.orig 2022-06-24 12:46:00.250658147 +0200
+++ zfs-lib.sh 2022-06-24 12:39:42.823358632 +0200
@@ -87,11 +87,11 @@
return
fi
- root=$(getarg root=)
+ xroot=$(getarg root=)
rootfstype=$(getarg rootfstype=)
# shellcheck disable=SC2249
- case "$root" in
+ case "$xroot" in
""|zfs|zfs:|zfs:AUTO)
root=zfs:AUTO
rootfstype=zfs
@@ -99,7 +99,7 @@
;;
ZFS=*|zfs:*)
- root="${root#zfs:}"
+ root="${xroot#zfs:}"
root="${root#ZFS=}"
root=$(echo "$root" | tr '+' ' ')
rootfstype=zfs
```
next prev parent reply other threads:[~2022-06-24 10:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 10:45 [ISSUE] " adrian-bl
2022-06-24 10:47 ` adrian-bl [this message]
2022-06-24 13:53 ` zdykstra
2022-06-24 13:54 ` ahesford
2022-06-24 14:19 ` adrian-bl
2022-06-24 14:22 ` adrian-bl
2022-06-24 15:31 ` ahesford
2022-06-24 16:25 ` Vaelatern
2022-06-24 16:41 ` Vaelatern
2022-06-30 21:30 ` ahesford
2022-06-30 21:30 ` [ISSUE] [CLOSED] " ahesford
2022-07-01 5:01 ` adrian-bl
2022-07-01 23:49 ` aaFn
2022-07-02 2:33 ` RunningDroid
2022-07-02 10:11 ` aaFn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624104703.j6POP1RI6dJeOR7qGnIoiLm_157-jEkx8-KEfbsYxsA@z \
--to=adrian-bl@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).