From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] usql: update to 0.10.0.
Date: Fri, 24 Jun 2022 21:17:09 +0200 [thread overview]
Message-ID: <20220624191709.VVXK2yRwILgDzmm-yHSal1aYALOLYz90qS8EcNnPzwY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37664@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/37664#discussion_r906336360
Comment:
usql --version doesn't report the correct version
```suggestion
go_import_path=github.com/xo/usql
go_ldflags="-X github.com/xo/usql/text.CommandVersion=${version}"
```
next prev parent reply other threads:[~2022-06-24 19:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 21:46 [PR PATCH] " adbrown101
2022-06-24 19:17 ` paper42 [this message]
2022-06-25 8:40 ` [PR PATCH] [Updated] " adbrown101
2022-06-25 8:40 ` [PR REVIEW] " adbrown101
2022-06-26 6:14 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624191709.VVXK2yRwILgDzmm-yHSal1aYALOLYz90qS8EcNnPzwY@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).