Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] black: update to 21.12b0.
@ 2021-12-14  5:33 Goorzhel
  2022-06-18  2:13 ` github-actions
                   ` (17 more replies)
  0 siblings, 18 replies; 19+ messages in thread
From: Goorzhel @ 2021-12-14  5:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 743 bytes --]

There is a new pull request by Goorzhel against master on the void-packages repository

https://github.com/Goorzhel/void-packages black
https://github.com/void-linux/void-packages/pull/34520

black: update to 21.12b0.
#### Testing the changes
- I tested the changes in this PR: **YES**

```
$ black --target-version py310 47cfr97
Usage: black [OPTIONS] SRC ...
Try 'black -h' for help.

Error: Invalid value for '-t' / '--target-version': invalid choice: py310. (choose from py27, py33, py34, py35, py36, py37, py38, py39)

<I update `black`.>

$ black --target-version py310 47cfr97
reformatted 47cfr97
All done! ✨ 🍰 ✨
1 file reformatted.
```


A patch file from https://github.com/void-linux/void-packages/pull/34520.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-black-34520.patch --]
[-- Type: text/x-diff, Size: 1220 bytes --]

From b25dc64d43e3b780bc9e0a4f2179976c847737ea Mon Sep 17 00:00:00 2001
From: Antonio Gurgel <antonio@goorzhel.com>
Date: Mon, 13 Dec 2021 21:25:42 -0800
Subject: [PATCH] black: update to 21.12b0.

---
 srcpkgs/black/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/black/template b/srcpkgs/black/template
index b17749777fb0..2d1a1b146622 100644
--- a/srcpkgs/black/template
+++ b/srcpkgs/black/template
@@ -1,7 +1,7 @@
 # Template file for 'black'
 pkgname=black
-version=21.9b0
-revision=2
+version=21.12b0
+revision=1
 build_style=python3-module
 # Disable tests that require `black` in the search path for commands.
 make_check_args="--deselect tests/test_primer.py::PrimerLibTests::test_gen_check_output
@@ -20,7 +20,7 @@ license="MIT"
 homepage="https://github.com/psf/black"
 changelog="https://raw.githubusercontent.com/psf/black/main/CHANGES.md"
 distfiles="${PYPI_SITE}/b/black/black-${version}.tar.gz"
-checksum=7de4cfc7eb6b710de325712d40125689101d21d25283eed7e9998722cf10eb91
+checksum=77b80f693a569e2e527958459634f18df9b0ba2625ba4e0c2d5da5be42e6f2b3
 
 pre_build() {
 	# <https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-python/black/black-21.8_beta0.ebuild#n45>.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 21.12b0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
@ 2022-06-18  2:13 ` github-actions
  2022-06-19  7:11 ` [PR PATCH] [Updated] " Goorzhel
                   ` (16 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: github-actions @ 2022-06-18  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1159340225

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] black: update to 21.12b0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
  2022-06-18  2:13 ` github-actions
@ 2022-06-19  7:11 ` Goorzhel
  2022-06-19  7:11 ` Goorzhel
                   ` (15 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: Goorzhel @ 2022-06-19  7:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

There is an updated pull request by Goorzhel against master on the void-packages repository

https://github.com/Goorzhel/void-packages black
https://github.com/void-linux/void-packages/pull/34520

black: update to 21.12b0.
#### Testing the changes
- I tested the changes in this PR: **YES**

```
$ black --target-version py310 47cfr97
Usage: black [OPTIONS] SRC ...
Try 'black -h' for help.

Error: Invalid value for '-t' / '--target-version': invalid choice: py310. (choose from py27, py33, py34, py35, py36, py37, py38, py39)

<I update `black`.>

$ black --target-version py310 47cfr97
reformatted 47cfr97
All done! ✨ 🍰 ✨
1 file reformatted.
```


A patch file from https://github.com/void-linux/void-packages/pull/34520.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-black-34520.patch --]
[-- Type: text/x-diff, Size: 2322 bytes --]

From 0656d7696fce17ebd42b7d6da077df1da9f658cd Mon Sep 17 00:00:00 2001
From: Antonio Gurgel <antonio@goorzhel.com>
Date: Mon, 13 Dec 2021 21:25:42 -0800
Subject: [PATCH 1/2] black: update to 21.12b0.

---
 srcpkgs/black/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/black/template b/srcpkgs/black/template
index b17749777fb0..7bc05f8c09b9 100644
--- a/srcpkgs/black/template
+++ b/srcpkgs/black/template
@@ -1,7 +1,7 @@
 # Template file for 'black'
 pkgname=black
-version=21.9b0
-revision=2
+version=22.3.0
+revision=1
 build_style=python3-module
 # Disable tests that require `black` in the search path for commands.
 make_check_args="--deselect tests/test_primer.py::PrimerLibTests::test_gen_check_output
@@ -20,7 +20,7 @@ license="MIT"
 homepage="https://github.com/psf/black"
 changelog="https://raw.githubusercontent.com/psf/black/main/CHANGES.md"
 distfiles="${PYPI_SITE}/b/black/black-${version}.tar.gz"
-checksum=7de4cfc7eb6b710de325712d40125689101d21d25283eed7e9998722cf10eb91
+checksum=35020b8886c022ced9282b51b5a875b6d1ab0c387b31a065b84db7c33085ca79
 
 pre_build() {
 	# <https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-python/black/black-21.8_beta0.ebuild#n45>.

From a5bc38e000b215ae37a34378ee4734b39bc609a0 Mon Sep 17 00:00:00 2001
From: Antonio Gurgel <antonio@goorzhel.com>
Date: Sun, 19 Jun 2022 00:07:50 -0700
Subject: [PATCH 2/2] python3-click: update to 8.1.3.

---
 srcpkgs/python3-click/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-click/template b/srcpkgs/python3-click/template
index 2583a95cc4ad..c0f39a2d3e70 100644
--- a/srcpkgs/python3-click/template
+++ b/srcpkgs/python3-click/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-click'
 pkgname=python3-click
-version=7.1.2
-revision=5
+version=8.1.3
+revision=1
 wrksrc="click-${version}"
 build_style="python3-module"
 hostmakedepends="python3-setuptools"
@@ -11,7 +11,7 @@ maintainer="Oliver Kiddle <okiddle@yahoo.co.uk>"
 license="BSD-3-Clause"
 homepage="http://click.pocoo.org/"
 distfiles="${PYPI_SITE}/c/click/click-${version}.tar.gz"
-checksum=d2b5255c7c6349bc1bd1e59e08cd12acbbd63ce649f2588755783aa94dfb6b1a
+checksum=7682dc8afb30297001674575ea00d1814d808d6a36af415a82bd481d37ba7b8e
 
 post_install() {
 	vlicense LICENSE.rst

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 21.12b0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
  2022-06-18  2:13 ` github-actions
  2022-06-19  7:11 ` [PR PATCH] [Updated] " Goorzhel
@ 2022-06-19  7:11 ` Goorzhel
  2022-06-19  7:23 ` [PR PATCH] [Updated] " Goorzhel
                   ` (14 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: Goorzhel @ 2022-06-19  7:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by Goorzhel on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1159636243

Comment:
I encountered psf/black#3111, but fixed it by updating `python3-click` from `7.1.2` to `8.1.3`.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] black: update to 21.12b0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (2 preceding siblings ...)
  2022-06-19  7:11 ` Goorzhel
@ 2022-06-19  7:23 ` Goorzhel
  2022-06-19 17:52 ` paper42
                   ` (13 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: Goorzhel @ 2022-06-19  7:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

There is an updated pull request by Goorzhel against master on the void-packages repository

https://github.com/Goorzhel/void-packages black
https://github.com/void-linux/void-packages/pull/34520

black: update to 21.12b0.
#### Testing the changes
- I tested the changes in this PR: **YES**

```
$ black --target-version py310 47cfr97
Usage: black [OPTIONS] SRC ...
Try 'black -h' for help.

Error: Invalid value for '-t' / '--target-version': invalid choice: py310. (choose from py27, py33, py34, py35, py36, py37, py38, py39)

<I update `black`.>

$ black --target-version py310 47cfr97
reformatted 47cfr97
All done! ✨ 🍰 ✨
1 file reformatted.
```


A patch file from https://github.com/void-linux/void-packages/pull/34520.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-black-34520.patch --]
[-- Type: text/x-diff, Size: 2321 bytes --]

From f7fbdc5f97266379a6ae48eb051fc90e8d3bd8e4 Mon Sep 17 00:00:00 2001
From: Antonio Gurgel <antonio@goorzhel.com>
Date: Mon, 13 Dec 2021 21:25:42 -0800
Subject: [PATCH 1/2] black: update to 22.3.0.

---
 srcpkgs/black/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/black/template b/srcpkgs/black/template
index b17749777fb0..7bc05f8c09b9 100644
--- a/srcpkgs/black/template
+++ b/srcpkgs/black/template
@@ -1,7 +1,7 @@
 # Template file for 'black'
 pkgname=black
-version=21.9b0
-revision=2
+version=22.3.0
+revision=1
 build_style=python3-module
 # Disable tests that require `black` in the search path for commands.
 make_check_args="--deselect tests/test_primer.py::PrimerLibTests::test_gen_check_output
@@ -20,7 +20,7 @@ license="MIT"
 homepage="https://github.com/psf/black"
 changelog="https://raw.githubusercontent.com/psf/black/main/CHANGES.md"
 distfiles="${PYPI_SITE}/b/black/black-${version}.tar.gz"
-checksum=7de4cfc7eb6b710de325712d40125689101d21d25283eed7e9998722cf10eb91
+checksum=35020b8886c022ced9282b51b5a875b6d1ab0c387b31a065b84db7c33085ca79
 
 pre_build() {
 	# <https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-python/black/black-21.8_beta0.ebuild#n45>.

From f8518c038ec49cb68d8404f8f1dcf42762517c1e Mon Sep 17 00:00:00 2001
From: Antonio Gurgel <antonio@goorzhel.com>
Date: Sun, 19 Jun 2022 00:07:50 -0700
Subject: [PATCH 2/2] python3-click: update to 8.1.3.

---
 srcpkgs/python3-click/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-click/template b/srcpkgs/python3-click/template
index 2583a95cc4ad..c0f39a2d3e70 100644
--- a/srcpkgs/python3-click/template
+++ b/srcpkgs/python3-click/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-click'
 pkgname=python3-click
-version=7.1.2
-revision=5
+version=8.1.3
+revision=1
 wrksrc="click-${version}"
 build_style="python3-module"
 hostmakedepends="python3-setuptools"
@@ -11,7 +11,7 @@ maintainer="Oliver Kiddle <okiddle@yahoo.co.uk>"
 license="BSD-3-Clause"
 homepage="http://click.pocoo.org/"
 distfiles="${PYPI_SITE}/c/click/click-${version}.tar.gz"
-checksum=d2b5255c7c6349bc1bd1e59e08cd12acbbd63ce649f2588755783aa94dfb6b1a
+checksum=7682dc8afb30297001674575ea00d1814d808d6a36af415a82bd481d37ba7b8e
 
 post_install() {
 	vlicense LICENSE.rst

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 21.12b0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (3 preceding siblings ...)
  2022-06-19  7:23 ` [PR PATCH] [Updated] " Goorzhel
@ 2022-06-19 17:52 ` paper42
  2022-06-20  0:02 ` jcgruenhage
                   ` (12 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: paper42 @ 2022-06-19 17:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1159783928

Comment:
Both you and @jcgruenhage updated python3-click in PRs, could you open a separate PR, create a list of all dependants and test them? This will probably needs more testing than what can be achieved when it's buried in PRs for different packages.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 21.12b0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (4 preceding siblings ...)
  2022-06-19 17:52 ` paper42
@ 2022-06-20  0:02 ` jcgruenhage
  2022-06-20  1:21 ` jcgruenhage
                   ` (11 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: jcgruenhage @ 2022-06-20  0:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1159836951

Comment:
So, regarding the click update, I've ran `./xbps-src -Q -s pkg <package>` for everything that depends on click, and `black, fava, gandi-cli, magic-wormhole, papis, python3-Flask, python3-click-threading, termdown, vdirsyncer` seems to be the list of packages that don't build right now with the update. I'll open a separate PR, as you suggested, looking through each of these and why they don't build.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 21.12b0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (5 preceding siblings ...)
  2022-06-20  0:02 ` jcgruenhage
@ 2022-06-20  1:21 ` jcgruenhage
  2022-06-20  3:03 ` Goorzhel
                   ` (10 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: jcgruenhage @ 2022-06-20  1:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1159864950

Comment:
Actually, this is horrible.. 

`black` does need to be upgraded at the same time, but with the newer version the jupyter tests for black fail, so more along that probably has to be checked as well.

`fava` has other problems and also doesn't want to build. With `fava` also updated, that problem is resolved, but now it has problems determining it's version after switching to pep517 build style as well.

`gandi-cli` fails over a hundred/a fourth of it's tests. Haven't looked deeper.

`magic-wormhole` is not even able to run it's tests in it's current state. It's complaining about wheel and pip not being available.

`papis` is the same story as `magic-wormhole`.

`python3-Flask` also has 4 of it's tests failing, but at least that's less than a percent. The tests I've seen so far all are related to Pytest deprecations, so nothing to really worry about.

`python3-click-threading` is the first of these that's easy enough: Updating it to 0.5.0 makes all of it's tests pass again :)

`termdown` is the same as `papir` and `magic-wormhole`.

`vdirsyncer` actually builds fine, not sure why that failed earlier.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 21.12b0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (6 preceding siblings ...)
  2022-06-20  1:21 ` jcgruenhage
@ 2022-06-20  3:03 ` Goorzhel
  2022-06-20  3:03 ` [PR PATCH] [Updated] black: update to 22.3.0 Goorzhel
                   ` (9 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: Goorzhel @ 2022-06-20  3:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

New comment by Goorzhel on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1159914102

Comment:
Yeah, this is going to get tricky. I'll remove `python3-click` from this PR and block it on @jcgruenhage's PR, #37514. (Or might it make more sense to start a new one for `click`?)

The way I understand it, those dependencies can be sorted into the following buckets:

### Can't run tests
- `magic-wormhole`
- `papis`
- `termdown`

### Fails tests
- `gandi-cli`
- `python3-Flask` (of little concern)
- `black`

### Has other problems
- `fava`

### Passes tests and builds
- `python3-click-threading` (if updated to 0.5.0)
- `vdirsyncer`

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] black: update to 22.3.0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (7 preceding siblings ...)
  2022-06-20  3:03 ` Goorzhel
@ 2022-06-20  3:03 ` Goorzhel
  2022-06-20  3:05 ` Goorzhel
                   ` (8 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: Goorzhel @ 2022-06-20  3:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

There is an updated pull request by Goorzhel against master on the void-packages repository

https://github.com/Goorzhel/void-packages black
https://github.com/void-linux/void-packages/pull/34520

black: update to 22.3.0.
#### Testing the changes
- I tested the changes in this PR: **YES**

```
$ black --target-version py310 47cfr97
Usage: black [OPTIONS] SRC ...
Try 'black -h' for help.

Error: Invalid value for '-t' / '--target-version': invalid choice: py310. (choose from py27, py33, py34, py35, py36, py37, py38, py39)

<I update `black`.>

$ black --target-version py310 47cfr97
reformatted 47cfr97
All done! ✨ 🍰 ✨
1 file reformatted.
```


A patch file from https://github.com/void-linux/void-packages/pull/34520.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-black-34520.patch --]
[-- Type: text/x-diff, Size: 1218 bytes --]

From 8cc8d3d68679d8c310e873933e53e0e5ca4b12a1 Mon Sep 17 00:00:00 2001
From: Antonio Gurgel <antonio@goorzhel.com>
Date: Mon, 13 Dec 2021 21:25:42 -0800
Subject: [PATCH] black: update to 22.3.0.

---
 srcpkgs/black/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/black/template b/srcpkgs/black/template
index b17749777fb0..7bc05f8c09b9 100644
--- a/srcpkgs/black/template
+++ b/srcpkgs/black/template
@@ -1,7 +1,7 @@
 # Template file for 'black'
 pkgname=black
-version=21.9b0
-revision=2
+version=22.3.0
+revision=1
 build_style=python3-module
 # Disable tests that require `black` in the search path for commands.
 make_check_args="--deselect tests/test_primer.py::PrimerLibTests::test_gen_check_output
@@ -20,7 +20,7 @@ license="MIT"
 homepage="https://github.com/psf/black"
 changelog="https://raw.githubusercontent.com/psf/black/main/CHANGES.md"
 distfiles="${PYPI_SITE}/b/black/black-${version}.tar.gz"
-checksum=7de4cfc7eb6b710de325712d40125689101d21d25283eed7e9998722cf10eb91
+checksum=35020b8886c022ced9282b51b5a875b6d1ab0c387b31a065b84db7c33085ca79
 
 pre_build() {
 	# <https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-python/black/black-21.8_beta0.ebuild#n45>.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 22.3.0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (8 preceding siblings ...)
  2022-06-20  3:03 ` [PR PATCH] [Updated] black: update to 22.3.0 Goorzhel
@ 2022-06-20  3:05 ` Goorzhel
  2022-06-20  8:57 ` paper42
                   ` (7 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: Goorzhel @ 2022-06-20  3:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

New comment by Goorzhel on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1159914102

Comment:
Yeah, this is going to get tricky. I'll remove `python3-click` from this PR and ~~block it on @jcgruenhage's PR, #37514. (Or might it make more sense to start a new one for `click`?)~~ open a separate one on @paper42's advice.
 
The way I understand it, those dependencies can be sorted into the following buckets:

### Can't run tests
- `magic-wormhole`
- `papis`
- `termdown`

### Fails tests
- `gandi-cli`
- `python3-Flask` (of little concern)
- `black`

### Has other problems
- `fava`

### Passes tests and builds
- `python3-click-threading` (if updated to 0.5.0)
- `vdirsyncer`

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 22.3.0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (9 preceding siblings ...)
  2022-06-20  3:05 ` Goorzhel
@ 2022-06-20  8:57 ` paper42
  2022-06-23  9:53 ` icp1994
                   ` (6 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: paper42 @ 2022-06-20  8:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1160168075

Comment:
It's also possible that tests were already broken. In that case, we don't have to care about that in the click update PR.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 22.3.0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (10 preceding siblings ...)
  2022-06-20  8:57 ` paper42
@ 2022-06-23  9:53 ` icp1994
  2022-06-23 10:03 ` icp1994
                   ` (5 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: icp1994 @ 2022-06-23  9:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1164199013

Comment:
For `black-22.3.0` a couple of the `depends` and `checkdepends` seem redundant. Same with the `make_check_args` and `pre_build()`.

As for the tests, you need to have a custom `do_check()` running the tests twice, with the jupyter dependencies disabled and enabled, as outlined in their [tox.ini](https://github.com/psf/black/blob/ae2c0758c9e61a385df9700dc9c231bf54887041/tox.ini#L37). With that, only one test should fail due to it's incompatibility with `python3-ipython-8.4.0`. It has already been [fixed upstream](https://github.com/psf/black/commit/712f8b37fb12a40ec6ea86903f44c2d0750f56a3) so I'd say it's fair to deselect this particular one.

I have a [working local build](https://github.com/icp1994/void-packages/blob/af9f829af2dc786699c250f3d9597b22cd8dc932/srcpkgs/black/template) but unsure whether moving a sub-directory in and out from `<masterdir>` during a `do_check()` is acceptable or not.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 22.3.0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (11 preceding siblings ...)
  2022-06-23  9:53 ` icp1994
@ 2022-06-23 10:03 ` icp1994
  2022-06-23 12:08 ` mhmdanas
                   ` (4 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: icp1994 @ 2022-06-23 10:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1164199013

Comment:
For `black-22.3.0` a couple of the `depends` and `checkdepends` seem redundant. Same with the `make_check_args` and `pre_build()`.

As for the tests, you need to have a custom `do_check()` running the tests twice, with the jupyter dependencies disabled and enabled, as outlined in their [tox.ini](https://github.com/psf/black/blob/ae2c0758c9e61a385df9700dc9c231bf54887041/tox.ini#L37). With that, only one test should fail due to it's incompatibility with `python3-ipython-8.4.0`. It has already been [fixed upstream](https://github.com/psf/black/commit/712f8b37fb12a40ec6ea86903f44c2d0750f56a3) so I'd say it's fair to deselect this particular one.

I have a [working local build](https://github.com/icp1994/void-packages/blob/d93dce4fb97d00b62fe941346fe693b3e90ce77b/srcpkgs/black/template) but unsure whether moving a sub-directory in and out of `<masterdir>` during a `do_check()` is acceptable or not.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 22.3.0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (12 preceding siblings ...)
  2022-06-23 10:03 ` icp1994
@ 2022-06-23 12:08 ` mhmdanas
  2022-06-23 12:09 ` mhmdanas
                   ` (3 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: mhmdanas @ 2022-06-23 12:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1164327328

Comment:
> For black-22.3.0 a couple of the depends and checkdepends seem redundant.

I went ahead and checked, and I found that `python3-regex` and `python3-typing_extensions` can be removed from `depends`. No idea what `checkdepends` are redundant though.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 22.3.0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (13 preceding siblings ...)
  2022-06-23 12:08 ` mhmdanas
@ 2022-06-23 12:09 ` mhmdanas
  2022-06-25  0:34 ` Goorzhel
                   ` (2 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: mhmdanas @ 2022-06-23 12:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1164327328

Comment:
> For black-22.3.0 a couple of the depends and checkdepends seem redundant.

I went ahead and checked, and I found that `python3-regex` and `python3-typing_extensions` can be removed from `depends`. No idea what `checkdepends` are redundant though.

Edit: ah, your local commit shows the removed dependencies, I didn't notice.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 22.3.0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (14 preceding siblings ...)
  2022-06-23 12:09 ` mhmdanas
@ 2022-06-25  0:34 ` Goorzhel
  2022-06-25  6:36 ` icp1994
  2022-06-25  6:38 ` [PR PATCH] [Closed]: " Goorzhel
  17 siblings, 0 replies; 19+ messages in thread
From: Goorzhel @ 2022-06-25  0:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New comment by Goorzhel on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1166153614

Comment:
`python3-click` has been addressed. @icp1994, since you got it working first, wanna send a PR superseding mine?

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: black: update to 22.3.0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (15 preceding siblings ...)
  2022-06-25  0:34 ` Goorzhel
@ 2022-06-25  6:36 ` icp1994
  2022-06-25  6:38 ` [PR PATCH] [Closed]: " Goorzhel
  17 siblings, 0 replies; 19+ messages in thread
From: icp1994 @ 2022-06-25  6:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/34520#issuecomment-1166205044

Comment:
Okay, I created https://github.com/void-linux/void-packages/pull/37676

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Closed]: black: update to 22.3.0.
  2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
                   ` (16 preceding siblings ...)
  2022-06-25  6:36 ` icp1994
@ 2022-06-25  6:38 ` Goorzhel
  17 siblings, 0 replies; 19+ messages in thread
From: Goorzhel @ 2022-06-25  6:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

There's a closed pull request on the void-packages repository

black: update to 22.3.0.
https://github.com/void-linux/void-packages/pull/34520

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

```
$ black --target-version py310 47cfr97
Usage: black [OPTIONS] SRC ...
Try 'black -h' for help.

Error: Invalid value for '-t' / '--target-version': invalid choice: py310. (choose from py27, py33, py34, py35, py36, py37, py38, py39)

<I update `black`.>

$ black --target-version py310 47cfr97
reformatted 47cfr97
All done! ✨ 🍰 ✨
1 file reformatted.
```


^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2022-06-25  6:38 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-14  5:33 [PR PATCH] black: update to 21.12b0 Goorzhel
2022-06-18  2:13 ` github-actions
2022-06-19  7:11 ` [PR PATCH] [Updated] " Goorzhel
2022-06-19  7:11 ` Goorzhel
2022-06-19  7:23 ` [PR PATCH] [Updated] " Goorzhel
2022-06-19 17:52 ` paper42
2022-06-20  0:02 ` jcgruenhage
2022-06-20  1:21 ` jcgruenhage
2022-06-20  3:03 ` Goorzhel
2022-06-20  3:03 ` [PR PATCH] [Updated] black: update to 22.3.0 Goorzhel
2022-06-20  3:05 ` Goorzhel
2022-06-20  8:57 ` paper42
2022-06-23  9:53 ` icp1994
2022-06-23 10:03 ` icp1994
2022-06-23 12:08 ` mhmdanas
2022-06-23 12:09 ` mhmdanas
2022-06-25  0:34 ` Goorzhel
2022-06-25  6:36 ` icp1994
2022-06-25  6:38 ` [PR PATCH] [Closed]: " Goorzhel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).