From: wael444 <wael444@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: snore-0.2
Date: Sat, 25 Jun 2022 05:29:23 +0200 [thread overview]
Message-ID: <20220625032923.wrrvVCpfA4rW10GXGNLoJiyN-Fq8zb1v3loTuWWfNuQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37299@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
New review comment by wael444 on void-packages repository
https://github.com/void-linux/void-packages/pull/37299#discussion_r906626974
Comment:
`CFLAGS="-DVERSION=${version}"` and `CFLAGS="-DVERSION=${version}"` will produce:
```
snore.c: In function 'main':
snore.c:112:15: error: expected ')' before numeric constant
112 | die("snore-"VERSION"\n");
| ^
| )
make: *** [Makefile:20: snore.o] Error 1
=> ERROR: snore-0.2_1: do_build: '${make_cmd} CC="$CC" CXX="$CXX" LD="$LD" AR="$AR" RANLIB="$RANLIB" CPP="$CPP" AS="$AS" OBJCOPY="$OBJCOPY" OBJDUMP="$OBJDUMP" CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS" LDFLAGS="$LDFLAGS" ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR: in do_build() at common/build-style/gnu-makefile.sh:9
```
i also took this from other templates.
next prev parent reply other threads:[~2022-06-25 3:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 9:45 [PR PATCH] " wael444
2022-05-26 9:46 ` wael444
2022-05-26 16:17 ` [PR REVIEW] " Chocimier
2022-05-26 16:17 ` Chocimier
2022-05-26 17:21 ` wael444
2022-05-26 17:27 ` [PR PATCH] [Updated] " wael444
2022-05-26 17:41 ` [PR REVIEW] " paper42
2022-05-26 17:43 ` wael444
2022-05-26 17:50 ` Chocimier
2022-06-07 11:38 ` [PR PATCH] [Updated] " wael444
2022-06-07 11:41 ` wael444
2022-06-11 22:21 ` classabbyamp
2022-06-14 16:04 ` [PR PATCH] [Updated] " wael444
2022-06-25 3:08 ` wael444
2022-06-25 3:21 ` [PR REVIEW] " classabbyamp
2022-06-25 3:22 ` classabbyamp
2022-06-25 3:29 ` wael444 [this message]
2022-06-29 20:30 ` [PR PATCH] [Updated] " wael444
2022-07-22 12:47 ` wael444
2022-07-22 13:46 ` paper42
2022-07-22 20:28 ` [PR REVIEW] " wael444
2022-07-22 21:19 ` classabbyamp
2022-07-23 9:49 ` wael444
2022-07-23 9:50 ` [PR PATCH] [Updated] " wael444
2022-07-23 9:51 ` wael444
2022-07-23 9:56 ` wael444
2022-10-24 2:14 ` New package: snore-0.3.1 github-actions
2022-11-08 2:13 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220625032923.wrrvVCpfA4rW10GXGNLoJiyN-Fq8zb1v3loTuWWfNuQ@z \
--to=wael444@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).