Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] dracut: add missing is_keysource parameter to cryptroot-ask
@ 2022-02-28 18:50 Nicop06
  2022-06-26  2:17 ` github-actions
  2022-07-11  2:13 ` [PR PATCH] [Closed]: " github-actions
  0 siblings, 2 replies; 3+ messages in thread
From: Nicop06 @ 2022-02-28 18:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

There is a new pull request by Nicop06 against master on the void-packages repository

https://github.com/Nicop06/void-packages dracut
https://github.com/void-linux/void-packages/pull/35892

dracut: add missing is_keysource parameter to cryptroot-ask
Without this change, rd.luks.key.tout is used, which is the number of
times cryptroot tries to find the key.


#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64`)

A patch file from https://github.com/void-linux/void-packages/pull/35892.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dracut-35892.patch --]
[-- Type: text/x-diff, Size: 1975 bytes --]

From 302886448bf76c0f8c2152ad60762cfb09560440 Mon Sep 17 00:00:00 2001
From: Nicolas Porcel <nicolasporcel06@gmail.com>
Date: Mon, 28 Feb 2022 18:41:22 +0000
Subject: [PATCH] dracut: add missing is_keysource parameter to cryptroot-ask

Without this change, rd.luks.key.tout is used, which is the number of
times cryptroot tries to find the key.
---
 .../dracut/patches/not_keysource_by_default.patch   | 13 +++++++++++++
 srcpkgs/dracut/template                             |  2 +-
 2 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/dracut/patches/not_keysource_by_default.patch

diff --git a/srcpkgs/dracut/patches/not_keysource_by_default.patch b/srcpkgs/dracut/patches/not_keysource_by_default.patch
new file mode 100644
index 000000000000..f0d8a060dee9
--- /dev/null
+++ b/srcpkgs/dracut/patches/not_keysource_by_default.patch
@@ -0,0 +1,13 @@
+diff --git a/modules.d/90crypt/parse-crypt.sh b/modules.d/90crypt/parse-crypt.sh
+index 4e899fed..60faab43 100755
+--- a/modules.d/90crypt/parse-crypt.sh
++++ b/modules.d/90crypt/parse-crypt.sh
+@@ -177,7 +177,7 @@ else
+             {
+                 printf -- 'ENV{ID_FS_TYPE}=="crypto_LUKS", RUN+="%s ' "$(command -v initqueue)"
+                 printf -- '--unique --settled --onetime --name cryptroot-ask-%%k '
+-                printf -- '%s $env{DEVNAME} luks-$env{ID_FS_UUID} %s"\n' "$(command -v cryptroot-ask)" "$tout"
++                printf -- '%s $env{DEVNAME} luks-$env{ID_FS_UUID} 0 %s"\n' "$(command -v cryptroot-ask)" "$tout"
+             } >> /etc/udev/rules.d/70-luks.rules.new
+         else
+             {
diff --git a/srcpkgs/dracut/template b/srcpkgs/dracut/template
index d3b6c6616722..22ffa7a82c4e 100644
--- a/srcpkgs/dracut/template
+++ b/srcpkgs/dracut/template
@@ -1,7 +1,7 @@
 # Template file for 'dracut'
 pkgname=dracut
 version=053
-revision=2
+revision=3
 build_style=configure
 configure_args="--prefix=/usr --sysconfdir=/etc"
 conf_files="/etc/dracut.conf"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: dracut: add missing is_keysource parameter to cryptroot-ask
  2022-02-28 18:50 [PR PATCH] dracut: add missing is_keysource parameter to cryptroot-ask Nicop06
@ 2022-06-26  2:17 ` github-actions
  2022-07-11  2:13 ` [PR PATCH] [Closed]: " github-actions
  1 sibling, 0 replies; 3+ messages in thread
From: github-actions @ 2022-06-26  2:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/35892#issuecomment-1166399978

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Closed]: dracut: add missing is_keysource parameter to cryptroot-ask
  2022-02-28 18:50 [PR PATCH] dracut: add missing is_keysource parameter to cryptroot-ask Nicop06
  2022-06-26  2:17 ` github-actions
@ 2022-07-11  2:13 ` github-actions
  1 sibling, 0 replies; 3+ messages in thread
From: github-actions @ 2022-07-11  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

There's a closed pull request on the void-packages repository

dracut: add missing is_keysource parameter to cryptroot-ask
https://github.com/void-linux/void-packages/pull/35892

Description:
Without this change, rd.luks.key.tout is used, which is the number of
times cryptroot tries to find the key.


#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64`)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-11  2:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-28 18:50 [PR PATCH] dracut: add missing is_keysource parameter to cryptroot-ask Nicop06
2022-06-26  2:17 ` github-actions
2022-07-11  2:13 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).