Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] xbps-src: consistent source style
@ 2022-02-27 18:05 kawaiiamber
  2022-02-27 18:06 ` [PR PATCH] [Updated] " kawaiiamber
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: kawaiiamber @ 2022-02-27 18:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

There is a new pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages xbps-src
https://github.com/void-linux/void-packages/pull/35878

xbps-src: consistent source style
On lines: 442, 458,  700, 849, and 873 - the `. FILE` style is used to source in a file. As far as I can tell, `. FILE` and `source FILE` is exactly the same. If `.` is used everywhere else, then it seems `source` should be changed to `.` for consistency unless there is a difference I'm not aware of.

A patch file from https://github.com/void-linux/void-packages/pull/35878.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xbps-src-35878.patch --]
[-- Type: text/x-diff, Size: 997 bytes --]

From 805a6dfb0cbe55d9d4dd82e0391edba0e0664d8e Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 27 Feb 2022 11:07:07 -0700
Subject: [PATCH] xbps-src: consistent source style

---
 xbps-src | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xbps-src b/xbps-src
index ff249015ed02..4184997bbfa2 100755
--- a/xbps-src
+++ b/xbps-src
@@ -938,12 +938,12 @@ case "$XBPS_TARGET" in
         ;;
     show-var)
         for f in ${XBPS_COMMONDIR}/environment/setup/*.sh; do
-            source $f
+            . $f
         done
         if [ "$XBPS_CROSS_BUILD" ]; then
-            source ${XBPS_COMMONDIR}/cross-profiles/${XBPS_CROSS_BUILD}.sh
+            . ${XBPS_COMMONDIR}/cross-profiles/${XBPS_CROSS_BUILD}.sh
         else
-            source ${XBPS_COMMONDIR}/build-profiles/${XBPS_MACHINE}.sh
+            . ${XBPS_COMMONDIR}/build-profiles/${XBPS_MACHINE}.sh
         fi
         eval value="\${$XBPS_TARGET_PKG}"
         echo $value

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] xbps-src: consistent source style
  2022-02-27 18:05 [PR PATCH] xbps-src: consistent source style kawaiiamber
@ 2022-02-27 18:06 ` kawaiiamber
  2022-06-26  2:17 ` github-actions
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: kawaiiamber @ 2022-02-27 18:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages xbps-src
https://github.com/void-linux/void-packages/pull/35878

xbps-src: consistent source style
On lines: 442, 458,  700, 849, and 873 - the `. FILE` style is used to source in a file. As far as I can tell, `. FILE` and `source FILE` is exactly the same. If `.` is used everywhere else, then it seems `source` should be changed to `.` for consistency unless there is a difference I'm not aware of.

[ci skip]

A patch file from https://github.com/void-linux/void-packages/pull/35878.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xbps-src-35878.patch --]
[-- Type: text/x-diff, Size: 997 bytes --]

From c25fecca538eac589ed484d3cb6c1a93c89648d4 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 27 Feb 2022 11:07:07 -0700
Subject: [PATCH] xbps-src: consistent source style

---
 xbps-src | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xbps-src b/xbps-src
index ff249015ed02..4184997bbfa2 100755
--- a/xbps-src
+++ b/xbps-src
@@ -938,12 +938,12 @@ case "$XBPS_TARGET" in
         ;;
     show-var)
         for f in ${XBPS_COMMONDIR}/environment/setup/*.sh; do
-            source $f
+            . $f
         done
         if [ "$XBPS_CROSS_BUILD" ]; then
-            source ${XBPS_COMMONDIR}/cross-profiles/${XBPS_CROSS_BUILD}.sh
+            . ${XBPS_COMMONDIR}/cross-profiles/${XBPS_CROSS_BUILD}.sh
         else
-            source ${XBPS_COMMONDIR}/build-profiles/${XBPS_MACHINE}.sh
+            . ${XBPS_COMMONDIR}/build-profiles/${XBPS_MACHINE}.sh
         fi
         eval value="\${$XBPS_TARGET_PKG}"
         echo $value

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: xbps-src: consistent source style
  2022-02-27 18:05 [PR PATCH] xbps-src: consistent source style kawaiiamber
  2022-02-27 18:06 ` [PR PATCH] [Updated] " kawaiiamber
@ 2022-06-26  2:17 ` github-actions
  2022-06-26 10:04 ` kawaiiamber
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2022-06-26  2:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/35878#issuecomment-1166399970

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: xbps-src: consistent source style
  2022-02-27 18:05 [PR PATCH] xbps-src: consistent source style kawaiiamber
  2022-02-27 18:06 ` [PR PATCH] [Updated] " kawaiiamber
  2022-06-26  2:17 ` github-actions
@ 2022-06-26 10:04 ` kawaiiamber
  2022-09-26  2:15 ` github-actions
  2022-10-11  2:14 ` [PR PATCH] [Closed]: " github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: kawaiiamber @ 2022-06-26 10:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35878#issuecomment-1166478266

Comment:
bump

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: xbps-src: consistent source style
  2022-02-27 18:05 [PR PATCH] xbps-src: consistent source style kawaiiamber
                   ` (2 preceding siblings ...)
  2022-06-26 10:04 ` kawaiiamber
@ 2022-09-26  2:15 ` github-actions
  2022-10-11  2:14 ` [PR PATCH] [Closed]: " github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2022-09-26  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/35878#issuecomment-1257385939

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: xbps-src: consistent source style
  2022-02-27 18:05 [PR PATCH] xbps-src: consistent source style kawaiiamber
                   ` (3 preceding siblings ...)
  2022-09-26  2:15 ` github-actions
@ 2022-10-11  2:14 ` github-actions
  4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2022-10-11  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

There's a closed pull request on the void-packages repository

xbps-src: consistent source style
https://github.com/void-linux/void-packages/pull/35878

Description:
On lines: 442, 458,  700, 849, and 873 - the `. FILE` style is used to source in a file. As far as I can tell, `. FILE` and `source FILE` is exactly the same. If `.` is used everywhere else, then it seems `source` should be changed to `.` for consistency unless there is a difference I'm not aware of.

[ci skip]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-10-11  2:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-27 18:05 [PR PATCH] xbps-src: consistent source style kawaiiamber
2022-02-27 18:06 ` [PR PATCH] [Updated] " kawaiiamber
2022-06-26  2:17 ` github-actions
2022-06-26 10:04 ` kawaiiamber
2022-09-26  2:15 ` github-actions
2022-10-11  2:14 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).