Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Change default runtime to crun
@ 2022-06-27 11:57 ltrsunny
  2022-06-27 12:56 ` ahesford
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: ltrsunny @ 2022-06-27 11:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]

There is a new pull request by ltrsunny against master on the void-packages repository

https://github.com/ltrsunny/void-packages patch-1
https://github.com/void-linux/void-packages/pull/37706

Change default runtime to crun
crun is a more lighter and popular choice now.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37706.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-37706.patch --]
[-- Type: text/x-diff, Size: 1080 bytes --]

From 8b0fada9581d93da21211d5eb29f657f498ffe70 Mon Sep 17 00:00:00 2001
From: Liu Taoran <49466661+ltrsunny@users.noreply.github.com>
Date: Mon, 27 Jun 2022 19:57:12 +0800
Subject: [PATCH] Change default runtime to crun

crun is a more lighter and popular choice now.
---
 srcpkgs/podman/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/podman/template b/srcpkgs/podman/template
index bc2e8cce46cb..b75bf1bf52ce 100644
--- a/srcpkgs/podman/template
+++ b/srcpkgs/podman/template
@@ -8,7 +8,7 @@ go_package="${go_import_path}/cmd/podman ${go_import_path}/cmd/rootlessport"
 go_build_tags="seccomp apparmor containers_image_ostree_stub"
 hostmakedepends="pkg-config go-md2man"
 makedepends="gpgme-devel libseccomp-devel device-mapper-devel libbtrfs-devel"
-depends="runc conmon cni-plugins slirp4netns containers.image fuse-overlayfs"
+depends="crun conmon cni-plugins slirp4netns containers.image fuse-overlayfs"
 short_desc="Simple management tool for containers and images"
 maintainer="Cameron Nemo <cnemo@tutanota.com>"
 license="Apache-2.0"

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Change default runtime to crun
  2022-06-27 11:57 [PR PATCH] Change default runtime to crun ltrsunny
@ 2022-06-27 12:56 ` ahesford
  2022-06-27 12:56 ` ahesford
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2022-06-27 12:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/37706#issuecomment-1167318708

Comment:
I don't know about lightness or popularity, but last time I checked, rootless podman won't work at all with runc because it can't control cgroups as it expects.

cc: @CameronNemo 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Change default runtime to crun
  2022-06-27 11:57 [PR PATCH] Change default runtime to crun ltrsunny
  2022-06-27 12:56 ` ahesford
@ 2022-06-27 12:56 ` ahesford
  2022-06-27 14:16 ` ltrsunny
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2022-06-27 12:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/37706#issuecomment-1167318708

Comment:
I don't know about lightness or popularity, but last time I checked, rootless podman won't work at all with runc because it can't control cgroups as it expects. Switching seems fine to me, but I don't know if there are adverse consequences that we'd want to avoid.

cc: @CameronNemo 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Change default runtime to crun
  2022-06-27 11:57 [PR PATCH] Change default runtime to crun ltrsunny
  2022-06-27 12:56 ` ahesford
  2022-06-27 12:56 ` ahesford
@ 2022-06-27 14:16 ` ltrsunny
  2022-06-27 16:03 ` CameronNemo
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ltrsunny @ 2022-06-27 14:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

New comment by ltrsunny on void-packages repository

https://github.com/void-linux/void-packages/pull/37706#issuecomment-1167411741

Comment:
> I don't know about lightness or popularity, but last time I checked, rootless podman won't work at all with runc because it can't control cgroups as it expects. Switching seems fine to me, but I don't know if there are adverse consequences that we'd want to avoid.
> 
> cc: @CameronNemo

I also found this problem on openwrt before, crun works well but runc cannot.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Change default runtime to crun
  2022-06-27 11:57 [PR PATCH] Change default runtime to crun ltrsunny
                   ` (2 preceding siblings ...)
  2022-06-27 14:16 ` ltrsunny
@ 2022-06-27 16:03 ` CameronNemo
  2022-06-27 16:06 ` CameronNemo
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: CameronNemo @ 2022-06-27 16:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/37706#issuecomment-1167539001

Comment:
>rootless podman won't work at all with runc because it can't control cgroups as it expects

this does not seem to be the case at all for me. but whatever it is just a default.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Change default runtime to crun
  2022-06-27 11:57 [PR PATCH] Change default runtime to crun ltrsunny
                   ` (3 preceding siblings ...)
  2022-06-27 16:03 ` CameronNemo
@ 2022-06-27 16:06 ` CameronNemo
  2022-06-27 19:18 ` ahesford
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: CameronNemo @ 2022-06-27 16:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/37706#issuecomment-1167543938

Comment:
FYI podman and conmon need updates. And the default runtime for buildah should be changed too.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Change default runtime to crun
  2022-06-27 11:57 [PR PATCH] Change default runtime to crun ltrsunny
                   ` (4 preceding siblings ...)
  2022-06-27 16:06 ` CameronNemo
@ 2022-06-27 19:18 ` ahesford
  2022-09-29  2:14 ` Podman: change " github-actions
  2022-10-13  2:15 ` [PR PATCH] [Closed]: " github-actions
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2022-06-27 19:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/37706#issuecomment-1167778384

Comment:
I just did a test and found that my previous issue with rootless podman and runc no longer exists; runc works just fine for me.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Podman: change default runtime to crun
  2022-06-27 11:57 [PR PATCH] Change default runtime to crun ltrsunny
                   ` (5 preceding siblings ...)
  2022-06-27 19:18 ` ahesford
@ 2022-09-29  2:14 ` github-actions
  2022-10-13  2:15 ` [PR PATCH] [Closed]: " github-actions
  7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2022-09-29  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/37706#issuecomment-1261655869

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Closed]: Podman: change default runtime to crun
  2022-06-27 11:57 [PR PATCH] Change default runtime to crun ltrsunny
                   ` (6 preceding siblings ...)
  2022-09-29  2:14 ` Podman: change " github-actions
@ 2022-10-13  2:15 ` github-actions
  7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2022-10-13  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

There's a closed pull request on the void-packages repository

Podman: change default runtime to crun
https://github.com/void-linux/void-packages/pull/37706

Description:
crun is a lighter and more popular choice now.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-10-13  2:15 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-27 11:57 [PR PATCH] Change default runtime to crun ltrsunny
2022-06-27 12:56 ` ahesford
2022-06-27 12:56 ` ahesford
2022-06-27 14:16 ` ltrsunny
2022-06-27 16:03 ` CameronNemo
2022-06-27 16:06 ` CameronNemo
2022-06-27 19:18 ` ahesford
2022-09-29  2:14 ` Podman: change " github-actions
2022-10-13  2:15 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).