* [PR PATCH] rofi-rbw: fix wofi support
@ 2022-06-28 13:39 TinfoilSubmarine
2022-06-28 18:13 ` [PR PATCH] [Merged]: " classabbyamp
0 siblings, 1 reply; 2+ messages in thread
From: TinfoilSubmarine @ 2022-06-28 13:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]
There is a new pull request by TinfoilSubmarine against master on the void-packages repository
https://github.com/TinfoilSubmarine/void-packages update/rofi-rbw
https://github.com/void-linux/void-packages/pull/37725
rofi-rbw: fix wofi support
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/37725.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update/rofi-rbw-37725.patch --]
[-- Type: text/x-diff, Size: 1977 bytes --]
From c50f9303f99041b3bc75b66f9cf698f93030bae9 Mon Sep 17 00:00:00 2001
From: Joel Beckmeyer <joel@beckmeyer.us>
Date: Mon, 27 Jun 2022 18:46:55 -0400
Subject: [PATCH] rofi-rbw: fix wofi support
---
srcpkgs/rofi-rbw/patches/wofi.patch | 28 ++++++++++++++++++++++++++++
srcpkgs/rofi-rbw/template | 2 +-
2 files changed, 29 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/rofi-rbw/patches/wofi.patch
diff --git a/srcpkgs/rofi-rbw/patches/wofi.patch b/srcpkgs/rofi-rbw/patches/wofi.patch
new file mode 100644
index 000000000000..9627b6771b3c
--- /dev/null
+++ b/srcpkgs/rofi-rbw/patches/wofi.patch
@@ -0,0 +1,28 @@
+From d059d0a4f352d295c116639798f8b5e110967e4f Mon Sep 17 00:00:00 2001
+From: Fabian Winter <5821180+fdw@users.noreply.github.com>
+Date: Mon, 27 Jun 2022 20:55:21 +0200
+Subject: [PATCH] Return correct values from wofi
+
+Returning no targets might not be the best idea...
+
+Issue: #51
+---
+ src/rofi_rbw/selector.py | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/rofi_rbw/selector.py b/src/rofi_rbw/selector.py
+index d2c9844..e5d8696 100644
+--- a/src/rofi_rbw/selector.py
++++ b/src/rofi_rbw/selector.py
+@@ -198,9 +198,9 @@ def show_selection(
+ encoding='utf-8'
+ )
+ if wofi.returncode == 0:
+- return [], DEFAULT(), wofi.stdout
++ return DEFAULT(), DEFAULT(), wofi.stdout
+ else:
+- return [], CANCEL(), wofi.stdout
++ return CANCEL(), CANCEL(), wofi.stdout
+
+ def select_target(
+ self,
diff --git a/srcpkgs/rofi-rbw/template b/srcpkgs/rofi-rbw/template
index 37dc916c12d6..5a2ef1eedcec 100644
--- a/srcpkgs/rofi-rbw/template
+++ b/srcpkgs/rofi-rbw/template
@@ -1,7 +1,7 @@
# Template file for 'rofi-rbw'
pkgname=rofi-rbw
version=1.0.0
-revision=1
+revision=2
build_style=python3-pep517
make_install_target="rofi_rbw-${version}-py3-none-any.whl"
hostmakedepends="python3-setuptools python3-wheel"
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PR PATCH] [Merged]: rofi-rbw: fix wofi support
2022-06-28 13:39 [PR PATCH] rofi-rbw: fix wofi support TinfoilSubmarine
@ 2022-06-28 18:13 ` classabbyamp
0 siblings, 0 replies; 2+ messages in thread
From: classabbyamp @ 2022-06-28 18:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]
There's a merged pull request on the void-packages repository
rofi-rbw: fix wofi support
https://github.com/void-linux/void-packages/pull/37725
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
See https://github.com/fdw/rofi-rbw/issues/51
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-28 18:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-28 13:39 [PR PATCH] rofi-rbw: fix wofi support TinfoilSubmarine
2022-06-28 18:13 ` [PR PATCH] [Merged]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).