From: stellarskylark <stellarskylark@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] Fix fillets-ng not including game data
Date: Wed, 29 Jun 2022 00:35:26 +0200 [thread overview]
Message-ID: <20220628223526.d5El8E2r0kVjGkU8N6B2py4rwYDadTB6GYg-ak5Itow@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37720@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
There is an updated pull request by stellarskylark against master on the void-packages repository
https://github.com/stellarskylark/void-packages master
https://github.com/void-linux/void-packages/pull/37720
Fix fillets-ng not including game data
Basically all I did was copy `do_install` from the `gnu-configure` build style and add a couple lines to copy the game data into `DESTDIR` as well. I chose to install it to `/usr/share/games/fillets-ng` because that is where Fillets looks for the game data by default.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/37720.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-37720.patch --]
[-- Type: text/x-diff, Size: 1082 bytes --]
From 0afe0ee330adb1d776f258b56c80656b213cadc7 Mon Sep 17 00:00:00 2001
From: Skylar Hill <stellarskylark@posteo.net>
Date: Tue, 28 Jun 2022 02:12:21 -0500
Subject: [PATCH] fillets-ng: include game data
---
srcpkgs/fillets-ng/template | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/fillets-ng/template b/srcpkgs/fillets-ng/template
index 8db27477c3c4..ca8b930a7842 100644
--- a/srcpkgs/fillets-ng/template
+++ b/srcpkgs/fillets-ng/template
@@ -1,7 +1,7 @@
# Template file for 'fillets-ng'
pkgname=fillets-ng
version=1.0.1
-revision=2
+revision=3
create_wrksrc=yes
build_wrksrc="fillets-ng-${version}"
build_style=gnu-configure
@@ -16,3 +16,7 @@ distfiles="${SOURCEFORGE_SITE}/fillets/fillets-ng-${version}.tar.gz
checksum="329a4d9515d60bebdb657d070824933b993b85864b9d3e302e6361accab992da
f0c979fb35ec550a43246fc209add8f45ca550a382c94d6383bb3f01b1073799"
replaces="fillets-ng-data>=0"
+post_install() {
+ mkdir -p ${DESTDIR}/usr/share/games/fillets-ng
+ cp -r $wrksrc/fillets-ng-data-${version}/* ${DESTDIR}/usr/share/games/fillets-ng
+}
next prev parent reply other threads:[~2022-06-28 22:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 7:18 [PR PATCH] " stellarskylark
2022-06-28 7:27 ` [PR PATCH] [Updated] " stellarskylark
2022-06-28 22:12 ` Duncaen
2022-06-28 22:35 ` stellarskylark [this message]
2022-06-29 12:18 ` [PR PATCH] [Closed]: " Duncaen
2022-07-01 16:13 ` stellarskylark
2022-07-01 18:07 ` paper42
2022-07-01 18:09 ` stellarskylark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628223526.d5El8E2r0kVjGkU8N6B2py4rwYDadTB6GYg-ak5Itow@z \
--to=stellarskylark@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).