From: leahneukirchen <leahneukirchen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: [WIP] ocaml: fix build on aarch64-musl
Date: Wed, 29 Jun 2022 18:42:53 +0200 [thread overview]
Message-ID: <20220629164253.bkMvvw3C9Au-R66COEzVMXf9gwAGgSFEYuEhyYB5PJ4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36268@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
There's a closed pull request on the void-packages repository
[WIP] ocaml: fix build on aarch64-musl
https://github.com/void-linux/void-packages/pull/36268
Description:
Earlier fix for *-musl platforms has been "nopie=yes", which disables
PIE by modifying CFLAGS/LDFLAGS/... during build. This results in
OCaml's runtime shared library linking fail.
Later OCaml releases incorporated a fix for *-musl platforms that
properly disables PIE only where required.
Set nopie_files instead, which respects OCaml's build system choice
of CFLAGS/LDFLAGS/... and fixes aarch64-build.
I am not entirely sure whether `nopie=yes` in every package is a good idea. It seems to only be required on *-musl except x86_64-musl(?).
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (aarch64-musl)
[ci skip]
prev parent reply other threads:[~2022-06-29 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 19:23 [PR PATCH] " ftrvxmtrx
2022-06-29 2:15 ` github-actions
2022-06-29 16:42 ` leahneukirchen
2022-06-29 16:42 ` leahneukirchen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629164253.bkMvvw3C9Au-R66COEzVMXf9gwAGgSFEYuEhyYB5PJ4@z \
--to=leahneukirchen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).