Github messages for voidlinux
 help / color / mirror / Atom feed
From: leahneukirchen <leahneukirchen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: New package: hatch-1.2.1
Date: Wed, 29 Jun 2022 18:45:36 +0200	[thread overview]
Message-ID: <20220629164536.CF8bXSXa_iqhNwxUKJdEosARA-U85LeodKr3mvL6oyk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37514@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2235 bytes --]

There's a merged pull request on the void-packages repository

New package: hatch-1.2.1
https://github.com/void-linux/void-packages/pull/37514

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

### Bikeshedding opportunities
 - ~~As they aren't just libraries, but also CLI tools, do hatch/hatchling need the `python3-` prefix? I personally don't like it, and would argue in favor of removing it.~~ Considering no one commented on this bit, I've decided to just get rid of.
 - ~~There's nearly no testing happening here, but that's due to the deps either requiring git checkouts with submodules, or themselves to be installed for testing. Any opinions on this? I'd prefer to have some amount of automatic testing here and not just a "JC has run this on his laptop once", considering that these are likely to be fairly central Python packages~~ there are a few tests failing now, but they are being run and there's a hundred times more tests that do work as intended. The ones failing where it's expecting to be running /usr/bin/python, but is actually running /usr/bin/python3 or similar things, which is fine IMO.
 - ~~Is a major update of python3-click something that might need additional testing? 29 of our packages depend on it, but on the other hand, it's *probably* fine, right?~~ Has been updated outside of this PR.
 
Fixes #37334

      parent reply	other threads:[~2022-06-29 16:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-11 12:28 [PR PATCH] New package: python3-hatch-1.2.1 jcgruenhage
2022-06-11 13:08 ` [PR REVIEW] " Chocimier
2022-06-11 13:58 ` [PR PATCH] [Updated] " jcgruenhage
2022-06-11 13:59 ` [PR REVIEW] " jcgruenhage
2022-06-11 13:59 ` jcgruenhage
2022-06-11 14:03 ` paper42
2022-06-11 14:13 ` jcgruenhage
2022-06-11 14:17 ` paper42
2022-06-11 14:21 ` [PR PATCH] [Updated] " jcgruenhage
2022-06-11 14:35 ` jcgruenhage
2022-06-11 14:43 ` jcgruenhage
2022-06-17 16:28 ` icp1994
2022-06-17 16:28 ` icp1994
2022-06-18  7:08 ` [PR REVIEW] " paper42
2022-06-18  7:08 ` paper42
2022-06-24 19:55 ` leahneukirchen
2022-06-26 10:01 ` [PR PATCH] [Updated] " jcgruenhage
2022-06-26 14:45 ` [PR PATCH] [Updated] New package: hatch-1.2.1 jcgruenhage
2022-06-29 16:45 ` leahneukirchen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220629164536.CF8bXSXa_iqhNwxUKJdEosARA-U85LeodKr3mvL6oyk@z \
    --to=leahneukirchen@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).