Re: [PR PATCH] [Updated] libopenraw: split the pixbuf loader into subpackage

[oreo639 <oreo639@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages low
https://github.com/void-linux/void-packages/pull/37749

libopenraw: split the pixbuf loader into subpackage
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

Someone had this issue on the GNOME matrix, libopenraw-pixbuf-loader wasn't loading their CR2 file correctly and I can reproduce it.
It works fine without the libopenraw pixbuf loader installed. This can cause issues if it is pulled in with libopenraw i.e. as an xfce thumbler dependency.

Seeing as the pixbuf loader part isn't needed by xfce or eog and the pixbuf loader is considered deprecated upstream, probably best to split it into its own package so people can install it if they really need it.



https://gitlab.freedesktop.org/libopenraw/libopenraw/-/issues/10

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37749.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-low-37749.patch --]
[-- Type: text/x-diff, Size: 2156 bytes --]

From ccf7fc09acd592a10b0d85e853c253146dc1d7a5 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Wed, 29 Jun 2022 15:49:52 -0700
Subject: [PATCH] libopenraw: split pixbuf loader into subpackage

The pixbuf loader can cause issues loading files and isn't always needed.

The pixbuf loader is also considered deprecated upstream, so it should probably
be split into its own package.
---
 srcpkgs/libopenraw-pixbuf-loader |  1 +
 srcpkgs/libopenraw/template      | 14 +++++++++++---
 2 files changed, 12 insertions(+), 3 deletions(-)
 create mode 120000 srcpkgs/libopenraw-pixbuf-loader

diff --git a/srcpkgs/libopenraw-pixbuf-loader b/srcpkgs/libopenraw-pixbuf-loader
new file mode 120000
index 000000000000..aa7a4d2d924b
--- /dev/null
+++ b/srcpkgs/libopenraw-pixbuf-loader
@@ -0,0 +1 @@
+libopenraw
\ No newline at end of file
diff --git a/srcpkgs/libopenraw/template b/srcpkgs/libopenraw/template
index 5b2f7bbd814f..1c399926cc5c 100644
--- a/srcpkgs/libopenraw/template
+++ b/srcpkgs/libopenraw/template
@@ -1,7 +1,7 @@
 # Template file for 'libopenraw'
 pkgname=libopenraw
 version=0.1.3
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--with-boost=${XBPS_CROSS_BASE}/usr"
 hostmakedepends="pkg-config curl"
@@ -10,8 +10,8 @@ short_desc="Library for camera RAW files decoding"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-3.0-or-later"
 #changelog="https://raw.githubusercontent.com/hfiguiere/libopenraw/master/NEWS"
-homepage="https://${pkgname}.freedesktop.org/wiki/"
-distfiles="https://${pkgname}.freedesktop.org/download/${pkgname}-${version}.tar.bz2"
+homepage="https://libopenraw.freedesktop.org/wiki/"
+distfiles="https://libopenraw.freedesktop.org/download/libopenraw-${version}.tar.bz2"
 checksum=6405634f555849eb01cb028e2a63936e7b841151ea2a1571ac5b5b10431cfab9
 
 post_install() {
@@ -29,3 +29,11 @@ libopenraw-devel_package() {
 		vmove usr/include
 	}
 }
+
+libopenraw-pixbuf-loader_package() {
+	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
+	description=" - pixbuf loader"
+	pkg_install() {
+		vmove "usr/lib/gdk-pixbuf-2.0/*/loaders/*.so"
+	}
+}