[PR PATCH] srcpkgs/crystal: update to 1.0.0.

[PR PATCH] srcpkgs/crystal: update to 1.0.0.

[mipmip]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

There is a new pull request by mipmip against master on the void-packages repository

https://github.com/mipmip/void-packages crystal-1.0
https://github.com/void-linux/void-packages/pull/30019

srcpkgs/crystal: update to 1.0.0.
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

#### Extra info

- upgrade to llvm11
- use openssl
- re-enabled do_check()

#### Archs

- I built this PR locally for these architectures with -Q:
  - [x] i686-glibc with -Q
  - [x] x86_64-glibc with -Q
  - [x] x86_64-musl with -Q

Were not able to test the ARM platforms



A patch file from https://github.com/void-linux/void-packages/pull/30019.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-crystal-1.0-30019.patch --]
[-- Type: text/x-diff, Size: 5706 bytes --]

From cddd96a3e4f99cb309fe8579f265dfd9ec97d178 Mon Sep 17 00:00:00 2001
From: Pim Snel <pim@lingewoud.nl>
Date: Mon, 5 Apr 2021 16:20:44 +0200
Subject: [PATCH] srcpkgs/crystal: update to 1.0.0.

---
 srcpkgs/crystal/template | 127 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 127 insertions(+)
 create mode 100644 srcpkgs/crystal/template

diff --git a/srcpkgs/crystal/template b/srcpkgs/crystal/template
new file mode 100644
index 000000000000..724d42d95da1
--- /dev/null
+++ b/srcpkgs/crystal/template
@@ -0,0 +1,127 @@
+# Template file for 'crystal'
+pkgname=crystal
+version=1.0.0
+revision=1
+archs="x86_64* i686*"
+_shardsversion=0.14.1
+_molinilloversion=0.1.0
+_bootstrapversion=1.0.0
+_bootstraprevision=1
+hostmakedepends="which tar llvm11 pkg-config"
+makedepends="gc-devel libatomic_ops pcre-devel libevent-devel libyaml-devel libxml2-devel"
+depends="gc-devel libatomic_ops pcre-devel libevent-devel libyaml-devel libxml2-devel gmp-devel openssl-devel llvm11 gcc pkg-config"
+checkdepends="readline-devel libyaml-devel gmp-devel openssl-devel git"
+short_desc="Crystal Programming Language"
+maintainer="lvmbdv <ata.kuyumcu@protonmail.com>"
+license="Apache-2.0"
+homepage="https://crystal-lang.org/"
+distfiles="
+ https://github.com/crystal-lang/crystal/archive/${version}.tar.gz
+ https://github.com/crystal-lang/shards/archive/v${_shardsversion}.tar.gz
+ https://github.com/crystal-lang/crystal-molinillo/archive/v${_molinilloversion}.tar.gz"
+checksum="6b85c9139a891732c1f10638030635ff9dbe4e6818cad81a5dbd72db40913019
+ 040b080acb4d4d44bfe07897219fdcb7525f783e253d8878d8381bf78f13f328
+ 1ecc7a8bf52a3bfdc0134d4c58f1155ef204a22a3fed151ac2d4ba6a9e9e0a15"
+nocross="FIXME: someone needs to sort out the llvm --cxxflags for cross building"
+_crystalflags="--release --no-debug --progress"
+
+build_options="binary_bootstrap"
+build_options_default="binary_bootstrap"
+desc_option_binary_bootstrap="Bootstrap using precompiled binaries"
+
+if [ "$build_option_binary_bootstrap" ]; then
+	case "$XBPS_MACHINE" in
+	x86_64)
+		distfiles+=" https://github.com/crystal-lang/crystal/releases/download/${_bootstrapversion}/crystal-${_bootstrapversion}-${_bootstraprevision}-linux-x86_64.tar.gz"
+		checksum+=" 00211ca77758e99210ec40b8c5517b086d2ff9909e089400f6d847a95e5689a4"
+		;;
+	x86_64-musl)
+		distfiles+=" https://github.com/crystal-lang/crystal/releases/download/${_bootstrapversion}/crystal-${_bootstrapversion}-${_bootstraprevision}-linux-x86_64.tar.gz"
+		checksum+=" 00211ca77758e99210ec40b8c5517b086d2ff9909e089400f6d847a95e5689a4"
+		;;
+	i686)
+		distfiles+=" https://github.com/crystal-lang/crystal/releases/download/${_bootstrapversion}/crystal-${_bootstrapversion}-${_bootstraprevision}-linux-i686.tar.gz"
+		checksum+=" 90ed246a21a94643153df455e7f6c1d5c102e062f1de1353e9504691b9230e70"
+		;;
+	*)
+		broken="cannot be built on $XBPS_MACHINE"
+		;;
+	esac
+else
+	hostmakedepends+=" crystal"
+fi
+
+do_extract() {
+	rm -Rf ${wrksrc}/shards/lib/molinillo
+	mkdir -p ${wrksrc}/{shards,shards/lib,shards/lib/molinillo,molinillo,$(vopt_if binary_bootstrap bootstrap)}
+	tar xfz ${XBPS_SRCDISTDIR}/${pkgname}-${version}/${version}.tar.gz --strip-components=1 -C ${wrksrc}
+	tar xfz ${XBPS_SRCDISTDIR}/${pkgname}-${version}/v${_shardsversion}.tar.gz --strip-components=1 -C ${wrksrc}/shards
+	tar xfz ${XBPS_SRCDISTDIR}/${pkgname}-${version}/v${_molinilloversion}.tar.gz --strip-components=1 -C ${wrksrc}/molinillo
+
+	mv -f ${wrksrc}/molinillo/src/* ${wrksrc}/shards/lib/molinillo
+	if [ "$build_option_binary_bootstrap" ]; then
+		case "$XBPS_MACHINE" in
+		x86_64-musl)
+			tar xf ${XBPS_SRCDISTDIR}/${pkgname}-${version}/crystal-${_bootstrapversion}-${_bootstraprevision}-linux-x86_64.tar.gz \
+				--strip-components=1 --exclude='lib/crystal/lib/libgc.a' -C ${wrksrc}/bootstrap
+			;;
+		*)
+			tar xf ${XBPS_SRCDISTDIR}/${pkgname}-${version}/crystal-${_bootstrapversion}-${_bootstraprevision}-linux-${XBPS_TARGET_MACHINE}.tar.gz \
+				--strip-components=1 -C ${wrksrc}/bootstrap
+			;;
+		esac
+	fi
+}
+
+do_build() {
+	if [ -z ${disable_parallel_build} ] && [ ${XBPS_MAKEJOBS} ]; then
+		_crystalflags="${_crystalflags} --threads ${makejobs:2:4}"
+	fi
+	make ${makejobs} release=1 FLAGS="${_crystalflags}" \
+		CRYSTAL_CONFIG_PATH="lib:/usr/lib/crystal" \
+		CRYSTAL_CONFIG_VERSION="${version}" \
+		CRYSTAL_CACHE_DIR="/tmp/crystal" \
+		$(vopt_if binary_bootstrap PATH="${wrksrc}/bootstrap/bin:$PATH")
+	make ${makejobs} docs CRYSTAL_CACHE_DIR="/tmp/crystal"
+
+	cd shards
+	${wrksrc}/bin/crystal build ${_crystalflags} -o bin/shards src/shards.cr
+}
+
+do_check() {
+	export PATH="${wrksrc}/.build:${wrksrc}/bin:/usr/bin:/bin"
+	#make ${makejobs} spec \
+	#	CRYSTAL_CONFIG_VERSION="${version}" \
+	#	CRYSTAL_CACHE_DIR="/tmp/crystal"
+
+	./bin/crystal build --single-module \
+		--exclude-warnings spec/std \
+		--exclude-warnings spec/compiler \
+		-o .build/std_spec spec/std_spec.cr
+
+	cd shards
+	git config --global user.email "void@blackhole.none"
+	git config --global user.name "Void Linux"
+	../bin/crystal spec ./spec/unit/
+	../bin/crystal spec ./spec/integration/
+	#make test
+}
+
+do_install() {
+	vmkdir /usr/bin
+	vmkdir /usr/lib/crystal
+	vmkdir /usr/share/doc/crystal
+	vmkdir /usr/share/doc/crystal/api
+	vmkdir /usr/share/licenses/shards
+
+	vinstall etc/completion.bash 644 \
+		usr/share/bash-completion/completions crystal
+	vinstall etc/completion.zsh 644 usr/share/zsh/site-functions _crystal
+	vcopy samples /usr/share/doc/crystal
+	vcopy docs/* /usr/share/doc/crystal/api
+	vcopy src/* /usr/lib/crystal
+	vbin .build/crystal crystal
+	vman man/crystal.1
+	vbin shards/bin/shards
+	cp shards/LICENSE ${DESTDIR}/usr/share/licenses/shards
+}

Re: srcpkgs/crystal: update to 1.0.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#issuecomment-813444639

Comment:
I think the commit should be `New package: crystal-1.0.0`? The package was removed and you're reintroducing it.

Re: [PR REVIEW] srcpkgs/crystal: update to 1.0.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#discussion_r607142766

Comment:
```suggestion
	x86_64*)
		distfiles+=" https://github.com/crystal-lang/crystal/releases/download/${_bootstrapversion}/crystal-${_bootstrapversion}-${_bootstraprevision}-linux-x86_64.tar.gz"
		checksum+=" 00211ca77758e99210ec40b8c5517b086d2ff9909e089400f6d847a95e5689a4"
		;;
```

Re: [PR PATCH] [Updated] srcpkgs/crystal: update to 1.0.0.

[mipmip]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

There is an updated pull request by mipmip against master on the void-packages repository

https://github.com/mipmip/void-packages crystal-1.0
https://github.com/void-linux/void-packages/pull/30019

srcpkgs/crystal: update to 1.0.0.
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

#### Extra info

- upgrade to llvm11
- use openssl
- re-enabled do_check()

#### Archs

- I built this PR locally for these architectures with -Q:
  - [x] i686-glibc with -Q
  - [x] x86_64-glibc with -Q
  - [x] x86_64-musl with -Q

Were not able to test the ARM platforms



A patch file from https://github.com/void-linux/void-packages/pull/30019.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-crystal-1.0-30019.patch --]
[-- Type: text/x-diff, Size: 5448 bytes --]

From cd2389d019f6faf0154fcdfdbb36854ff6bc1699 Mon Sep 17 00:00:00 2001
From: Pim Snel <pim@lingewoud.nl>
Date: Mon, 5 Apr 2021 16:20:44 +0200
Subject: [PATCH] srcpkgs/crystal: New package: crystal-1.0.0

---
 srcpkgs/crystal/template | 123 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 123 insertions(+)
 create mode 100644 srcpkgs/crystal/template

diff --git a/srcpkgs/crystal/template b/srcpkgs/crystal/template
new file mode 100644
index 000000000000..e0f7d50e55b0
--- /dev/null
+++ b/srcpkgs/crystal/template
@@ -0,0 +1,123 @@
+# Template file for 'crystal'
+pkgname=crystal
+version=1.0.0
+revision=1
+archs="x86_64* i686*"
+_shardsversion=0.14.1
+_molinilloversion=0.1.0
+_bootstrapversion=1.0.0
+_bootstraprevision=1
+hostmakedepends="which tar llvm11 pkg-config"
+makedepends="gc-devel libatomic_ops pcre-devel libevent-devel libyaml-devel libxml2-devel"
+depends="gc-devel libatomic_ops pcre-devel libevent-devel libyaml-devel libxml2-devel gmp-devel openssl-devel llvm11 gcc pkg-config"
+checkdepends="readline-devel libyaml-devel gmp-devel openssl-devel git"
+short_desc="Crystal Programming Language"
+maintainer="lvmbdv <ata.kuyumcu@protonmail.com>"
+license="Apache-2.0"
+homepage="https://crystal-lang.org/"
+distfiles="
+ https://github.com/crystal-lang/crystal/archive/${version}.tar.gz
+ https://github.com/crystal-lang/shards/archive/v${_shardsversion}.tar.gz
+ https://github.com/crystal-lang/crystal-molinillo/archive/v${_molinilloversion}.tar.gz"
+checksum="6b85c9139a891732c1f10638030635ff9dbe4e6818cad81a5dbd72db40913019
+ 040b080acb4d4d44bfe07897219fdcb7525f783e253d8878d8381bf78f13f328
+ 1ecc7a8bf52a3bfdc0134d4c58f1155ef204a22a3fed151ac2d4ba6a9e9e0a15"
+nocross="FIXME: someone needs to sort out the llvm --cxxflags for cross building"
+_crystalflags="--release --no-debug --progress"
+
+build_options="binary_bootstrap"
+build_options_default="binary_bootstrap"
+desc_option_binary_bootstrap="Bootstrap using precompiled binaries"
+
+if [ "$build_option_binary_bootstrap" ]; then
+	case "$XBPS_MACHINE" in
+	x86_64*)
+		distfiles+=" https://github.com/crystal-lang/crystal/releases/download/${_bootstrapversion}/crystal-${_bootstrapversion}-${_bootstraprevision}-linux-x86_64.tar.gz"
+		checksum+=" 00211ca77758e99210ec40b8c5517b086d2ff9909e089400f6d847a95e5689a4"
+		;;
+	i686)
+		distfiles+=" https://github.com/crystal-lang/crystal/releases/download/${_bootstrapversion}/crystal-${_bootstrapversion}-${_bootstraprevision}-linux-i686.tar.gz"
+		checksum+=" 90ed246a21a94643153df455e7f6c1d5c102e062f1de1353e9504691b9230e70"
+		;;
+	*)
+		broken="cannot be built on $XBPS_MACHINE"
+		;;
+	esac
+else
+	hostmakedepends+=" crystal"
+fi
+
+do_extract() {
+	rm -Rf ${wrksrc}/shards/lib/molinillo
+	mkdir -p ${wrksrc}/{shards,shards/lib,shards/lib/molinillo,molinillo,$(vopt_if binary_bootstrap bootstrap)}
+	tar xfz ${XBPS_SRCDISTDIR}/${pkgname}-${version}/${version}.tar.gz --strip-components=1 -C ${wrksrc}
+	tar xfz ${XBPS_SRCDISTDIR}/${pkgname}-${version}/v${_shardsversion}.tar.gz --strip-components=1 -C ${wrksrc}/shards
+	tar xfz ${XBPS_SRCDISTDIR}/${pkgname}-${version}/v${_molinilloversion}.tar.gz --strip-components=1 -C ${wrksrc}/molinillo
+
+	mv -f ${wrksrc}/molinillo/src/* ${wrksrc}/shards/lib/molinillo
+	if [ "$build_option_binary_bootstrap" ]; then
+		case "$XBPS_MACHINE" in
+		x86_64-musl)
+			tar xf ${XBPS_SRCDISTDIR}/${pkgname}-${version}/crystal-${_bootstrapversion}-${_bootstraprevision}-linux-x86_64.tar.gz \
+				--strip-components=1 --exclude='lib/crystal/lib/libgc.a' -C ${wrksrc}/bootstrap
+			;;
+		*)
+			tar xf ${XBPS_SRCDISTDIR}/${pkgname}-${version}/crystal-${_bootstrapversion}-${_bootstraprevision}-linux-${XBPS_TARGET_MACHINE}.tar.gz \
+				--strip-components=1 -C ${wrksrc}/bootstrap
+			;;
+		esac
+	fi
+}
+
+do_build() {
+	if [ -z ${disable_parallel_build} ] && [ ${XBPS_MAKEJOBS} ]; then
+		_crystalflags="${_crystalflags} --threads ${makejobs:2:4}"
+	fi
+	make ${makejobs} release=1 FLAGS="${_crystalflags}" \
+		CRYSTAL_CONFIG_PATH="lib:/usr/lib/crystal" \
+		CRYSTAL_CONFIG_VERSION="${version}" \
+		CRYSTAL_CACHE_DIR="/tmp/crystal" \
+		$(vopt_if binary_bootstrap PATH="${wrksrc}/bootstrap/bin:$PATH")
+	make ${makejobs} docs CRYSTAL_CACHE_DIR="/tmp/crystal"
+
+	cd shards
+	${wrksrc}/bin/crystal build ${_crystalflags} -o bin/shards src/shards.cr
+}
+
+do_check() {
+	export PATH="${wrksrc}/.build:${wrksrc}/bin:/usr/bin:/bin"
+	#make ${makejobs} spec \
+	#	CRYSTAL_CONFIG_VERSION="${version}" \
+	#	CRYSTAL_CACHE_DIR="/tmp/crystal"
+
+	./bin/crystal build --single-module \
+		--exclude-warnings spec/std \
+		--exclude-warnings spec/compiler \
+		-o .build/std_spec spec/std_spec.cr
+
+	cd shards
+	git config --global user.email "void@blackhole.none"
+	git config --global user.name "Void Linux"
+	../bin/crystal spec ./spec/unit/
+	../bin/crystal spec ./spec/integration/
+	#make test
+}
+
+do_install() {
+	vmkdir /usr/bin
+	vmkdir /usr/lib/crystal
+	vmkdir /usr/share/doc/crystal
+	vmkdir /usr/share/doc/crystal/api
+	vmkdir /usr/share/licenses/shards
+
+	vinstall etc/completion.bash 644 \
+		usr/share/bash-completion/completions crystal
+	vinstall etc/completion.zsh 644 usr/share/zsh/site-functions _crystal
+	vcopy samples /usr/share/doc/crystal
+	vcopy docs/* /usr/share/doc/crystal/api
+	vcopy src/* /usr/lib/crystal
+	vbin .build/crystal crystal
+	vman man/crystal.1
+	vbin shards/bin/shards
+	cp shards/LICENSE ${DESTDIR}/usr/share/licenses/shards
+}

Re: [PR REVIEW] srcpkgs/crystal: update to 1.0.0.

[mipmip]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by mipmip on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#discussion_r607146846

Comment:
Thanks, for this suggestion. Did not know about these wildcards in a case statement.

Re: New package: crystal-1.0.0

[mfiano]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by mfiano on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#issuecomment-875436618

Comment:
I would love to have Crystal as a package in the official repos. Been keeping an eye on this for a while to weigh my move away from Arch :)

Re: New package: crystal-1.0.0

[notramo]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by notramo on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#issuecomment-917410672

Comment:
I tried to build it locally, but it complains about LLVM_CONFIG versions.

Re: New package: crystal-1.0.0

[notramo]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New comment by notramo on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#issuecomment-917410672

Comment:
I tried to build it locally, but it complains about LLVM_CONFIG versions. Maybe there was a toolchain update?

Re: New package: crystal-1.0.0

[notramo]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by notramo on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#issuecomment-1082646202

Comment:
@mipmip is there any progress on this?

Re: New package: crystal-1.0.0

[mipmip]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by mipmip on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#issuecomment-1085689468

Comment:
@notramo No sorry, I moved on to NixOS myself.

Re: New package: crystal-1.0.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#issuecomment-1171851293

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: New package: crystal-1.0.0

[notramo]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

New comment by notramo on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#issuecomment-1175004099

Comment:
I tried to update it to latest Crystal, but the libgc shipped in bootstrap package doesn't seem to like musl. The Crystal devs recommended building libgc locally on musl and swapping it with the bundled one. https://github.com/crystal-lang/crystal/issues/12035
I tried it, but it failed to build, so I have to fix that first.

Re: New package: crystal-1.0.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#issuecomment-1267825642

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: crystal-1.0.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

There's a closed pull request on the void-packages repository

New package: crystal-1.0.0
https://github.com/void-linux/void-packages/pull/30019

Description:
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

#### Extra info

- upgrade to llvm11
- use openssl
- re-enabled do_check()

#### Archs

- I built this PR locally for these architectures with -Q:
  - [x] i686-glibc with -Q
  - [x] x86_64-glibc with -Q
  - [x] x86_64-musl with -Q

Were not able to test the ARM platforms

Re: New package: crystal-1.0.0

[notramo]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by notramo on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#issuecomment-1283803914

Comment:
[ GitHub stale bot considered harmful - Drew DeVault's blog](https://drewdevault.com/2021/10/26/stalebot.html)

Re: New package: crystal-1.0.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/30019#issuecomment-1283807282

Comment:
This PR wasn't updated for 2 years and the author moved away from Void. If it wasn't closed by the bot, we would close it manually. If you want to package this, create a new package PR.