Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] conmon: update to 2.1.2.
@ 2022-06-30 17:29 Idesmi
  2022-07-01  4:26 ` CameronNemo
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Idesmi @ 2022-06-30 17:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

There is a new pull request by Idesmi against master on the void-packages repository

https://github.com/Idesmi/void-packages containers
https://github.com/void-linux/void-packages/pull/37764

conmon: update to 2.1.2.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (crossbuild):
  - aarch64

@CameronNemo 

A patch file from https://github.com/void-linux/void-packages/pull/37764.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-containers-37764.patch --]
[-- Type: text/x-diff, Size: 1237 bytes --]

From 7a18ebfaf6021bb3d8fe472527bfaa92a6e057f9 Mon Sep 17 00:00:00 2001
From: Enrico Belleri <idesmi@protonmail.com>
Date: Thu, 30 Jun 2022 18:25:32 +0200
Subject: [PATCH] conmon: update to 2.1.2.

---
 srcpkgs/conmon/template | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/conmon/template b/srcpkgs/conmon/template
index 48c937d008c8..9fa6f62f26b1 100644
--- a/srcpkgs/conmon/template
+++ b/srcpkgs/conmon/template
@@ -1,19 +1,18 @@
 # Template file for 'conmon'
 pkgname=conmon
-version=2.1.1
+version=2.1.2
 revision=1
 build_style=gnu-makefile
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config gcc-go-tools"
 makedepends="libglib-devel libseccomp-devel"
 short_desc="OCI container runtime monitor"
 maintainer="Cameron Nemo <cnemo@tutanota.com>"
 license="Apache-2.0"
 homepage="https://github.com/containers/conmon"
 distfiles="https://github.com/containers/conmon/archive/v${version}.tar.gz"
-checksum=676bcd5eb7d51cd5510ac9b7513726d9d0e42698fb01e763c25aad8f0c7edde4
+checksum=8ba76eb54c319197235fd39c3a5b5a975b5a21e02cd4be985b8619220a497a0e
 
-do_install() {
-	vbin bin/conmon
+post_install() {
 	vmkdir usr/libexec/podman
 	ln -sf ../../bin/conmon "${DESTDIR}/usr/libexec/podman"
 }

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: conmon: update to 2.1.2.
  2022-06-30 17:29 [PR PATCH] conmon: update to 2.1.2 Idesmi
@ 2022-07-01  4:26 ` CameronNemo
  2022-07-01  4:46 ` classabbyamp
  2022-07-01  4:46 ` [PR PATCH] [Closed]: " classabbyamp
  2 siblings, 0 replies; 6+ messages in thread
From: CameronNemo @ 2022-07-01  4:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/37764#issuecomment-1171921355

Comment:
Leaning toward a nak. Why do we need gcc-go-tools? We almost never want that. If we use a go toolchain, we use the official one.

Also why the change to using the makefile for do_install?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: conmon: update to 2.1.2.
  2022-06-30 17:29 [PR PATCH] conmon: update to 2.1.2 Idesmi
  2022-07-01  4:26 ` CameronNemo
@ 2022-07-01  4:46 ` classabbyamp
  2022-07-01  4:46 ` [PR PATCH] [Closed]: " classabbyamp
  2 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2022-07-01  4:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37764#issuecomment-1171930559

Comment:
superceded by #37774 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: conmon: update to 2.1.2.
  2022-06-30 17:29 [PR PATCH] conmon: update to 2.1.2 Idesmi
  2022-07-01  4:26 ` CameronNemo
  2022-07-01  4:46 ` classabbyamp
@ 2022-07-01  4:46 ` classabbyamp
  2 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2022-07-01  4:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

There's a closed pull request on the void-packages repository

conmon: update to 2.1.2.
https://github.com/void-linux/void-packages/pull/37764

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (crossbuild):
  - aarch64

@CameronNemo 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: conmon: update to 2.1.2
  2022-07-01  4:38 [PR PATCH] " CameronNemo
  2022-07-01  4:40 ` CameronNemo
@ 2022-07-01  4:44 ` Idesmi
  1 sibling, 0 replies; 6+ messages in thread
From: Idesmi @ 2022-07-01  4:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by Idesmi on void-packages repository

https://github.com/void-linux/void-packages/pull/37774#issuecomment-1171929574

Comment:
Sure. I didn't know we had md2man in repos, it's better

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: conmon: update to 2.1.2
  2022-07-01  4:38 [PR PATCH] " CameronNemo
@ 2022-07-01  4:40 ` CameronNemo
  2022-07-01  4:44 ` Idesmi
  1 sibling, 0 replies; 6+ messages in thread
From: CameronNemo @ 2022-07-01  4:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/37774#issuecomment-1171927831

Comment:
@Idesmi a lot of these container packages use go-md2man to build their manpages. They will often try to build go-md2man from source by default, but I prefer to just install go-md2man in the hostmakedepends then point the make jobs or whatever to the host version. Makes the builds go faster. Don't need to pull in a whole Go toolchain. 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-07-01  4:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-30 17:29 [PR PATCH] conmon: update to 2.1.2 Idesmi
2022-07-01  4:26 ` CameronNemo
2022-07-01  4:46 ` classabbyamp
2022-07-01  4:46 ` [PR PATCH] [Closed]: " classabbyamp
2022-07-01  4:38 [PR PATCH] " CameronNemo
2022-07-01  4:40 ` CameronNemo
2022-07-01  4:44 ` Idesmi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).